Commit Graph

20 Commits

Author SHA1 Message Date
Marc Bernard
cd5d43977a
Filter code inspection/syntax check (#4946)
* Filter code inspection/syntax check

In case of generated maintenance screens, the code inspection/syntax check include findings in SAP code (`LSVIM*` includes). This change removes those findings.

* Update zcl_abapgit_code_inspector.clas.abap
2021-09-12 07:12:53 +02:00
Lars Hvam
329fd9dc0e
interface and factory for ZCL_ABAPGIT_PERSIST_SETTINGS (#4882)
the old get_instance() method in ZCL_ABAPGIT_PERSIST_SETTINGS has been moved to a method in zcl_abapgit_persist_factory, plus interface added. Added to persist injector
2021-08-03 15:13:16 +02:00
victorizbitskiy
73496a2755
Refactor: Exception handling #4852 (#4869)
https://github.com/abapGit/abapGit/issues/4852
2021-07-13 09:13:25 +02:00
Mike Pokraka
624616674c
Replace SELECT * with field list (#4675) 2021-03-27 09:07:08 +01:00
Marc Bernard
dd37881589
702: Fix syntax error and missing check variant (#4117)
* 702: Downport 

No chaining with CHANGING

* 702: Downport

* Syntax check variant

* Too many fields warning

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:29:09 +01:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
Marc Bernard
324db52335
Enhance result view of Code Inspector/Syntax Check (#3717)
* Enhance result view of Code Inspector/Syntax Check

* Enhance result view of Code Inspector/Syntax Check

* Enhance result view of Code Inspector/Syntax Check

* Lint

* Move sort
2020-08-07 07:17:42 +02:00
mariusraht2
4421cdc209
Issue 3399: Use c or char instead of sychar (#3410)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Delete pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Use char or c instead of sychar

* Replaced char with type of c

Co-authored-by: mariusraht1 <mariusraht+1@gmail.com>
2020-05-24 11:23:50 +02:00
Frederik Hudák
a64b6d96f8
Don't run code inspector in parallel when disabled (#3348)
* Don't run code inspector in parallel when disabled

* Restructure if

* Fix spacing

* Fix comment position
2020-05-07 11:30:35 +02:00
Jaime Rodriguez Capote
1a896613b4 Issue #3136 ATC Check - GEN_INCLUDE_NOT_EXEC dump (#3145)
* Issue #3136 ATC Check - GEN_INCLUDE_NOT_EXEC dump

* abaplint checks

* Raname method check_obj_before_add to skip_object

* change skip_object logic

* CASE for objecttype
2020-01-08 12:21:44 +01:00
Lars Hvam
b42f3bc485
Refactoring (#3134)
* fully type constants

* moving to single line

* move to single line

* enable keep_single_parameter_on_one_line
2019-12-28 12:11:32 +01:00
Christian Günter
4f47fa64a7 zcl_abapgit_code_inspector: Remove duplication (#3117)
* zcl_abapgit_code_inspector: Remove duplication 

Removes duplication of subpackage determination in zcl_abapgit_code_inspector

* add current package
2019-12-12 11:01:29 +01:00
larshp
9b9417b094 remove empty lines in statements #2474 2019-03-03 02:43:03 -08:00
larshp
0c0cf96e9e bugfix 2019-02-21 06:15:05 +00:00
larshp
5b44d8e89b REPO, remove method RUN_CODE_INSPECTOR
the successful flag is now saved in code inspector class instead
2019-02-20 22:00:36 -08:00
Lars Hvam
ffcd6c82ed
Refactor code inspector (#2412)
* delete method GET_INSPECTION

delete method GET_INSPECTION, not called from anywhere

* delete class ZCL_ABAPGIT_ABAP_UNIT_TESTS

* delete class ZCL_ABAPGIT_SYNTAX_CHECK

* delete class ZCL_ABAPGIT_ADHOC_CODE_INSP

* move VARIANT to importing in RUN

instead of in the constructor

* one variable containing the name

instaed of 2 with same contents

* linting
2019-02-19 21:37:40 -08:00
Christian Guenter
1913b7eaeb AdHoc code inspection: ask user for check variant 2019-01-16 09:33:13 +01:00
Christian Guenter
06c3d69b64 Code Inspector: Fix background processing
This commit enables the code inspector for background processing.
Before this commit is applied code inspection in background resulted in lock errors.
2018-11-05 12:46:58 +01:00
Christian Günter
ef956b9486 Parallelize code inspector 2018-10-02 07:46:57 +02:00
christianguenter2
ea798193d0 Block commit/push if code inspection has errors
- new local setting to set check variant
- new local setting to block pull if code inspector check fails
- check is executed before staging
- new page to display code inspector results
2018-06-28 13:21:29 +02:00