Commit Graph

4891 Commits

Author SHA1 Message Date
Marc Bernard
9e629475dc
Fix dump ASSERTION_FAILED (#5190)
"Exists check" might be called for objects without `TADIR` entry (like `NSPC`). 

Regression of #4952 which removed the "if"

a72d3314cb (diff-4a3135e0f538157951fefdea06986dc644f6005a2af7f6917ff7f7f2f771f622L299)
2021-12-08 20:50:37 -05:00
Marc Bernard
1bed7ae318
Repo view: Set minimum width of status column (#5180)
* Repo view: Set minimum width of status column

As seen in https://github.com/abapGit/abapGit/issues/5178, if the repo view table is very wide, the status column might not wide enough and be wrapped. 

Change ensures a minimum width of the column.

* Reduce

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-08 11:57:25 -05:00
Marc Bernard
97821c8428
Add user exit for adjusting display of filenames (#5185)
The filenames can become very long, for example, usage of many sub-packages, namespaces, objects like function groups, or BSP/Fiori apps with many sub-objects, or a long paths as starting folder. This can make the repository view very busy or render the output as a very wide table (see #5169, #5178).

This exit allows to adjust the filename according to your own rules. 

Here's an example for shortening the display of files for sub-objects:

```abap
  METHOD zif_abapgit_exit~adjust_display_filename.

    DATA:
      lv_path TYPE string,
      lv_name TYPE string,
      lv_ext1 TYPE string,
      lv_ext2 TYPE string.

    SPLIT iv_filename AT '.' INTO lv_path lv_name lv_ext1 lv_ext2.

    IF lv_ext2 IS INITIAL.
      " Main object
      rv_filename = iv_filename.
    ELSE.
      " Sub object
      rv_filename = |…{ lv_ext1 }.{ lv_ext2 }|.
    ENDIF.

  ENDMETHOD.
```
2021-12-08 08:07:45 +01:00
Christian Günter
451ab7cadf
WebGUI: Disable jump (#5184)
Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2021-12-06 16:13:24 -05:00
Christian Günter
ad5bad77cb
Webgui: fix path + file encoding issue (#5182)
Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2021-12-06 15:34:30 -05:00
Marc Bernard
b5af548ed8
Fix "Remove" button for data tables (#5177)
The remove button was not working because it was defined as a second `main` button.
2021-12-03 22:02:46 -05:00
Christian Günter
94e6bdc20b
Patch: Fix link hints (#5176) 2021-12-03 09:10:04 -05:00
Marc Bernard
4910506b35
Fix vimium links (#5175)
* Fix vimium links

* Lint
2021-12-02 07:52:58 +01:00
Christian Günter
29f35b0d47
remove superfluous function name (#5174)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-12-01 09:30:18 -05:00
Marc Bernard
29a9201a3b
Commit page: option to hide author fields (#5171)
* Commit page: option to hide author fields

The vast majority of time the committer is the same as the author (I assume). This adds an option to hide the author name and email fields on the commit form.

* Update docs

* Update docs

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-12-01 09:27:30 -05:00
dependabot[bot]
b512f6477a
Update @abaplint/cli requirement from ^2.82.1 to ^2.82.10 (#5173)
Updates the requirements on [@abaplint/cli](https://github.com/abaplint/abaplint) to permit the latest version.
- [Release notes](https://github.com/abaplint/abaplint/releases)
- [Commits](https://github.com/abaplint/abaplint/commits)

---
updated-dependencies:
- dependency-name: "@abaplint/cli"
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-12-01 09:11:13 +01:00
Marc Bernard
3fa3323b2e
Refactor: Jump to Object Logic (#5158)
* Refactor: Jump to Object Logic

Continue #5114

- Removes jump_adt and jump_se11 from zcl_abapgit_objects_super
- Remove almost all object-specific jump handlers (zif_abapgit_object~jump) since they are covered by GUI Jumper now

* Remove ZCL_ABAPGIT_OBJECT_SICF

* Remove obsolete RS_TOOL_ACCESS

* FUGR

* IATU

* PDXX

* SRVD

* XINX

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-11-29 15:52:13 -05:00
Marc Bernard
9778ec5258
Diff/Patch: Adjust view menu (#5168)
"Ignore Indentation" was not accurate. Renamed it to "Ignore Whitespace".
2021-11-26 10:10:14 -05:00
Lars Hvam
d73825c222
1.113.0 (#5166)
* 1.113.0

* v1.113.0
2021-11-26 08:21:42 +01:00
Shyam Balachandran
9aa0dd154e
SRVB: Service Binding object changes (#4976)
* Fix issue 3443

Service Binding(SRVB) object changes

* Correcting abap lint findings

* Correcting abaplint findings 2

* Update zcl_abapgit_object_srvb.clas.abap

Changes to serialize and exists methods

* Update zcl_abapgit_object_srvb.clas.abap

Correct serialize and exists method

* Update zcl_abapgit_object_srvb.clas.abap

abapgit lint fixes

* Update zcl_abapgit_object_srvb.clas.abap

- Correcting exists method based on feedback
- Removing incorrect DDIC options for SRVB

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-11-26 08:06:50 +01:00
Lars Hvam
0cb1e7e4f8
update npm packages to latest (#5161)
* update npm packages to latest

* upd
2021-11-26 07:47:05 +01:00
Christian Günter
13c4d57dd3
Patch: enable new view options similar to Diff (#5162)
* enable new view options on patch page

* add unit test

* new constant for unchanged lines
2021-11-26 07:41:57 +01:00
Marc Bernard
095c35f49b
Diff: Add options to ignore indent, comments, case (#5146)
* Diff: Add options to ignore indent, comments, case

Continuing on #2804

Enjoy!

* Skip new tests

* Trigger actions

* Trigger action

* Trigger action

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-25 07:33:48 +01:00
Marc Bernard
74cc4610c0
Docs: Add i18n section to dev guidelines (#5160) 2021-11-23 18:37:42 +01:00
g-back
510441d486
Decouple last direct usage of CL_GUI_FRONTEND_SERVICES (#5145)
* Add new methods 


directory_create and directory_exis

* clean up whitespace

* normalize whitespace, formatting, comments

* decouple direct usage of cl_gui_frontend_services

* downport + concatenate to string template

* move param to single line

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-23 09:09:38 -05:00
Marc Bernard
928300a5c2
Repo View: Remove file path in folder view (#5159)
No need to show path when in folder view.

Before:

After:
2021-11-22 19:21:29 -05:00
Marc Bernard
4ecbc30a2e
Add DRUL and DTDC to mass activation (#5156)
* Add DRUL and DTDC to mass activation

DDIC mass activation supports Dependency Rules (DRUL) and Dynamic Cache (DTDC) object

* Len

* Update abap_transpile.json
2021-11-22 13:30:19 -05:00
Marc Bernard
2c4221f109
Skip ZCL_ABAPGIT_INTEGRATION_GIT tests (#5157)
Temporarily skip this test class. Worked ok before #1775, but not anymore.
2021-11-22 13:27:04 -05:00
Alexander Tsybulsky
a671bb8dc3
Expand TABL includes before PUT (#5153) 2021-11-22 12:57:38 -05:00
Marc Bernard
fb3bebe61f
Avoid double action runs - Revert (#5151)
* Avoid double action runs

* Update build.yml

* Revert all

* Revert all
2021-11-19 13:25:19 -05:00
Marc Bernard
de6291a9c0
Avoid double action runs (#5150)
`skip-duplicate-actions` for build job
2021-11-19 13:01:46 -05:00
Marc Bernard
49181d0240
Avoid double action runs (#5149)
Next try using `skip-duplicate-actions`
2021-11-19 12:55:19 -05:00
Marc Bernard
25a29df749
Avoid double action runs (#5148) 2021-11-19 12:20:31 -05:00
Lars Hvam
4301d3e8c8
no chained assignment (#5140)
* no chained assignment

* bugfix
2021-11-19 16:19:27 +01:00
Christian Günter
b6b0aef3b6
add links inside forms to command palette (#5144) 2021-11-18 15:32:19 -05:00
Christian Günter
2dc5626e70
add form actions to command palette (#5141)
* add form actions to command palette

* fix attribute

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-11-18 14:17:52 -05:00
Marc Bernard
543969e870
Fix icon hover in repo bar (#5143)
Closes #5142
2021-11-18 12:12:26 -05:00
Lars Hvam
bc6248edad
docs: supported, use fixed font (#5138) 2021-11-17 14:30:21 +01:00
Christian Günter
9d0e19feb9
add more toolbars to CommandPalette (#5136) 2021-11-17 07:52:47 +01:00
Frank Müller
6d02555f96
Check that include belongs to the same fugr (#5134)
* Check that include belongs to the same fugr

* abaplint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-15 16:50:44 +01:00
Marc Bernard
86262f4e54
Diff/Patch: Add "Filter by Object Type" (#5129)
* Diff/Patch: Add "Filter by Object Type"

Enhancement of filter options:

- Renamed "Type" to "Extension"
- Added "Object Type" 

Closes #3249

* Switch to INSERT

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-11-15 16:48:19 +01:00
Lars Hvam
49bc056fec
unit testing updates (#5111)
* unit testing updates

* upd

* transpile zcl_abapgit_ui_factory

* services repo

* all services

* repo

* zcl_abapgit_cts_api

* zcl_abapgit_default_transport
2021-11-14 16:08:50 +01:00
Christian Günter
500d7eeb9f
hotkeys for form actions (#5133) 2021-11-14 14:55:38 +01:00
Christian Günter
e4b29954a4
Show implicit form hotkeys (#5132)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-14 07:45:44 +01:00
Marc Bernard
060abb8635
Make exceptions compatible with 702 (#5116)
* Make exceptions compatible with 702

702 does not deserialize exception classes correctly that have a constructor in a super class (see #1273). Adding an explicit constructor that calls the super-constructor, the issue is avoided.

* Pretty

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-14 07:28:38 +01:00
Lars Hvam
7affd4e918
docs: installation also refer to ADT (#5131)
ref https://answers.sap.com/questions/13520450/whats-the-se38-or-se80.html
2021-11-12 09:04:08 -05:00
Marc Bernard
8f28a1aab3
Adjust syntax highlighter output (#5128)
* Adjust syntax highlighter output

Minor adjustment to output of syntax highlighter. There's no need to escape quotes, so `e_html_text` is sufficient.

PS: Change will make implementing "Highlight parts where a changed line is changed" a bit easier (#2804)

* Adjust tests

* Update abap_transpile.json

* Update test case

* Revert

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-12 06:55:02 +01:00
Marc Bernard
da3d5c953f
Update guide-changelog.md (#5130) 2021-11-11 18:04:46 -05:00
sandraros
fa5cf53914
Update guide-changelog.md (#5127)
The changelog is displayed only if the repository contains a class which implements `ZIF_APACK_MANIFEST`, whose constructor initializes the current version in attribute `zif_apack_manifest~descriptor-version`.
2021-11-11 17:53:21 -05:00
Marc Bernard
0d957aac17
Exclude package from AJSON mirror (#5125)
* Exclude package from AJSON mirror

Just copy `z*` objects which keeps `package.devc.xml`

* Update package.devc.xml

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-10 16:45:10 +01:00
g-back
289f22d79d
Add Feature: Create New Branch for Commit (#5123)
* add feature: create new branch for commit

* add clarifying comments

* add check for empty branch name

* remove check box, add condense to new branch name

* add duplicate check for branch name

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-11-10 09:19:47 -05:00
Marc Bernard
51aeea2bc5
Update descriptions of MIME objects (#5124) 2021-11-09 17:22:25 -05:00
Lars Hvam
590e7eb175
update to node16 + ignore scripts (#5117)
* update to node16 + ignore scripts

* latest
2021-11-09 16:28:56 +01:00
Marc Bernard
53951dc2ad
Remove more unused variables (#5112)
* Remove more unused variables

* rm

* rm

* rm

* rm

* needed for refactor later

* rm

* Needed for callback

* rm

* rm

* Pragma

* rm enho

* rm

* rm

* Setting unused_variables

* Revert unused_variables setting

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-09 16:22:29 +01:00
Derby
0ee847e383
bug: When Imoprt ZIP does not display error log. (#5121)
In case of offline + Import ZIP, error log is not showed.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-09 16:14:49 +01:00