Commit Graph

2199 Commits

Author SHA1 Message Date
Alexander Tsybulsky
1248319d82 UI move to core package (#2543)
* move to core package

* zcx_cancel to ui_core
2019-03-18 07:58:48 -07:00
Alexander Tsybulsky
1ad16a03fe SCI page deisgn (#2542)
* codeinsp design, phase 1

* fix alpha_output

* final design
2019-03-18 07:58:34 -07:00
Alexander Tsybulsky
85085b6434 improve list css 2019-03-17 01:42:55 -07:00
Alexander Tsybulsky
2ab4ae9f26 Refactor GUI interfaces (#2540)
* refactor gui interfaces

* delete zif_abapgit_gui_router

* move zif_abapgit_gui_page_hotkey to ui

* linter fixes
2019-03-17 01:42:41 -07:00
larshp
ff6725e759 replace uses of log with interface 2019-03-17 01:39:52 -07:00
Jakub Filak
903b794aa2 ux: help users to get that package is versioned
I was approached by a colleague of mine who was not sure how to deal
with the message:

- 'Package $FOO_BAR already in use'

I thought it was caused by the fact that some super or sub-package was
already watched by abapgit but whenI found the message in source codes I
figured out that there is already a repo for that package.

This patch should make the message easier to understand, so the new
version is:

- 'Package $FOO_BAR already versioned as FOO by DEVELOPER'
2019-03-16 03:52:17 -07:00
Alexander Tsybulsky
17dc2501eb GUI, asset manager refactoring (#2536)
* refactor asset manager

* assets man tests

* linter fixes

* linter fix
2019-03-16 03:44:55 -07:00
Martin Fuchs
a1c626ddce Introduce ZIF_ABAPGIT_LOG (#2534)
* ZIF_ABAPGIT_LOG

Introducing the log interface ZIF_ABAPGIT_LOG

* Add ZIF_ABAPGIT_LOG to ZCL_ABAPGIT_LOG

Add ZIF_ABAPGIT_LOG to ZCL_ABAPGIT_LOG
2019-03-16 03:33:58 -07:00
Lars Hvam
5b6cc04159
use RETURNING instead of EXPORTING (#2533)
* READ_FILE use returning instead of exporting

* PARSE_LINE, use returning instead of exporting
2019-03-16 03:33:17 -07:00
Lars Hvam
f9318305e9
Minor fixes (#2532)
* minor fixes regarding unused variables

* minor code inspector fixes
2019-03-15 05:54:39 -07:00
Lars Hvam
a3b3399a8e
v1.86.0 (#2531) 2019-03-15 04:46:42 -07:00
Alexander Tsybulsky
9b38d79cce GUI CORE, move constants (#2526)
* zcl_abapgit_gui constants

* renames in all classes

* zif_abapgit_html

* zif_abapgit_html related renames

* remove gui->free for now
2019-03-15 02:22:08 -07:00
larshp
dcaf585d47 move file_download to ui package
move file_download to ui package, part of #2510

the zip class should ideally work without frontend interaction, and just provide/parse the raw xstrings, this way it can be reused across different frontend technologies
2019-03-15 01:52:42 -07:00
larshp
6dc56433ab allow injection of progress indicator 2019-03-15 01:14:45 -07:00
larshp
4e780068c7 DTEL, skip TPARA
DTEL, skip TPARA #2520
2019-03-15 01:13:15 -07:00
Sdfraga
7c8b2228fb Branch Overview Page gitGraph Horizontal Top scrollbar (#2492)
* Adding HTML new elements to BOverview Page

* Adding gitGraph CSS propertires

* Adding gitGraph scroller function

* Set gitGraph Scroller css width dynamically

* Initialize Top Horizontal Scroller on GitGraph

* Adding setGitGraphScroller() to BOverview HTML

* Fixed HTML wrong TAG

* Adding some comments

* Fixing abaplint messages

* Refactoring Indentation for Travis

* Refactoring for Travis

* Removing trailing spaces for Travis
2019-03-14 02:52:40 -07:00
larshp
c93998abe0 Add auth check exit for repo creation 2019-03-14 10:45:38 +01:00
Martin Fuchs
31fc55af56 fix filter_files_to_deserialize
in method zcl_abap_objects->filter_files_to_deserialize the object condense is done too early, need to be done at the end
2019-03-14 10:14:49 +01:00
Lars Hvam
48f6cb1bb1
move ZCL_ABAPGIT_FRONTEND_SERVICES to UI (#2516)
* move ZCL_ABAPGIT_FRONTEND_SERVICES to UI

move ZCL_ABAPGIT_FRONTEND_SERVICES to UI package

* move factory and interface

* fix errors found by linter
2019-03-14 01:34:19 -07:00
Lars Hvam
88822bb735
add method to determine if running in cloud (#2515)
* add method to determine if running in cloud

add new class and method to determine if abapGit is running on ABAP cloud/Steampunk systems, part of an effort to align codelines #2511

* fix naming

* add simple unit test
2019-03-14 01:33:39 -07:00
larshp
a0a8131db4 fix syntax warning for missing method impl 2019-03-14 00:21:27 -07:00
Lars Hvam
13213e2f2f
decode object name #2504 (#2507)
* decode object name #2504

* fix

* fix
2019-03-14 00:21:02 -07:00
larshp
d8da05b8bc tutorial, show correct abapgit package
tutorial, show correct abapgit package

#2461
2019-03-12 21:49:36 -07:00
GoWa
21527528c6 call redefined method of IF 2019-03-12 21:49:15 -07:00
larshp
25f6284493 implement GET_DESERIALIZE_STEPS
this is a quick fix, field LATE_DESER will be removed in future
2019-03-12 07:37:56 -07:00
GoWale
6b7b2ba5c5 Implement deserialize steps and swap DDIC/ABAP order (#2449)
* Implement deserialize steps swap DDIC/ÁBAP order

* fix for wapa and abaplint

* bugfix in falback logic and type definition

* fixed constant usage

* fixed abaplint and constant usage

* focus only on design change of deserialze

* focus only on design change of deserialze

* Bugfix for CI because of changes of the order

* cleanup

* cleanup

* minor changes

* move types to IF
2019-03-12 02:08:00 -07:00
Sebastian Wolf
a5de7a8769 Add serialization for APACK manifests (#2485)
* Add serialization for APACK manifests

* Add documentation for APACK serialization

* APACK docs: Add more information about dependency format

* APACK: Some words about transporting ZIF_APACK_MANIFEST

* APACK: Move definitions in own interface

* APACK: Don't build the manifest file twice...
2019-03-11 23:34:32 -07:00
Christian Guenter
c7093e753e Remove "disable octicons" user settings 2019-03-06 22:37:05 -08:00
Alexander Tsybulsky
c03bb681b3 Offline icons (#2454)
* font

* css fix and icon rendering

* assets and font link in html head

* more icons

* more css fixes

* replace icon names

* dev docs

* Fonts update

* icons rename

* doc update

* linter fixes

* fix for abapmerge
2019-03-06 00:49:04 -08:00
Lars Hvam
fc167ff3cd
update abaplint config to latest (#2480)
* update abaplint config to latest

* remove some descriptions

* remove more descriptions

* fixes

* fixes
2019-03-04 07:12:42 -08:00
larshp
9b9417b094 remove empty lines in statements #2474 2019-03-03 02:43:03 -08:00
Gregor Wolf
24486c7d56 Add subrc before the value 2019-03-03 00:23:29 -08:00
Christian Guenter
963ff52dab Link hints: disable when no tooltips are visible
- Disable link hints mode when no tooltips are visible, e.g. when we pressed a non-existing combination.
- Smaller refactorings
2019-03-01 00:06:53 -08:00
Gregor Wolf
b04226e8f1 Add missing sy-subrc to exception 2019-03-01 00:06:41 -08:00
larshp
14beb8cfac refactor nested IF to single IF 2019-03-01 00:06:29 -08:00
larshp
7da7327f36 SPRX downport 2019-02-27 21:56:30 -08:00
Gregor Wolf
06097f9614 Add missing Subrc %3D { sy-subrc } 2019-02-27 21:52:30 -08:00
larshp
afa63c8f3b IWPR basic version #75
IWPR basic version #75

can later be extended with implementations of IS_LOCKED, JUMP, and CHANGED_BY

this uses the generic serializer via OBJH, like abapGit-Plugins
2019-02-27 05:34:39 -08:00
Christian Guenter
8cc6567d40 rename zcl_abapgit_tag to zcl_abapgit_git_tag 2019-02-26 21:29:41 -08:00
Gregor Wolf
c22cacb197 Add sy-subrc to exception 2019-02-26 21:29:01 -08:00
Lars Hvam
af3b59b3f0
v1.85.0 (#2458) 2019-02-25 21:55:05 -08:00
Christian Günter
389512f690 Patch / git add -p: Add and remove sections
After this commit is applied it is possible to add and remove
sections of code on the stage/patch page.
2019-02-25 21:29:24 -08:00
larshp
9225e0ea0d More error information, RS_CORR_INSERT 2019-02-25 21:28:23 -08:00
Christian Guenter
f73e18d587 Online repo "display name" to overrule default name 2019-02-25 07:20:01 -08:00
larshp
2011be5696 SICF fixes
save data to field ICFALTNME

clear ICFALTNME_ORIG as the api sets it automagically
2019-02-24 22:46:23 -08:00
Lars Hvam
34e8e0bb69
Uninstall, fix some error messages (#2451)
* SUSO, fix error message

* DDLS error message

instead of "Object could not be deleted"
2019-02-24 22:46:02 -08:00
larshp
ea40225d1c ZCL_ABAPGIT_REPO_ONLINE add testclass include
add testclass include in order to avoid evil dumps while upgrading/reset local
2019-02-24 09:25:50 +00:00
larshp
452c72d6ce move contents of ZCL_ABAPGIT_OBJECT_TABL_VALID to
move contents of ZCL_ABAPGIT_OBJECT_TABL_VALID to ZCL_ABAPGIT_OBJECT_TABL_COMPAR

#2436
2019-02-21 23:05:12 -08:00
larshp
7ff994dd03 fix VCLS diffs in VCLSTRUDEP_TAB #2432 2019-02-21 23:04:56 -08:00
Christian Guenter
e19c54d3a1 New user setting: Disable parallel processing 2019-02-20 22:20:39 -08:00
Lars Hvam
3213d0c2dd
Deserialization performance, refactor COMPARE_TO_REMOTE_VERSION (#2438)
* core part refactored #2436

* indentation

* fix implementations

* delete ZCL_ABAPGIT_COMPARISON_NULL

* pretty print

* Update serializers.md

* downport
2019-02-20 22:20:24 -08:00
larshp
0c0cf96e9e bugfix 2019-02-21 06:15:05 +00:00
larshp
75ee96bce0 Activate parallel DDIC activation #1055
Activate parallel DDIC activation #1055

With this more activation errors will be shown, plus better performance
2019-02-20 22:01:03 -08:00
larshp
897755a0eb SOTR skip creation if already exists #2209 2019-02-20 22:00:51 -08:00
larshp
5b44d8e89b REPO, remove method RUN_CODE_INSPECTOR
the successful flag is now saved in code inspector class instead
2019-02-20 22:00:36 -08:00
Lars Hvam
3cc38cdf90
SPRX, change serialization logic (#2431)
* SPRX, change serialization logic

* some progress

* delete method dequeue_proxy

* move deserialize_proxy to INTF
2019-02-20 22:00:22 -08:00
Lars Hvam
ae5cf8ccc5
PROG + CLAS, suppress popup (#2428)
* PROG, suppress popup

* CLAS, suppress dialog
2019-02-19 21:38:28 -08:00
Christian Günter
a821944e57 Fix filename constr.: Add ext. only if not initial
With this commit we fix the filename construction so that for
objects without file extension the correct filename is constructed.
Before this commit is applied these objects create file names with
an additional dot at the end.
2019-02-19 21:38:16 -08:00
Lars Hvam
ffcd6c82ed
Refactor code inspector (#2412)
* delete method GET_INSPECTION

delete method GET_INSPECTION, not called from anywhere

* delete class ZCL_ABAPGIT_ABAP_UNIT_TESTS

* delete class ZCL_ABAPGIT_SYNTAX_CHECK

* delete class ZCL_ABAPGIT_ADHOC_CODE_INSP

* move VARIANT to importing in RUN

instead of in the constructor

* one variable containing the name

instaed of 2 with same contents

* linting
2019-02-19 21:37:40 -08:00
Christian Guenter
e91697e4e2 New global user settings 'Disable octicons'
With this commit a new user setting called 'disable octicons' is
introduced. Octicons should be disabled when the client doesn't have
internet access or the abapGit UI hangs sometimes.
By default this option isn't active.
2019-02-18 06:31:06 -08:00
larshp
73c3c787ba tadir, delete unused parameter io_folder_logic 2019-02-18 05:28:31 -08:00
Christian Günter
4cdcb53c2b ENHO: check existence before deletion
With this commit we add an existence check the delete method
of ENHO serializer because some enhancements, like implicit source code
enhancements of classes, are deleted implicitly.
2019-02-18 05:28:12 -08:00
Lars Hvam
d0a721b2cf
Move methods to private (#2416)
* ZCL_ABAPGIT_GUI_CHUNK_LIB move 2 methods private

* HTML_ACTION_UTILS move two methods private

* move calculate_skip_testclass to private

* move BUILD_ASX_NODE to private
2019-02-18 05:27:49 -08:00
larshp
d09b97749f delete type tty_lines, not used anywhere 2019-02-18 01:30:42 -08:00
Lars Hvam
9c38004422
Zip refactoring (#2413)
* move method UNZIP_FILE to private

* use LIKE LINE OF
2019-02-18 01:30:26 -08:00
Christian Günter
b588daf5f7 ECATT: remove dynamic method calls #2407 (#2411)
* ECATT: remove dynamic method calls

This commit introduces two new interfaces to remove dynamic method calls.
- ZIF_ABAPGIT_ECATT_DOWNLOAD
- ZIF_ABAPGIT_ECATT_UPLOAD

* ECATT: Rename method

Rename method z_set_stream_for_upload to set_stream_for_upload
as we now use our own interface and there's no risk that SAP 
standard introduces a method with the same name
2019-02-18 01:30:14 -08:00
larshp
c02aa72e99 move get_local_checksums method to private 2019-02-17 01:29:11 -08:00
Lars Hvam
9d4436822e
Cleanup (#2408)
* delete method CHECK_PROG_CHANGED_SINCE

not in use anymore

* delete method ADD_XML_FROM_PLUGIN

looks like it is not used anywhere, also not in plugins

* naming conventions
2019-02-17 01:28:58 -08:00
Lars Hvam
97ca88e909
1.84.0 (#2405)
* update version

* Update changelog.txt
2019-02-15 07:22:06 -08:00
Mattias Johansson
add9450d37 Ignore files not in local repo (#2404)
* Changed default text in branch popup

* Downgrade to Abap 7.02 syntax

* Reduce line length of commit (for abaplint)

* Ignore files that are not in local repo

Ignore files that are not in local repo when doing transport to branch

* Changed line indent

* More indentation fixes
2019-02-15 06:52:36 -08:00
Lars Hvam
e42fa60841
git minor changes (#2403)
* git minor changes

code inspector changes

* pretty print
2019-02-15 06:52:11 -08:00
Lars Hvam
25d4c9ea07
Remove HAS_CHANGED_SINCE #1021 (#2401)
* core part removed

* remove method implementations
2019-02-15 06:51:57 -08:00
larshp
a58652954f limit max threads to 32 2019-02-15 03:27:14 -08:00
Martin Fuchs
94c95d46cb Refactoring of CORR_INSERT and adjustment for object types (#2392)
* Refactoring of CORR_INSERT and adjustment for object types

* CORR_INSERT without CORR_CHECK

* Z exception
2019-02-15 03:26:42 -08:00
larshp
426f815bee downport #2389 2019-02-14 21:10:07 -08:00
Boris Sachsenberg
6cc5e63dfd Exclude reusable includes in FUGR deserialization
Function groups can use includes that were separately created as programs of type include. Those includes could be reusedin various other programs and function groups. They might even be created in a different package. This type of include is an object of it's own that get serialized with it's package as a separate object. Therefore it should not be included in serialization of any function group that uses it. This fix checks for which includes TADIR entries of type PROG exists and excludes them from serialization in FUGR serializer.
2019-02-14 21:09:32 -08:00
larshp
2a3cab2b78 ACID, delete after where-used objects 2019-02-14 07:18:06 -08:00
larshp
de41791d27 background mode, deletion, fix commit message
the message now lists the deleted files, and not all objects that have previously been updated
2019-02-14 07:17:46 -08:00
p-dmitrij
de4c92fb73 SFPF, SFPI: Error by import (issue #2353) (#2388)
* SFPF, SFPI: Error by import (issue #2353)

The renumbering of the attributes "id" and "href" is reworked

* Pretty printer of the full class source

* indentation
2019-02-13 04:49:35 -08:00
Lars Hvam
4e40705350
Downport (#2390)
* SHI3, remove unused variable

* SUSC, constant, plus no need to pass attributes
2019-02-12 21:46:10 -08:00
larshp
e2e703a0bd DOMA do not serialize texts without language #2311 2019-02-12 21:45:53 -08:00
larshp
01f1af8b7f PINF fix deserialization sequence 2019-02-12 21:45:39 -08:00
Lars Hvam
777fabea14
1.83.0 (#2381)
* SPRX supported

* update version

* Update changelog.txt
2019-02-11 22:31:41 -08:00
Dmitry Pisarev
de7dfea3d3 SCP1: Text tables are not imported #2348
The field "recnumber" of the internal table "cs_scp1-scprvall" is condensed now in xml
2019-02-11 22:17:58 -08:00
larshp
5018eae46c refactor public attributes #2369
refactor public attributes #2369
2019-02-09 23:28:22 -08:00
Lars Hvam
e54cac4bdc
fix for user exit SSL ID (#2373)
* fix for user exit SSL ID

* also pass url to HTTP_CLIENT exit
2019-02-09 23:28:09 -08:00
larshp
82296484d4 allow changing remote and branch for write protect
allow changing remote and branch for write protected repos. In the old days changing remote and branch triggered a pull, this is decoupled, so there should be no changes to the local code when switching remote or branch
2019-02-07 03:08:39 -08:00
Lars Hvam
3e1de36861
PINF downport (#2367)
* PINF downport

PINF downport, #2365

* update
2019-02-07 00:56:13 -08:00
larshp
f68c3c244e SPRX: refactor
SPRX: refactor, issue #2365
2019-02-07 00:55:59 -08:00
larshp
474a4b9051 include "SPRX" in SPRX error description 2019-02-05 23:11:34 -08:00
Lars Hvam
30547792dd
use built in types (#2363)
* replace use of x255

* use same type as field source

* remove use of text25

* remove use of numc4

* remove use of DATUM
2019-02-05 23:08:04 -08:00
larshp
6c3e6b85ed SFPF: Error by pulling of an existing object
SFPF: Error by pulling of an existing object #2352
2019-02-05 23:07:38 -08:00
Lars Hvam
cb4479b95b
Cleanup (#2361)
* pretty print

* move identical code outside IF

* remove space before .

* remove unreferenced variables

* remove unreferenced variables

* remove unreferenced variables

* fix pseudo comment

* remove unreferenced field symbols
2019-02-04 23:08:29 -08:00
GoWale
4dceb54758 Flag SET-/GET_PARAM bug - move fix to deserialize (#2360)
* add missing functions in plugin VCLS

* fix pretty print

* fix check usage for abaplint

* adjust detection of locks

* german type

* move fix to deserialize

* fix syntax for 7.02
2019-02-03 22:06:33 -08:00
Christian Guenter
8219acf73b SPRX: improve exception handling 2019-02-03 21:43:32 -08:00
Christian Guenter
f0c8375dbd SOTS: fix code inspector errors 2019-02-03 21:32:38 -08:00
larshp
c6c45baa90 Additional default ignores
Additional default ignores #2347
2019-02-03 21:32:11 -08:00
Christian Guenter
2c8a3f3b17 SPRX: fix class definition 2019-02-03 21:15:44 +01:00
Mattias Johansson
0467707a5b Changed default text in branch popup (#2344)
* Changed default text in branch popup

* Downgrade to Abap 7.02 syntax

* Reduce line length of commit (for abaplint)
2019-02-02 03:52:14 -08:00
Christian Günter
6cc064d794 SPRX: Proxy Object
Proxy objects are quite complex. With this commit we add basic SPRX support.

Working scenarios are:
- Service Consumer
- Service Provider
2019-02-02 03:06:11 -08:00