Commit Graph

208 Commits

Author SHA1 Message Date
Lars Hvam
a0c37350a9
use zcl_abapgit_convert for language code conversion (#6382)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-08-13 13:51:10 -04:00
Lars Hvam
efa8f775ee
ALV: steampunk syntax compatibility (#6381) 2023-07-30 07:52:24 +02:00
ThomasPloski
e177147f10
Introduce ABAP Language Version base functionality (#6346)
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-07-23 15:03:46 +02:00
Alexander Tsybulsky
b50be07041
Separate translations from XML, PO files (#6189) 2023-07-17 10:50:52 +03:00
Alexander Tsybulsky
e2b2f1712d
Refactoring in settings-remote (WIP) (#6300)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-06-01 17:39:41 +02:00
Alexander Tsybulsky
a660f0114e
Modals unification, in-page, own page, better abstraction, on example of settings_remote page (#6277)
Co-authored-by: Marc Bernard <marc@marcbernardtools.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: lars <larshp@hotmail.com>
2023-05-21 14:44:04 +02:00
Marc Bernard
01b4af32fb
Reorg packages (#6285)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-05-16 10:21:01 +02:00
Marc Bernard
583af5c928
Fix xstring conversion on non-Unicode systems (#6237)
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2023-04-22 17:45:03 +02:00
Lars Hvam
80b3c74ce7
extract calls to SUSR_USER_ADDRESS_READ (#6204)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-04-12 07:06:39 +02:00
Marc Bernard
b6beda19f1
Show performance metrics for long-running ops (#6148)
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-03-16 16:53:20 +01:00
Alexander Tsybulsky
abf5bd268b
Refactoring of DB pages, and new UI features (#6134) 2023-03-14 18:04:30 +01:00
Alexander Tsybulsky
c8636912f1
File status refactoring, part 2 (#6124)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-03-06 19:45:20 +01:00
Lars Hvam
02fba0e272
reqirement helper: move type to private section (#6112) 2023-03-01 19:09:15 +01:00
Lars Hvam
110da66989
version: method parse_version_from_source is unused? (#6100) 2023-02-27 08:33:32 +01:00
Alexander Tsybulsky
c0a5fadfee
Refactor popup_to_select_from_list (#6089)
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-02-26 13:02:31 +01:00
Marc Bernard
1ca12015eb
Refactor: replace newline/crlf with built-in (#6057) 2023-02-09 20:03:07 +01:00
Lars Hvam
13714f63a5
git: refactor to use convert class (#6051) 2023-02-08 11:01:40 +01:00
Lars Hvam
41abebbfb8
move method extract_author_data to private (#6040) 2023-02-06 08:06:02 +01:00
Lars Hvam
14d0982fa9
move hash class to git folder (#6039) 2023-02-06 07:39:05 +01:00
Lars Hvam
d856b4ed91
move progress code to new folder (#6031) 2023-02-03 13:41:27 +01:00
Lars Hvam
773f2f7749
refactor, extract git definitions to git (#6029)
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2023-02-03 11:46:00 +01:00
Lars Hvam
7382459a23
rename and move time class (#6024) 2023-02-02 09:28:13 +01:00
Marc Bernard
24e79943f5
Update object descriptions - Part 2 (#6019) 2023-02-02 09:03:51 +01:00
Christian Günter
c61cf0d586
Fix Diff: Ignore comment edge cases (#5984) 2023-01-11 18:45:57 +01:00
Marc Bernard
323dfbd235
Reorg: Package hierarchy (#5946)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-12-15 12:07:02 -05:00
Marc Bernard
9ad6fa8afb
Diff/Patch: Improve beacons (#5914) 2022-12-06 09:02:48 -05:00
Marc Bernard
a6ec3e0c3e
Refactor: BOM handling (#5878)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-11-22 13:14:07 -05:00
Alexander Tsybulsky
969d00b482
Repo overview page, Polishing (#5859)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-11-14 10:13:47 -05:00
Alexander Tsybulsky
1fe63ac80e
Local organization/grouping/labeling of repos (#5814) 2022-11-03 09:03:51 +01:00
Christian Günter
1be856d23a
Fix failing unit test for SAP_BASIS SP00 (#5801)
* Fix failing unit test for SAP_BASIS SP00

before this fix ls_requirement-min_patch gets negative for SP00 and therefore failing

* fix linter

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-10-04 09:53:42 -04:00
Bo Larsson
284f056f60
downport assert_true() (#5711)
closes #5710
2022-08-05 13:18:55 +02:00
Marc Bernard
8baf69ed98
Diff: Properly show diffs for whitespace (#5643) 2022-06-23 14:35:31 +02:00
Marc Bernard
787bc605b0
Propagate codepage conversion errors (#5638) 2022-06-23 07:12:25 +02:00
Marc Bernard
ee2c77e6af
Refactor: Email validation (#5568)
Move `is_valid_email` to utitlity class for reuse
2022-05-18 17:42:45 +02:00
Marc Bernard
3666dda767
Rename methods returning boolean (#5436)
Just a bit of Clean ABAP:
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-nouns-for-classes-and-verbs-for-methods

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-03 10:40:12 +02:00
Marc Bernard
995e77e949
Visualize difference for EOF (#5404) 2022-03-25 06:58:33 +01:00
Marc Bernard
631132736d
UI: Center Popups - Part (#5315)
Adjusting more popups #5275
2022-02-02 07:35:02 +01:00
Marc Bernard
ce31e33688
Refactor: Activation log (#5302)
* Refactor: Activation log

- Merges the activation log into the regular pull log
- Removes duplicate messages

* Update

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-01 15:24:35 +01:00
Marc Bernard
254e6d51e3
UI: Center Popups - Part 2 (#5290)
* UI: Center Popups - Part 2

Adjusting more popups #5275

* Refactor for method length

* Lint indent
2022-01-25 18:40:20 +01:00
Marc Bernard
269c7cb1e6
Adjust diff algorithm (#5251)
* Adjust diff algorithm

This implements a workaround for the kernel issue when determining diffs (see https://github.com/abapGit/abapGit/issues/4395 for background). 

Here's an example of the change.

Before:

After:

* Lint + check

* Add test

* Ignore new tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-11 07:22:46 +01:00
Lars Hvam
1387128719
unit testing updates (#5246)
* unit testing updates

* fix

* split unit test method, ZCL_ABAPGIT_HTML_FORM_UTIL

* run is_empty

* type changes

* update notes

* update

* upd

* update notes

* run check_author_regex

* run parse_commits

* update notes

* add notes

* update

* run extract_author_data1

* run extract_author_data2

* run extract_author_data9

* update notes
2022-01-06 08:14:43 +01:00
Jaime Rodriguez Capote
8175825041
Requirements dependency check (#5223)
* Check req. when release/patch length is different

* Tests for requirement check

* abaplint checks

* Check for pach value longer than 4 characters
2021-12-16 12:00:14 -05:00
Christian Günter
13c4d57dd3
Patch: enable new view options similar to Diff (#5162)
* enable new view options on patch page

* add unit test

* new constant for unchanged lines
2021-11-26 07:41:57 +01:00
Marc Bernard
095c35f49b
Diff: Add options to ignore indent, comments, case (#5146)
* Diff: Add options to ignore indent, comments, case

Continuing on #2804

Enjoy!

* Skip new tests

* Trigger actions

* Trigger action

* Trigger action

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-25 07:33:48 +01:00
Lars Hvam
4301d3e8c8
no chained assignment (#5140)
* no chained assignment

* bugfix
2021-11-19 16:19:27 +01:00
Marc Bernard
a37cf58e01
Refactor: Jump to Object Logic (#5114)
* Refactor: Jump to Object Logic

The goal is to greatly simplify the code to jump to an object, and to separate UI and object layers some more.

This PR introduces GUI Jumper (`zcl/if_abapgit_gui_jumper`), which covers all generic options to show an object. It tries the following options in order:
- ADT (if enabled)
- Workbench with line number
- Workbench without line number
- Transport System (new)

Only if all fail, abapGit will call the object-specific handler. 

Next steps:

- Remove `jump_adt` and `jump_se11` from `zcl_abapgit_objects_super` and replace by GUI Jumper
- Remove almost all object-specific jump handler since they are covered by GUI Jumper now

* Add class

* Lint

* Misleading name
2021-11-07 08:15:08 +01:00
Christian Günter
57879a87ed
Patch: improve performance - new secondary keys (#5102)
* Patch: improve performance - new secondary keys

* cleanup

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-05 05:30:17 +01:00
Christian Günter
0dc66c6246
new algorithm for binary file detection (#5068)
* new algorithm for binary file detection

* only check first 1000 bytes

* cleanup

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-28 15:36:02 +02:00
Marc Bernard
c15b58400a
Enhance diff class (#5044)
* Enhance diff class

- Refactor `zcl_abapgit_diff` to use `RS_CMP_COMPUTE_DELTA` instead of `SVRS_COMPUTE_DELTA_REPS` (needs less code in abapGit)
- Replace `abaptxt_255` with `rswsourcet` which removes 255 character per line limit. Now diffs on long lines are calculated properly.
- Add "ignore indent", "ignore comments", and "ignore case" options. These correspond to the options for the Split Screen Editor in SAP GUI and work the same way. The options are *not* exposed to the UI yet.

Same functionality, same performance.

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-25 16:06:27 +02:00
Frederik Hudák
ea0c834992
Fix syntax check warnings (#5055)
* Fix syntax check warnings

* The classes can be final
2021-10-25 15:33:13 +02:00