Commit Graph

2371 Commits

Author SHA1 Message Date
Lars Hvam
a616f5d3f5
fix protected redef #3053 (#3100) 2019-12-04 10:21:12 +01:00
sandraros
175f2fabec Code selection by column on DIFF screen (#3091)
* Code selection by column on DIFF screen

Fix of #3089

Two ways to select a text:

1. Position the mouse at the start of the text, press mouse left button, keep pressed, drag to the end of the text, release the button

2. Position the mouse at the start of the text, press mouse left button, release the button, position the mouse to the end of the text, press shift key + mouse left button.

Two ways to copy the selected text:

1. Press Ctrl + C or Ctrl + Ins

2. Mouse right button on the text to display the context menu and choose Copy

SPLIT VIEW (code at the left is the LOCAL code and code at the right is the REMOTE code):
- Text can be selected only at the left side, or only at the right side.
- The dummy empty lines which show the place of lines which exist only at the other side are not copied.

UNIFIED VIEW (LOCAL and REMOTE are mixed in the same column, "green plus" lines correspond to lines only in the LOCAL code, "red minus" lines correspond to lines only in the REMOTE code.
- Only the lines from the REMOTE code are copied

PATCH VIEW (split view + one extra column on the left)
- Same features as the SPLIT VIEW

* corrections lint javascript

* merge latest abapgit changes

* corrections lint javascript

* JS refactor functions to prototyped fns (classes)

* JS lint corrections + minor last minute changes

* conform current common.js standards

* LINT conform to common.js standards

* unused lines removed
2019-12-02 09:32:15 +01:00
mariusraht2
02204d07b4 Improved time conversion (#3096)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Improved time conversion

Preparation for #3040

> rename time%3D>get to time%3D>get_unix
> added time conversion from unix to real (get_real)
> added unit tests for time conversion

* abapLint

* Raise cx_static_check and removed exc handling
2019-12-02 09:28:41 +01:00
Paweł Wiejkut
0b5b1b60df InfoObject support (#3058)
* InfoObject support

* Checks fixes

* Code corrections - return and lock check

* Check fix

* addend infoobjects information

* transport and package support

* check fix

* Update ref-supported.md

* metadata change

* Transport fixes
2019-11-27 06:23:54 +01:00
Alexander Tsybulsky
39ee3c961f fix #3048, remote only stage js error (#3086) 2019-11-27 06:19:01 +01:00
Italo N
0f379b950a DOMA: consider clearing VALPOS (#3083) 2019-11-26 07:39:25 +01:00
g-back
965082510b Exchange sy-langu usage with mv_language for consistency (#3082) 2019-11-26 07:29:59 +01:00
Lars Hvam
29cb891d23
remove obsolete NO_HANDLER pragmas (#3085)
* remove obsolete NO_HANDLER pragmas

* update lint to latest
2019-11-25 07:35:41 +01:00
mariusraht2
064e006c88 Issue 3042: Error author regex (#3070)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Tags: Error author regex

> Regex couldn't match with string "pull[bot] <39814207+pull[bot]@users.noreply.github.com> 1573216988 +0000" because "[]" weren't allowed

* abapLint

* Added unit test for author_regex

#3042

* Any character in author name and Unit Tests

#3042
#3069

* Unit Tests and utils method for author regex

#3042
#3069

> Unit Tests for author_regex (zif_abapgit_definitions)
> New utils method for regex check as utils method in zcl_abapgit_utils
> Regex for author expects now at least one character for the author name ('^(.+)'...)
> Use zif_abapgit_definitions%3D>ty_commit_tt  instead of local type of the same type in class zcl_abapgit_branch_overview

* Changed utils method/tests and moved unit tests

#3042 - Error author regex
#3069 - Add unit tests

> Renamed is_author to extract_author_data and moved related source code from branch_overview to utils class
> Changed related unit tests to handle exception or not
> Moved unit tests to local class of zcl_abapgit_utils

* abapLint

* abapLint

* abapLint

* abapLint

* exclude 7bit test for testclass
2019-11-21 06:40:25 +01:00
mariusraht2
6491967d76 Issue 3029: TABL: SAPGUI data preview doesn't work when opened (#3059)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* TABL: SAPGUI data preview doesn't work when opened

Fixes #3029

> Call RS_TOOL_ACCESS instead of ABAP4_CALL_TRANSACTION

* Delete pull.yml
2019-11-17 10:42:21 +01:00
mariusraht2
5fa3057c48 Issue 3042: Error author regex on Tag switch (#3067)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Tags: Error author regex

> Regex couldn't match with string "pull[bot] <39814207+pull[bot]@users.noreply.github.com> 1573216988 +0000" because "[]" weren't allowed

* abapLint
2019-11-17 10:38:09 +01:00
mariusraht2
89dfeb69f8 Issue 3060: Check repo URLs before creating a new online repo (#3063)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Check repo URLs before creating a new online repo

Fixes #3060

* Check repo URLs before creating a new online repo

Use method zcl_abapgit_url%3D>name and replace the assert with an exception
2019-11-17 10:31:27 +01:00
mariusraht2
8df12d34e0 Issue 3061: Change default value for creation of playground page (#3062)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Change def. value for creation of playground page

Closes #3061

* Update zcl_abapgit_popups.clas.abap
2019-11-17 10:18:40 +01:00
Christian Günter
83a781e1d7 IWVB: SAP Gateway Business Suite Enablement -Vocab (#3049) 2019-11-12 11:03:04 +01:00
Alexander Tsybulsky
5edea3acda quick fix unicode char in js (ctrl+enter) #3035 (#3052) 2019-11-11 09:21:22 +01:00
Christian Günter
93f5186b1d Object serializer descriptions (#3050) 2019-11-11 09:15:03 +01:00
Christian Günter
061245a33b IAXU: downport no static call of CL_W3_API_XML3 (#3047)
* IAXU: downport no static call of CL_W3_API_XML3

* downport check_duplicates
2019-11-08 13:02:12 +01:00
Lars Hvam
3776ac353a
Get all branches, including pull request refs (#3031)
* update example for listing branches

* do not ignore any branches

* add new get_all method

* Update zcl_abapgit_git_branch_list.clas.testclasses.abap
2019-11-06 09:51:34 +01:00
mariusraht2
4f1ed3b8b6 Exception Handling: IATU refactored (#3043)
* Create pull.yml

* Refactored IATU

* Delete pull.yml

* abapLint
2019-11-06 09:46:35 +01:00
mariusraht2
fb527126ef Fix applied (#3037) 2019-11-06 09:42:47 +01:00
Lars Hvam
04a6d7e484
Update abaplint.json to latest (#3045)
* Update abaplint.json

* chain mainly declarations
2019-11-06 09:35:18 +01:00
mariusraht2
e014efd3f4 log viewer: refactor types (#3041) 2019-11-06 09:30:21 +01:00
Lars Hvam
678b3bebd5
pretty print class (#3032) 2019-11-06 08:53:28 +01:00
g-back
7c05815437 Small refactorings (#3033)
* remove unusued variables

* surround "recover_version" calls with try-catch
2019-11-05 08:09:47 +01:00
Italo N
be9b57a0f2 Commit form should not be cleared on error (#3015)
* Commit form should not be cleared on error

* move the type definition to ZIF_ABAPGIT_DEFINITION

* Move type definition to new interface
2019-11-04 11:48:53 +01:00
Alexander Tsybulsky
f0bb81f04a #3022 patch commit state 2019-11-03 07:57:28 +01:00
Alexander Tsybulsky
d501afdf83 downport (#3026) 2019-11-01 17:25:44 +01:00
Frederik Hudák
509a69e480 'Duplicates' error: show duplicate object names (#3024)
* 'Duplicates' error: show duplicate object names

* Update zcl_abapgit_objects.clas.abap

* Update zcl_abapgit_objects.clas.abap
2019-11-01 17:22:04 +01:00
Lars Hvam
dca54d2590
refactoring public attributes (#3023)
* testclass for testing and remove public attr

* refactor public vars in local class

* rename
2019-11-01 17:07:17 +01:00
Lars Hvam
9c6bba620c
1.91.0 (#3019)
* 1.91.0

* Update changelog.txt
2019-10-31 15:16:45 +01:00
Italo N
7d587e1a1a Issue #2957 (#2975)
But It's generate a lot of DIFF, when XML remote has the INDEX filled.
2019-10-31 15:07:59 +01:00
Frederik Hudák
04e196b816 Improve branching messages (#3018)
Mention name of branch which was just deleted/switched to.
2019-10-31 14:35:29 +01:00
Alexander Tsybulsky
4f3bd19a8b stage UX improvements: ctrl-enter, autoadd deleted, remote state bugfix (#3007)
* stage: ctrl-enter, autoadd deleted

* linter fix

* eslint fix

* review fixes
2019-10-31 14:29:23 +01:00
Christian Guenter
99761e37c9 Links: add tooltip with hotkey 2019-10-31 08:42:37 +01:00
Johan Wigert
df303d2cc6 Object should be removed, but has NO deletion flag in transport (#3009)
* Update zcl_abapgit_transport_objects.clas.abap

* Update zcl_abapgit_transport_objects.clas.testclasses.abap
2019-10-30 06:50:16 +01:00
Alexander Tsybulsky
1af5648e5f Diff state at stage and commit pages (#3003)
* state at stage and commit pages

* review fix
2019-10-27 11:26:59 +01:00
Italo N
f4c8d13a2c Bug - PROG name contain '%3D' (#2980)
Issue #2923
2019-10-27 11:19:32 +01:00
Christian Günter
c99ff03253 FTGL: feature toggle (#3004)
* FTGL: feature toggle

* update ref-supported

* Update ref-supported.md
2019-10-27 08:46:57 +01:00
Alexander Tsybulsky
af97a51fa5 commit selected button (#2993) 2019-10-25 06:46:01 +02:00
mariusraht2
3900842392 Add object type IAXU (#2978)
* Possible Solution #1

* Update zcl_abapgit_objects_super.clas.xml

* abapLint

* Removed german language flag

* Fixes

* Removed flag for german language

* Removed test code

* abapLint

* Implemented suggestions from PR

> mo_xml_api is just local now
> li_service removed
> implemented exception handling for calls of xml api methods set_changeable, delete and save
> integrated sy-subrc into all exception calls
> wrote update routine if IAXU object already exists (object will be deleted first and after that local method save is called)

* abapLint

* abapLint

* String template, restructured api methods

* Remove descriptions

* abapLint

* Fixed issues after restructuring api methods calls

* Alternative error handling for existence check

* Use api existence check instead of load

* Fixed some bugs
2019-10-24 05:53:12 +02:00
Alexander Tsybulsky
fc2c803be5 me filter 2019-10-22 15:27:28 +02:00
larshp
523ab5c862 refactor CONSTANT definition 2019-10-20 14:51:34 +02:00
David Scheiklies
f4e33039d6 Add commit success message (#2979)
* New version of #2973

* Update zcl_abapgit_gui_page_commit.clas.abap
2019-10-16 21:40:17 -07:00
Christian Günter
b7d0f2115e SMTG: OM: Email Template implementation (#2976) 2019-10-15 22:32:03 -07:00
g-back
033b32de7d Repository-Validation: More specific Error Message (#2965)
* add additional read to better specifiy error msg

issue #2914

* add line break in error message
2019-10-15 22:23:23 -07:00
Alexander Tsybulsky
5c10415b28 possibility to export pkg with master lang only (#2966) 2019-10-13 23:02:42 -07:00
Christian Günter
bc082b15b0 Link Hints: fix start value calculation (#2970)
* Link Hints: fix start value calculation

* fix comment
2019-10-13 22:39:56 -07:00
Marcello Urbani
b8cc55ec3f Fixes #2904 dump importing zip (#2963)
* Fixes #2904 dump importing zip

* Fix linting issues
2019-10-12 04:00:10 -07:00
Alex
17a67933e3 Fix for issue #2922 (#2960)
* added a picture for pull from zip

it can then be used in guide-import-zip.md

* Fix for Issue 2922

https://github.com/larshp/abapGit/issues/2922

Added a new test method find_head_closing_tag.
Implemented fix in method zcl_abapgit_gui_html_processor->find_head_offset.

* Removed dont needed Pull_from_zip.png 

Removed dont needed Pull_from_zip.png

* Restored NewLines handling in patch_html

Restored NewLines handling in patch_html

* Fixed some abapLint Warnings

Fixed some abapLint Warnings

* Fixed some abapLint messages

Fixed some abapLint messages
2019-10-12 03:56:28 -07:00
ThomasPloski
dcb4d94275 Support of Baseinfo String for DDLS Object Handler (#2967)
* support of baseinfo string in ddls

* fixes abaplint findings

* fixes abaplint issues
2019-10-11 05:41:01 -07:00