Commit Graph

4704 Commits

Author SHA1 Message Date
Lars Hvam
a798bdeda2
Enable unit test debugging in vscode (#4891) 2021-08-11 11:34:54 +02:00
Lars Hvam
b547fd2d0f
docs: minor change, add ")" (#4892) 2021-08-06 08:12:24 +02:00
Lars Hvam
329fd9dc0e
interface and factory for ZCL_ABAPGIT_PERSIST_SETTINGS (#4882)
the old get_instance() method in ZCL_ABAPGIT_PERSIST_SETTINGS has been moved to a method in zcl_abapgit_persist_factory, plus interface added. Added to persist injector
2021-08-03 15:13:16 +02:00
Lars Hvam
e6bac818cf
git transport: add unit test for parse() (#4889) 2021-08-03 10:33:24 +02:00
Lars Hvam
ddcb538ccd
get_null(), fix syntax error (#4890) 2021-08-03 10:27:24 +02:00
Lars Hvam
19304ad924
change local hostname determination (#4885)
* change local hostname determination

* fix
2021-08-03 06:49:45 +02:00
Lars Hvam
2bde0ce55a
simplify get_null() + git branch list: add unit test (#4886)
add unit test which parses the response from hex, ie. containing a real null value

simplify get_null() method, it only returns 1 character, but 2 characters are calculated
2021-08-03 06:47:16 +02:00
github-actions[bot]
9d1e14a90d
ajson, Automatic Update (#4888)
* [create-pull-request] automated change

* Update zcl_abapgit_ajson.clas.locals_imp.abap

* Update zcl_abapgit_ajson.clas.locals_imp.abap

* Update ajson_mirror.yaml

* skip parse_bare_values

Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-02 06:57:22 +02:00
Lars Hvam
a85ffb83d0
update npm dependencies (#4887) 2021-07-31 20:01:20 +02:00
Lars Hvam
da310e0137
zcl_abapgit_exit: add IF gi_exit IS NOT INITIAL. (#4884)
* zcl_abapgit_exit: add IF gi_exit IS NOT INITIAL.

* set description
2021-07-31 11:28:00 +02:00
Lars Hvam
9f025fa656
testing scaffolding (#4875)
* additional classes are transpiled
* additional unit tests run under node.js
* `abap_transpile.json` moved to folder `/test/` from root
* new `npm run integration` target, doesnt really do anything yet
* new `/test/Readme.md` with [notes and stuff](https://github.com/abapGit/abapGit/pull/4875/files#diff-5de36acd90308dc62abf7855a686ee7052ffb6e762c756fd735fb0c9fbd9595d)
2021-07-29 16:55:43 +02:00
Lars Hvam
ed4fb14582
actions: only run one build job (#4880)
* Update build.yml

* Update build.yml

* Update build.yml
2021-07-29 16:51:16 +02:00
Lars Hvam
e075b951a4
align use of unescape_url() (#4878) 2021-07-29 16:49:38 +02:00
Lars Hvam
8068e8fb0e
git transport: move constants to method (#4877)
the constants are only used locally in the method, the definitions have been moved to the method instead of the private section of the class
2021-07-22 06:56:40 +02:00
Lars Hvam
910bf46ae4
XML unit test, follow up (#4876) 2021-07-21 11:58:40 +02:00
Lars Hvam
9675ad6007
Replace use of type W3URL with string (#4874)
* replace W3URL with string

* fixes

* ASSERT strlen( iv_url ) <= 250.
2021-07-21 11:41:56 +02:00
Lars Hvam
e74c68e204
Decouple XML from UI factory (#4873) 2021-07-21 11:39:47 +02:00
Christian Günter
553d1f2319
LinkHints: trigger onclick event for checkboxes (#4870)
* LinkHints: trigger onclick event for checkboxes

* refactor

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-20 16:33:34 +02:00
Lars Hvam
a52ab7329b
update deps + additional unit testing via open-abap (#4871) 2021-07-18 13:17:24 +02:00
Marc Bernard
ab3f24fe06
BRF+ System Application (#4856)
* BRF+ System Application 

- Clear user/time/system-specific fields
- Fix deletion of object
- Remove unnecessary "exists check"
- Updated test case https://github.com/abapGit-tests/FDT0

* Lint

* Lint

* WEBI: Improve error handling

Pass messages to log

* Reverse WEBI

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-17 10:26:47 +02:00
victorizbitskiy
73496a2755
Refactor: Exception handling #4852 (#4869)
https://github.com/abapGit/abapGit/issues/4852
2021-07-13 09:13:25 +02:00
Marc Bernard
6ff7074aec
Auto creation of package during new online (#4814)
* Auto creation of package during new online 

If you create a new online repository and the repo does not contain any SAP package, then abapGit will prompt you for the package attributes and create the package for you. This is, for example, the case when you use an newly created online repo as a starting point. 

If the repo does contain a package, then the package will be created automatically when you pull from the repo (as described in [docs](https://docs.abapgit.org/ref-packages.html)).

Closes #4538

* Update docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-07-09 15:28:55 +02:00
Christian Günter
bffe75958c
SMTG: Implement changed_by (#4867)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-09 15:23:58 +02:00
Frederik Hudák
2cfb2790cf
Open repo - disable enter if command field is open (#4868) 2021-07-08 09:31:57 +02:00
Marc Bernard
39512676ca
WEBI: Improve error handling (#4864) 2021-07-06 17:36:40 +02:00
Marc Bernard
1d98688be5
Dialogs: Set autofocus on first form element (#4853)
* Dialogs: Set autofocus on first form element

Improves usability. 

Closes #4816

* Autofocus for commit page

- Works in case JS is not an option

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-06 11:41:34 +02:00
Frederik Hudák
60a82331b5
Add more keyboard shortcuts for main page (#4846)
* Add more shortcuts for main page

* Update zabapgit_css_common.w3mi.data.css

* Update zcl_abapgit_gui_router.clas.abap

* Change keyboard shortcuts

* fix js

* fix js

* deindent

* indentation

* one more

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-07-06 11:32:27 +02:00
Marc Bernard
2e7d642786
ECVO: Fix "empty xml" error (#4863)
* ECVO: Fix "empty xml" error

Fixes regression from #3991

* Upload
2021-07-06 11:11:27 +02:00
Marc Bernard
7c32f824df
TABL: Clear DB Indexname (#4850)
Fixes diffs because platform specific DB index names. 

Updated test repo: https://github.com/abapGit-tests/TABL_with_index

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-01 14:15:32 +02:00
github-actions[bot]
a8eb86b747
[create-pull-request] automated change (#4855)
Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-01 14:13:47 +02:00
Lars Hvam
5365f536ae
update deps (#4854)
* update deps

* upd
2021-07-01 10:08:09 +02:00
Sascha Wächter
30615e848e
Started with BRF+ serialization and fixed some errors from the first attempt (#4797)
* Fixed Version BRF+ Integration

* BRF+ serialization

* Fixed obsolete parameters and wrong boolean type

* Fixed some errors and filtered ComponentReleeases

ComponentReleeases in XML Export and Import of BRF+ API can be omitted and works also the same. Next try if I could delete the useless metadata (User, System, etc...) or must leave them empty and fill them manually before deserialization.

* Some little changes

Removed Parameter iv_marked_option for older releases and removed method wb_request_choice. Changed to transport automatically.
Aligned some parameters.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-06-28 13:29:56 +02:00
Marc Bernard
3defa2c165
WDCA: Clear parameter descriptions (#4851)
Fixes diffs because of parameters that are different between releases (or even SPs) or languages
2021-06-22 16:47:45 +02:00
Mike Pokraka
b1cc6a2912
Refactor method in FM call for 702 (#4848) 2021-06-15 09:43:04 +02:00
Frederik Hudák
f892c9b4dc
fix unclosed tr tag (#4845)
* fix unclosed tr tag

fixes mistake from #4771
2021-06-14 18:23:59 +02:00
Frederik Hudák
d4cbf7059e
Repo overview - rework action buttons + cosmetic changes (#4771)
* Repo overview - cosmetic changes

* extract logic to method

* Update src/ui/zcl_abapgit_gui_page_repo_over.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* fix if in if

* unshorten remote, move package, improve wrapping

* Add max width for columns

* Mostly working now

* add prefixes

* Remove checkbox, move package where it was

* Keyboard navigation

< > to navigate in list (arrow keys don't seem to trigger), enter to open selected

* Ellipsis for repo url, use css variable

* Fix css, js persistence

* Fix invalid function name

* add back !important to override hover color

* abaplint

* Don't use const in js

* more eslint

* Remove unused field symbol

* eslint

* Bring back repo lock icon, styling improvements

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-06-14 14:44:38 +02:00
Christian Günter
6f8e3f45fa
Set focus: fix code inspector warning + improve error handling (#4843)
* Set Focus: fix code inspector warning 

+ improve error handling

* fix method signature
2021-06-14 10:58:01 +02:00
Mike Pokraka
a9c40ea972
Remove experimental status from PDTS (#4831)
* Remove experimental status of PDTS

* Remove experimental status from PDTS
2021-06-10 10:03:17 +02:00
Marc Bernard
f857194037
Focus HTML control on abapGit startup (#4817)
* Focus HTML control on abapGit startup 

`cl_gui_control=>set_focus` must be called during PBO. Maybe there's a nicer way to pass the HTML control to the PBO.

* Move to output form

* Set focus

* Add autofocus
2021-06-09 17:24:59 +02:00
Marc Bernard
34f350499c
Adjust documentation for mobile devices (#4827)
I tested the change with Google Dev Tools and docs.abapgit.org should work now also on devices with smaller screens.

Closes #4824
2021-06-08 16:52:17 +02:00
Lars Hvam
096aded586
LANGU rollbacks (#4829)
* LANGU rollbacks

#4828

* Update abaplint.json
2021-06-08 16:42:20 +02:00
Lars Hvam
753c2f5d21
Do not read TADIR-KORRNUM (#4825)
KORRNUM is misused for calculating the serialization sequence
2021-06-07 14:49:11 +02:00
Marc Bernard
a92059d059
Docs: Fix image links (#4823) 2021-06-06 10:16:14 +02:00
Marc Bernard
435bc07150
Docs: Add CI description (#4820)
* Docs: Add CI description

Moved description from https://github.com/abapGit/CI readme

* Images

* Add json example

* Add link

* Link

* Update ci.md

* Update docs/collections/_development/ci.md

* Update ci.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-06-06 09:45:35 +02:00
Marc Bernard
38c453eb8b
FTGL: Update transport when deleting (#4821)
Add object to transport when deleting it.
2021-06-06 09:43:05 +02:00
Lars Hvam
6098a4fbdb
update deps (#4818)
* update deps

* upd
2021-06-06 09:41:13 +02:00
Marc Bernard
ce731ecd22
Docs: Formatting of changelog description (#4819)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-06-04 15:14:43 +02:00
Marc Bernard
887e7dd332
Offline repo: "Compare via RFC" feature (#4789)
* Offline repo: "Import via RFC" feature

Adds option to **offline** repositories for importing a repo via an RFC connection from another SAP system. It's a shortcut for doing "Export ZIP" in one system, and "Import ZIP" in the other.

Closes #4784

Pre-requisite: abapGit develop version (with this change) is installed on remote SAP system. 

Note: The general recommendation is to use **online** repositories and a git server for comparing and synchronizing systems.

* Lint

* Create guide-import-rfc.md

* Langu

* Langu

* Write-protect only

* Compare

* Compare

* Compare

* Compare

* Git

* Update docs/guide-import-rfc.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-06-04 15:09:09 +02:00
Marc Bernard
e2a156a326
Replace deprecated LANGU type (#4815)
* Replace deprecated LANGU type

Replace with `sy-langu` and update abaplint rule

* Replace langu

* Add langu to void types

* Replace table of langu
2021-06-02 08:04:05 +02:00
Marc Bernard
4cdb04c2c7
SCVI: Replace generic with native check (#4808)
* SCVI: Replace generic with native check

Replaces generic exist check with native function call

* Variable

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-06-01 13:05:49 +02:00