Commit Graph

4704 Commits

Author SHA1 Message Date
Lars Hvam
7b336a4a71
cleanup unused local variables (#4739) 2021-05-01 09:51:05 +02:00
dependabot-preview[bot]
2e65b3e9fd
Update @abaplint/cli requirement from ^2.74.10 to ^2.74.11 (#4743)
Updates the requirements on [@abaplint/cli](https://github.com/abaplint/abaplint) to permit the latest version.
- [Release notes](https://github.com/abaplint/abaplint/releases)
- [Commits](https://github.com/abaplint/abaplint/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-01 09:49:08 +02:00
fdupret
10b6c550e2
Fix wrong variable used (#4741) 2021-05-01 09:46:14 +02:00
Marc Bernard
1150390bdd
Settings: Adjust background (#4731)
Changes background to secondary color (same as repo top bar)
2021-04-29 17:20:04 +02:00
Lars Hvam
b2d7dbd81e
update deps (#4730) 2021-04-29 07:14:41 +02:00
Marc Bernard
d47c72f429
Remote Settings: Toolbar icon & clean-up (#4724)
* Remote Settings: Clean-up

Continue #4718

- Branch > Switch to PR: removed
- Advanced > Checkout commit: removed
- Advanced > Make Offline / Online: removed menu items and popups
- Advanced > Change Remote: removed menu item and page

* Remove ty_popups

* Remove checkout_commit

* Remove repo_view switch_to_pr

* Remove get_switched

* Add "Edit" icon also for offline

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-27 19:03:06 +02:00
Marc Bernard
0feff94a32
Add icons and update icon docs (#4721)
* Update icon docs

Help, Utilities, Edit, Info, In Progress (Github annotation status), Failure (Github annotation status)

* Add icons

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-27 18:58:00 +02:00
Mike Pokraka
58956a1059
Refactor PDTS into PDXX superclass (#4717)
* Add superclass

* Refactor into PDXX superclass

* Unit tests respect experimental indicator

* Lint

* Lint

* Lint+CHECK misbehaving

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-27 18:53:26 +02:00
Marc Bernard
2884cf21ba
Docs: Extend "ignore files" description (#4725)
Closes #3694
2021-04-27 06:33:16 +02:00
Lars Hvam
9576a83e0e
docs: update links and articles (#4716) 2021-04-25 10:02:49 +02:00
Lars Hvam
1b9674e620
git transport: error on empty git reply (#4714) 2021-04-25 10:01:10 +02:00
Marc Bernard
a225e05950
New "Remote" tab in repo settings (#4705)
* New "Switch" tab in repo settings

This PR adds a new tab to the repo settings which combines all options for switching the repository to a different source:

- Switch between "Online" and "Offline"
- Switch to Branch, Tag, Commit, or Pull Request

Note 1: Value help for URL history has not been implemented yet.

Note 2: None of the existing related menu items have been removed yet.

* Clean-up

* Clean-up

* Clean-up

* Clean-up

* Clean-up

* Change to "Remote"

- rename class 
- add "autosave" for on/offline switch
- change "Switch" to "Remote"

* Update on/offline switch

* Update on/offline switch

* Update zcl_abapgit_gui_page_sett_remo.clas.abap

* Grammar

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-25 09:59:00 +02:00
Frederik Hudák
b1c76b9852
DCLS: implement changed_by (#4712) 2021-04-21 08:53:29 +02:00
Mike Pokraka
69ac4fd768
Change some masters to main %26 remove unused parameter (#4710)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-19 17:15:47 +02:00
Lars Hvam
3afc2fa1b5
change deploy build setup (#4711)
* change deploy build setup

* +x
2021-04-19 17:12:11 +02:00
github-actions[bot]
f264f33b7e
ajson, Automatic Update (#4708)
* [create-pull-request] automated change

* Update ajson_mirror.yaml

Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-18 11:36:07 +02:00
Lars Hvam
b23c0dc1b8
ajson, automatically PR from mirror (#4707)
* ajson, automatically PR from mirror

* upd

* upd

* upd

* upd

* upd

* setup node v2

* update deps

* upd
2021-04-18 11:19:57 +02:00
Mike Pokraka
dd6becccbe
Accept remote without HEAD (#4706)
* Accept remote without HEAD

* Update src/git/zcl_abapgit_git_branch_list.clas.testclasses.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-18 11:18:33 +02:00
Marc Bernard
41b301cc11
Fix dump in case of package name conflicts (#4704)
Replaces assert with error message (#4620)
2021-04-16 10:05:14 +02:00
Marc Bernard
f55cdcc253
Refactor filename logic (#4697)
Combines `zcl_abapgit_file_status=>identify_object` and `zcl_abapgit_object_files=>filename` into new class `zcl_abapgit_filename_logic`. This class provides `file_to_object` and `object_to_file` conversion logic similar to what `zcl_abapgit_folder_logic` does for packages and git folders. 

Also includes unit tests which were missing for the old methods.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-15 16:14:53 +02:00
Marc Bernard
f18a8ee82b
Terminology: Inclusive Language - Part 5 (#4702)
* Terminology: Inclusive Language - Part 5

Change of terminology (#4043)

- Replace `get_master_language` with `get_main_language` and remove it

* File Status

* Jump

* Language

* Main language

* Main language
2021-04-15 08:32:09 +02:00
g-back
4c6d407156
Export Package to Files: Fix for Namespaced Packages (#4701)
* escape package only for file name


make package parameter immutable

* fix form id
2021-04-14 12:43:24 +02:00
Marc Bernard
f290658941
Fix HTML for news panel (#4695)
* Fix HTML for news panel

Add missing `<ul>` tag

* Adjust UL

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-14 09:24:02 +02:00
Christian Günter
a3b6ad8d80
fix nbsp (#4677)
fix nbsp

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-14 09:21:26 +02:00
Lars Hvam
5c5982a6c5
update deps (#4699) 2021-04-14 09:00:17 +02:00
Marc Bernard
23f62b993f
ENHx: Change order for deserialize (#4698)
Enhancements might refer to other objects of the repo so create them after the other objects.

Example: Repo includes enhancement for an exception class. Therefore, the exception class has to be deserialized before the enhancement.
2021-04-13 06:39:34 +02:00
Marc Bernard
eb8812eaac
Show "data" by object in repo view (#4689)
* Show "data" by object in repo view

Continuing on #3441

- "data" is now shown as `TABU` `<table>` in the repo view

* Remove get_item

* Add cmnt

* Update src/objects/core/zcl_abapgit_serialize.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update zcl_abapgit_serialize.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2021-04-12 14:53:09 +02:00
Marc Bernard
631d0fdccb
Refactor status calculation (#4679)
* Fix dump due to package name conflicts

Raises an error message instead of dumping

Closes #4620

* Split calculate_status

* Refactor only

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-10 11:26:31 +02:00
Marc Bernard
7bc767312e
Catch send errors in HTTP client (#4690)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-10 11:17:26 +02:00
Marc Bernard
d9f4ee7a54
Remove BCS usage (#4693)
Closes #4440

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-10 11:13:35 +02:00
Marc Bernard
086a23daca
ODSO: Replace exceptions that exist in SAP_BW only (#4694)
Closes #4692
2021-04-10 10:55:57 +02:00
Marc Bernard
b6db4e2c23
Adjusting to "main" branch (#4691)
* Adjusting to "main" branch

* Adjust filename
2021-04-08 13:02:20 +02:00
Marc Bernard
607ac4f3ab
SOTS: Uninstall with usage reference (#4687)
* SOTS: Uninstall with usage reference

Remove usage references of `SOTS` texts during uninstall

* Add comment

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-08 10:33:13 +02:00
Marc Bernard
cea83ffb86
Improve reuse of HTML viewer (#4688)
* Improve reuse of HTML viewer

Adding optional parameters to allow reuse of HTML viewer in subscreens and allow testing of query parameter table (potential replacement of `zcl_abapgit_html_action_util=>parse...`).

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-07 17:50:31 +02:00
Marc Bernard
cd6da45a12
ENHx: Improve error messages (#4686)
Include reference to previous exception and exception texts in error messages for enhancement implementations (`ENHO`, `ENHC`)
2021-04-07 17:48:53 +02:00
Lars Hvam
1fb55fe3e8
TLOCK performance (#4636)
* add new method get_transports_for_list

* downport

* read tlock into local buffer

* fix

* refactor

* upd

* cleanup

* bugfix

* return data

* refactor staging page to use new logic

* lower case

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2021-04-03 09:06:45 +02:00
Marc Bernard
bf5199b8d2
APACK: Replace interface name with constant (#4684)
* APACK: Replace interface name with constant

Closes #4248

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-03 08:59:44 +02:00
Marc Bernard
de6f8b9bbc
Ignore unit test if experimental features are not enabled (#4683)
Closes #4678

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-03 08:47:22 +02:00
Marc Bernard
2a99c742eb
Add header for status column in repo view (#4680)
* Add header for status column in repo view

* Sort status

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-01 17:12:54 +02:00
Marc Bernard
b6e7efd75b
New online repo: Replace "clone" with "create" (#4682)
Closes #4681
2021-04-01 17:11:11 +02:00
Alexander Tsybulsky
e5e558a312
Log refactoring, part 1 (#4676)
* log: new features

* log in exception

* log via gui_services

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-27 10:57:57 +01:00
Marc Bernard
56a0dca134
Refactor: Objects Class (#4664)
* Refactor: Objects Class

Splits `zcl_abapgit_objects` into smaller classes

Moves the following methods and related test cases:

`zcl_abapgit_objects_check`
- `deserialize_check`
- `warning_overwrite_find`
- `warning_package_find`
- `checks_adjust`
- `warning_overwrite_adjust`
- `warning_package_adjust`

`zcl_abapgit_files_deserialize`
- `files_to_deserialize`
- `filter_files_to_deserialize`
- `prioritize_deser`
- `adjust_namespaces`

* PP

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-27 10:46:38 +01:00
Marc Bernard
fd49e8dbe6
No changes during upgrade or locked system/client (#4674)
In addition to the client setting (repository objects modifiable or not, scc4), abapGit will not allow changes to any local objects, if

- system is set to "not modifiable" (se03)
- system is running an upgrade
- system is a shadow system

Closes #4267

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-27 10:29:38 +01:00
Mike Pokraka
624616674c
Replace SELECT * with field list (#4675) 2021-03-27 09:07:08 +01:00
Marc Bernard
73dde20557
Add warning if namespace is not modifiable (#4669)
* Add warning if namespace is not modifiable

Closes #4648

* If

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-26 09:11:35 +01:00
Marc Bernard
0c2f060445
Fix namespace check (for DOCT objects) (#4671)
Improve regex to avoid conflict with object names that contain multiple `/`

Closes #4670
2021-03-26 06:45:48 +01:00
Marc Bernard
8f0532d015
ENHC: Fix error when updating object (#4667)
If the composite enhancement already exists, trying to update it fails with error "Error while creating enhancement implementation"

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-25 12:19:34 +01:00
Marc Bernard
18d484af39
PROG: Refactor deserialize and fix inactive code (#4657)
* PROG: Refactor deserialize and fix inactive code

This is a follow-up to #4500, #4509, #4518

- Split `ZCL_ABAPGIT_OBJECTS_PROGRAM->DESERIALIZE_PROGRAM` into smaller methods
- `INSERT_PROGRAM` now uses standard `RPY_PROGRAM_INSERT` and only does `INSERT REPORT` in exceptional cases like function groups (see below)
- Special case of Code Inspector variants is handled by `ZCL_ABAPGIT_OBJECT_PROG->DESERIALIZE_WITH_EXT` since these aren't actual programs (but includes containing data)

Using the standard function fixes the issue of inactive code that can't be accessed after a pull. This used to happen, for example, when a program contained syntax errors due to missing objects.

* Update zcl_abapgit_objects_program.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-25 07:56:20 +01:00
Marc Bernard
4c8f7fe117
ENHO: Clear fields for exceptions (#4666) 2021-03-24 14:55:11 +01:00
g-back
eee6b00378
Minor fixes/changes (#4665)
* remove assert, remove unused variable

* update documentation, follow-up to #4663
2021-03-24 13:34:02 +01:00