Commit Graph

53 Commits

Author SHA1 Message Date
Marc Bernard
cb58678c79
Refactor: Types related to object interface (#7096)
Some checks are pending
main-build / build-merged (push) Waiting to run
main-build / auto-tag (push) Waiting to run
main-build / auto-tag-artifact (push) Blocked by required conditions
main-build / coverage (push) Waiting to run
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2024-12-05 18:01:09 +01:00
Marc Bernard
ae1f4e3143
Clean-up select_add_order_by (#6616) 2023-11-03 08:51:42 -04:00
Christian Günter
7bdd8f9f4c
Extract calls to FM FUNCTION_EXISTS (#6588) 2023-10-27 13:16:53 +02:00
Alexander Tsybulsky
b50be07041
Separate translations from XML, PO files (#6189) 2023-07-17 10:50:52 +03:00
Marc Bernard
39d2e88be3
Enhance Serializer Interface - Follow-up (#6233) 2023-04-20 17:34:03 +02:00
Marc Bernard
5f1dc6d5e0
Enhance Serializer Interface (#6229) 2023-04-20 16:20:01 +02:00
Alexander Tsybulsky
018e56cfcf
USE_LXE settings and serialization of selected languages (in old format) (#6168)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-03-30 15:17:18 +02:00
Alexander Tsybulsky
69515e5f55
LXE: more objects (#6144) 2023-03-13 17:36:00 +01:00
Marc Bernard
1a5199a5e3
DOMA: Fix domains with custom conversion exit (#5998) 2023-01-17 11:18:35 +01:00
Marc Bernard
f1c1aad740
Delete obsolete longtexts on pull (#5751)
* Delete obsolete longtexts on pull

Longtexts that exist in the system but not in the remote repository are deleted when pulling.

Closes #5202

* Refactor

* Constant

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-09-23 09:57:44 -04:00
Marc Bernard
0ab3ee0a06
Remove aliases from object classes (#5588) 2022-06-04 10:33:42 +02:00
Gregor Wolf
276ad4e808
Exclude technical language from intf, clas, prog, dtel, doma and tabl (#5598)
* exclude technical language from DOMA

* exclude technical language from DTEL

* exclude technical language from TABL

* exclude technical language from CLAS

* exclude technical language from PROG

* exclude technical language from INTF

* fix abaplint issue: Place pragma at end of statem.

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-05-30 12:18:32 +02:00
Marc Bernard
5127bfdb9d
DDIC: Improve active/inactive check (#5486)
* DDIC: Improve active/inactive check

Use `is_active_ddic` (function `DDIF_STATE_GET`) for all DDIC object types. This is more accurate than the current method (function `RS_INACTIVE_OBJECTS_WARNING`) since it detects newly created but not active objects as well.

* Fix const

* Remove "no active version" error

* Update comment

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-09 08:08:32 +02:00
Marc Bernard
a828d80044
DOMA: Fix serialize of translations (#5304)
Closes #5296

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-01 14:36:31 +01:00
Marc Bernard
6efaa0e0b4
Refactor: Remove ddic flag (#5295)
Closes #5264

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-30 16:37:56 +01:00
Marc Bernard
3fa3323b2e
Refactor: Jump to Object Logic (#5158)
* Refactor: Jump to Object Logic

Continue #5114

- Removes jump_adt and jump_se11 from zcl_abapgit_objects_super
- Remove almost all object-specific jump handlers (zif_abapgit_object~jump) since they are covered by GUI Jumper now

* Remove ZCL_ABAPGIT_OBJECT_SICF

* Remove obsolete RS_TOOL_ACCESS

* FUGR

* IATU

* PDXX

* SRVD

* XINX

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-11-29 15:52:13 -05:00
Frederik Hudák
35e3ce8640
DOMA - clear domname from fixed values (#4941)
* DOMA  - clear valpos, domname from fixed values

* undo clear of valpos

* retrigger ci

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-24 06:30:52 +02:00
Lars Hvam
096aded586
LANGU rollbacks (#4829)
* LANGU rollbacks

#4828

* Update abaplint.json
2021-06-08 16:42:20 +02:00
Marc Bernard
e2a156a326
Replace deprecated LANGU type (#4815)
* Replace deprecated LANGU type

Replace with `sy-langu` and update abaplint rule

* Replace langu

* Add langu to void types

* Replace table of langu
2021-06-02 08:04:05 +02:00
Marc Bernard
8a0af2fc67
DDIC: Error message in case of "new" versions (#4584)
In case DDIC objects exist as "new" version only , the system will now raise an error message to alert the user that "No active version was found". 

Note: The log will disappear after some navigation and such objects will not be included in the repo view if they only exist locally (until they are activated).
2021-03-02 17:38:26 +01:00
Lars Hvam
8e07d46f4b
jump_se11, remove unused parameters (#4498) 2021-02-09 15:50:27 +01:00
Marc Bernard
73576ee60e
Improve error messages (#4472)
* Improve error messages

Pass T100 messages to UI/log

* T100 errors

* APACK

* OO

* DEVC

* DRUL

* DTDC

* SRVB

* OBJS

* Program

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-03 16:31:55 +01:00
Marc Bernard
31a550db0f
Refactor I18N settings (#4423)
* Refactor I18N settings

- Consolidate I18N parameters into a structure and pass it to xml and serializer classes (#4415)
- Continue change of terminology (#4043)

* Remove changes to serializer class

* Main lang

* DSYS

* OTGR

* Repo view

* Main langu

* Repo view %26 stage

* Serialize

* Settings

* Repo view

* Defs

* Stage

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-19 14:29:09 +01:00
Marc Bernard
5ed2f5bb22
DOMA: Fix serialize for missing translations (#4283)
Closes #4278

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-04 09:01:24 +01:00
Marc Bernard
b25a67acea
Terminology: Inclusive Language - Part 2 (#4159)
* Terminology: Inclusive Language - Part 2

Change "Master Language" to "Main Language" in UI and comments (documentation and variables next)

* Docs

* Docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-11 10:36:38 +01:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
Marc Bernard
9704ce6708
Fix ZIF_ABAPGIT_OBJECT~EXISTS methods (#3967)
* Fix ZIF_ABAPGIT_OBJECT~EXISTS methods

* Fix EXISTS

* CMPT

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-02 10:23:00 +02:00
g-back
6f8147036e
XML Refactoring: Various Objects (#3891)
* change xml references

* change xml reference
2020-09-16 15:23:14 +02:00
Marc Bernard
49f8ac48c0
DOMA: Fix translation of domain values (#3692)
* DOMA: Fix translations

* DOMA: Fix translations

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-06 13:46:07 +02:00
Marc Bernard
4f0a5480a1
Improved error message when uninstalling DDIC objects (#3562)
* Update zcl_abapgit_object_doma.clas.abap

* Uninstall DDIC

* DDIC uninstall

* Pretty print

* DOMA delete append

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-07 15:36:13 +02:00
Lars Hvam
d36b43defe
line break parameters (#3444)
* line break parameters

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* fix
2020-06-04 15:10:35 +02:00
Jaime Rodriguez Capote
90e3208163
Skip dom. appends serialization (#3275) 2020-03-29 09:16:54 +02:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
Italo N
0f379b950a DOMA: consider clearing VALPOS (#3083) 2019-11-26 07:39:25 +01:00
Lars Hvam
714fe7202d
whitespace fixes (#2964)
* whitespace fixes

* fix sql compare operators
2019-10-11 02:50:16 -07:00
Alexander Tsybulsky
f2f82278e7 Serialize master lang only + settings UI improvements (#2954)
* repo settings ui improvements

* serialize_master_lang_only UI

* downport

* connect settings and serialization (MSAG)

* dtel doma tran prog fugr

* linter fixes
2019-10-07 23:03:57 -07:00
Martin Fuchs
9f2db446b1 simplified GET_DESERIALIZE_STEPS
Since all object handler contains exactly the same CASE statement for STEP definition, I would recommend that each object handler simply returns the STEP he belongs to.
This fix should "simply" issue #2499.
2019-05-05 00:57:52 -07:00
GoWa
21527528c6 call redefined method of IF 2019-03-12 21:49:15 -07:00
larshp
25f6284493 implement GET_DESERIALIZE_STEPS
this is a quick fix, field LATE_DESER will be removed in future
2019-03-12 07:37:56 -07:00
Lars Hvam
3213d0c2dd
Deserialization performance, refactor COMPARE_TO_REMOTE_VERSION (#2438)
* core part refactored #2436

* indentation

* fix implementations

* delete ZCL_ABAPGIT_COMPARISON_NULL

* pretty print

* Update serializers.md

* downport
2019-02-20 22:20:24 -08:00
Lars Hvam
25d4c9ea07
Remove HAS_CHANGED_SINCE #1021 (#2401)
* core part removed

* remove method implementations
2019-02-15 06:51:57 -08:00
Martin Fuchs
94c95d46cb Refactoring of CORR_INSERT and adjustment for object types (#2392)
* Refactoring of CORR_INSERT and adjustment for object types

* CORR_INSERT without CORR_CHECK

* Z exception
2019-02-15 03:26:42 -08:00
larshp
e2e703a0bd DOMA do not serialize texts without language #2311 2019-02-12 21:45:53 -08:00
Domi Bigl
cf05295170 mark inactive objects in repo list #1943 (#2017)
* mark inactive objects in repo list

Inactive object are marked in the repo list
The sort order for changed files is not changed
unchanged inactive files come right after the changed files

* move acitve check to object interface

* add is_active for objects up to F

* add is_active for objects up to P

* add is_active for objects up to T

* add is_active for objects up to X

all core object implement (except SSFO) the standard active check via FM RS_INACTIVE_OBJECTS_WARNING now

* add is_active to plugins bridge - always active

* finish object interface implementation + objects

* add is_active for offline with object interface

* rename returning to RV_

* use returning for serialize

* cleanup, PP, UT
2018-10-31 15:54:57 +01:00
Christian Guenter
46f32e6422 Longtext serialization for DTEL, DOMA and TABL
This commit adds three new methods to ZCL_ABAPGIT_OBJECTS_SUPER:
- SERIALIZE_LONGTEXTS
- DESERIALIZE_LONGTEXTS
- DELETE_LONGTEXTS
They can be called on demand in concrete object type serializers.

In this commit they were called from DTEL, DOMA and TABL
2018-08-28 08:30:13 +02:00
Frederik Hudák
c4639f65ce Removed endmethod and endclass comments - objects folder 2018-07-28 10:10:16 +02:00
christianguenter2
6521d09470 Block pull if any of deserialized object is locked 2018-06-18 14:18:58 +02:00
Lars Hvam
10dbd74f57
Minor changes (#1442)
* remove try without catch

* reduce nesting

* reduce nesting

* reduce line length
2018-06-04 15:12:03 +02:00
Christian G#nter
98ee4fdde5 DOMA: catch cx_sy_dyn_call_param_not_found 2018-05-14 10:54:06 +00:00
Christian G#nter
11256b44e2 DOMA: revert 82ece0f 2018-05-14 10:14:07 +00:00