Commit Graph

3256 Commits

Author SHA1 Message Date
Marc Bernard
a94d06d493
DDLS: Fix dump in lower releases (#4915)
* DDLS: Fix dump in lower releases

- Add requirements check to constructor
- Prevent delete call in case object does not exist

Ref #4899

* Update message

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-12 10:07:41 -04:00
Marc Bernard
61e629cd1f
Improvements for Objects Class (#4944)
* Improvements for Objects Class

This introduces a new `is_type_supported` method for `zcl_abapgit_objects` which is about 30x faster than the current `is_supported` method.

`is_type_supported` is used in the other methods like `changed_by` and `exists` to avoid instanciating or calling the object class unnecessarily. It won't be necessary to check for support before using these methods which will alllow simplifying the calling programs (separate PR).

There are also some new test cases for `is_type_supported` and for serializing a commom interface.

* No user id for unsupported objects

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-12 07:33:41 +02:00
github-actions[bot]
c2d96c0327
ajson, Automatic Update (#4947)
* [create-pull-request] automated change

* upd

Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-12 07:31:03 +02:00
Marc Bernard
cd5d43977a
Filter code inspection/syntax check (#4946)
* Filter code inspection/syntax check

In case of generated maintenance screens, the code inspection/syntax check include findings in SAP code (`LSVIM*` includes). This change removes those findings.

* Update zcl_abapgit_code_inspector.clas.abap
2021-09-12 07:12:53 +02:00
Lars Hvam
ab701df97e
SPPF support (#4938)
* SPPF support

#4839

* update docs

* pretty print

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-09-10 11:01:02 -04:00
Lars Hvam
e7e8af832e
align package descripions (#4939)
prefix all package descriptions with "abapGit - "
2021-09-10 10:58:36 -04:00
Lars Hvam
3b67d90e76
5 additional unit tests running (#4935) 2021-09-10 07:46:05 +02:00
Marc Bernard
bbfc90420a
Dialogs: Clarify comment on password popup (#4932)
* Dialogs: Clarify comment on password popup

* Update zabapgit_password_dialog.prog.abap
2021-09-02 10:34:32 -04:00
Marc Bernard
08f90dd1f7
Fix "Cannot switch origin twice" in remote settings (#4921)
Closes #4919

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@gmail.com>
2021-08-31 07:31:12 +02:00
Lars Hvam
2bdb06519c
check exists() before changed_by() (#4925)
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-08-31 07:29:10 +02:00
Lars Hvam
54036c11dd
workaround changed_by (#4924)
* workaround changed_by

* ugh
2021-08-30 10:46:19 +02:00
github-actions[bot]
b028446d57
ajson, Automatic Update (#4922)
* [create-pull-request] automated change

* Update zcl_abapgit_ajson.clas.testclasses.abap

* Update zcl_abapgit_ajson.clas.testclasses.abap

* skip unit test parse_error

Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-30 07:35:00 +02:00
Jacek W
5f6b5a73c8
Add "Last changed by" to repo page (#4920)
* Add "Last changed by" to repo page

Proposition for #3267

* Add "Last changed by" to repo page

For #3267
- add "Changed by" also for local items

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-30 07:26:02 +02:00
Marc Bernard
de8b3e4fb2
JavaGUI: Workaround for trailing null values (#4903)
SAP GUI for Java 7.70 has trailing null values in postdata (if data >256 characters). This is a bug that SAP will have to fix.

As a workaround, abapGit will strip the trailing null values.  The workaround shall be removed 2022-12-31 latest.

Closes #4832

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-29 13:05:05 +02:00
Jacek W
549fc9a2ef
Add icon link for changing remote repo on the list (#4907)
* Add icon link for changing remote repo on the list

Proposition for #4737

* Add icon link for changing remote repo on the list

- corrections for PR #4907
- fixed syntax

* Update zcl_abapgit_gui_page_repo_over.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-08-29 12:54:03 +02:00
Marc Bernard
e86e2267c0
Improve message if object type is not supported (#4913)
Minor text change
2021-08-27 14:53:20 -04:00
Marc Bernard
6b81d7d958
Improve message for subpackage errors (#4911)
Clarify error and resolution options in case subpackage already exists in system but is not included in pack hierarchy of repo root package.

Closes #4904
2021-08-27 12:58:12 -04:00
Marc Bernard
f2a801ad1a
Dialogs: Add comment to password popup (#4910)
Temporarily, adding a comment to the password popup regarding Github login. 

To be removed end of 2021

https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/

Closes #4909
2021-08-27 12:46:28 -04:00
Lars Hvam
40fa13278d
xml input: add basic unit test case (#4894) 2021-08-25 08:11:02 +02:00
Lars Hvam
7556bf6951
1.109.0 (#4896) 2021-08-16 08:32:43 +02:00
github-actions[bot]
41c9e0880b
ajson, Automatic Update (#4895) 2021-08-16 08:20:05 +02:00
Lars Hvam
329fd9dc0e
interface and factory for ZCL_ABAPGIT_PERSIST_SETTINGS (#4882)
the old get_instance() method in ZCL_ABAPGIT_PERSIST_SETTINGS has been moved to a method in zcl_abapgit_persist_factory, plus interface added. Added to persist injector
2021-08-03 15:13:16 +02:00
Lars Hvam
e6bac818cf
git transport: add unit test for parse() (#4889) 2021-08-03 10:33:24 +02:00
Lars Hvam
ddcb538ccd
get_null(), fix syntax error (#4890) 2021-08-03 10:27:24 +02:00
Lars Hvam
19304ad924
change local hostname determination (#4885)
* change local hostname determination

* fix
2021-08-03 06:49:45 +02:00
Lars Hvam
2bde0ce55a
simplify get_null() + git branch list: add unit test (#4886)
add unit test which parses the response from hex, ie. containing a real null value

simplify get_null() method, it only returns 1 character, but 2 characters are calculated
2021-08-03 06:47:16 +02:00
github-actions[bot]
9d1e14a90d
ajson, Automatic Update (#4888)
* [create-pull-request] automated change

* Update zcl_abapgit_ajson.clas.locals_imp.abap

* Update zcl_abapgit_ajson.clas.locals_imp.abap

* Update ajson_mirror.yaml

* skip parse_bare_values

Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-02 06:57:22 +02:00
Lars Hvam
da310e0137
zcl_abapgit_exit: add IF gi_exit IS NOT INITIAL. (#4884)
* zcl_abapgit_exit: add IF gi_exit IS NOT INITIAL.

* set description
2021-07-31 11:28:00 +02:00
Lars Hvam
e075b951a4
align use of unescape_url() (#4878) 2021-07-29 16:49:38 +02:00
Lars Hvam
8068e8fb0e
git transport: move constants to method (#4877)
the constants are only used locally in the method, the definitions have been moved to the method instead of the private section of the class
2021-07-22 06:56:40 +02:00
Lars Hvam
910bf46ae4
XML unit test, follow up (#4876) 2021-07-21 11:58:40 +02:00
Lars Hvam
9675ad6007
Replace use of type W3URL with string (#4874)
* replace W3URL with string

* fixes

* ASSERT strlen( iv_url ) <= 250.
2021-07-21 11:41:56 +02:00
Lars Hvam
e74c68e204
Decouple XML from UI factory (#4873) 2021-07-21 11:39:47 +02:00
Christian Günter
553d1f2319
LinkHints: trigger onclick event for checkboxes (#4870)
* LinkHints: trigger onclick event for checkboxes

* refactor

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-20 16:33:34 +02:00
Marc Bernard
ab3f24fe06
BRF+ System Application (#4856)
* BRF+ System Application 

- Clear user/time/system-specific fields
- Fix deletion of object
- Remove unnecessary "exists check"
- Updated test case https://github.com/abapGit-tests/FDT0

* Lint

* Lint

* WEBI: Improve error handling

Pass messages to log

* Reverse WEBI

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-17 10:26:47 +02:00
victorizbitskiy
73496a2755
Refactor: Exception handling #4852 (#4869)
https://github.com/abapGit/abapGit/issues/4852
2021-07-13 09:13:25 +02:00
Marc Bernard
6ff7074aec
Auto creation of package during new online (#4814)
* Auto creation of package during new online 

If you create a new online repository and the repo does not contain any SAP package, then abapGit will prompt you for the package attributes and create the package for you. This is, for example, the case when you use an newly created online repo as a starting point. 

If the repo does contain a package, then the package will be created automatically when you pull from the repo (as described in [docs](https://docs.abapgit.org/ref-packages.html)).

Closes #4538

* Update docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-07-09 15:28:55 +02:00
Christian Günter
bffe75958c
SMTG: Implement changed_by (#4867)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-09 15:23:58 +02:00
Frederik Hudák
2cfb2790cf
Open repo - disable enter if command field is open (#4868) 2021-07-08 09:31:57 +02:00
Marc Bernard
39512676ca
WEBI: Improve error handling (#4864) 2021-07-06 17:36:40 +02:00
Marc Bernard
1d98688be5
Dialogs: Set autofocus on first form element (#4853)
* Dialogs: Set autofocus on first form element

Improves usability. 

Closes #4816

* Autofocus for commit page

- Works in case JS is not an option

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-06 11:41:34 +02:00
Frederik Hudák
60a82331b5
Add more keyboard shortcuts for main page (#4846)
* Add more shortcuts for main page

* Update zabapgit_css_common.w3mi.data.css

* Update zcl_abapgit_gui_router.clas.abap

* Change keyboard shortcuts

* fix js

* fix js

* deindent

* indentation

* one more

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-07-06 11:32:27 +02:00
Marc Bernard
2e7d642786
ECVO: Fix "empty xml" error (#4863)
* ECVO: Fix "empty xml" error

Fixes regression from #3991

* Upload
2021-07-06 11:11:27 +02:00
Marc Bernard
7c32f824df
TABL: Clear DB Indexname (#4850)
Fixes diffs because platform specific DB index names. 

Updated test repo: https://github.com/abapGit-tests/TABL_with_index

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-01 14:15:32 +02:00
github-actions[bot]
a8eb86b747
[create-pull-request] automated change (#4855)
Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-01 14:13:47 +02:00
Sascha Wächter
30615e848e
Started with BRF+ serialization and fixed some errors from the first attempt (#4797)
* Fixed Version BRF+ Integration

* BRF+ serialization

* Fixed obsolete parameters and wrong boolean type

* Fixed some errors and filtered ComponentReleeases

ComponentReleeases in XML Export and Import of BRF+ API can be omitted and works also the same. Next try if I could delete the useless metadata (User, System, etc...) or must leave them empty and fill them manually before deserialization.

* Some little changes

Removed Parameter iv_marked_option for older releases and removed method wb_request_choice. Changed to transport automatically.
Aligned some parameters.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-06-28 13:29:56 +02:00
Marc Bernard
3defa2c165
WDCA: Clear parameter descriptions (#4851)
Fixes diffs because of parameters that are different between releases (or even SPs) or languages
2021-06-22 16:47:45 +02:00
Mike Pokraka
b1cc6a2912
Refactor method in FM call for 702 (#4848) 2021-06-15 09:43:04 +02:00
Frederik Hudák
f892c9b4dc
fix unclosed tr tag (#4845)
* fix unclosed tr tag

fixes mistake from #4771
2021-06-14 18:23:59 +02:00
Frederik Hudák
d4cbf7059e
Repo overview - rework action buttons + cosmetic changes (#4771)
* Repo overview - cosmetic changes

* extract logic to method

* Update src/ui/zcl_abapgit_gui_page_repo_over.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* fix if in if

* unshorten remote, move package, improve wrapping

* Add max width for columns

* Mostly working now

* add prefixes

* Remove checkbox, move package where it was

* Keyboard navigation

< > to navigate in list (arrow keys don't seem to trigger), enter to open selected

* Ellipsis for repo url, use css variable

* Fix css, js persistence

* Fix invalid function name

* add back !important to override hover color

* abaplint

* Don't use const in js

* more eslint

* Remove unused field symbol

* eslint

* Bring back repo lock icon, styling improvements

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-06-14 14:44:38 +02:00