Commit Graph

4817 Commits

Author SHA1 Message Date
Alexander Tsybulsky
aa6bd86e9b
.gitattributes (#5081)
* git attributes

* renormalize endings

* text auto

* add shell scripts
2021-11-02 06:08:13 +01:00
Derby
53ddddb8e3
bug in zcl_abapgit_file_status->check_namespace (#5069)
Fix regular expression

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-11-01 14:57:06 -04:00
Marc Bernard
a3e598ac1f
FUGR/PROG: Keep field text in case of masking (#5072)
* FUGR/PROG: Keep field text in case of masking

If masking is used with a dynpro field, then the text (mask) must not be cleared.

Closes #5071
2021-10-29 11:30:00 -04:00
Lars Hvam
09a0a43b95
more unit test and coverage (#5051)
* wip, update npm packages

* upd

* run simple_test

* run array_test

* run visit_types

* run empty_filter_simple

* run empty_filter_deep

* run path_filter

* run path_filter_deep

* run and_filter

* transpile zcl_abapgit_data_injector

* upd

* transpile extra files

* transpile zif_abapgit_data_deserializer

* two extra interfaces

* compile enum providers

* and zcl_abapgit_proxy_auth

* compile repo listener

* zcl_abapgit_repo_filter

* update note

* run coverage

* and upload

* refactor action
2021-10-29 07:46:32 +02:00
Christian Günter
0dc66c6246
new algorithm for binary file detection (#5068)
* new algorithm for binary file detection

* only check first 1000 bytes

* cleanup

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-28 15:36:02 +02:00
Marc Bernard
01df821def
Repo view: Switch "Path" and "Changed by" columns (#5062)
Closes #5059

Before:

After:

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-28 15:34:06 +02:00
Christian Günter
64b7de74ee
Page patch: fix for binary files involved (#5067) 2021-10-28 09:04:19 +02:00
Christian Günter
fea99f89ab
Page patch: fix mixed-up tooltips (#5065) 2021-10-27 17:11:44 +02:00
Marc Bernard
679f2050b0
Diff and Patch Pages Update (#5056)
* Diff and Patch Pages Update

- Fix refresh of a single file on diff page (it was displaying all diffs afterwards)
- Add some hotkey assignments
- Replace "Refresh" after filename with icon

normal:

hover:

* Local refresh on patch page

* Update zcl_abapgit_gui_page_patch.clas.abap

* Patch page: Add js for refresh all hotkey

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-10-27 07:28:17 +02:00
Marc Bernard
2a27d34c08
Docs: Update API get_repo_from_package call (#5063) 2021-10-26 19:52:49 -04:00
Marc Bernard
aa60faa299
Commit Page Update (#5048)
* Commit Page Update

Here's the redesigned commit page moving to the HTML forms you know form other dialogs (goes together with #5047 for best look).

New features:
- check of mandatory entries
- validation of email address format
- link to docs (t.b..d.)
- summary of changes on top, list of changed filed on bottom
- placeholder for body

Closes #5029

* rm > remove

* Create guide-stage-commit.md

* Add files via upload

* Update guide-stage-commit.md

* Delete commit_done.png

* Add files via upload

* Update guide-moving-package.md

* Add files via upload

* Add files via upload

* Update zcl_abapgit_gui_page_patch.clas.xml

* Update zcl_abapgit_gui_page_stage.clas.xml

* Update zcl_abapgit_gui_page_merge.clas.xml

* Update zcl_abapgit_gui_page_commit.clas.xml

* Update zcl_abapgit_gui_page_code_insp.clas.xml

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-25 16:12:06 +02:00
Marc Bernard
c15b58400a
Enhance diff class (#5044)
* Enhance diff class

- Refactor `zcl_abapgit_diff` to use `RS_CMP_COMPUTE_DELTA` instead of `SVRS_COMPUTE_DELTA_REPS` (needs less code in abapGit)
- Replace `abaptxt_255` with `rswsourcet` which removes 255 character per line limit. Now diffs on long lines are calculated properly.
- Add "ignore indent", "ignore comments", and "ignore case" options. These correspond to the options for the Split Screen Editor in SAP GUI and work the same way. The options are *not* exposed to the UI yet.

Same functionality, same performance.

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-25 16:06:27 +02:00
Marc Bernard
45806c5a95
Refactor serializer class (#4994)
* Refactor serializer class

- Consolidate i18n parameters
- Move determination of translation languages into serializer class
- Pass translation language setting when parallel processing (was a bug)

* Lint

* Add unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-25 16:01:40 +02:00
Marc Bernard
91f77324ea
CSS adjustments (#5047)
* CSS adjustments 

I made a few small CSS adjustments to make things a bit more consistent

- Repo overview: Adjust hightlight for current row 
- Repo: Add background color to table header to match staging
- Repo: Fix hightlight for current row 
- Staging: Slight color and table border adjustments
- Forms: Slight color adjustments for textarea placeholder
- DB Utility: Add hightlight for current row

* Update to dark theme

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-25 15:50:01 +02:00
Frederik Hudák
ea0c834992
Fix syntax check warnings (#5055)
* Fix syntax check warnings

* The classes can be final
2021-10-25 15:33:13 +02:00
g-back
1e5befc44a
Decouple cl_gui_frontend_services (#5046)
* add additional methods

* fix whitespace

* add parameter prefixes

* zip: refactor usage of frontend_services

* debug info: refactor usage of frontend_services

* services basis: refactor frontend_services usage

* objects_super: refactor usage of frontend_services

* router: refactor usage of frontend_services

* services_abapgit: refactor usage of frontend_serv

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-20 17:54:23 +02:00
github-actions[bot]
27eca9b766
ajson, Automatic Update (#5036)
* [create-pull-request] automated change

* upd

* fix

Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-20 17:50:51 +02:00
Marc Bernard
e85e2f51d3
Measure backend render time (#5043)
This measures the time it takes in the backend to prepare the HTML page. Result is shown when hovering over abapGit logo in the page footer.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-19 06:38:56 +02:00
Lars Hvam
d54940075b
update npm dependencies (#5045) 2021-10-19 06:36:29 +02:00
Marc Bernard
e8a6cb8a51
XSLT: Fix activation error (#5042)
Remove activation from `deserialize` and use `zcl_abapgit_objects_activation` instead.
2021-10-18 15:08:44 -04:00
Christian Günter
a8e7518348
enable command palette for Diff/Patch/Stage (#5040)
* enable command palette for Diff/Patch

* enable command palette for Stage

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-10-18 15:06:34 -04:00
Christian Günter
bf5634d243
Diff/Patch: Split view - enable line hover (#5039)
* patch page: enable line hover

* improve CSS + enable for unified

* add more CSS classes to table rows
2021-10-18 15:00:25 -04:00
Marc Bernard
7c977f4c4d
UI: Correct placeholder color for textarea (#5037) 2021-10-15 09:31:43 -04:00
Derby
9b582b039a
WDCA: Add support for appl. config content (#5030)
* object WDCA

object WDCA
+ wdy_config_appl-xcontent
+ wdy_config_appt

* Update zcl_abapgit_object_wdca.clas.abap

* Update src/objects/zcl_abapgit_object_wdca.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/objects/zcl_abapgit_object_wdca.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update zcl_abapgit_object_wdca.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-15 07:35:03 +02:00
g-back
4b5b654b49
Online Repo: URL to clipboard (#5034)
* import latest icon set

* Add export URL to clipboard for online repos

* omit parameter name

* adjust indent

* add url class

* Update src/ui/zcl_abapgit_gui_chunk_lib.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2021-10-15 07:30:41 +02:00
Christian Günter
0b71f14f93
'add objects to tr' - fix log display (#5032)
Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-14 16:57:35 +02:00
Christian Günter
e340131487
Log viewer - hide empty columns (#5033)
* Log viewer - hide empty columns

* reduce popup width

* adjust popup width

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2021-10-14 12:10:05 +02:00
Alexander Tsybulsky
65701dbcc8
pull on package reassign (#4999)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-13 06:12:19 +02:00
Alexander Tsybulsky
8a3aa38d82
fix SERVICES_REPO=>POPUP_DECISIONS (#4998)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-13 06:10:31 +02:00
Marc Bernard
df35124b71
Docs: Update font details (#5031) 2021-10-12 18:02:33 +02:00
Lars Hvam
cf642470d6
unit testing updates (#5027)
update to eslint 8
run 4 more unit test methods
update abaplint stuff to latest
2021-10-11 14:30:51 +02:00
Alexander Tsybulsky
253d6abec7
switch back from PR bugfix (#5028)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-11 07:47:31 +02:00
Christian Günter
4ce32ba7a6
Diff-page: enable refresh functions (#4992)
* Diff-page: Enable refresh functions

* cleanup

* Diff: add refresh local hotkey

* Rename 'Refresh' to 'Refresh All'

Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2021-10-09 07:06:55 +02:00
Alexander Tsybulsky
372a2ab7ae
SCI result at stage and commit pages (#5002)
* sci result at stage and commit pages

* improvements

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-10-09 07:04:57 +02:00
Frederik Hudák
423cdd1009
Change abapgit font to 72 (#5026) 2021-10-07 10:10:40 +02:00
Marc Bernard
bdafff8581
Fix stage filter (#5023)
* Fix stage filter

* Update js

* Update js

* Lint

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2021-10-06 14:15:02 -04:00
Frederik Hudák
4a5cf13eca
Don't lowercase transport request id (#5022)
* Don't lowercase transport request id

* fix error

* uppercase username and package too
2021-10-06 20:10:09 +02:00
Frederik Hudák
87e435dc5d
Main page - don't suppress titles for favorites (#5025) 2021-10-06 20:08:08 +02:00
Frederik Hudák
bd1ffd1f2e
Add pull and diff buttons to main page (#5021)
* Add more action buttons to main page

* Fix line length
2021-10-06 19:36:39 +02:00
Lars Hvam
93d14fcc81
repo content list: keep last changed_by in memory (#5019)
#5016
2021-10-06 15:36:51 +02:00
Frederik Hudák
00934cfdaf
Only show favorites on startup (#4997)
* Only load favorites on startup

* downport

* Escape sql

* Fix select, refactoring

* Fix parameter name

* Refactoring

* Update src/repo/zcl_abapgit_repo_srv.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/repo/zcl_abapgit_repo_srv.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/repo/zcl_abapgit_repo_srv.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* indent

* remove me

* Add type column to select

* lint

* Add info message at the bottom of the list

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-06 08:04:09 +02:00
Marc Bernard
51ce0b4df9
FUGR: Fix performance issue (#5017)
Optimize selection of function group includes.
2021-10-06 08:01:51 +02:00
Marc Bernard
1783f70bc0
Docs: Update links for settings help (#5014)
* Docs: Update links

After #5008

* Update zcl_abapgit_gui_page_sett_info.clas.abap

* Update zcl_abapgit_gui_page_sett_locl.clas.abap

* Update zcl_abapgit_gui_page_sett_remo.clas.abap

* Update zcl_abapgit_gui_page_sett_repo.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-05 18:44:01 +02:00
Marc Bernard
b4c5e2e401
Docs: Add "Remote Settings" (#5008)
* Docs: Add "Remote Settings"

* Update ref-dot-abapgit.md

* Delete repo_settings_remote.png

* Add files via upload

* Update link

* Update link

* Add "Repo Settings" to navigation

* Update and rename ref-dot-abapgit.md to settings-dot-abapgit.md

* Update settings-dot-abapgit.md

* Create settings-local.md

* Create settings-remote.md

* Update settings-local.md

* Update and rename other-background-mode.md to settings-background-mode.md

* Update settings-background-mode.md

* Update and rename ref-settings-stats.md to settings-stats.md

* Update zcl_abapgit_gui_page_sett_remo.clas.abap

* Update zcl_abapgit_gui_page_sett_locl.clas.abap

* Update zcl_abapgit_gui_page_sett_bckg.clas.abap

* Update zcl_abapgit_gui_page_sett_info.clas.abap

* Update zcl_abapgit_gui_page_sett_repo.clas.abap

* Update zcl_abapgit_gui_page_sett_bckg.clas.abap

* Update zcl_abapgit_gui_page_sett_info.clas.abap

* Update zcl_abapgit_gui_page_sett_locl.clas.abap

* Update zcl_abapgit_gui_page_sett_remo.clas.abap

* Update zcl_abapgit_gui_page_sett_repo.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-05 18:40:42 +02:00
Marc Bernard
6b7318a78c
Docs: Add example for staging (#5012) 2021-10-05 18:32:34 +02:00
Frederik Hudák
3f4a92cfe3
Repo page - inform on bottom if only changes are shown (#5011) 2021-10-05 15:04:17 +02:00
Marc Bernard
8ec439b9a0
Docs: Add example for casting to API doc (#5010)
* Docs: Add example for casting to API doc

* Update api.md
2021-10-05 14:57:04 +02:00
Marc Bernard
2b8c21bdbc
SXCI: Inactive classic BAdIs (#5006)
* SXCI: Inactive classic BAdIs

Implements a workaround since SAP does not show inactive classic BAdIs properly (missing entry in table `dwinactive`).

* Update zcl_abapgit_object_sxci.clas.abap

* Update src/objects/zcl_abapgit_object_sxci.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Change by

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-05 06:12:45 +02:00
Marc Bernard
0379bc6d11
Change Package Assignment (#4980)
* Change Package Assignment

Previously, if an object was assigned to another package (but not changed otherwise), AG would delete and re-create the object. This was also visible in the "Selective Pull" popups:



The new process is smarter and detects such changes. It re-assigns the package (via a TADIR change) and avoids dropping and re-creating. The package overwrite popup is also avoided (it will still appear if the object itself was changed, too):

* Better icon

* Add unit test

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
2021-10-05 06:02:20 +02:00
Marc Bernard
3e14313f32
SMIM: Last Changed By (#5009)
If "last changed" user is not found on logical object, try selection on physical object
2021-10-05 05:57:46 +02:00