Commit Graph

2876 Commits

Author SHA1 Message Date
Michael Käsemann
aa90f278b7 Added Buffering to ZCL_ABAPGIT_SAP_PACKAGE (#1724)
* Added Buffering to ZCL_ABAPGIT_SAP_PACKAGE

- Added a buffering option to ZCL_ABAPGIT_SAP_PACKAGE=>LIST_SUBPACKAGES, which gives a performance increase in repos with a deep tree structure, because all relevant packages are read from the DB only once and then the determination of subpackages is performed on an internal buffer table.

* Used buffered SAP package information determination in file status processing

* Level-based Subpackage Selection

- Replaced buffered package access with level-based subpackage selection

* Minor fix for select statements to avoid warnings
2018-07-31 17:31:18 +02:00
Christian Guenter
fa61f45886 SSFO: fix jump to text module
After this commit is applied jump to smartforms
text modules works as expected.
2018-07-31 13:46:30 +02:00
Michael Käsemann
b3679f0868 Added Buffering to ZCL_ABAPGIT_FOLDER_LOGIC (#1723)
* Added Buffering to ZCL_ABAPGIT_FOLDER_LOGIC

- Converted ZCL_ABAPGIT_FOLDER_LOGIC=>PACKAGE_TO_PATH and ZCL_ABAPGIT_FOLDER_LOGIC=>PATH_TO_PACKAGE to instance methods, so they can work with buffered data when constructiing path information. This gives a performance advantage in repos with a depp tree structure and multiple leaf packages
- Adapted all calling code to use an instance of ZCL_ABAPGIT_FOLDER_LOGIC instead of the previously available static methods
- Where applicaple PACKAGE_TO_PATH and PATH_TO_PACKAGE were called in an instance of ZCL_ABAPGIT_FOLDER_LOGIC, which was instanced outside of a processing loop and thus profited from the introduced buffering

* Fixed errors

* Removed obsolete coding artifacts

Removed an obsolete parameter, that accidentally got merged into the code when building the pull request

* Forwarded FOLDER_LOGIC instance to recursed calls

Forwarded ZCL_ABAPGIT_FOLDER_LOGIC instance to subsequent BUILD calls to make use of buffering, until the optimizations in #1725 are in place.
2018-07-31 12:19:29 +02:00
larshp
eac0045305 background: fix dump when reconfiguring
fix dump due to old background settings
2018-07-30 16:53:55 +02:00
Lars Hvam
4180373b46
Refactoring, HTML_ACTION_UTILS #1710 (#1720)
* DBCONTENT_DECODE to ZCL_ABAPGIT_GUI_PAGE_DB_EDIT

* PARSE_COMMIT_REQUEST to ZCL_ABAPGIT_GUI_PAGE_COMMI
2018-07-30 16:33:52 +02:00
Lars Hvam
71a1d1776d
Update screenshot (#1719)
screenshot of 1.73.0

update in: README and index of docs
2018-07-29 14:17:22 +02:00
Lars Hvam
e904130b67
v1.73.0 (#1718)
Background mode must be reconfigured after installing this version
New interface ZIF_ABAPGIT_BACKGROUND for implementing custom handlers
Background mode will now push deletions
2018-07-29 14:11:22 +02:00
larshp
58fa197ed5 Move settings type to background interface 2018-07-29 14:01:45 +02:00
Lars Hvam
4fa485bf96
Remove superfluous spaces (#1712)
* remove spaces

* remove spaces

* remove spaces

* remove double space
2018-07-29 10:08:54 +02:00
Lars Hvam
43da0f819c
Background mode refactoring (#1707)
* move background logic to new package

* background refactored

* background, gui page refactored

* find implementations

and fix code inspector findings

* pretty print interface
2018-07-29 10:08:42 +02:00
Frederik Hudák
c4639f65ce Removed endmethod and endclass comments - objects folder 2018-07-28 10:10:16 +02:00
Lars Hvam
67c76df109
Delete unreferenced types (#1705)
* remove ty_adler32

* remove tt_file_diff
2018-07-28 07:26:14 +02:00
Lars Hvam
62580af494
Omit parameter name where possible (#1704)
* zcl_abapgit_2fa_github_auth omit parameter name

* ecatt omit parameter names

* zcl_abapgit_ecatt_script_downl pretty print

* zcl_abapgit_ecatt_script_downl omit parameter name

* zcl_abapgit_ecatt_val_obj_upl omit parameter name

* zcl_abapgit_file_status omit parameter name

* zcl_abapgit_gui omit parameter name

* zcl_abapgit_gui_page_boverview omit parameter name

* zcl_abapgit_syntax_highlighter omit parameter name
2018-07-28 07:25:28 +02:00
Christian Guenter
7a7587a481 Background: Push deleted objects
Before this commit is applied deletions weren't pushed in background
mode. With this commit the deletions are pushed.
2018-07-28 07:24:57 +02:00
Lars Hvam
d013f34893
1.72.2 (#1703)
* update version

* v1.72.2
2018-07-27 13:34:44 +02:00
larshp
e5c75da12c background: remove unused variables 2018-07-27 13:17:49 +02:00
larshp
06d06e23fe list_subpackages: order by primary key
list_subpackages: order by primary key, to fix HANA warning
2018-07-27 13:17:29 +02:00
larshp
faf2f93197 no need to pass is_checks by value
plus some methods reordered
2018-07-27 13:17:14 +02:00
Lars Hvam
95a8a42c25
Parse commit message in branch overview, fix for PGP signature #1387 (#1698)
* pretty print, trigger reordering of methods

* skip PGP signature

* change PARSE_COMMITS to static

change PARSE_COMMITS to static and add unit tests class

* add simple unit test and fix CI findings
2018-07-27 13:16:34 +02:00
Christian Guenter
8c38e17df6 CHAR: fix copy and paste error
Before this commit is applied we get DBSQL_DUPLICATE_KEY_ERROR
dumps while 'reset local'.
2018-07-27 06:17:32 +02:00
Michael Käsemann
4a51d2845c Small performance improvement in ZCL_ABAPGIT_FILE_STATUS=>CALCULATE_STATUS, where the subpackage information is read only once and then sorted and the sorted information can then be accessed through a binary search read. 2018-07-26 13:38:24 +02:00
Christian Guenter
494cc5a8f8 CHAR: catch exceptions and implement is_locked
Before this commit is applied we get shortdumps when the object
is locked during deserialization or deletions.
2018-07-26 13:37:10 +02:00
Christian Guenter
9966bf4c86 Refactor: SET PARAMETER EUK
After this commit is applied all calls of "SET PARAMETER 'EUK'"
are replaced with the call of objects_super->set_default_package.
The method uses the ABAP memory which is in this case more reliable.
2018-07-25 16:16:28 +02:00
Christian Günter
8572013c7e CHAR: fix package popup during pull #1661 (#1689)
* CHAR: fix package popup during pull

* Remove superfluous ABAP memory clearance

memory is already cleared in RS_CORR_INSERT

* Introduce objects_super set_default_package

Refactor set default package logic to super class
zcl_abapgit_objects_super method set_default_package.
2018-07-25 15:00:52 +02:00
Christian Guenter
335759f741 Store user and time for last deserialize
With this commit after every deserialize operation the user, date and time
are stored in repo xml. The information is shown in repo overview.
2018-07-25 06:50:18 +02:00
Christian Guenter
5d439e3699 Code inspector for offline repositories
Before this commit it wasn't possible to run code inspection
for offline repos. A dump occured.
With this commit it is possible to run code inspections
for offline repos, too.
2018-07-25 06:47:59 +02:00
mkaesemann
e132c17205 Fixed spelling error 2018-07-25 06:44:07 +02:00
Michael Käsemann
a80ae3c4f5 Fixed naming and missing data element definition 2018-07-25 06:44:07 +02:00
Michael Käsemann
9f50c2d59e ZIF_ABAPGIT_SAP_PACKAGE~LIST_SUBPACKAGES in ZCL_ABAPGIT_SAP_PACKAGE returned duplicate entries for subpackages with more than 1 hierarchy level, because the recursion selected all subpackages of a given package and added them to the list and then parsed the added subpackages again, which would in turn again select the subpackages of the subpackage. 2018-07-25 06:44:07 +02:00
Christian Guenter
bb82f2c8bd Refresh online repo: call BRANCH_LIST just once
Before this commit is applied BRANCH_LIST is called twice while
refreshing an online repo. This leads to two identical HTTP calls.
After this commit is applied BRANCH_LIST is only called once and
therefore only one HTTP request is sent.
2018-07-25 06:43:21 +02:00
larshp
d7e90aae60 move version definition to separate interface
moved version from DEFINITIONS interface to new VERSION interface, to avoid possible future merge conflicts, see #960
2018-07-25 06:37:38 +02:00
Johannes Konings
5ee467b401 changed URL to current build
URL to the current build is broken. Changed to https://raw.githubusercontent.com/abapGit/build/master/zabapgit.abap.
Is this the correct URL?
2018-07-24 05:11:37 +02:00
Johannes Konings
f770fe08c8 presentation "DevOps in SAP ABAP Landscapes"
added presentation "DevOps in SAP ABAP Landscapes" which include abapGit
2018-07-23 13:51:44 +02:00
larshp
640839ad0e Do not delete repo at pull error #1675
Some time ago, the repo was pulled immediately after creation, this has been changed, so we do not need this workaround anymore. Also see #843
2018-07-22 11:55:13 +02:00
Christian Guenter
01c2cfb610 NEWS: Only update last_change_seen if changed 2018-07-22 11:06:38 +02:00
Christian Günter
7ac8dc15b6 Remove local SHA1 from online repository #1485, #1509 (#1666)
* Remove local SHA1 from online repository

In this commit we remove the local SHA1 and all its references from
ZCL_ABAPGIT_REPO_ONLINE. SHA1 is also removed from repo persistency.
SHA1 insn't needed anymore. All where-used places were either migrated to
remote_SHA1 or removed.

* reintroduce logic after push
2018-07-22 10:11:09 +02:00
larshp
45bb5c7405 AVAS: propagate exception to caller
AVAS, propagate exception to caller, this will fix the syntax warning
2018-07-22 09:46:13 +02:00
larshp
10a14dd387 docs: add improve this page link #931 2018-07-22 09:27:09 +02:00
Christian Guenter
1c368ed80c FUGR: Update short text if already exists
If the short text of the function group has changed in the remote repo,
it's currently not possible to pull that change.
With this commit the short text is pulled properly.
2018-07-22 07:21:06 +02:00
larshp
52758028a7 delete commented unit test code #1189 2018-07-22 07:20:12 +02:00
larshp
60a4f5ed56 FUGR: show error code from RS_FUNCTION_POOL_INSERT
FUGR: show error code from RS_FUNCTION_POOL_INSERT
2018-07-21 11:36:30 +02:00
Lars Hvam
16dcb2ea99
Optimize STATUS performance (#1664)
* Optimize STATUS performance

move list_subpackages() outside of loop

* logic updated
2018-07-21 11:36:15 +02:00
Johannes Konings
b98db9bd7c branch overview: no singleton (#1665)
https://github.com/larshp/abapGit/issues/1647
2018-07-20 11:21:26 +02:00
Johannes Konings
cdf2f5f448 ABAP Unit for ZCL_ABAPGIT_BRANCH_OVERVIEW #1647 (#1654)
branch overview:
* preparation ABAP Unit
* change to key

#1647
2018-07-20 09:29:41 +02:00
Lars Hvam
7079e5ac50
Version 1.72.1 (#1663)
* 1.72.1

* v1.72.1 changelog
2018-07-20 08:10:50 +02:00
larshp
7d622fc495 CHAR: fix dump during pull #1660
Set the activation state to inactive for the values
2018-07-20 07:26:19 +02:00
Christian Guenter
1c2a1f709e CUS1: deserialization add RS_CORR_INSERT
before this commit CUS1 wasn't deserialized properly because no TADIR entry was inserted.
2018-07-20 07:20:33 +02:00
Christian Guenter
25980d80fe SICF: Delete data from ICFAPPLCUST
The data in table ICFAPPLCUST (Application Customizing Data) isn't
deleted by cl_icf_tree=>if_icf_tree~delete_node( ). Before this commit
is applied it's not possible to delete ICF nodes with data in that table.
With this commit we delete the data in the table. It's the same as
transaction SICF does.
2018-07-20 06:45:40 +02:00
Johannes Konings
66ed47d876 doc: typo corrected 2018-07-19 05:08:07 +02:00
Christian Guenter
3ba843ad54 VCLS jump: open view cluster in new window
Before this commit VCLS jump calls VIEWCLUSTER_MAINTENANCE_CALL
which opens inplace. But that's not compatible with abapGit UI
and nothing is visible.

And the semantics changed. The above mentioned FM call the view
cluster for data maintenance and not the development object.
To be aligned with abapGit logic now the transaction SE54 is called.
2018-07-18 18:24:15 +02:00