Commit Graph

4 Commits

Author SHA1 Message Date
Marc Bernard
6623679e67
Dialogs: HTML forms - follow-up (#4329)
* Dialogs: HTML forms - follow-up

Follow-up to #4264:

- Split `zcl_abapgit_html_form` class
Processing form data has been moved to `zcl_abapgit_html_form_utils`

- `iv_is_main` refactored to `iv_cmd_type`

- In case of unsaved data, form exit will now prompt for confirmation (`zcl_abapgit_html_form_utils`)

* dot space

* lint

* Remove const

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-02 15:12:09 +01:00
Marc Bernard
16e8f3d02d
Dialogs: HTML form enhancements (#4172)
* Dialogs: HTML form enhancements

In preparation for https://github.com/abapGit/abapGit/issues/4171, HTML forms were enhanced as follows:

- New integer fields (type "number") with min/max, https://github.com/abapGit/abapGit/issues/3559
- Added support for minlength/maxlength for text fields
- Added support for read-only fields
- Added support for password fields
- New option for adding a help button to the form (with URL link)
- Moved HTML snippets to render method
- Changed parameters to csequence to also accept char variables (like abap_true)
- Minor adjustments to styles

* Lint and fix ul/fieldgroup

* Min/max validation, textarea

* Close textarea tag

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-14 11:28:19 +01:00
Alexander Tsybulsky
19c49fd960
Bugfixes in html_form and Finetune add pages to new event (#4011)
* refactor validation in html_form + UT

* minor UT tweak

* subtle form bugfix (boolc return space string)

* cleanup add forms

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-12 16:40:24 +02:00
Alexander Tsybulsky
f5dfd328f5
Dialogs: add online repo HTML form (#3533)
* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks
2020-07-01 08:16:52 +02:00