Commit Graph

197 Commits

Author SHA1 Message Date
Lars Hvam
89e5010fd0
Naming conventions fixes, #2053 (#2058)
* fix more naming conventions

* more naming conventions fixes
2018-11-07 12:05:27 +01:00
larshp
788a7fedb9 naming conventions #2053 2018-11-07 09:00:12 +01:00
Christian Guenter
45a2ba1cd1 add factory for GUI_IS_AVAILABLE
This commit adds an indirection for function module GUI_IS_AVAILABLE
via interface ZIF_ABAPGIT_GUI_FUNCTIONS and factory ZCL_ABAPGIT_UI_FACTORY.

For tests the implementation can be replaced with
ZCL_ABAPGIT_UI_INJECTOR=>SET_GUI_FUNCTIONS
2018-11-03 08:42:32 +01:00
Domi Bigl
cf05295170 mark inactive objects in repo list #1943 (#2017)
* mark inactive objects in repo list

Inactive object are marked in the repo list
The sort order for changed files is not changed
unchanged inactive files come right after the changed files

* move acitve check to object interface

* add is_active for objects up to F

* add is_active for objects up to P

* add is_active for objects up to T

* add is_active for objects up to X

all core object implement (except SSFO) the standard active check via FM RS_INACTIVE_OBJECTS_WARNING now

* add is_active to plugins bridge - always active

* finish object interface implementation + objects

* add is_active for offline with object interface

* rename returning to RV_

* use returning for serialize

* cleanup, PP, UT
2018-10-31 15:54:57 +01:00
Frederik Hudák
1bb195b344 Removed the rest of endmethod/endclass comments 2018-10-18 07:27:27 +02:00
Lars Hvam
fa39fcd43f
Code inspector fixes (#1997)
* pretty print

* definitions to top of routine

* space before .

* omit parameter names where possible

* double space after if

* remove pseudo comments where possible
2018-10-12 07:56:27 +02:00
Alexander Tsybulsky
7be37d4acd Fix diff colors for MM state #1991 2018-10-11 10:16:36 +02:00
Lars Hvam
f8075e77d7
add missing spaces (#1984)
* add missing spaces

* plus change the approach for this unit test
2018-10-02 16:08:43 +02:00
Domi Bigl
246b943b87 hide current branch and HEAD in delete popup #1908 (#1961)
* hide current branch and HEAD in delete popup

* refactoring and cleanup

* hide also HEAD symref

* throw  branch delete refused
2018-09-29 08:53:55 +02:00
Lars Hvam
10ea325ca8
interface for zcl_abapgit_stage_logic #1955 (#1956)
* interface for zcl_abapgit_stage_logic #1955

* factory, fix injection
2018-09-27 15:03:29 +02:00
Marcello Urbani
eb34b7eeec Share output and event handler for code inspector 2018-09-25 16:23:07 +02:00
Christian Guenter
2b4ff9529b Page Stage: Preserve filter value
On page stage the filter value is preserved while navigating
to diff or commit page and navigate back.
2018-09-21 09:20:36 +02:00
Domi Bigl
529bfc478e add handling of deleted branches in branchoverview (#1928)
* add handling of deleted branches in branchoverview

also display deleted branches in branch overview but w/o a branch name

* PP #1823
2018-09-21 09:12:38 +02:00
Domi Bigl
f61eb50dbf Code inspector results do not respect 'Jump to ADT first' setting #1892 (#1903)
* enable ADT jump from CI result

* enable ADT jump from CI result for all objects

* cleanup + PP

* cleanup + PP + save/activate in ADT

* remove commented code
2018-09-16 10:05:38 +02:00
Domi Bigl
29ce3e8170 handle abapgit_home in CI page 2018-09-10 16:12:00 +02:00
Christian Günter
0fa50309a1 Staging smaller chunks of code like git add -p (#1842)
* Staging smaller chunks of code like git add -p

With this commit a new feature which works similar to git add -p
is added. We are now able to patch, which means that we can
commit on line basis. And are not restricted anymore to commit
only on file basis.

* move get_page_patch to stage page

* Refactor JS

* Refactor JS
2018-09-08 08:58:25 +02:00
Domi Bigl
93c518a142 Branch OV - Sort by parents instead of time + PP #577 (#1890)
* Branch OV - Sort by parents instead of time #577

* Branch OV - Sort by parents PP #577
2018-09-08 08:30:42 +02:00
Christian Guenter
2fa5ba0dcf UI: Change repo urls to hyperlinks
This commit changes the repo urls on the main and overview
pages to hyperlinks.
2018-08-29 12:35:49 +02:00
Christian Guenter
f167adecd2 Fix layout in merge mode 2018-08-28 08:30:23 +02:00
Eduardo Ferrari Copat
de90a9c1b8 Fixes #1229: Enable SAP GUI for Java settings (#1865)
* Insert initial line before bothsequence and action

* Change settings boolean read to support Java GUI

Standard netweaver and Java GUI netweaver parse differently the checkboxes on HTML pages. This commit consider the value on the checkbox aseither "on" or "X".
2018-08-27 10:04:40 +02:00
Christian Guenter
97c40c8f8f Fix: Impossible to save a dummy variant for backgr 2018-08-22 06:30:48 +02:00
Christian Guenter
491306ff41 Fix: hotkey overview close key dynamically 2018-08-20 18:27:04 +02:00
Christian Guenter
98cae2c9fd Introduce global hotkeys
With this commit we are able to define global hotkeys. Which means
that the hotkey is active on all pages. The global hotkeys are
defined in ZCL_ABAPGIT_GUI_PAGE=>GET_HOTKEY_ACTIONS. The first
globally defined hotkey is the hotkey overview with the default
hotkey '?' assigned to it. This was previously hard coded in the js.
2018-08-18 06:57:25 +02:00
Christian Günter
f46e1e1c59 Fix close hotkey overview popup #1833 (#1835)
* Fix close hotkey overview popup

* Add text how to close hotskeys overview
2018-08-17 13:34:09 +02:00
Christian Guenter
d329a2d69f Add switch branch hotkey 2018-08-17 10:47:43 +02:00
Christian Guenter
f0415a22fd More hotkeys
More on page main and code inspector,
plus changed default for settings.
2018-08-17 09:55:09 +02:00
Christian Guenter
e699e7b0c9 Offline repo: make name obligatory 2018-08-17 09:26:55 +02:00
Christian Guenter
5c2a646809 Hotkey overview
After this commit is applied one can open the hotkey overview
with '?'.
2018-08-17 09:26:12 +02:00
Johannes Konings
d25bfaf725 fix some naming conventions
https://github.com/larshp/abapGit/issues/1132
2018-08-17 09:24:22 +02:00
Johannes Konings
c3691622ed fix some naming conventions
https://github.com/larshp/abapGit/issues/1132
2018-08-16 06:32:19 +02:00
Christian Günter
fc1df4b9ee Introduce customizable hotkeys #1728 (#1820)
* Introduce customizable hotkeys

With this commit customizable hotkeys are introduced. They can
be defined in the user specific settings. Currently we support
only one letter keybindigs e.g. 's', 't' or 'x' and no modifiers.

Every page in the UI can decide which actions it offers for the
hotkeys. Therefore we introduce the interface ZIF_ABAPGIT_GUI_PAGE_HOTKEY
with the method GET_HOTKEY_ACTIONS. At this point in time only
the main page offers actions for hotkeys, but the mechanism works
already for all pages. New actions for hotkeys can be defined
easily.

Hotkeys are only available for installed abapGit repositories.
Because we need to detect the classes which implement the above
mentioned interface and it seems that there is no easy way to do
that for local classes. Maybe we can add it later when we know more.

We don't supply default key bindings. So it is totally up to the
user to define them.

* provide default hotkeys
2018-08-16 06:32:03 +02:00
larshp
6044d3e7b2 move PERSIST_USER behind interface
move PERSIST_USER behind interface

will be moved to instantiate via factory in follow up PR
2018-08-13 18:34:28 +02:00
Lars Hvam
1dbc2195f8
update gitgraph to latest (#1814)
* update gitgraph to latest

* docs: dependencies, update gitgraph to latest
2018-08-13 18:33:45 +02:00
larshp
273947240c interface and factory for persist_repo 2018-08-10 07:02:30 +02:00
larshp
e9a2d30950 optimize ZCL_ABAPGIT_GUI_PAGE_STAGE
optimize performance in ZCL_ABAPGIT_GUI_PAGE_STAGE, it will now only find changed_by once per item instead of per file #1794
2018-08-09 07:28:25 +02:00
larshp
e49b404b58 delete some unreferenced variables 2018-08-07 16:01:29 +02:00
Christian Guenter
0fa4ed299e downport 702 2018-08-07 10:26:57 +02:00
Johannes Konings
8e556701c3 New online popup, fix descriptions #1752
https://github.com/larshp/abapGit/issues/1752
2018-08-06 20:06:17 +02:00
larshp
f0fb0f0470 TADIR performance
TADIR performance #1756

All usages of TADIR aligned to use the same structure. 
DELFLAG added in the structure.
2 identical structure definitions deleted.

todo: test this PR works after abapmerge has run
2018-08-06 15:39:15 +02:00
Christian Günter
400846e036 Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER #1775 (#1776)
* Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER

* catch exception if interfaces doesn't exist

Catch exception if IF_OO_SOURCE_POS_INDEX_HELPER doesn't exist
2018-08-06 15:11:40 +02:00
Johannes Konings
6ddd20e2b5 fix some naming convention #1132 (#1771)
* fix some naming convention

https://github.com/larshp/abapGit/issues/1132

* fix abaplint Reduce line length

https://github.com/larshp/abapGit/pull/1771
2018-08-06 13:10:03 +02:00
Lars Hvam
18573089e2
Refactor staging + git + online repo (#1769)
* change merge and staging

always push to the top of the currently selected branch

* remove branch and sha1 from stage object #365

* REPO not longer part of GIT_PORCELAIN

SET_OBJECTS moved to private

* and remove fields from constructor
2018-08-06 12:55:13 +02:00
larshp
02cccf6995 delete method set_new_remote in online repo
delete method set_new_remote in online repo

#1757
2018-08-05 13:12:36 +02:00
larshp
1d035cf1ab create_branch refactored 2018-08-05 12:47:54 +02:00
larshp
28adb2f790 separate repo from DELETE_TAG 2018-08-05 12:17:34 +02:00
larshp
748a32f57c separate repo from DELETE_BRANCH 2018-08-05 12:17:34 +02:00
larshp
71b7f9d788 separate repo from CREATE_TAG 2018-08-05 12:17:34 +02:00
larshp
d431f2d9d0 separate repo from CREATE_BRANCH 2018-08-05 12:17:34 +02:00
larshp
742f3e5e2c Sacrifice HEAD_BRANCH feature in repo
Sacrifice  HEAD_BRANCH feature in repo, suggest instead implementing a branch list cache later

#1757
2018-08-05 11:52:56 +02:00
Lars Hvam
bca3fd6002
help, rename wiki to documentation (#1751)
* remove ENDMETHOD comments

* help, rename wiki to documentation

help, rename wiki to documentation

remove action from router and action definitions
2018-08-05 08:08:28 +02:00
Christian Guenter
a72edf9725 Remove 'Stage' from diff page
After this commit is applied it's no longer possible to stage
at the diff page. This simplifies the screen flow.
2018-08-04 09:49:23 +02:00
Christian Guenter
62506f52bb Default link_hint_key and background color
With this commit link_hint_key and link_hint_backgroun_dcolor
are populated with default values.
2018-08-04 09:13:43 +02:00
Christian Günter
ff4d126856 Vimium like link hint navigation #1706 (#1729)
* Vimium like link hint navigation

After this commit is applied, the link hint navigation can be used.
The feature can be activated and configured in the user settings.
Role model is the link hint navigation in the Google Chrome plugin
Vimium.

* refactoring: introduce KeyNavigation prototype

* refactoring: introduce LinkHints prototype
2018-08-04 07:36:28 +02:00
Frederik Hudák
34a65ba8e4 Removed unnecessary default comments from testclasses 2018-08-03 13:32:57 +02:00
larshp
eac0045305 background: fix dump when reconfiguring
fix dump due to old background settings
2018-07-30 16:53:55 +02:00
Lars Hvam
4180373b46
Refactoring, HTML_ACTION_UTILS #1710 (#1720)
* DBCONTENT_DECODE to ZCL_ABAPGIT_GUI_PAGE_DB_EDIT

* PARSE_COMMIT_REQUEST to ZCL_ABAPGIT_GUI_PAGE_COMMI
2018-07-30 16:33:52 +02:00
Lars Hvam
4fa485bf96
Remove superfluous spaces (#1712)
* remove spaces

* remove spaces

* remove spaces

* remove double space
2018-07-29 10:08:54 +02:00
Lars Hvam
43da0f819c
Background mode refactoring (#1707)
* move background logic to new package

* background refactored

* background, gui page refactored

* find implementations

and fix code inspector findings

* pretty print interface
2018-07-29 10:08:42 +02:00
Lars Hvam
67c76df109
Delete unreferenced types (#1705)
* remove ty_adler32

* remove tt_file_diff
2018-07-28 07:26:14 +02:00
Lars Hvam
62580af494
Omit parameter name where possible (#1704)
* zcl_abapgit_2fa_github_auth omit parameter name

* ecatt omit parameter names

* zcl_abapgit_ecatt_script_downl pretty print

* zcl_abapgit_ecatt_script_downl omit parameter name

* zcl_abapgit_ecatt_val_obj_upl omit parameter name

* zcl_abapgit_file_status omit parameter name

* zcl_abapgit_gui omit parameter name

* zcl_abapgit_gui_page_boverview omit parameter name

* zcl_abapgit_syntax_highlighter omit parameter name
2018-07-28 07:25:28 +02:00
Christian Guenter
335759f741 Store user and time for last deserialize
With this commit after every deserialize operation the user, date and time
are stored in repo xml. The information is shown in repo overview.
2018-07-25 06:50:18 +02:00
Christian Guenter
5d439e3699 Code inspector for offline repositories
Before this commit it wasn't possible to run code inspection
for offline repos. A dump occured.
With this commit it is possible to run code inspections
for offline repos, too.
2018-07-25 06:47:59 +02:00
larshp
d7e90aae60 move version definition to separate interface
moved version from DEFINITIONS interface to new VERSION interface, to avoid possible future merge conflicts, see #960
2018-07-25 06:37:38 +02:00
Christian Günter
7ac8dc15b6 Remove local SHA1 from online repository #1485, #1509 (#1666)
* Remove local SHA1 from online repository

In this commit we remove the local SHA1 and all its references from
ZCL_ABAPGIT_REPO_ONLINE. SHA1 is also removed from repo persistency.
SHA1 insn't needed anymore. All where-used places were either migrated to
remote_SHA1 or removed.

* reintroduce logic after push
2018-07-22 10:11:09 +02:00
Johannes Konings
cdf2f5f448 ABAP Unit for ZCL_ABAPGIT_BRANCH_OVERVIEW #1647 (#1654)
branch overview:
* preparation ABAP Unit
* change to key

#1647
2018-07-20 09:29:41 +02:00
Lars Hvam
4f96d8dbee
show path in diff page #1624 (#1638)
show path in diff page #1624

plus remove some comments after ENDMETHOD
2018-07-14 06:51:07 +02:00
Christian Günter
4f9f47cd59 Set transport request if needed during uninstall or reset local (#1596)
* delete checks: set transport request if needed

this ensures that the transport request is set when deleting objects.
E.g. uninstalling the repositoy or reset local.

* separate type for delete checks
2018-07-11 16:18:08 +02:00
Christian Günter
c161b0d5d4 Overview page: initial focus to filter (#1616) 2018-07-11 15:45:56 +02:00
Christian Guenter
3f2e9be939 Do not automatically deserialize last seen repo
- new default behaviour is that the last seen repo isn't deserialized automatically. Instead the user has to choose a repo to work with
- old behaviour can be reactivated via user setting
2018-07-09 16:15:36 +02:00
Christian Guenter
3ce838269d add timezone to overview page 2018-07-08 09:54:34 +00:00
Christian Guenter
7684e7b2ad merge page: remove duplication 2018-07-08 09:40:00 +00:00
Lars Hvam
c6713e608d
Merge pull request #1587 from JohannesKonings/issue_1586
Embedded Expressions ALPHA cause syntax error on NW 7.31 #1586
2018-07-08 07:19:20 +02:00
Lars Hvam
528f8d7c3c
Merge pull request #1583 from larshp/issue_1449
remove link to plugins #1449
2018-07-08 07:18:51 +02:00
Johannes Konings
1f81fd9eff Expressions ALPHA to CONVERSION_EXIT_ALPHA_OUTPUT
https://github.com/larshp/abapGit/issues/1586
2018-07-07 18:03:50 +02:00
larshp
21bd0ec64c remove link to plugins #1449
remove link to plugins #1449
2018-07-07 08:33:52 +00:00
larshp
79b6ed0fa5 commit after updating checksums #1562
commit after updating checksums #1562

plus remove some comments
2018-07-07 07:43:19 +00:00
Lars Hvam
0403e29109
Merge pull request #1573 from christianguenter2/issue_1559
run code inspector after conflict resolution
2018-07-07 09:01:14 +02:00
Christian Guenter
c6ebf2be1f run code inspector after conflict resolution 2018-07-06 16:34:16 +02:00
Christian Guenter
73f2bdd13b Add creator and created at to overview page 2018-07-06 13:46:49 +00:00
Lars Hvam
6f54a1e9ff
Merge pull request #1553 from flaiker/requirements-ui
Add UI for requirements in repo settings
2018-07-03 07:45:29 +02:00
Lars Hvam
18709bdf74
Merge pull request #1550 from christianguenter2/issue_1543
New repository overview page
2018-07-02 19:50:17 +02:00
Christian Guenter
59128df664 downport code inspector page 2018-07-02 10:38:23 +00:00
Fabian Lupa
127f5a3c9c Remove unused action decode methode 2018-07-02 00:51:38 +02:00
Fabian Lupa
43e91a6296 Add UI for requirements in repo settings
Fixes #1547
2018-07-01 18:27:07 +02:00
Christian Guenter
6dfb6316c6 Repository overview page 2018-07-01 16:47:28 +02:00
Lars Hvam
52fb9858ff
Merge pull request #1532 from christianguenter2/1460
move db util pages to separate package
2018-06-28 13:41:58 +02:00
Lars Hvam
cda961dbe1
Merge pull request #1527 from christianguenter2/tag_popups
tag popups: dependency injection
2018-06-28 13:33:55 +02:00
christianguenter2
ea798193d0 Block commit/push if code inspection has errors
- new local setting to set check variant
- new local setting to block pull if code inspector check fails
- check is executed before staging
- new page to display code inspector results
2018-06-28 13:21:29 +02:00
christianguenter2
557ae3279f move db util pages to separate package 2018-06-28 12:04:25 +02:00
Christian Guenter
fb91909947 tag popups dependency injection 2018-06-25 11:15:46 +02:00
Christian Guenter
36f257f0bb Dependency injection for ZCL_ABAPGIT_SAP_PACKAGE 2018-06-18 15:37:16 +02:00
Lars Hvam
838769d0bc
Merge pull request #1516 from FreHu/master
Fixed error message when committing without author name
2018-06-18 15:23:47 +02:00
Frederik Hudák
7e4285c1a8 Fixed error message when committing 2018-06-18 09:21:51 +02:00
larshp
9f75d6bd2b refresh repo cache after deletion #1482 2018-06-17 08:23:56 +00:00
christianguenter2
4662883723 Introduce ZIF_ABAPGIT_POPUPS
- create popups with factory ZCL_ABAPGIT_UI_FACTORY
- inject test doubles with injector class ZCL_ABAPGIT_UI_INJECTOR
2018-06-15 11:21:48 +02:00
Lars Hvam
de23d5bf95
Merge pull request #1484 from larshp/issue_1390
first dependency injection, TADIR #1390
2018-06-14 06:27:04 +02:00
Jakub Filak
fb6efabfb9 tp: use the correct transport type in the tr popup
We are developing in an infinity system which is somehow cloned into a
new releases system. When we need to backport a bug fixes we do
cherry-pick the commits and pull them the release system. However, in
those systems we need to use the task type Repair.

Hence, we need to overwrite the default value of the parameter
wi_task_type of the function TRINT_ORDER_CHOICE which is 'S'
(Development/Correction) with the value 'R'.

I use the function TRINT_GET_REQUEST_TYPE and for the sake of simplicity
I assume that it is enough to know the transport type of the repository
package - in other words, it is no necessary to check every deserialized
object.

Related to #1446
2018-06-12 13:33:49 +02:00
larshp
4e67e884de first dependency injection #1390
* extract public methods of ZCL_ABAPGIT_TADIR to new interface
* create factory ZCL_ABAPGIT_FACTORY
* refactor existing calls
2018-06-10 12:11:48 +00:00
larshp
4219c6d162 cl_aunit_assert is obsolete 2018-06-10 11:45:39 +00:00
Christian Guenter
8ddeacade5 fix gui show changes only 2018-06-08 08:35:20 +02:00