Commit Graph

72 Commits

Author SHA1 Message Date
Frederik Hudák
add83f5b94
Repo overview performance improvements (#4541)
* Repo overview performance improvements

* Rework map_repo_list_to_overview

* Reduce usages of get_key

* Fix inline data

* Don't load package descriptions in repo overview

the select is expensive

* suppress titles for non-favorite repositories

* lint

* Update src/ui/zcl_abapgit_gui_page_repo_over.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* optimize render_repo_palette

* Optimize gui_router

* Update zcl_abapgit_gui_page_repo_over.clas.abap

* Update zcl_abapgit_migrations.clas.abap

* remove unused variable

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-21 11:29:01 +01:00
Frederik Hudák
e68feff2e1
Main page - disable hover info for package/user links (#4545)
* Main page - Only show hover info for favorites

in package, user links

suppress titles for non-favorite repositories

* always suppress loading titles in repo overview

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-20 17:22:25 +01:00
Marc Bernard
3db8c950b8
Adjust "ZIP" spelling (#4495)
* ZIP

* ZIP

* ZIP

* ZIP

* ZIP
2021-02-08 14:46:05 +01:00
Marc Bernard
2e476eb7b2
Dialogs: HTML forms for repo settings (#4384)
* Dialogs: HTML forms for repo settings

This moves the repo settings to HTML forms. The settings are split into three pages:
- Repository settings (ie abapgit.xml)
- Local settings
- Infos

* Lint

* Infos > Stats

* Infos > Stats

* Infos > Stats

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-08 13:09:37 +01:00
Eduardo Ferrari Copat
16258c59b6
Checkout commit: additional user interface (#4120) (#4349)
* Set branch name with commit

* Can't stage when commit is checked out

* Add missing variable

* Remove passing a parameter, since set relies on IS SUPPLIED

* Undo last commit

* Intelligent create branch when commit is checked o

ut

* lint

* Fix cancel buttons (missing commit)

* Code review

* Remove unused variables

* Add extra line

* Remove unused variable

* Add back new branch pop-up. Considers tag.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-28 12:39:26 +01:00
Marc Bernard
82668de47b
UI: New pages for global and personal settings (#4192)
* Dialogs: New pages for global and personal setting

Redesign of abapGit settings using HTML forms. Two functional changes to old settings page:
- "Development Internal Settings" are only visible when using the developer version (not in standalone program)
- "User-specific hotkey settings" are not available anymore. The default hotkeys continue to work as before.

Global/Personal settings can be reached using hotkeys "x" and "y".

* Lint

* Hide button

* Change to top menu

* Remove old page

* Remove old page

* fix links

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-23 08:24:17 +01:00
Lars Hvam
3162b23c39
Move git url repo methods (#4147)
* Move git url repo methods

This moves methods GET_COMMIT_DISPLAY_URL and GET_DEFAULT_COMMIT_DISPLAY_URL from the repo class to new class in new package GIT_PLATFORM.

we want to keep the repo class small, as its quite complex and central

#4085

* fix line length
2020-11-10 06:34:16 +01:00
Marc Bernard
87a3806ce1
UI: Unify rendering of transport, user names - part 2 (#4133)
- Added icon for user
- Changed icon for transport to truck
- Adapted "staging" page 
- Renamed CSS-classes because of conflict with classes used on staging page

Screenshots #4097
Closes #4098

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-04 14:51:34 +01:00
Lars Hvam
df652f0436
delete various unused local variables (#4126) 2020-11-03 08:43:04 +01:00
Marc Bernard
e6acd28bda
Fix invalid HTML (#4128)
* Fix invalid HTML

- Fix HTML in case changelog contains `<, >, &` characters

* Invalid unquoted attribute value

* No tags after </body>
2020-11-03 08:38:02 +01:00
Marc Bernard
29aea372a5
UI: Adjustments to Repo Palette (#4079)
* UI: Adjustments to Repo Palette

- Sort alphabetically
- Pad offline icon (using CSS)

* CSS

* CSS

* Remove css changes

Css is fixed in #4112

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
2020-11-02 09:38:33 +01:00
Marc Bernard
666dfbda66
UI: Unify rendering of branch, package, transport, user names (#4097)
* UI: Unify rendering of branch, package, user names

Branch name was already rendered "boxed with a leading icon". The same is now done for package and user names.

See `zcl_abapgit_gui_chunk_lib->render_branch_name, render_package_name, render_user_name`.

Closes #4059

* Lint %26 transport

* Unknown user

* Transport css

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-30 10:13:09 +01:00
Frederik Hudák
888bbcb27e
Disable sorting for action column (#4087)
* Disable sorting for action column

* abaplint

* Revert renamed methods
2020-10-28 12:23:00 +01:00
mariusraht2
69b6c3c38a
Implementation (#4086) 2020-10-28 10:41:22 +01:00
Fabian Lupa
ceeb95eec1
Fix arrow direction for sort order (#4062) 2020-10-26 08:06:28 +01:00
mariusraht2
54ce6771bd
Issue #4027: Resolve possible crash of AG and add option to be able to suppress showing commit hash on Code Inspector result page (#4028)
* Replace LEAVE with CALL SCREEN

* Add new option iv_show_commit

Add new option iv_show_commit to GUI_CHUNK_LIB to be able to suppress showing commit hash on GUI_PAGE_CODE_INSP page

* abapLint: Replace 'EQ' by '='

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Hide commit hash on other pages too

Hide commit hash on ZCL_ABAPGIT_GUI_PAGE_REPO_SETT and ZCL_ABAPGIT_GUI_PAGE_SYNTAX pages

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-19 11:19:02 +02:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
Marc Bernard
42c909e688
Refactor: Remove dynamic instantiation of ZCL_ABAPGIT_MESSAGE_HELPER (#3966)
* Refactor: Remove dynamic instantiation of ZCL_ABAPGIT_MESSAGE_HELPER

Consolidate `ZCL_ABAPGIT_MESSAGE_HELPER` features into `ZCX_ABAPGIT_EXCEPTION` and removes helper.

* Remove helper

* Pretty

* Update chunk_lib

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-05 16:50:36 +02:00
Alexander Tsybulsky
e95b6f7806
html event abstraction, phase 3 - query (#3903)
* event->query

* page db refactoring

* linter fix

* linter fix

* address repo via key= param

* linter

* mv_getdata WIP

* mv_getdata - finish

* cleanup action utils

* linter fix

* another linter fix

* docs for event->query
2020-09-28 16:41:59 +02:00
Marc Bernard
dc9773bee9
Fix handling of T100 exceptions (#3943)
* Fix errors raised during deletion

* Fix error handler

* Harmonize top and bottom message banners

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-27 10:56:08 +02:00
Fabian Lupa
b7d318d2e9
Add button to launch IEChooser.exe on Windows (#3922)
* Add button to launch IEChooser.exe on Windows

* Fix CASE statement

* Determine iechooser.exe path using system directory

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-23 12:31:01 +02:00
Fabian Lupa
a2f57aeb9a
Split up global settings button and utility menu (#3913)
* Split settings and dev utils menu

* Fix missing settings hotkey on repo view

* Revert "Fix missing settings hotkey on repo view"

This reverts commit 1444744a5f.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-22 08:54:40 +02:00
Lars Hvam
5b93872199
reduce existing string templates (#3886) 2020-09-15 08:14:42 +02:00
Fabian Lupa
dc5725b49c
Add performance test (#3847)
* Add performance test

* Fix some linter errors

* Refactor free selections to reduce method length

* Performance test add title to result ALV

* Attempt downport

* Downport

* Pretty Printer VS abaplint

* Undo more changes done by pretty printer

* Adjust performance popup title and ALV layout

* Move free sel dialog to global for abapmerge

* Move some type definitions for abapmerge

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-08 10:39:20 +02:00
Lars Hvam
6739b768e9
html refactoring (#3843)
* html refactoring

change A() to instance method
remove ADD_CHECKBOX alias

* removes ICON alias

* more
2020-09-06 09:45:51 +02:00
Marc Bernard
c09cc67c83
Fix startup of repo view (#3831)
* Update error msg

* Fix login popup errors and cancelation

* Remove validate/reset methods

* Lint

* Rename iv_repo_online to io_repo_online

* Change to error in status bar

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-04 09:32:38 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Lars Hvam
98a261df1b
remove some unused variables (#3825) 2020-09-01 16:32:44 +02:00
Lars Hvam
86657cc691
HTML refactoring (#3813)
* HTML refactoring

* removes the ADD_ICON alias

#3460

* remove IS_EMPTY alias

* more

* refactoring
2020-08-31 09:37:36 +02:00
Lars Hvam
271e365f06
html, use interfaces (#3811)
* html, use interfaces

* more

* more

* more

* this removes the ADD_A alias
2020-08-29 08:00:56 +02:00
Lars Hvam
84c80a761c
refactoring, use interface for html (#3793)
* refactoring, use interface for html

replace uses of zcl_abapgit_html with zif_abapgit_html

#3460

* replace additional uses of the A alias

* This removes the A alias from the HTML class

This removes the following alias,
"a FOR zif_abapgit_html~a ."

* fix syntax error
2020-08-27 07:51:51 +02:00
Frederik Hudák
f5052cf0b6
Use title case in page titles, menus, forms (#3765)
* Use title case for page titles

Other minor changes:

- patch page is no longer called diff
- "code inspector" in main page action menu renamed to "check"

* Two more

* Update zcl_abapgit_gui_page_db_dis.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Repo advanced menu

* Commit form labels

* Repo setting lables

* Settings, repo

* Final ones?

* Database util

* Column name in stage page

* abaplint

* Update zcl_abapgit_gui_page_stage.clas.abap

* Hover texts for stage column, commit settings

* lint
2020-08-22 09:50:10 +02:00
Lars Hvam
d5e5baa7d8
delete method ZCL_ABAPGIT_HTML=>CREATE (#3736) 2020-08-18 06:54:20 +02:00
Lars Hvam
f878f3b4c3
remove some double spaces (#3740) 2020-08-16 08:24:12 +02:00
Lars Hvam
d1f277365b
create_sotr, remove unused parameters (#3739)
* minor changes

* create_sotr, remove unused parameters
2020-08-16 08:21:49 +02:00
Domi Bigl
20f93ff514
show last commit hash with link if possible (#3731)
* show last commit hash w/ link if possible

link to commit is supported for github.com and bitbucket.org

* remove inline data declaration

* add gitlab link support with UT

* add commit icon for non supported provider

* remove inline declaration

* remove new for CRETE OBJECT

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-13 15:41:45 +02:00
Lars Hvam
17b6411cdb
remove unused variables (#3721)
* remove unused

* remove fstate

* remove

* false

* AVAS, delete method insert_links

* fstate

* sotr

* WAPA

* ssfo

* ddls mock
2020-08-11 18:11:39 +02:00
Alexander Tsybulsky
144cb8822c
improve missing branch styling (#3619)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-13 11:34:39 +02:00
Frederik Hudák
d49d0656b0
Top menu improvements (#3590)
* Use icons, add back menu to repo show page

* Event handling

* Abaplint

* Add menu to tutorial page

* Lint

* More icons

* Update tutorial, reorganize button code

* Move icon css

* Fix error

* Fix menu
2020-07-09 09:12:58 +02:00
Alexander Tsybulsky
2699e2d513
fix repo palette (#3580)
* fix repo palette

* fix page_view_repo after rebase

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-07 14:59:31 +02:00
Lars Hvam
024167ce97
replace SYREPID (#3501)
* Update abaplint.json

* replace SYREPID
2020-06-16 07:34:12 +02:00
Lars Hvam
d36b43defe
line break parameters (#3444)
* line break parameters

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* fix
2020-06-04 15:10:35 +02:00
Alexander Tsybulsky
8eae18c0f5
Gui refactoring part 4 (#3362)
* refactoring and remove get_events from gui_page

* cleanups

* more cleanups

* register_deferred_script

* refactor page_stage

* refactor page_diff

* refactor page_commit

* refactor page_debuginfo

* linter fixes

* refactor page_tag

* refactor rage_repo_over

* refactor page_patch

* make gui_page->scripts private
2020-05-20 17:50:00 +02:00
Alexander Tsybulsky
c056076170
Gui refactoring 2 (#3338)
* hotkeys refactoring: draft logic

- new interfaces
- gui services binding
- move render to zcl_hotkeys
- move global hotkeys to hotkeys class
- remove unnecessary stuff from gui_page

* implement zif_abapgit_gui_hotkeys in rel.pages

* settings page draft

* remove zif_abapgit_gui_page_hotkey

* linter fixes

* finalize rendering logic

* finalize settings

* linter fix

* sorting tweak

* fix abapgit_full work

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-05-08 10:26:54 +02:00
Lars Hvam
b42f3bc485
Refactoring (#3134)
* fully type constants

* moving to single line

* move to single line

* enable keep_single_parameter_on_one_line
2019-12-28 12:11:32 +01:00
Lars Hvam
714fe7202d
whitespace fixes (#2964)
* whitespace fixes

* fix sql compare operators
2019-10-11 02:50:16 -07:00
Christian Guenter
d7e2833483 Warning at stage when not logged on in master lang 2019-10-06 01:12:33 -07:00
Christian Günter
3905c67edd Order by on repo page (#2933)
* Order by on repo page

* move render_cols_pec to zcl_abapgit_gui_chunk_lib

* cleanup

* cleanup

* first new working version

* fix lint

* add OrderByHelper

* add new feature clear

* rename ICON to CLEAR

* cleanup

* refactor actions

* fix typo in method name

* remove duplication

* rename render_col_spec to render_order_by_table_he

* refactor type

* fix eslint warning

* isoltate repo_tab CSS

* fix non-code and metadata files at the top

* refactor

* cleanup

* new features "diffs first" + remove clear

* refactor

* take directories into account

* cleanup
2019-10-05 22:54:04 -07:00
Christian Günter
c008788b9b Improve error information - follow up Part 3 (#2837)
*  Improve tooltip of "Goto source" link

* add another test
2019-08-05 01:57:30 -07:00
Christian Günter
50a6cf8ac9 Improve error information - follow up Part I (#2813)
* Improve error information - follow up Part I

- Bug: remove errorenous regex
- Add tooltip for message id and message class

* Replace text of message link
2019-07-30 05:04:00 -07:00