Commit Graph

2605 Commits

Author SHA1 Message Date
Marc Bernard
1ef0aa9e74
Fix related to textpools of includes (#3389)
Reference: 0b4809de6d

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-23 11:55:46 +02:00
Marc Bernard
3620e12ee9
Fix CX_SY_RANGE_OUT_OF_BOUNDS dump (#3394)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-23 11:53:02 +02:00
Frederik Hudák
0a67f95c11
Replace assert in gui_page_stage with check (#3392)
* Update zcl_abapgit_gui_page_stage.clas.abap

* Change to exception

* add reference to issue as comment in code

* Update zcl_abapgit_gui_page_stage.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-23 11:42:41 +02:00
Marc Bernard
6d2deece76
Add missing TH closing tag (#3393) 2020-05-23 06:32:34 +02:00
Maxim Engel
f20e13d3ab
Fix for missing-field-popup (#3391)
Fix for missing-field-popup during cloning online repos, due to missing description.

Closes #3390
2020-05-22 17:43:23 +02:00
Frederik Hudák
5d34284805
Highlight hovered line (#3347)
* Highlight hovered line

* Better hover color

* Remove hover border in diffs

* Change bacgkround color

* Fix unrelated syntax errors in css
2020-05-22 10:10:41 +02:00
Marc Bernard
aa204c1e8f
Map blank "last changed by" to "unknown" (#3387)
* Map blank "last changed by" to "unknown" 

Fix blank entry in filter dropdown

* Whitespace
2020-05-22 10:02:33 +02:00
Lars Hvam
353b813683
1.95.0 (#3384)
* 1.95.0

* Update changelog.txt
2020-05-21 07:39:32 +02:00
larshp
2d168e170b move stage structures to interface #3377 2020-05-21 07:25:54 +02:00
Frederik Hudák
2886c00592 Fix syntax error in gui_router
Somehow lost this change from #3378. The class no longer exists.
2020-05-21 06:58:26 +02:00
Frederik Hudák
be260435f5
Move explore link (#3378)
* Move explore link

* Update zcl_abapgit_services_abapgit.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-20 19:47:42 +02:00
Frederik Hudák
3335317278
Remove page playground (#3375)
* Remove page playground

* Remove constant
2020-05-20 18:28:03 +02:00
Alexander Tsybulsky
8eae18c0f5
Gui refactoring part 4 (#3362)
* refactoring and remove get_events from gui_page

* cleanups

* more cleanups

* register_deferred_script

* refactor page_stage

* refactor page_diff

* refactor page_commit

* refactor page_debuginfo

* linter fixes

* refactor page_tag

* refactor rage_repo_over

* refactor page_patch

* make gui_page->scripts private
2020-05-20 17:50:00 +02:00
germanysources
47a2332cc7
encode and decode signed commits (#3373)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-20 12:42:38 +02:00
Marc Bernard
aa71ed52ae
Set filter for file open and save dialogs / Add new setting for default commit comment (#3371)
* Set filter for file open and save dialogs

Set the file filter dropdown and default to *.ZIP in file open and save dialogs

* Add new setting for default commit comment

New abapGit setting to define a default for the comment used for commits. Object and/or filename can added to the comment automatically, which works similar to GitHub if a single file is changed. If multiple objects are changed, then object/file count is included in the default for the comment.

* Update CLAS ZCL_ABAPGIT_GUI_PAGE_COMMIT

* Fix text for $object

Fixed case when one object with multiple files was changed

* Pretty print

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-20 12:37:58 +02:00
Marc Bernard
840d818b2d
Minor improvement for debug info (#3372)
- Full SAP GUI patch
- APACK version
2020-05-19 17:46:07 +02:00
Frederik Hudák
202e2d0239
Unify different wordings of 'Diff' (#3367)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-19 07:30:51 +02:00
Alexander Tsybulsky
310d8673dd
Gui refactoring, chapter 3 (#3355)
* zcl_abapgit_html_parts primitive

* integrate parts in GUI

* bughunting and renames

* scripts collection, move hotkeys js to parts

* linter fixes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-13 12:58:43 +02:00
Marc Bernard
40a1ef3a13
Allow setting of display name for offline repos (#3359)
Minor improvement to enable "Display Name" setting for offline projects which is shown in favorites for example
2020-05-13 12:42:23 +02:00
Lars Hvam
0944649ffd
CHAR downport (#3354)
closes #3353
2020-05-08 12:05:51 +02:00
Alexander Tsybulsky
c056076170
Gui refactoring 2 (#3338)
* hotkeys refactoring: draft logic

- new interfaces
- gui services binding
- move render to zcl_hotkeys
- move global hotkeys to hotkeys class
- remove unnecessary stuff from gui_page

* implement zif_abapgit_gui_hotkeys in rel.pages

* settings page draft

* remove zif_abapgit_gui_page_hotkey

* linter fixes

* finalize rendering logic

* finalize settings

* linter fix

* sorting tweak

* fix abapgit_full work

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-05-08 10:26:54 +02:00
Frederik Hudák
a64b6d96f8
Don't run code inspector in parallel when disabled (#3348)
* Don't run code inspector in parallel when disabled

* Restructure if

* Fix spacing

* Fix comment position
2020-05-07 11:30:35 +02:00
Frederik Hudák
14a2820d30
Filter msag longtexts by master language in database (#3344)
* Serialize master lang only - DTEL, DOCT

* Filter msag longtext in database
2020-05-05 08:40:01 +02:00
Jakub Filak
ccba5c0286
CHAR fixes (#3346)
* char: deserialize missing attribute hide_icons

* char: unlock upon all errors

It's very annoying when I have to go to SM12 to unlock CHAR
objects which could not be activated due to a missing OTGR.
2020-05-05 06:43:56 +02:00
Frederik Hudák
055d1b8591
Serialize master lang only - DTEL, DOCT (#3343) 2020-05-04 18:09:54 +02:00
Frederik Hudák
240fc1ed06
CUS0, CUS1, CUS2 - Serialize master lang only (#3342)
The "serialize master language only" setting is not respected everywhere. This PR fixes CUS0, CUS1, CUS2 object types.
2020-05-04 16:02:49 +02:00
Christian Günter
1cf1a30e81
Downport (#3341)
* downport DTDC

* downport DRUL

* Downport AMSD

* downport BDEF

* more downport

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2020-05-04 11:34:32 +02:00
mariusraht2
b91043a270
Refactor Popup (#3310)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Delete pull.yml

* Refactored popup logic

Related to #3040

Refactoring of popup logic/calling to be able to reuse it as commit list.

* Removed reset flag

Removed reset flag cause it doesn't belong to this PR (will be readded later)

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-04 08:36:24 +02:00
Christian Günter
5234a25c35
DTDC: Dynamic Cache (#3335)
* DTDC: Dynamic Cache

* Update ref-supported.md

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2020-05-02 17:04:08 +02:00
Christian Günter
2d991b2315
DRUL: Dependency Rule (#3336)
* DRUL: Dependency Rule

* Update ref-supported.md

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2020-05-02 17:01:00 +02:00
Christian Günter
a785bcdb99
DDLS: Ignore baseinfo file not exists error (#3334)
Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2020-05-02 16:51:52 +02:00
Jaime Rodriguez Capote
6b74fb5d33
Check table SEOMETAREL (#3322)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-02 16:45:47 +02:00
Christian Günter
1f536b3225
SRVD: Service Definition (#3329)
* SRVD: Service Definition

* Update ref-supported.md

* cleanup

* change file extension to assrvd

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-02 16:39:31 +02:00
Jakub Filak
4be0dd14ba
Move misplaced object handler to their correct package (#3327)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-02 16:32:48 +02:00
Christian Günter
02b208487c
AMSD: Logical Database Schema (#3337)
* AMSD: Logical Database Schema

* Update ref-supported.md

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2020-05-02 16:26:14 +02:00
Christian Günter
eacfe8a2b7
BDEF: Behaviour Definition (#3331)
* BDEF: Behaviour Definition

add transport handling

* Update ref-supported.md

* refactor

* remove DDLS activation

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-02 16:15:55 +02:00
Christian Günter
e2b64d83c6
SRVB: Service Binding (#3330)
* SRVB: Service Binding

* cleanup

* Update ref-supported.md

* Update ref-supported.md

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-02 16:07:12 +02:00
abapChaoLiu
90bf633b8f
Add support to object OA2P - OAuth2 Profile (#3302)
* add support to object OA2P - OAuth2 Profile

* remove some comments

* fix abaplint errors

* docs: OAP2 supported

* Update ref-supported.md

* Update .abapgit.xml

* remove system specific information in SERIALIZE()

* Add support to method JUMP()

* Avoid manipulating DB tables directly

* fix abapLint errors

* fix abapLint errors

* fix abapLint error

* code object and APIs dynamically

Co-authored-by: Chao Liu <abapChaoLiu@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2020-04-26 09:00:56 +02:00
Jaime Rodriguez Capote
1b36d98ef8
(de)serialization (z)if_apack_manifest (#3311)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-26 08:54:50 +02:00
Rakshith Gore
b0d54f97e3
STVI, Transaction variants (#3307)
* Screen Variants Support

* Update package.devc.xml

* Checks Corrected

* Package Description Change

* Transaction Variant Supported

* Delete zcl_abapgit_object_stvi.clas.xml

* Delete zcl_abapgit_object_stvi.clas.abap

* Transaction Variants Supported

* Checks Corrected

* Clean Code

* Handle User Details

* Delete zcl_abapgit_object_scvi.clas.abap

Delete Conflicting files

* Delete zcl_abapgit_object_scvi.clas.xml

Deleting conflicting files

* docs, STVI, Transaction variant

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-23 07:09:51 +02:00
Rakshith Gore
f0641a7292
SCVI: Screen Variants Support (#3306)
* Screen Variants Support

* Update package.devc.xml

* Checks Corrected

* Package Description Change

* Transaction Variant Supported

* Delete zcl_abapgit_object_stvi.clas.xml

* Delete zcl_abapgit_object_stvi.clas.abap

* Clean Code

* Handle User Details

* docs, SCVI supported

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-22 07:29:26 +02:00
abapChaoLiu
4ab4abcc6b
fix - handle exception cx_oo_clif_scan_error_detai (#3314)
fix issue 3313

Co-authored-by: Chao Liu <abapChaoLiu@gmail.com>
2020-04-22 07:24:07 +02:00
mariusraht2
c2fc8f00fe
Issue 3294: ZCL_ABAPGIT_TIME: Unit Test fails on AS ABAP 752, SP04 (#3295)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Updated testclass for util_time

* abaplint, get_utc

* Delete pull.yml

* Made time tests method more simple

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-15 14:15:03 +02:00
Christian Günter
48454c5922
fix page diff dump: use repo instead of repo_online (#3304)
* fix page diff dump: use repo instead of repo_onlin

* make repo online an attribute
2020-04-14 18:57:21 +02:00
Christian Günter
c9241e7cff
Fix zcl_abapgit_gui_component definition (#3299)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-09 09:39:35 +02:00
Christian Günter
decc2d4863
Page Patch: fix unit test (#3293) 2020-04-08 15:58:22 +02:00
Jaime Rodriguez Capote
0bc7e6bde7
Clean code (#3292)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-07 18:49:09 +02:00
Alexander Tsybulsky
0eb22a0c87
Gui refactor, part 1 (#3289)
* gui component and event registering

* remove iv_prev_page from event_handler if

* constructors raising zcx_abapgit_exception

* get_gui_services - UT friendly

* linter fixes

* more linter fixes

* zif_gui_services stub all methods

* linter fix

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-07 10:30:43 +02:00
Jaime Rodriguez Capote
fce71de4d1
Use constants for Y/N/P (#3291)
* Use constants

* Pretty Printer
2020-04-05 10:55:24 +02:00
Jaime Rodriguez Capote
27ac61e95d
Apack dependencies (#3285)
* Support APACK dependencies

Check installed apack package dependencies for current repository
Display a popup with dependencies

* abaplint checks

* abaplint checks

* abaplint checks

* Popup only when dependency not met

* abaplint checks

* abaplint checks

* Optimization

* abaplint checks

* abaplint checks

* Fix typo "dependeNcies"

* Remove address from dependency check

* Dependencies popup title

* Dependencies popup enhanced

* EXCEPTION column replacing MET
* Enable Git URL hiperlink

* APACK doc - Version dependency support

* Dependencies version check support

* abaplint checks

* abaplint checks

* Version utils

* fix syntax warning

* move set_dot_apack to protected

Co-authored-by: larshp <larshp@hotmail.com>
2020-04-05 08:57:59 +02:00
Christian Günter
803ca23176
Refactor page diff: Introduce subclass for patch (#3283)
* Introduce zcl_abapgit_gui_page_patch as subclass of zcl_abapgit_gui_page_diff

introduce pop-method on GUI stack

fix linter + raising exception when gui stack emp

introduce zcl_abapgit_gui_page_patch

more

add

fix linter

remove go back to patch after commit

fix linter

remove bookmark for stage page

remove pop

src/ui/core/zcl_abapgit_gui.clas.abap

 src/zcl_abapgit_repo_online.clas.abap

* refactor: move more logic to  render_line_split_ro

* refactor move logic to render_diff_head_after_stat

* add logic to render_table_head_non_unified

* extract render_table_head_unified

* extract of is_patch_possible calculation

* fix linter

* move hotkey to patch

* refactor and rename to get_normalized_fname_with_p

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-31 17:14:13 +02:00
Lars Hvam
6957f6e9fb
1.94.0 (#3279)
* 1.94.0

* v1.94.0
2020-03-29 14:16:36 +02:00
Jaime Rodriguez Capote
90e3208163
Skip dom. appends serialization (#3275) 2020-03-29 09:16:54 +02:00
Christian Günter
1e4560b32a
Patch: new refresh functions (#3271)
* Patch: Refresh object first working version

* Patch: add refresh local and refresh repo + refact

* add missing stuff

* fix lint

* refactoring and cleanup

* add missing stuff

* refactor

* refactor

* refactor

* add title for menu bar

* Save and restore scroll position

* refactoring and cleanup

* refactor

* cleanup

* cleanup

* cleanup

* remove new hotkey

* disable object refresh for non-object files

* remove restore scrollposition

* cleanup

* refactor

* cleanup

* save scroll position

* Fix: refresh of deleted objects

* Fix dump: refresh new objects

* add hotkey support for refresh all local objects

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-26 12:30:22 +01:00
Frederik Hudák
63640bb3fc
Minor ux improvements (#3253)
* Resize stage list to full width

* Move patch button to the top menu

* Center stage list, increase line width in repo, stage

* Repo page - Increase line height for path column

* Stage list to full size

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-21 09:56:53 +01:00
Jaime Rodriguez Capote
7bf443d7a8
SHA1 for file zcl_abapgit_object_chdo.clas.abap (#3264) 2020-03-15 07:34:22 +01:00
Marcello Urbani
68117adb97
CHDO: clear UZEIT and UTIME dynamically (#3256) bis (#3260)
* CHDO: clear UZEIT and UTIME dynamically (#3256) bis

* fix variable name
2020-03-14 11:14:30 +01:00
Christian Günter
5c65f3411d
CHDO: clear UZEIT and UTIME dynamically (#3256)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-13 10:46:49 +01:00
Eduardo Ferrari Copat
e74d40516c
Diff - Add option to collapse files (#3248)
* Update zcl_abapgit_gui_page_diff.clas.abap

* Update zcl_abapgit_gui_page_diff.clas.abap

* Update zabapgit_css_common.w3mi.data.css

* Update zabapgit_css_common.w3mi.data.css

* test

* Update zabapgit_css_theme_default.w3mi.data.css

* Add collapse to css

* Add user select

* onDiffCollapse

* show source

* src

* Tries text

* hide/show

* uses nodisplay instead of hidden

* good hide

* ===

* Add button

* lint

* lint

* set function as global

* lint

* Exclude gui page diff

* remove extra space

* chevron

* pointer

* class

* Icons

* lint

* lint

* hide

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-12 17:09:00 +01:00
Frederik Hudák
31a912b124
Use xml syntax highlighter for html as well (#3251)
I came upon a `w3ht.data.html` object without syntax highlighting. We can reuse the xml highlighter for html.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-11 16:46:21 +01:00
g-back
79a1a667c6
Switch branch protected (#3250)
* add write-protect check for switch branch

* disable link for disabled toolbar functions

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-11 12:54:24 +01:00
Paweł Wiejkut
b0741dd419
AREA Object support (#3235)
* IOBJ fix #3105

* Variable fix

* BW function modules check

* AREA support

AREA support

* update, comment fix

* update

* iobj update

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-11 12:47:31 +01:00
g-back
07c87edd03
PINF: Exporting to Returning Parameter (#3252)
* change exporting to returning parameter

* enable prefer_returning_to_exporting
2020-03-11 11:42:15 +01:00
larshp
e638e6065a ZCL_ABAPGIT_GUI_PAGE_DIFF propagate exception 2020-03-10 08:17:12 +01:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
larshp
8fcf072917 remove call to super->constructor
there is no super class
2020-03-09 17:19:34 +01:00
Lars Hvam
c227d473df
Authorization objects in transactions #3233 (#3237)
* Support authorization in TRAN

* abaplint checks

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-05 18:43:58 +01:00
Jaime Rodriguez Capote
c9ae5ac122
Transaction, unknown cinfo #3223 (#3232)
* Determination transaction type

* Determine TX type

* abaplint checks
2020-03-04 06:41:04 +01:00
Lars Hvam
a85db8c8b8
SRFC: clear some admin fields (#3225)
* SRFC: clear some admin fields

* fix lock problem and delete problem
2020-03-04 06:34:58 +01:00
Jaime Rodriguez Capote
2ca3a3da91
CHDO change document object #802 (#3207)
* Support for CHDO

* Remove dependency from GENERIC

* Skip gen. objects by CHDO

* abaplint checks

* Moved filter to zcl_abapgit_repo

* Adjusted filter logic

* Delete unused methods

* Extract apply filter methods

New class zcl_abapgit_repo_filter generated with apply filter methods

* docs: update supported with CHDO

* Clear serialization fields

* Set package at deserialize

* Check errors at deserialize
2020-03-04 06:29:31 +01:00
Lars Hvam
4b35ecffb3
FUGR: Give proper error messages for RFC parameter (#3222)
* FUGR: Give proper error messages for RFC parameter

* reduce line length
2020-03-03 10:21:33 +01:00
larshp
b4b3414009 non existing package: fix dump #3224 2020-03-03 10:10:35 +01:00
Daniel Wegner
eb10fae8ef
Proxy bypass (#3221)
* add proxy bypass option in settings

* add proxy bypass popup and persist settings

* add proxy bypass to proxy config class

* Fix Proxy Bypass Button HTML

* Fix indentation

* Implement Method popup_proxy_bypass

* Fix behaviour in case of empty range tab

* Fix behaviour in case of empty range tab 2
2020-03-02 15:30:23 +01:00
Christian Günter
cec926e954
Diff: Only add beacon at beginning while patching (#3218) 2020-02-20 16:43:02 +01:00
Christian Günter
a8d474fab4
Patch: add path to jump target (#3216)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-20 09:39:56 +01:00
Alexander Tsybulsky
0961429903
#3209 DOCU master lang only (#3217) 2020-02-20 08:28:12 +01:00
Christian Günter
1668e670cf
Fix patch: multiple files with same name (#3213)
- unify id generation
- generate unique filenames

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-19 14:24:04 +01:00
Christian Günter
109c8c3be4
Patch: Remember patched lines when cancel Commit (#3212)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-19 13:55:19 +01:00
Christian Günter
5067e403b7
Patch: add beacon at beginning of objects (#3210)
* Patch: add beacon at beginning of objects

* extract constant + fix unit test
2020-02-19 12:48:26 +01:00
Johan Wigert
e57037e12c
Stage of IWMO, IWSG, IWSV (#3205)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-11 10:23:28 +01:00
Mauricio Lauffer
a9a505faf4
Prefer RETURNING to EXPORTING (#3204)
* refactor: Prefer RETURNING to EXPORTING

* refactor: Prefer RETURNING to EXPORTING
2020-02-11 10:20:45 +01:00
Lars Hvam
eb7e819b25 refactoring, delete unused variables and methods (#3203)
* zlib

* xml

* processor

* shi5

* remove unused filter parameter

* pinf cleanup

* ssfo delete empty method

* highlighter

* gui page res, remove unused

* remove unused in diff class

* adt link

* gui, remove 2 unused parameters

* branch overview
2020-02-09 09:38:17 +01:00
Jaime Rodriguez Capote
d5bc9b89c6
Img structure enhancement (#3200)
* Structure sequence extension

* Selection ORDER BY PRIMARY KEY
2020-02-08 09:02:51 +01:00
Jaime Rodriguez Capote
701f83ec2d
Travis-CI Error (#3201)
./src/ui/zcl_abapgit_gui_page_merge.clas.abap[187, 18] - Keep single parameter on one line (keep_single_parameter_on_one_line)

https://travis-ci.org/jrodriguez-rc/abapGit/builds/647280505?utm_medium=notification%26utm_source=github_status
2020-02-07 12:34:59 +01:00
g-back
48032207a8
remove macro, replace with method calls (#3198)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-03 09:16:36 +01:00
GB
4b35d98e5d remove macro, replace with method calls 2020-02-03 09:13:31 +01:00
Lars Hvam
7aea72f63a
git pack, remove macros #3170 (#3191) 2020-02-03 06:57:53 +01:00
larshp
a9b3ed7ac3 SUPPORTED_LIST, return sorted table 2020-02-02 10:12:05 +01:00
Alexander Tsybulsky
1be907bd73
remove DEFINE from zcl_abapgit_news (#3194)
* remove DEFINE from zcl_abapgit_news

* linter fix

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-02 09:48:07 +01:00
Lars Hvam
ab0d1a3fa6
remove DEFINE from merge class #3170 (#3192)
heh, this code is a mess, and need to add unit tests for it sometime
2020-02-02 09:25:12 +01:00
Lars Hvam
38837c3268
zlib, remove macros, #3170 (#3190)
* zlib, remove macros, #3170

* sneaky update to abaplint.json

* sneaky sneaky

* Update abaplint.json
2020-02-02 07:01:56 +01:00
Lars Hvam
52bd0795be
v1.93.0 (#3189)
* 1.93.0

* v1.93.0
2020-02-01 07:53:08 +01:00
Jens Schwarz
9285dd29b3
Fix for issue #1044 (#3167)
* Fix for issue #1044

* Change of local variable names

* fix of bad indentation

* Update src/objects/zcl_abapgit_objects_files.clas.abap

Co-Authored-By: Lars Hvam <larshp@hotmail.com>

* Update zcl_abapgit_objects_files.clas.abap

* Also always add BOM in abapgit.xml file

* Update zcl_abapgit_dot_abapgit.clas.abap

* Update zcl_abapgit_objects_files.clas.abap

* Update zcl_abapgit_convert.clas.abap

* Update zcl_abapgit_convert.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-01 07:43:08 +01:00
g-back
985d569f30
DIFF: Remove macros (#3188)
* remove macros

* change 740 syntax, move method call outside loop

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-01 07:38:05 +01:00
Alexander Tsybulsky
0dba9e5af3
remove DEFINE from zcl_abapgit_gui_view_repo (#3186)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-30 08:10:53 +01:00
Alexander Tsybulsky
0c3cdf639e
remove DEFINED from zcl_abapgit_gui_page_repo_over (#3185)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-30 08:03:19 +01:00
Alexander Tsybulsky
dc96e3b3ef
remove DEFINE from zcl_abapgit_ui_factory (#3184)
* remove DEFINE from zcl_abapgit_ui_factory

* linter fixes

* better approach

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-30 07:57:53 +01:00
g-back
3f00ed06d7
replace macros with methods (#3183) 2020-01-30 07:48:40 +01:00
mariusraht2
a1699302a6 Beautify (#3179)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Beautify

[OPT] Executed Pretty Printer
[OPT] Moved some types to definitions interface to be global

* Beautify

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
2020-01-26 14:32:48 +01:00
larshp
d8047ccad6 use built-in type 2020-01-25 17:47:33 +01:00
Christian Günter
9805cce0af fix: ignore not supp. objects during lock check (#3176)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-25 09:51:46 +01:00
Lars Hvam
9872f28d1d
GUI_PAGE_MERGE: refactor DEFINE (#3173)
* GUI_PAGE_MERGE: refactor DEFINE

* fix
2020-01-25 09:48:26 +01:00
Lars Hvam
2c7f325ecb
merge: refactor DEFINE _visit to method (#3171) 2020-01-25 09:44:05 +01:00
Lars Hvam
847a8d9444
branch_overview: refactor DEFINE to private method (#3168) 2020-01-25 09:38:13 +01:00
Jakub Filak
3314e00069 fugr: do not uncoditionally add T00 include (#3164)
I know don't why but on our systems the "include for generated
maintenance views" is returned from the function module
RS_GET_ALL_INCLUDES, so when we add it in the method
zcl_abapgit_object_fugr=>includes we have the file twice which cause
duplicate errors on our systems.

I didn't remove the code because we are supposed to run on all ABAP
rutime versions and the problem with duplicates for the T00 includes has
started occurring only recently, so the older versions need this
artificial include (I guess).

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-24 16:02:01 +01:00
Lars Hvam
3e0b0505b1
remove commented code (#3166)
* update abaplint.json

* remove commented code

* remove 2 unused variables
2020-01-24 14:31:04 +01:00
Paweł Wiejkut
fa07c370a6 ODSO Support - new (#3146)
* IOBJ fix #3105

* Variable fix

* BW function modules check

* ODSO Support

* update

* Data type fixes

* check fix

* refactoring, variables simplification

* IOBJ support extension

Extension of current IOBJ support by handling of:
-attributes
-compondings
-hierarchy

* IOBJ downgrade

* Dynamic method fix

* lint fixes

* space fix

* Remove unused variables

* table type fix

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2020-01-19 08:39:39 +01:00
Christian Günter
92f8ee0d62 DOCT: consider all versions (#3161)
* DOCT: consider version - use ZCL_ABAPGIT_LONGTEXTS

* fix linter

* switch to factory

* fix linter
2020-01-19 08:34:48 +01:00
Fabian Lupa
c4f4c713b6 Handle spaces in stage filter (#3153)
* Handle spaces in stage filter

#3073

* Fix JS lint issue

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-14 17:01:56 +01:00
Christian Günter
2df559ebdd IOBJ: Refactoring - remove RTTC + cleanup (#3156)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-13 18:48:58 +01:00
Christian Guenter
bae1e21c5b Refactoring: Delete unused variables 2020-01-13 18:41:52 +01:00
Paweł Wiejkut
c9e8ca2c93 IOBJ support enhancement (#3147)
* IOBJ fix #3105

* Variable fix

* BW function modules check

* Enhancement of iobj support

Enhancement of iobj support which enable handling of:
-attributes,
-compoundings,
-hierarchies

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-11 10:11:57 +01:00
Christian Günter
f9dfa6c22a MSAG: fix, order by primary key (#3149)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-11 10:04:28 +01:00
Lars Hvam
75812fb17b
less prefixes (#3144) 2020-01-11 09:24:36 +01:00
Jaime Rodriguez Capote
1a896613b4 Issue #3136 ATC Check - GEN_INCLUDE_NOT_EXEC dump (#3145)
* Issue #3136 ATC Check - GEN_INCLUDE_NOT_EXEC dump

* abaplint checks

* Raname method check_obj_before_add to skip_object

* change skip_object logic

* CASE for objecttype
2020-01-08 12:21:44 +01:00
Jaime Rodriguez Capote
9e3c73b277 Issue 3066: Class text elements translation (#3078)
* Issue 3066: Class text elements translation

* Removed comments for Issue 3066

* Pull request checks

* Travis-CI checks fixes

* Travis-CI checks fixes - Identation

* Interfaces pretty printed

* Travis-CI identation check

* Travis-CI identation check

* Changes type tt_langu and serialization

Type tt_langu moved from zif_abapgit_definitions to ZCL_ABAPGIT_OBJECTS_PROGRAM
Encapsulated code to serialize DOCU, TPOOL and SOTR for classes

* abaplint corrections

* abaplint corrections

* Encapsulated serialization %26 new IF lang def.

* zif_abapgit_definitions types indentation

* Restore zif_abapgit_definitions

* Revert zcl_abapgit_object_clas

* Revert zcl_abapgit_object_clas

* Revert zcl_abapgit_objects_program

* Revert zif_abapgit_oo_object_fnc.intf.abap

* Revert zcl_abapgit_object_clas.clas.abap

* Class text language

* Class text language

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-08 07:36:36 +01:00
mariusraht2
1f49f7a76d Issue 3130: TYPE: Type Group/Pool isn't being recognized (#3131)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Remove select for exists check

Due to the language flag-specific select a type group/pool couldn't be found. Removed the select at all because the following FM also recognizes unexistent type groups/pools and sets sy-subrc to something <> 0.

* Fill description if available in login language

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-08 07:14:21 +01:00
Christian Günter
baac63ce87 IOBJ: Downport BAPI* structures (#3142)
* IOBJ: Downport BAPI* structures

* fix linter

* Update zcl_abapgit_object_iobj.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-08 07:10:34 +01:00
Geert-Jan Klaps
1bed3ba6e7 Fix activation error 7.40 EhP 4 (IARP/IASP) #3139 (#3140) 2020-01-07 11:47:04 +01:00
Lars Hvam
e201bf566f
remove class prefixes if its current class (#3137)
* remove class prefixes if its current class

* Update abaplint.json
2020-01-06 13:20:19 +01:00
Christian Günter
a256a0b406 Refactor IARP + IASP API calls (#3135)
* Refactor IARP

* Refactor IARP

* Refactor IASP

* Update zcl_abapgit_object_iasp.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2019-12-28 12:23:54 +01:00
Lars Hvam
b42f3bc485
Refactoring (#3134)
* fully type constants

* moving to single line

* move to single line

* enable keep_single_parameter_on_one_line
2019-12-28 12:11:32 +01:00
Christian Guenter
ade359ecd3 Implement jump for IWMO, IWPR, IWSV and IWVB 2019-12-19 13:58:38 +01:00
Christian Günter
56e2ef3983 Fix: Preserve spaces in error messages (#3128)
* Fix: Preserve spaces in error messages

* cleanup + fix linter
2019-12-19 10:30:22 +01:00
mariusraht2
5bee54fff3 Commit icon added (#3124)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Added new icon code-commit via SMW0
2019-12-19 06:20:22 +01:00
Christian Günter
82486ec350 IOBJ: Use RSD_S_VIOBJ instead of RSD_S_VI_OBJ (#3121) 2019-12-17 08:44:17 +01:00
Michael Schneider
2ae0e1e4cf Fix protected redefinitions
During creation of classes with redefinitions in the protected section, entries in table SEOREDEF are not updated properly.

Reason: The buffer of Class Builder does not recognize the creation of the inheritance in the active version.  During the creation of the super class relationship in SEO_INHERITANCE_CREATE_F_DATA only the inactive buffer is updated. The buffer for the active version has still the state that the class has no super class.

Therefore, SEOREDEF is filled with an empty super class name. 

If the buffer is refreshed before the metadata is updated, the super class is read correctly before SEOREDEF entries are created.
2019-12-17 08:41:21 +01:00
Christian Günter
4f47fa64a7 zcl_abapgit_code_inspector: Remove duplication (#3117)
* zcl_abapgit_code_inspector: Remove duplication 

Removes duplication of subpackage determination in zcl_abapgit_code_inspector

* add current package
2019-12-12 11:01:29 +01:00
Christian Günter
60a57cf356 Add package parameter to zif_abapgit_object~delete (#3114) 2019-12-11 10:42:45 +01:00
Paweł Wiejkut
01b6d9d92a IOBJ fix - issue 3105 (#3108)
* IOBJ fix #3105

* Variable fix

* BW function modules check
2019-12-11 07:10:15 +01:00
Johan Wigert
57d199b4ed Can't transport Report Program Application Variant (#3111)
See #3107
2019-12-11 07:03:44 +01:00
Lars Hvam
7e15c7a844
1.92.0 (#3103)
* 1.92.0

* 1.92.0
2019-12-05 15:34:27 +01:00
Frederik Hudák
c686a7dd3b Unescape '=' character (#3102)
* Unescape '=' character

* fix abaplint
2019-12-05 15:23:47 +01:00
Frederik Hudák
c846801d19 Add adt link to objects on diff page (#3095)
* Add adt link to object name on diff page

* Fix abaplint, improve error handling

* abaplint

* Remove superflous method
2019-12-05 08:59:15 +01:00
Lars Hvam
a616f5d3f5
fix protected redef #3053 (#3100) 2019-12-04 10:21:12 +01:00
sandraros
175f2fabec Code selection by column on DIFF screen (#3091)
* Code selection by column on DIFF screen

Fix of #3089

Two ways to select a text:

1. Position the mouse at the start of the text, press mouse left button, keep pressed, drag to the end of the text, release the button

2. Position the mouse at the start of the text, press mouse left button, release the button, position the mouse to the end of the text, press shift key + mouse left button.

Two ways to copy the selected text:

1. Press Ctrl + C or Ctrl + Ins

2. Mouse right button on the text to display the context menu and choose Copy

SPLIT VIEW (code at the left is the LOCAL code and code at the right is the REMOTE code):
- Text can be selected only at the left side, or only at the right side.
- The dummy empty lines which show the place of lines which exist only at the other side are not copied.

UNIFIED VIEW (LOCAL and REMOTE are mixed in the same column, "green plus" lines correspond to lines only in the LOCAL code, "red minus" lines correspond to lines only in the REMOTE code.
- Only the lines from the REMOTE code are copied

PATCH VIEW (split view + one extra column on the left)
- Same features as the SPLIT VIEW

* corrections lint javascript

* merge latest abapgit changes

* corrections lint javascript

* JS refactor functions to prototyped fns (classes)

* JS lint corrections + minor last minute changes

* conform current common.js standards

* LINT conform to common.js standards

* unused lines removed
2019-12-02 09:32:15 +01:00
mariusraht2
02204d07b4 Improved time conversion (#3096)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Improved time conversion

Preparation for #3040

> rename time%3D>get to time%3D>get_unix
> added time conversion from unix to real (get_real)
> added unit tests for time conversion

* abapLint

* Raise cx_static_check and removed exc handling
2019-12-02 09:28:41 +01:00
Paweł Wiejkut
0b5b1b60df InfoObject support (#3058)
* InfoObject support

* Checks fixes

* Code corrections - return and lock check

* Check fix

* addend infoobjects information

* transport and package support

* check fix

* Update ref-supported.md

* metadata change

* Transport fixes
2019-11-27 06:23:54 +01:00
Alexander Tsybulsky
39ee3c961f fix #3048, remote only stage js error (#3086) 2019-11-27 06:19:01 +01:00
Italo N
0f379b950a DOMA: consider clearing VALPOS (#3083) 2019-11-26 07:39:25 +01:00
g-back
965082510b Exchange sy-langu usage with mv_language for consistency (#3082) 2019-11-26 07:29:59 +01:00
Lars Hvam
29cb891d23
remove obsolete NO_HANDLER pragmas (#3085)
* remove obsolete NO_HANDLER pragmas

* update lint to latest
2019-11-25 07:35:41 +01:00
mariusraht2
064e006c88 Issue 3042: Error author regex (#3070)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Tags: Error author regex

> Regex couldn't match with string "pull[bot] <39814207+pull[bot]@users.noreply.github.com> 1573216988 +0000" because "[]" weren't allowed

* abapLint

* Added unit test for author_regex

#3042

* Any character in author name and Unit Tests

#3042
#3069

* Unit Tests and utils method for author regex

#3042
#3069

> Unit Tests for author_regex (zif_abapgit_definitions)
> New utils method for regex check as utils method in zcl_abapgit_utils
> Regex for author expects now at least one character for the author name ('^(.+)'...)
> Use zif_abapgit_definitions%3D>ty_commit_tt  instead of local type of the same type in class zcl_abapgit_branch_overview

* Changed utils method/tests and moved unit tests

#3042 - Error author regex
#3069 - Add unit tests

> Renamed is_author to extract_author_data and moved related source code from branch_overview to utils class
> Changed related unit tests to handle exception or not
> Moved unit tests to local class of zcl_abapgit_utils

* abapLint

* abapLint

* abapLint

* abapLint

* exclude 7bit test for testclass
2019-11-21 06:40:25 +01:00
mariusraht2
6491967d76 Issue 3029: TABL: SAPGUI data preview doesn't work when opened (#3059)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* TABL: SAPGUI data preview doesn't work when opened

Fixes #3029

> Call RS_TOOL_ACCESS instead of ABAP4_CALL_TRANSACTION

* Delete pull.yml
2019-11-17 10:42:21 +01:00
mariusraht2
5fa3057c48 Issue 3042: Error author regex on Tag switch (#3067)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Tags: Error author regex

> Regex couldn't match with string "pull[bot] <39814207+pull[bot]@users.noreply.github.com> 1573216988 +0000" because "[]" weren't allowed

* abapLint
2019-11-17 10:38:09 +01:00
mariusraht2
89dfeb69f8 Issue 3060: Check repo URLs before creating a new online repo (#3063)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Check repo URLs before creating a new online repo

Fixes #3060

* Check repo URLs before creating a new online repo

Use method zcl_abapgit_url%3D>name and replace the assert with an exception
2019-11-17 10:31:27 +01:00
mariusraht2
8df12d34e0 Issue 3061: Change default value for creation of playground page (#3062)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Change def. value for creation of playground page

Closes #3061

* Update zcl_abapgit_popups.clas.abap
2019-11-17 10:18:40 +01:00
Christian Günter
83a781e1d7 IWVB: SAP Gateway Business Suite Enablement -Vocab (#3049) 2019-11-12 11:03:04 +01:00
Alexander Tsybulsky
5edea3acda quick fix unicode char in js (ctrl+enter) #3035 (#3052) 2019-11-11 09:21:22 +01:00
Christian Günter
93f5186b1d Object serializer descriptions (#3050) 2019-11-11 09:15:03 +01:00