Commit Graph

52 Commits

Author SHA1 Message Date
Marc Bernard
af3e47527d
CLAS: Refactor skip of SADL classes (#6198) 2023-04-06 11:19:32 +02:00
Alexander Tsybulsky
018e56cfcf
USE_LXE settings and serialization of selected languages (in old format) (#6168)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-03-30 15:17:18 +02:00
Alexander Tsybulsky
69515e5f55
LXE: more objects (#6144) 2023-03-13 17:36:00 +01:00
Marc Bernard
a2278c94da
CLAS: Fix variable name (#6127) 2023-03-03 20:26:31 +01:00
Marc Bernard
5351a4b4e8
CLAS: Fix recording of changes in transport (#6047) 2023-02-08 12:45:49 +01:00
Marc Bernard
67093085f6
CLAS,ENHO: Fix inactive enhancements (#5810)
* CLAS,ENHO: Fix inactive enhancements

When pulling a change to an existing class, existing enhancement where inactivated and the enhancement code deleted. 

This was caused by unnecessarily calling `CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE'` in `zcl_abapgit_oo_class->create`, twice.

The change avoids the second call if the class properties and attributes have *not* been changed. Interfaces are handled the same way. 

Tested with CI tests for classes and interfaces:


Closes #5809

* Clear

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-10-07 15:00:31 -04:00
Jon Friesen
954d913191
CLAS,INTF: Support for component documentation (#5575)
* serialization

* full sotr class serialization

* nw 7.02 compatibility

* ensure consistent order

* Second attempt to stage support for CLAS and INTF 

Second attempt to stage support for CLAS and INTF, first attempt did not have changes

* Pretty printed

* Lint compliance part 1

* Lint compliance part 2

* code review remediation plus one bugfix

includes one bugfix - do not write entries in <DOCU_CAT> if there are no lines of text

* Update src/objects/zcl_abapgit_objects_program.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Switch to new method

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Marc Bernard <marc@marcbernardtools.com>
2022-10-04 09:33:38 -04:00
Marc Bernard
b18586ba32
CLAS,INTF: Add missing shorttexts (#5755)
* CLAS,INTF: Add missing shorttexts

Serializes shorttexts for sub components (like method and event parameters).

Preparation for https://github.com/abapGit/abapGit/pull/5718

New test cases:

https://github.com/abapGit-tests/INTF_docu
https://github.com/abapGit-tests/CLAS_docu

* Clear/set class/interface name for shorttexts

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-09-15 11:34:32 -04:00
Marc Bernard
01297df9a5
Avoid duplicate key error (#5663)
Follow-up #5652

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-06-29 14:39:10 +02:00
Marc Bernard
0ab3ee0a06
Remove aliases from object classes (#5588) 2022-06-04 10:33:42 +02:00
Gregor Wolf
276ad4e808
Exclude technical language from intf, clas, prog, dtel, doma and tabl (#5598)
* exclude technical language from DOMA

* exclude technical language from DTEL

* exclude technical language from TABL

* exclude technical language from CLAS

* exclude technical language from PROG

* exclude technical language from INTF

* fix abaplint issue: Place pragma at end of statem.

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-05-30 12:18:32 +02:00
Marc Bernard
ca5023c6d0
CLAS: Add to deletion transport (#5563)
Fix missing transport entry
2022-05-23 18:16:22 +02:00
sandraros
b3c89a8ff2
Create empty classes/interfaces before DDIC (#5393)
* Force XSLT activation during deserialize

* Revert "Force XSLT activation during deserialize"

This reverts commit 7d6fc64ddb.

* Create empty class/interface before DDIC phase

Fix #5392

* pretty printer ZCL_ABAPGIT_OBJECT_INTF

* abaplint zcl_abapgit_object_clas

* Update zcl_abapgit_object_clas.clas.abap

* Update zcl_abapgit_object_dtel.clas.abap

* Update zcl_abapgit_object_intf.clas.abap

* Update zcl_abapgit_object_tabl.clas.abap

* Update zcl_abapgit_object_ttyp.clas.abap

* Update zcl_abapgit_objects.clas.abap

* Update zcl_abapgit_object_clas.clas.abap

* Update zcl_abapgit_object_intf.clas.abap

* Update zif_abapgit_object.intf.abap

* Update src/objects/zcl_abapgit_object_intf.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update order numbers

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-26 16:07:15 +02:00
Marc Bernard
524f6eebc5
CLAS/INTF: Fix serialize/deserialize of documentation (#5374)
* INTF: Fix serialize/deserialize of documentation

Documentation of interfaces (document class IF) was missing and has been added.

* Fix translations
2022-02-28 14:25:52 +01:00
Fabian Lupa
dc51247e9b
Always use active version for DOCU CL (#5201)
* Always use active version for DOCU CL

* CLAS/INTF delete documentation on pull

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-14 06:36:00 +01:00
Marc Bernard
3fa3323b2e
Refactor: Jump to Object Logic (#5158)
* Refactor: Jump to Object Logic

Continue #5114

- Removes jump_adt and jump_se11 from zcl_abapgit_objects_super
- Remove almost all object-specific jump handlers (zif_abapgit_object~jump) since they are covered by GUI Jumper now

* Remove ZCL_ABAPGIT_OBJECT_SICF

* Remove obsolete RS_TOOL_ACCESS

* FUGR

* IATU

* PDXX

* SRVD

* XINX

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-11-29 15:52:13 -05:00
Alexander Tsybulsky
c0ad1a96d0
Better multi-lang class tpool handling (#5074)
* better multilang class tpool handling

* dont save lang list on empty clas docu

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-02 06:10:03 +01:00
Marc Bernard
3393aaaf94
CLAS: Replace APACK references (#4968)
Also replaces references to APACK types
2021-09-23 17:35:03 -04:00
Marc Bernard
e2a156a326
Replace deprecated LANGU type (#4815)
* Replace deprecated LANGU type

Replace with `sy-langu` and update abaplint rule

* Replace langu

* Add langu to void types

* Replace table of langu
2021-06-02 08:04:05 +02:00
Lars Hvam
7b336a4a71
cleanup unused local variables (#4739) 2021-05-01 09:51:05 +02:00
Marc Bernard
bf5199b8d2
APACK: Replace interface name with constant (#4684)
* APACK: Replace interface name with constant

Closes #4248

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-03 08:59:44 +02:00
Marc Bernard
a1cc7f8668
CLAS: Fix several issues related to class includes (#4510)
* CLAS: Remove test class include

Once unit tests are disabled, the test class include is now completely removed (before it might have still contains obsolete code).

Closes #4460

* Reverse pp

* Update 6 objects

* Typo

* Typo

* Revert

* Revert

* Revert

* Revert

* Revert

* Lint

* Update zcl_abapgit_oo_class.clas.abap

* Move add_to_activation

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-12 07:05:47 +01:00
Marc Bernard
31a550db0f
Refactor I18N settings (#4423)
* Refactor I18N settings

- Consolidate I18N parameters into a structure and pass it to xml and serializer classes (#4415)
- Continue change of terminology (#4043)

* Remove changes to serializer class

* Main lang

* DSYS

* OTGR

* Repo view

* Main langu

* Repo view %26 stage

* Serialize

* Settings

* Repo view

* Defs

* Stage

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-19 14:29:09 +01:00
Lars Hvam
95e427b970
Move type ty_seocompotx_tt (#4168) 2020-11-12 14:29:42 +01:00
Marc Bernard
b25a67acea
Terminology: Inclusive Language - Part 2 (#4159)
* Terminology: Inclusive Language - Part 2

Change "Master Language" to "Main Language" in UI and comments (documentation and variables next)

* Docs

* Docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-11 10:36:38 +01:00
Marc Bernard
5068e7553c
CLAS: Performance APACK (#4016)
- Replace `select count` with `select single`
- Remove unnecessary loops
- Keep SAP apack manifest during deserialize (if available)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-13 16:49:21 +02:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
g-back
6f8147036e
XML Refactoring: Various Objects (#3891)
* change xml references

* change xml reference
2020-09-16 15:23:14 +02:00
g-back
4dde63360e
XML Refactoring: Comparator/OO_Object_FNC (#3888)
* change xml references to interfaces


changed reference in interfaces:
- zif_abapgit_comparator
- zif_abapgit_oo_object_fnc

* change reference of xml in dependent objects

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-16 12:43:40 +02:00
Marc Bernard
b0d1d04ade
Automatically repair ZCX_ABAPGIT_EXCEPTION (#3840)
* Automatically repair ZCX_ABAPGIT_EXCEPTION

See #3833

* Add TODO

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-06 09:11:19 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Marc Bernard
0ea7b702ce
Refactor and enhance OTR support (#3681)
* WDYN: Fix missing texts

Texts were missing if more than one concept existed per WebDynpro component. Also fixes unit tests which were not working properly before and adds anew test.

* Pretty print

* Refactor and enhance SOTR support

Now supports all objects that use OTR: CLAS (LIMU/CPUB), ENHC, ENHO, ENHS, ENSC, WAPA (LIMU/WAPP) WDYA, WDYN (LIMU/WDYV), WEBI

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-09 08:41:47 +02:00
Frederik Hudák
b12c811159
Master lang only - clear descriptions for clas, intf (#3388)
* Master lang only - descriptions for clas, intf

* Use master language instead of logon language

* sy-langu to master language - fix cus0, cus1, cus2

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-23 12:59:54 +02:00
Jaime Rodriguez Capote
6b74fb5d33
Check table SEOMETAREL (#3322)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-02 16:45:47 +02:00
Jaime Rodriguez Capote
1b36d98ef8
(de)serialization (z)if_apack_manifest (#3311)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-26 08:54:50 +02:00
Jaime Rodriguez Capote
9e3c73b277 Issue 3066: Class text elements translation (#3078)
* Issue 3066: Class text elements translation

* Removed comments for Issue 3066

* Pull request checks

* Travis-CI checks fixes

* Travis-CI checks fixes - Identation

* Interfaces pretty printed

* Travis-CI identation check

* Travis-CI identation check

* Changes type tt_langu and serialization

Type tt_langu moved from zif_abapgit_definitions to ZCL_ABAPGIT_OBJECTS_PROGRAM
Encapsulated code to serialize DOCU, TPOOL and SOTR for classes

* abaplint corrections

* abaplint corrections

* Encapsulated serialization %26 new IF lang def.

* zif_abapgit_definitions types indentation

* Restore zif_abapgit_definitions

* Revert zcl_abapgit_object_clas

* Revert zcl_abapgit_object_clas

* Revert zcl_abapgit_objects_program

* Revert zif_abapgit_oo_object_fnc.intf.abap

* Revert zcl_abapgit_object_clas.clas.abap

* Class text language

* Class text language

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-08 07:36:36 +01:00
Lars Hvam
714fe7202d
whitespace fixes (#2964)
* whitespace fixes

* fix sql compare operators
2019-10-11 02:50:16 -07:00
Lars Hvam
9de609ef2a
refactor seox (#2850) 2019-08-06 23:24:48 -07:00
Martin Fuchs
9f2db446b1 simplified GET_DESERIALIZE_STEPS
Since all object handler contains exactly the same CASE statement for STEP definition, I would recommend that each object handler simply returns the STEP he belongs to.
This fix should "simply" issue #2499.
2019-05-05 00:57:52 -07:00
Lars Hvam
7bbaf069e2
File format update collection (#2605)
* File format update - changed object handler

I removed the following fields:

CLAS
VSEOCLASS-VERSION

INTF
VSEOINTERF-VERSION

PROG
PROGDIR-STATE

DCLS
AS4LOCAL
ABAP_LANGUAGE_VERSION (if exists)

DDLS
ABAP_LANGUAGE_VERSION (if exists)

DDLX
VERSION
RESPONSIBLE
MASTER_SYSTEM

MSAG
DOKIL-DOKSTATE

ENQU
DD25V-AS4LOCAL
DD25V-AS4VERS

* fix syntax error

* also clear PROG VARCL

* update XML files
2019-03-31 01:17:46 -07:00
GoWa
21527528c6 call redefined method of IF 2019-03-12 21:49:15 -07:00
larshp
25f6284493 implement GET_DESERIALIZE_STEPS
this is a quick fix, field LATE_DESER will be removed in future
2019-03-12 07:37:56 -07:00
Lars Hvam
3213d0c2dd
Deserialization performance, refactor COMPARE_TO_REMOTE_VERSION (#2438)
* core part refactored #2436

* indentation

* fix implementations

* delete ZCL_ABAPGIT_COMPARISON_NULL

* pretty print

* Update serializers.md

* downport
2019-02-20 22:20:24 -08:00
Lars Hvam
25d4c9ea07
Remove HAS_CHANGED_SINCE #1021 (#2401)
* core part removed

* remove method implementations
2019-02-15 06:51:57 -08:00
Lars Hvam
c9252b1b2a
CLAS cleanup (#2204)
* cleanup old experimental CLAS

* Move ZCL_ABAPGIT_OO_CLASS_NEW to _CLASS
2018-12-17 08:17:07 +01:00
Eduardo Ferrari Copat
d47027ad6c Remove redundant class and interface metadata (#2195)
* Remove CLSFINAL from VSEOCLASS serialization

* Remove EXPOSURE from VSEOCLASS serialization

* Remove clsabstrct from VSEOCLASS serialization

* Remove EXPOSURE from VSEOINTERF serialization

* Revert "Remove EXPOSURE from VSEOINTERF serialization"

This reverts commit 4036b7d015.
2018-12-12 14:31:42 +01:00
Domi Bigl
cf05295170 mark inactive objects in repo list #1943 (#2017)
* mark inactive objects in repo list

Inactive object are marked in the repo list
The sort order for changed files is not changed
unchanged inactive files come right after the changed files

* move acitve check to object interface

* add is_active for objects up to F

* add is_active for objects up to P

* add is_active for objects up to T

* add is_active for objects up to X

all core object implement (except SSFO) the standard active check via FM RS_INACTIVE_OBJECTS_WARNING now

* add is_active to plugins bridge - always active

* finish object interface implementation + objects

* add is_active for offline with object interface

* rename returning to RV_

* use returning for serialize

* cleanup, PP, UT
2018-10-31 15:54:57 +01:00
Fabian Lupa
ce05bb65b1 Serialize additional class component metadata (#1889)
* Serialize additional class component metadata

Fixes #1872

* Improve update_attributes performance

* Update WF attribute handling to use API
2018-09-25 16:11:50 +02:00
Christian Guenter
e394966795 FIX: CLAS is_locked read enque
Read enqueue entries instead of enqueueing
2018-08-22 06:34:32 +02:00
Marcello Urbani
f35c285605 clean up ZCL_ABAPGIT_OBJECT_CLAS_OLD, #1801 (#1846)
* refactor zcl_abapgit_object_clas

removed dependencies from zcl_abapgit_object_clas_old, moved methods

* deleted zcl_abapgit_object_clas_old
2018-08-21 10:34:55 +02:00