Commit Graph

21 Commits

Author SHA1 Message Date
larshp
e84358ae27 fix urlencoding 2017-07-23 12:41:19 +00:00
Jakub Filak
102e5f9858 html_utils: URL unescape parameter fields
For some strange reason even post data is URL escaped on our
servers.

How I discovered this issue:
1. go to stage
2. leave some files in the state ?
3. click the Commit link
4. get the error 'process_stage_list: unknown method %3F'

URL decode '%3F' and see that the value is '?'.

The value is set to the hidden input fields in its unescaped form
in the function submitSapeventForm() but the value is escaped in
the method lif_gui_page~on_event of the class lcl_gui_page_stage.
2017-07-20 15:04:16 +02:00
Lars Hvam
c843a3cce5 Merge pull request #822 from christianguenter2/ISSUE_821
Unnecessary assertion removed ISSUE 821
2017-07-17 19:56:50 +02:00
Christian Günter
d7fb8d5bdc Issue 795 (#820)
* Add first unit tests for parse_fields

* Fix Issue 795 - parse_fields with german umlauts

* fix formatting issues

* Refcatoring method renaming

* Unchained method calls

#795

* Fixed linter error and change usage of class...

Fixed linter error. E.g. encoded umlauts as hex values.

Replaced all usages of cl_http_utility%3D>if_http_utility~string_to_fields with lcl_html_action_utils%3D>parse_fields

* add URL decoding logic
2017-07-17 19:54:43 +02:00
Christian Guenter
0492e35c25 Unnecessary assertion removed 2017-07-08 14:54:12 +00:00
larshp
824195f63a rename classes #733 2017-06-09 07:41:05 +00:00
larshp
6a75a0922c move constants and types to interface 2017-06-07 18:26:53 +00:00
bigld
7a34c9de21 New Parameter for Commit Message Length - #648
Two setting parameter to adjust commit comment length (50-100) and Body line size (72-100)
2017-04-24 08:13:07 +02:00
Alexander Tsybulsky
be79b3234a page_diff UX filter finalizing 2017-03-10 22:14:03 +02:00
Alexander Tsybulsky
ca91c22371 separate login, author and committer #535
committer - double m, double t ;)
2017-02-22 19:36:09 +02:00
larshp
4ca551b74e update to latest abapGit format 2017-01-22 09:37:26 +00:00
larshp
68c51626a3 edit xml - fix dump, close #539 2017-01-17 16:05:23 +00:00
EduardoCopat
9063a2d6a6 Settings (proxy) #412 (#414)
* Added empty settings page
Also added it in the Advanced meun

* Added Settings HTML structure

* Provide settings persistence
I put the unit tests in the persistence include rather than the unit test include

* Triggering settings save on UI event

* Plug-in the proxy settings into CL_HTTP_CLIENT
Also, removed a break point...

* abaplint fixes

* abaplint fixes #2
2016-11-10 16:40:49 +01:00
larshp
32cac9d00e rework "object to zip" to files
for cherry picking objects, without exporting the entire package

previous implementation was too slow, as it had to serialize the entire package, and just needed files for one object
2016-10-25 19:37:55 +02:00
larshp
d03a9bdcc7 code inspector and pretty printer 2016-10-15 09:58:36 +00:00
sbcgua
e5174d45aa Diff all feature at stage page (#396)
* cherrypick cache repo results (#280)

* lcl_gui_view_repo_content - code reorg #280

* fix

* folders part 1 #280

* cherrypick refresh

* cherrypick 2 pretty print

* cherrypick log style

* cherrypick lock icon

* cherrypick background icon and toc marker

* cherrypick macro include

* unit test for lcl_path and fixes

* folders part2 #280

* changes_only at user profile #280

* fix empty package

* fix dump on type change

* new repo, remove fixes, close #393, close #394

* merge fix

* all repo diff at stage page
2016-10-15 01:32:04 +02:00
sbcgua
fdf96cbf6c render repo refactor and folders view #280 2016-10-14 11:03:37 +03:00
sbcgua
a95afceb03 UI: Main page, hide file list, adjust diff #347 2016-09-20 17:58:35 +03:00
atsy
aa3c2a233a bg services, navigation action renaming (#345)
* #319, refactor render_repo_menu

* #319, btw: decrease short list size, fix db exept

* #319, small text fixes, preparations for remotes

* #319 preparations 2

* #319 refactor popup_to_confirm

* #319 detach logic DRAFT

* #319, btw: decrease short list size, fix db exept

* #319 refactor popup_to_confirm

* #319, part 2

* #338 small fixes

* #338 lcl_services_repo, part1

* #338, remove files_commit action logic
Removes files_commit action handling 
and lcl_zip->files_commit
and modifies interface of lcl_zip->export

* #338, services_repo fixes and improvements

* #338, lcl_services_abapgit

* #338, small improvements

* #338 adopt render_repo_menu from #319

* #338 lcx_cancel

* #338 zip services

* #338 abapgit services finetune

* #338 lcx_cancel finetune

* #338 zip finetune

* fix repo_menu

* #388 small adj

* #338 lcl_services_git part1

* #338 lcl_services_db, html_actions features

* #338, services_repo=>new_offline

* #338, delete/switch branch to lcl_services_git

* #338, improvements in switch_branch

* #338, switch_branch more improvements

* #319 attach, detach, change - complete

* #319, fine tuning - repo_popup title

* #319 linter fixes

* #319 Pull-Stage improvements, sha1 in files

* #338 rename page links go_

* #338 lcl_services_background
2016-09-18 08:43:06 +02:00
atsy
7719fa3d44 route, popups, services (#342)
* #319, btw: decrease short list size, fix db exept

* #319 refactor popup_to_confirm

* #338 small fixes

* #338 lcl_services_repo, part1

* #338, remove files_commit action logic
Removes files_commit action handling 
and lcl_zip->files_commit
and modifies interface of lcl_zip->export

* #338, services_repo fixes and improvements

* #338, lcl_services_abapgit

* #338, small improvements

* #338 adopt render_repo_menu from #319

* #338 lcx_cancel

* #338 zip services

* #338 abapgit services finetune

* #338 lcx_cancel finetune

* #338 zip finetune

* #388 small adj

* #338 lcl_services_git part1

* #338 lcl_services_db, html_actions features

* #338, services_repo=>new_offline

* #338, delete/switch branch to lcl_services_git

* #338, improvements in switch_branch

* #338, switch_branch more improvements
2016-09-17 08:46:55 +02:00
sbcgua
0cf7800daf #329 reorg includes 2 2016-09-08 15:08:55 +03:00