Commit Graph

25 Commits

Author SHA1 Message Date
larshp
ff6725e759 replace uses of log with interface 2019-03-17 01:39:52 -07:00
Lars Hvam
fc167ff3cd
update abaplint config to latest (#2480)
* update abaplint config to latest

* remove some descriptions

* remove more descriptions

* fixes

* fixes
2019-03-04 07:12:42 -08:00
larshp
73c3c787ba tadir, delete unused parameter io_folder_logic 2019-02-18 05:28:31 -08:00
Lars Hvam
cb4479b95b
Cleanup (#2361)
* pretty print

* move identical code outside IF

* remove space before .

* remove unreferenced variables

* remove unreferenced variables

* remove unreferenced variables

* fix pseudo comment

* remove unreferenced field symbols
2019-02-04 23:08:29 -08:00
Lars Hvam
e8b6b0020d
Add interface for ZCL_ABAPGIT_PROGRESS #2303 (#2316)
* interface for progress class

* adjust branch overview

* adjust git pack

* adjust diff page

* adjust objects class

* adjust activation class

* adjust repo online class

* adjust serialize class

few methods moved

* adjust tadir class
2019-01-23 06:28:54 +01:00
larshp
9270a58b62 cleanup unreference variables 2018-11-09 11:55:47 +01:00
larshp
7cdbbc92b6 remove some unreferenced variables 2018-11-08 16:35:08 +01:00
Lars Hvam
06616580eb
Naming conventions (#2059)
* fix naming conventions

* naming conventions
2018-11-07 12:50:20 +01:00
Domi Bigl
cf05295170 mark inactive objects in repo list #1943 (#2017)
* mark inactive objects in repo list

Inactive object are marked in the repo list
The sort order for changed files is not changed
unchanged inactive files come right after the changed files

* move acitve check to object interface

* add is_active for objects up to F

* add is_active for objects up to P

* add is_active for objects up to T

* add is_active for objects up to X

all core object implement (except SSFO) the standard active check via FM RS_INACTIVE_OBJECTS_WARNING now

* add is_active to plugins bridge - always active

* finish object interface implementation + objects

* add is_active for offline with object interface

* rename returning to RV_

* use returning for serialize

* cleanup, PP, UT
2018-10-31 15:54:57 +01:00
Frederik Hudák
1bb195b344 Removed the rest of endmethod/endclass comments 2018-10-18 07:27:27 +02:00
Lars Hvam
fa39fcd43f
Code inspector fixes (#1997)
* pretty print

* definitions to top of routine

* space before .

* omit parameter names where possible

* double space after if

* remove pseudo comments where possible
2018-10-12 07:56:27 +02:00
larshp
ba787d373e SICF: Decouple from core, #1941
Change calls to static SICF methods to dynamic, in order to be able to support systems which do not have SICF objects.
2018-09-27 15:03:15 +02:00
Christian Guenter
d82a02cd0e downport 2018-08-06 18:11:09 +02:00
larshp
f0fb0f0470 TADIR performance
TADIR performance #1756

All usages of TADIR aligned to use the same structure. 
DELFLAG added in the structure.
2 identical structure definitions deleted.

todo: test this PR works after abapmerge has run
2018-08-06 15:39:15 +02:00
Michael Käsemann
f9746cf199 Optimized ZCL_ABAPGIT_TADIR=>BUILD for better performance (#1725)
* Optimized ZCL_ABAPGIT_TADIR=>BUILD for better performance

- Using the optimizations in ZCL_ABAPGIT_FOLDER_LOGIC (PR #1723) and ZCL_ABAPGIT_SAP_PACKAGE (PR #1724) to optimize the TADIR build method, by first determining all relevant subpackages and then processing them in one go instead of having to recurse and read information from the DB separately.
- Note that the optimization can also be used without the changes in #1723 and #1724, but the effect will be less or worse and the coding requires adaptations.

* Fixes coding artifact of #1723

Removed a coding artifact that makes use of importing parameter ÌO_FOLDER_LOGIC`, which is no longer needed in the flat BUILD processing.

* Adapted for rework in #1724

After adapting PR #1724 to no longer use buffering, but instead select packages with a level-based selection, the buffering parameter in `ZCL_ABAPGIT_SAP_PACKAGE=>LIST_SUBPACKAGES` no longer exists and should not be used in this PR.

* Compressed IF/ELSE construct

* Removed whitespaces

* Fixed auto-merge issue

Removed a double variable declaration resulting from git auto-merge
2018-08-02 06:48:13 +02:00
Michael Käsemann
b3679f0868 Added Buffering to ZCL_ABAPGIT_FOLDER_LOGIC (#1723)
* Added Buffering to ZCL_ABAPGIT_FOLDER_LOGIC

- Converted ZCL_ABAPGIT_FOLDER_LOGIC=>PACKAGE_TO_PATH and ZCL_ABAPGIT_FOLDER_LOGIC=>PATH_TO_PACKAGE to instance methods, so they can work with buffered data when constructiing path information. This gives a performance advantage in repos with a depp tree structure and multiple leaf packages
- Adapted all calling code to use an instance of ZCL_ABAPGIT_FOLDER_LOGIC instead of the previously available static methods
- Where applicaple PACKAGE_TO_PATH and PATH_TO_PACKAGE were called in an instance of ZCL_ABAPGIT_FOLDER_LOGIC, which was instanced outside of a processing loop and thus profited from the introduced buffering

* Fixed errors

* Removed obsolete coding artifacts

Removed an obsolete parameter, that accidentally got merged into the code when building the pull request

* Forwarded FOLDER_LOGIC instance to recursed calls

Forwarded ZCL_ABAPGIT_FOLDER_LOGIC instance to subsequent BUILD calls to make use of buffering, until the optimizations in #1725 are in place.
2018-07-31 12:19:29 +02:00
Christian Guenter
6a9acb8a1b add injector class 2018-06-14 20:33:34 +02:00
Lars Hvam
b7fc27cfcf
Merge pull request #1497 from christianguenter2/issue_1493
Pass log object to user exit method change_tadir
2018-06-14 06:28:46 +02:00
Christian Guenter
a38d9feaff Pass log object to user exit method change_tadir 2018-06-13 19:15:53 +00:00
larshp
4e67e884de first dependency injection #1390
* extract public methods of ZCL_ABAPGIT_TADIR to new interface
* create factory ZCL_ABAPGIT_FACTORY
* refactor existing calls
2018-06-10 12:11:48 +00:00
Christian Guenter
c7179ed509 new exit: change_tadir 2018-06-10 10:59:00 +02:00
larshp
4657965117 fix dump 2018-05-10 06:17:25 +00:00
larshp
837b819e0c set devclass to blank if obj does not exist #1356 2018-05-08 07:04:12 +00:00
Lars Hvam
f17985b27e
Add option for "Only local objects", issue 1260 (#1268)
* refactor write protect and ignore subpackages

to local settings structure, this makes it a lot easier to exetend, plus adds structure

* delete method GET_MASTER_LANGUAGE

* add local settings to repo settings page

* add setting for only local objects #1260
2018-03-26 12:23:01 +02:00
Lars Hvam
18ea5d637c
lcl_repo (#1205)
* lcl_repo and more to global

* cleanup includes

* fix indentation
2018-02-15 15:10:13 +01:00