Commit Graph

51 Commits

Author SHA1 Message Date
Alexander Tsybulsky
c0a5fadfee
Refactor popup_to_select_from_list (#6089)
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-02-26 13:02:31 +01:00
Lars Hvam
a7c20da7a2
move ALV type defintion to intf popups (#6034)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-02-03 16:37:47 +01:00
Lars Hvam
773f2f7749
refactor, extract git definitions to git (#6029)
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2023-02-03 11:46:00 +01:00
Christian Günter
97f357f107
Set transport request in local repo settings or user exit (#5916) 2022-12-08 08:45:16 -05:00
Christian Günter
2b5211a778
Local settings: add F4 value help for check varint (#5910) 2022-12-02 11:15:30 -05:00
Christian Günter
c40406930a
add label F4 value help (#5891)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-11-30 12:29:40 -05:00
Marc Bernard
e1f78f733b
Remove unused branch popup (#5742)
`branch_popup_callback` and `POPUP_GET_VALUES_USER_BUTTONS` are not used anymore and leftovers from previous refactoring.
2022-09-07 09:47:44 -04:00
Marc Bernard
ddd7e47425
Refactor: Commit list popup (#5569)
* Refactor: Commit list popup

- Move popup for selecting a commit to `zcl_abapgit_popup`
- Allow to skip sorting of commits in `zcl_abapgit_git_commit` which often led to "too many commits" error (on GitHub you get the 300 most recent commits)

Popup will be used in `zcl_abapgit_gui_page_sett_remo` and `zcl_abapgit_gui_page_tags` (separate PR)

* Fix test classes

* Replace popup in remote settings

* Remove type

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-24 16:43:46 +02:00
Marc Bernard
0fea49b74c
Remove "Tag Overview" popup (#5463)
* Remove "Tag Overview" popup

- The "Tag > Overview" feature has been removed (because of bad performance and low value)
- The tag select popup has been refactored. The code has been moved to `zcl/if_abapgit_popups`. Only change is that the popup is now centered like the others.
- Therefore, class `zcl_abapgit_tag_popups` has been removed

* Update injectors

* Remove interface

* Secondary key
2022-04-25 07:28:07 +02:00
Marc Bernard
3742f2b0d6
UI: Transport popup (#5453) 2022-04-22 07:37:15 +02:00
Marc Bernard
ef502d8275
UI: Transport popup (#5452)
Add parameter for new logic
2022-04-06 15:55:48 +02:00
Lars Hvam
e5eb8d0d0a
icon, fix short dump (#5386)
#5385
2022-03-01 08:02:32 +01:00
Lars Hvam
4ac0183df2
unit testing updates (#5354) 2022-02-19 09:02:13 +01:00
Frank Müller
c932426b44
Pre Filter Backend and GUI Logic (#5227)
* Initial

* Adjustments

* Router

* Abaplint

* abaplint

* diff between eclipse and vscode

* Multiple Adjustments

* Split Backend And GUI Logic

* Multiple Adjustments

* No Unit Tests

* abaplint

* Rename ZCL_ABAPGIT_REPO_PRE_FILTER to ...TR

* Multiple Adjustments

* Refactor the OVP action links into a toolbar

* abaplint

* Replace BAPI_MSG by STRING

* Rename Pre Filter to Object Filter

* Rename Pre Filter also in abap_transpile.json

* restore from main

* Check if <ls_item>-li_class is filled in Toolbar

* Adj. toolbars and move TR Req to zif_abapgit_popup

* abaplint

* Move  ty_trrngtrkor_tt to zif_abapgit_definitions

* abaplint

* Move and rename filter menu entries

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: IBM <mbox-060-sap-extern-tbom@daimler.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-01-25 10:00:09 +01:00
Marc Bernard
c2e9e58319
Enhance "Force Pull" to become "Selective Pull" (#4733)
* Enhance "Force Pull" to become "Selective Pull"

With this PR you can now peform a selective pull. Yay!

- Changes "Force Pull" to show *all* changed objects in the usual "Overwrite Popup". This allows you to select individual objects to be pulled no matter if they were changed locally or remotely.
- Does *not* change the regular "Pull" logic

Closes #413, #4282

* Combine delete and overwrite popups

* Add icons to abaplint.json

* Change if to case

* Add icons to abaplint.json

* Enhance UTs

* show_icon

* Show icon

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-20 06:19:00 +02:00
Marc Bernard
d47c72f429
Remote Settings: Toolbar icon & clean-up (#4724)
* Remote Settings: Clean-up

Continue #4718

- Branch > Switch to PR: removed
- Advanced > Checkout commit: removed
- Advanced > Make Offline / Online: removed menu items and popups
- Advanced > Change Remote: removed menu item and page

* Remove ty_popups

* Remove checkout_commit

* Remove repo_view switch_to_pr

* Remove get_switched

* Add "Edit" icon also for offline

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-27 19:03:06 +02:00
Mike Pokraka
69ac4fd768
Change some masters to main %26 remove unused parameter (#4710)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-19 17:15:47 +02:00
g-back
1cbda2f2ae
Refactor "Export Package to ZIP" to HTML Form (#4652)
* refactor export package to zip to HTML form

* change literal to constant

* downport statement

* remove popup package_export

* reorder methods, unify whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-22 13:17:54 +01:00
Lars Hvam
11fd111572
move perf test option to new repo (#4645)
* move perf test option to new repo

Moving the performance test option to separate repository,
https://github.com/abapGit/performance-test

I guess this feature is not used very often, it will reduce the overall code size, and instead of refactoring these popups to HTML they can stay ALVs in the new repo

* fixes
2021-03-17 07:12:59 +01:00
g-back
72f34f5bdf
Refactor "Object to Files" to html form (#4623)
* start conversion from popup to html form

* replace magic with constants

* revert label

* restructure to gui component


modify export object logic

* adjust whitespace

* remove test_changed_by functionality

* remove popup_object

Co-authored-by: Goran Back <g.back@geringhoff.de>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-12 12:31:17 +01:00
Lars Hvam
d7f74bd49c
zif_abapgit_poups cleanup (#4608)
* zif_abapgit_poups cleanup

delete method POPUP_TO_INFORM

* delete method POPUP_PROXY_BYPASS
2021-03-07 12:15:26 +01:00
Marc Bernard
978b7a4a57
Terminology: Inclusive Language - Part 4 (#4432)
* Terminology: Inclusive Language - Part 4

Continue change of terminology (#4043)

* Service

* Language

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-21 17:18:03 +01:00
Lars Hvam
e35df57646
Change TY_SVAL_TT location (#4155) 2020-11-10 14:21:42 +01:00
mariusraht2
9ac7630711
ZABAPGIT_FORMS: Remove obsolete form package_popup and related callback handler (#4029)
* ZABAPGIT_FORMS: Remove obsolete methods

- Remove branch_popup
- Remove package_popup

* Readd branch_popup

* Readd branch_popup

* Remove related callback handler

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-16 09:11:18 +02:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
Marc Bernard
25774396e6
Dialogs: add offline repo HTML form (#3960)
* Dialogs: add offline repo HTML form

* Dialogs: add offline repo HTML form

* Dialogs: add offline repo HTML form

* Lint

* Lint

* Chaining

* Set required attribute

* Check for empty display name

* Change validation

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-03 10:18:45 +02:00
Fabian Lupa
dc5725b49c
Add performance test (#3847)
* Add performance test

* Fix some linter errors

* Refactor free selections to reduce method length

* Performance test add title to result ALV

* Attempt downport

* Downport

* Pretty Printer VS abaplint

* Undo more changes done by pretty printer

* Adjust performance popup title and ALV layout

* Move free sel dialog to global for abapmerge

* Move some type definitions for abapmerge

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-08 10:39:20 +02:00
Alexander Tsybulsky
a4e6c87985
Switching to PRs (#3695)
* string map: public entries (read only)

* port http agent

* draft wip

* drafting

* fix SSL

* port ajson

* integrate ajson and http_agent

* agent global headers

* github enumerator

* update ajson

* draft wip

* enumerator factory

* http_agent via factory

* proxy

* repo->switch_origin draft

* refactor enum factory

* Revert "refactor enum factory"

This reverts commit bcfef40b38991adfe5f73677919db6bd0c652f7c.

* page wiring draft

* scripts draft

* "let it work!"

* repo setings page draft

* linter

* linter

* linter

* linter

* linter

* better settings page

* finetune page

* cleanups

* change hotkey

* fix ajson_error

* Update src/zcl_abapgit_repo_online.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* abaplint nesting 6

* remove description

* back to good old popups

* linter

* move commands to branches dropdown

* auth helpers

* move json to separate package

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-27 07:47:27 +02:00
Marc Bernard
af5b898a37
Refactor branch constants (#3784)
* Branch constants

* Refactor branch constants

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-24 11:25:46 +02:00
Lars Hvam
837d45bc83
fix whitespace (#3690) 2020-07-31 06:22:01 +02:00
Frederik Hudák
a1ecc65ecc
Improved branching messages (#3685)
* Improvements to branch messages

* Names without refs/heads
2020-07-31 06:15:56 +02:00
Alexander Tsybulsky
f5dfd328f5
Dialogs: add online repo HTML form (#3533)
* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks
2020-07-01 08:16:52 +02:00
Frederik Hudák
657405433d
Add master language setting to new repo popups (#3409)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-26 06:29:31 +02:00
Lars Hvam
5a21bbba7d
remove self interface references (#3412) 2020-05-24 15:28:25 +02:00
Frederik Hudák
3335317278
Remove page playground (#3375)
* Remove page playground

* Remove constant
2020-05-20 18:28:03 +02:00
mariusraht2
b91043a270
Refactor Popup (#3310)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Delete pull.yml

* Refactored popup logic

Related to #3040

Refactoring of popup logic/calling to be able to reuse it as commit list.

* Removed reset flag

Removed reset flag cause it doesn't belong to this PR (will be readded later)

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-04 08:36:24 +02:00
Daniel Wegner
eb10fae8ef
Proxy bypass (#3221)
* add proxy bypass option in settings

* add proxy bypass popup and persist settings

* add proxy bypass to proxy config class

* Fix Proxy Bypass Button HTML

* Fix indentation

* Implement Method popup_proxy_bypass

* Fix behaviour in case of empty range tab

* Fix behaviour in case of empty range tab 2
2020-03-02 15:30:23 +01:00
Alexander Tsybulsky
5c10415b28 possibility to export pkg with master lang only (#2966) 2019-10-13 23:02:42 -07:00
Lars Hvam
1dbd4d1912
Refactoring types (#2785)
* align use less different types

* refactor

* updates
2019-07-15 09:33:37 -07:00
Alexander Tsybulsky
f39aab3244 fix display name in attache/change remote 2019-04-08 07:21:09 -07:00
Alexander Tsybulsky
ecc1c85ee7 GUI subclass zcx_abapgit_cancel from zcx_abapgit_exception (#2576)
* subclass zcx_abapgit_cancel from zcx_abapgit_excep

* upper case
2019-03-26 23:51:38 -07:00
Jakub Filak
77cea9c92a New repo with Folder Logic and Ignore Sub-packages params (#2561)
* repo: do not validate sub-packages when ignored

In our landscape, we often need to version a package which has
sub-packages and those sub-packages have own repositories - the super
package provides framework and the sub-packages provides production
functionality.

When adding a new repository for these "framework" super-packages,
we need want to configure "Ignore sub-packages" because they are
already versioned in standalone repositories.

We also need to turn of the sub-package repo package check which is done
by this patch.

Dependency of #2395

* repo: allow creating with folder logic and ignore package

I need to enable users to add a new online repo with ignored
sub-packages and PREFIX folder logic because we often deal with
framework + implementations packages hierarchies.

Dependency of #2395

* repo: add folder logic and ign. sub.pkg to the new repo popup

This patch adds the parameters Folder logic and Ignore subpackages to
the new online repo popup to help us deal with old package which do not
follow the prefix approach for subpackages and to allow us to version
superpackages (which are shared by many developers) in separate
repositories.

I am not sure how to add a check-box to the popup window. I think I need
to find the right table with the righ column of the type char(1).

Closes #2395
2019-03-22 05:50:46 -07:00
Christian Guenter
f73e18d587 Online repo "display name" to overrule default name 2019-02-25 07:20:01 -08:00
Christian Guenter
ad7809e4f2 Offline repo: Folder logic in create popup 2019-01-28 00:57:50 -08:00
Lars Hvam
3f494f091f
Use built-in types (#2306)
* remove uses of DTEL BOOLEAN

* remove uses of DTEL BOOLE_D

* remove uses of DTEL FLAG

* remove uses of DTEL SAP_BOOL

* remove uses of DTEL XFELD

* Update zcl_abapgit_popups.clas.abap
2019-01-20 07:59:24 +01:00
Domi Bigl
246b943b87 hide current branch and HEAD in delete popup #1908 (#1961)
* hide current branch and HEAD in delete popup

* refactoring and cleanup

* hide also HEAD symref

* throw  branch delete refused
2018-09-29 08:53:55 +02:00
Johannes Konings
c3691622ed fix some naming conventions
https://github.com/larshp/abapGit/issues/1132
2018-08-16 06:32:19 +02:00
Johannes Konings
8e556701c3 New online popup, fix descriptions #1752
https://github.com/larshp/abapGit/issues/1752
2018-08-06 20:06:17 +02:00
larshp
f0fb0f0470 TADIR performance
TADIR performance #1756

All usages of TADIR aligned to use the same structure. 
DELFLAG added in the structure.
2 identical structure definitions deleted.

todo: test this PR works after abapmerge has run
2018-08-06 15:39:15 +02:00
christianguenter2
ea798193d0 Block commit/push if code inspection has errors
- new local setting to set check variant
- new local setting to block pull if code inspector check fails
- check is executed before staging
- new page to display code inspector results
2018-06-28 13:21:29 +02:00