Commit Graph

3408 Commits

Author SHA1 Message Date
Marc Bernard
b331de6bc7
Naming of class constants (#4945)
* Naming of class constants

This is in preparation of enforcing a naming convention for constants in classes/interfaces. At the end, the following lint rule shall be set:

```json
    "class_attribute_names": {
      "constants": "^C_.+$",
...
    },
```

After this, the only remaining constants not following this rule are in `zcl_abapgit_version`.

* Update zif_abapgit_dot_abapgit.intf.abap

* Update zcl_abapgit_gui_chunk_lib.clas.abap

* Update zcl_abapgit_gui_router.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-14 16:47:48 +02:00
Marc Bernard
68c4f10e02
SRFC: Improvements (#4912)
* SRFC: Improvements

- Check if `SRFC` is supported in `constructor`. This will ensure proper error handling (closes #4899). Note: Using the constructor is how it should be checked for other object types as well. 
- Added `changed_by` logic
- Simplified catch code

* SRFC: Improvements

* SRFC: Improvements

* Update message

* Raise

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-12 10:09:33 -04:00
Marc Bernard
a94d06d493
DDLS: Fix dump in lower releases (#4915)
* DDLS: Fix dump in lower releases

- Add requirements check to constructor
- Prevent delete call in case object does not exist

Ref #4899

* Update message

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-12 10:07:41 -04:00
Marc Bernard
61e629cd1f
Improvements for Objects Class (#4944)
* Improvements for Objects Class

This introduces a new `is_type_supported` method for `zcl_abapgit_objects` which is about 30x faster than the current `is_supported` method.

`is_type_supported` is used in the other methods like `changed_by` and `exists` to avoid instanciating or calling the object class unnecessarily. It won't be necessary to check for support before using these methods which will alllow simplifying the calling programs (separate PR).

There are also some new test cases for `is_type_supported` and for serializing a commom interface.

* No user id for unsupported objects

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-12 07:33:41 +02:00
github-actions[bot]
c2d96c0327
ajson, Automatic Update (#4947)
* [create-pull-request] automated change

* upd

Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-12 07:31:03 +02:00
Marc Bernard
cd5d43977a
Filter code inspection/syntax check (#4946)
* Filter code inspection/syntax check

In case of generated maintenance screens, the code inspection/syntax check include findings in SAP code (`LSVIM*` includes). This change removes those findings.

* Update zcl_abapgit_code_inspector.clas.abap
2021-09-12 07:12:53 +02:00
Lars Hvam
ab701df97e
SPPF support (#4938)
* SPPF support

#4839

* update docs

* pretty print

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-09-10 11:01:02 -04:00
Lars Hvam
e7e8af832e
align package descripions (#4939)
prefix all package descriptions with "abapGit - "
2021-09-10 10:58:36 -04:00
Lars Hvam
3b67d90e76
5 additional unit tests running (#4935) 2021-09-10 07:46:05 +02:00
Marc Bernard
bbfc90420a
Dialogs: Clarify comment on password popup (#4932)
* Dialogs: Clarify comment on password popup

* Update zabapgit_password_dialog.prog.abap
2021-09-02 10:34:32 -04:00
Marc Bernard
08f90dd1f7
Fix "Cannot switch origin twice" in remote settings (#4921)
Closes #4919

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@gmail.com>
2021-08-31 07:31:12 +02:00
Lars Hvam
2bdb06519c
check exists() before changed_by() (#4925)
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-08-31 07:29:10 +02:00
Lars Hvam
54036c11dd
workaround changed_by (#4924)
* workaround changed_by

* ugh
2021-08-30 10:46:19 +02:00
github-actions[bot]
b028446d57
ajson, Automatic Update (#4922)
* [create-pull-request] automated change

* Update zcl_abapgit_ajson.clas.testclasses.abap

* Update zcl_abapgit_ajson.clas.testclasses.abap

* skip unit test parse_error

Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-30 07:35:00 +02:00
Jacek W
5f6b5a73c8
Add "Last changed by" to repo page (#4920)
* Add "Last changed by" to repo page

Proposition for #3267

* Add "Last changed by" to repo page

For #3267
- add "Changed by" also for local items

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-30 07:26:02 +02:00
Marc Bernard
de8b3e4fb2
JavaGUI: Workaround for trailing null values (#4903)
SAP GUI for Java 7.70 has trailing null values in postdata (if data >256 characters). This is a bug that SAP will have to fix.

As a workaround, abapGit will strip the trailing null values.  The workaround shall be removed 2022-12-31 latest.

Closes #4832

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-29 13:05:05 +02:00
Jacek W
549fc9a2ef
Add icon link for changing remote repo on the list (#4907)
* Add icon link for changing remote repo on the list

Proposition for #4737

* Add icon link for changing remote repo on the list

- corrections for PR #4907
- fixed syntax

* Update zcl_abapgit_gui_page_repo_over.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-08-29 12:54:03 +02:00
Marc Bernard
e86e2267c0
Improve message if object type is not supported (#4913)
Minor text change
2021-08-27 14:53:20 -04:00
Marc Bernard
6b81d7d958
Improve message for subpackage errors (#4911)
Clarify error and resolution options in case subpackage already exists in system but is not included in pack hierarchy of repo root package.

Closes #4904
2021-08-27 12:58:12 -04:00
Marc Bernard
f2a801ad1a
Dialogs: Add comment to password popup (#4910)
Temporarily, adding a comment to the password popup regarding Github login. 

To be removed end of 2021

https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/

Closes #4909
2021-08-27 12:46:28 -04:00
Lars Hvam
40fa13278d
xml input: add basic unit test case (#4894) 2021-08-25 08:11:02 +02:00
Lars Hvam
7556bf6951
1.109.0 (#4896) 2021-08-16 08:32:43 +02:00
github-actions[bot]
41c9e0880b
ajson, Automatic Update (#4895) 2021-08-16 08:20:05 +02:00
Lars Hvam
329fd9dc0e
interface and factory for ZCL_ABAPGIT_PERSIST_SETTINGS (#4882)
the old get_instance() method in ZCL_ABAPGIT_PERSIST_SETTINGS has been moved to a method in zcl_abapgit_persist_factory, plus interface added. Added to persist injector
2021-08-03 15:13:16 +02:00
Lars Hvam
e6bac818cf
git transport: add unit test for parse() (#4889) 2021-08-03 10:33:24 +02:00
Lars Hvam
ddcb538ccd
get_null(), fix syntax error (#4890) 2021-08-03 10:27:24 +02:00
Lars Hvam
19304ad924
change local hostname determination (#4885)
* change local hostname determination

* fix
2021-08-03 06:49:45 +02:00
Lars Hvam
2bde0ce55a
simplify get_null() + git branch list: add unit test (#4886)
add unit test which parses the response from hex, ie. containing a real null value

simplify get_null() method, it only returns 1 character, but 2 characters are calculated
2021-08-03 06:47:16 +02:00
github-actions[bot]
9d1e14a90d
ajson, Automatic Update (#4888)
* [create-pull-request] automated change

* Update zcl_abapgit_ajson.clas.locals_imp.abap

* Update zcl_abapgit_ajson.clas.locals_imp.abap

* Update ajson_mirror.yaml

* skip parse_bare_values

Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-02 06:57:22 +02:00
Lars Hvam
da310e0137
zcl_abapgit_exit: add IF gi_exit IS NOT INITIAL. (#4884)
* zcl_abapgit_exit: add IF gi_exit IS NOT INITIAL.

* set description
2021-07-31 11:28:00 +02:00
Lars Hvam
e075b951a4
align use of unescape_url() (#4878) 2021-07-29 16:49:38 +02:00
Lars Hvam
8068e8fb0e
git transport: move constants to method (#4877)
the constants are only used locally in the method, the definitions have been moved to the method instead of the private section of the class
2021-07-22 06:56:40 +02:00
Lars Hvam
910bf46ae4
XML unit test, follow up (#4876) 2021-07-21 11:58:40 +02:00
Lars Hvam
9675ad6007
Replace use of type W3URL with string (#4874)
* replace W3URL with string

* fixes

* ASSERT strlen( iv_url ) <= 250.
2021-07-21 11:41:56 +02:00
Lars Hvam
e74c68e204
Decouple XML from UI factory (#4873) 2021-07-21 11:39:47 +02:00
Christian Günter
553d1f2319
LinkHints: trigger onclick event for checkboxes (#4870)
* LinkHints: trigger onclick event for checkboxes

* refactor

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-20 16:33:34 +02:00
Marc Bernard
ab3f24fe06
BRF+ System Application (#4856)
* BRF+ System Application 

- Clear user/time/system-specific fields
- Fix deletion of object
- Remove unnecessary "exists check"
- Updated test case https://github.com/abapGit-tests/FDT0

* Lint

* Lint

* WEBI: Improve error handling

Pass messages to log

* Reverse WEBI

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-17 10:26:47 +02:00
victorizbitskiy
73496a2755
Refactor: Exception handling #4852 (#4869)
https://github.com/abapGit/abapGit/issues/4852
2021-07-13 09:13:25 +02:00
Marc Bernard
6ff7074aec
Auto creation of package during new online (#4814)
* Auto creation of package during new online 

If you create a new online repository and the repo does not contain any SAP package, then abapGit will prompt you for the package attributes and create the package for you. This is, for example, the case when you use an newly created online repo as a starting point. 

If the repo does contain a package, then the package will be created automatically when you pull from the repo (as described in [docs](https://docs.abapgit.org/ref-packages.html)).

Closes #4538

* Update docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-07-09 15:28:55 +02:00
Christian Günter
bffe75958c
SMTG: Implement changed_by (#4867)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-09 15:23:58 +02:00
Frederik Hudák
2cfb2790cf
Open repo - disable enter if command field is open (#4868) 2021-07-08 09:31:57 +02:00
Marc Bernard
39512676ca
WEBI: Improve error handling (#4864) 2021-07-06 17:36:40 +02:00
Marc Bernard
1d98688be5
Dialogs: Set autofocus on first form element (#4853)
* Dialogs: Set autofocus on first form element

Improves usability. 

Closes #4816

* Autofocus for commit page

- Works in case JS is not an option

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-06 11:41:34 +02:00
Frederik Hudák
60a82331b5
Add more keyboard shortcuts for main page (#4846)
* Add more shortcuts for main page

* Update zabapgit_css_common.w3mi.data.css

* Update zcl_abapgit_gui_router.clas.abap

* Change keyboard shortcuts

* fix js

* fix js

* deindent

* indentation

* one more

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-07-06 11:32:27 +02:00
Marc Bernard
2e7d642786
ECVO: Fix "empty xml" error (#4863)
* ECVO: Fix "empty xml" error

Fixes regression from #3991

* Upload
2021-07-06 11:11:27 +02:00
Marc Bernard
7c32f824df
TABL: Clear DB Indexname (#4850)
Fixes diffs because platform specific DB index names. 

Updated test repo: https://github.com/abapGit-tests/TABL_with_index

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-01 14:15:32 +02:00
github-actions[bot]
a8eb86b747
[create-pull-request] automated change (#4855)
Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-01 14:13:47 +02:00
Sascha Wächter
30615e848e
Started with BRF+ serialization and fixed some errors from the first attempt (#4797)
* Fixed Version BRF+ Integration

* BRF+ serialization

* Fixed obsolete parameters and wrong boolean type

* Fixed some errors and filtered ComponentReleeases

ComponentReleeases in XML Export and Import of BRF+ API can be omitted and works also the same. Next try if I could delete the useless metadata (User, System, etc...) or must leave them empty and fill them manually before deserialization.

* Some little changes

Removed Parameter iv_marked_option for older releases and removed method wb_request_choice. Changed to transport automatically.
Aligned some parameters.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-06-28 13:29:56 +02:00
Marc Bernard
3defa2c165
WDCA: Clear parameter descriptions (#4851)
Fixes diffs because of parameters that are different between releases (or even SPs) or languages
2021-06-22 16:47:45 +02:00
Mike Pokraka
b1cc6a2912
Refactor method in FM call for 702 (#4848) 2021-06-15 09:43:04 +02:00
Frederik Hudák
f892c9b4dc
fix unclosed tr tag (#4845)
* fix unclosed tr tag

fixes mistake from #4771
2021-06-14 18:23:59 +02:00
Frederik Hudák
d4cbf7059e
Repo overview - rework action buttons + cosmetic changes (#4771)
* Repo overview - cosmetic changes

* extract logic to method

* Update src/ui/zcl_abapgit_gui_page_repo_over.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* fix if in if

* unshorten remote, move package, improve wrapping

* Add max width for columns

* Mostly working now

* add prefixes

* Remove checkbox, move package where it was

* Keyboard navigation

< > to navigate in list (arrow keys don't seem to trigger), enter to open selected

* Ellipsis for repo url, use css variable

* Fix css, js persistence

* Fix invalid function name

* add back !important to override hover color

* abaplint

* Don't use const in js

* more eslint

* Remove unused field symbol

* eslint

* Bring back repo lock icon, styling improvements

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-06-14 14:44:38 +02:00
Christian Günter
6f8e3f45fa
Set focus: fix code inspector warning + improve error handling (#4843)
* Set Focus: fix code inspector warning 

+ improve error handling

* fix method signature
2021-06-14 10:58:01 +02:00
Mike Pokraka
a9c40ea972
Remove experimental status from PDTS (#4831)
* Remove experimental status of PDTS

* Remove experimental status from PDTS
2021-06-10 10:03:17 +02:00
Marc Bernard
f857194037
Focus HTML control on abapGit startup (#4817)
* Focus HTML control on abapGit startup 

`cl_gui_control=>set_focus` must be called during PBO. Maybe there's a nicer way to pass the HTML control to the PBO.

* Move to output form

* Set focus

* Add autofocus
2021-06-09 17:24:59 +02:00
Lars Hvam
096aded586
LANGU rollbacks (#4829)
* LANGU rollbacks

#4828

* Update abaplint.json
2021-06-08 16:42:20 +02:00
Lars Hvam
753c2f5d21
Do not read TADIR-KORRNUM (#4825)
KORRNUM is misused for calculating the serialization sequence
2021-06-07 14:49:11 +02:00
Marc Bernard
38c453eb8b
FTGL: Update transport when deleting (#4821)
Add object to transport when deleting it.
2021-06-06 09:43:05 +02:00
Marc Bernard
887e7dd332
Offline repo: "Compare via RFC" feature (#4789)
* Offline repo: "Import via RFC" feature

Adds option to **offline** repositories for importing a repo via an RFC connection from another SAP system. It's a shortcut for doing "Export ZIP" in one system, and "Import ZIP" in the other.

Closes #4784

Pre-requisite: abapGit develop version (with this change) is installed on remote SAP system. 

Note: The general recommendation is to use **online** repositories and a git server for comparing and synchronizing systems.

* Lint

* Create guide-import-rfc.md

* Langu

* Langu

* Write-protect only

* Compare

* Compare

* Compare

* Compare

* Git

* Update docs/guide-import-rfc.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-06-04 15:09:09 +02:00
Marc Bernard
e2a156a326
Replace deprecated LANGU type (#4815)
* Replace deprecated LANGU type

Replace with `sy-langu` and update abaplint rule

* Replace langu

* Add langu to void types

* Replace table of langu
2021-06-02 08:04:05 +02:00
Marc Bernard
4cdb04c2c7
SCVI: Replace generic with native check (#4808)
* SCVI: Replace generic with native check

Replaces generic exist check with native function call

* Variable

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-06-01 13:05:49 +02:00
Marc Bernard
ac8bde9f6c
Fix use of sy-langu in object serializers (#4807)
* Fix use of sy-langu in object serializers

- Replace sy-langu variable with mv_language
- Replace sy-langu type with langu (makes it easier to spot sy-langu)
- Enhance generic serializer to use mv_language
- Add unit tests to generic serializer 
- Adjust and simplify serializers that are based on generic class

Closes #2080

* Update scvi+ueno

* Revert scvi

* Langu

* Langu

* Langu

* Langu

* Langu

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-06-01 13:02:42 +02:00
Christian Günter
c332473ec0
Enable input fields (submit and text) for link hints (#4802)
* Enable input fields for link hints

* add Link Hints for all INPUTs and TEXTAREAs

* disable LinkHints when number input is active
2021-06-01 12:59:51 +02:00
Christian Günter
53dec3d2e8
Improve secondary key access (#4801) 2021-05-31 07:47:30 +02:00
Marc Bernard
ad244abacd
Terminology: Inclusive Language - Part 6 (#4791)
* Terminology: Inclusive Language - Part 6

Change remaining variables and switch setting to main_language. 

Finally closes #4043

* Add todo

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-28 13:15:00 +02:00
Christian Günter
9c8e566e58
git transport: fix check report status for GitLab and Bitbucket (#4796) 2021-05-28 06:14:28 +02:00
Christian Günter
f97320f1dc
Create branch: Add existence check (#4794)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-28 06:09:27 +02:00
Marc Bernard
5f4eb56071
DEVC: Application component for local packages (#4790)
For local packages, the application component is now stored in AG persistence. This will avoid the diff, if transportable packages are pulled into local packages.

Closes #1880
2021-05-28 05:45:17 +02:00
Christian Günter
1fa51e7c0a
Checkout commit: Improve error message (#4793)
Checkout commit: Improve error message.
Checking out commits is currently limited to branches with less than 99 commits. If this limit is reached a message appears saying 'No commits are available in this branch.'.
After this commit is applied the error message is 'Cannot find initial commit. Too many commits. Action not possible.'.
2021-05-27 14:54:56 +02:00
Juraj Adásek
f710d368e5
Regenerate profile SAP_ALL (#4792)
* Regenerate profile SAP_ALL

* Regenerate profile SAP_ALL after SUSO delete

Co-authored-by: Juraj Adasek <juraj.adasek@sap.com>
2021-05-27 06:05:22 +02:00
github-actions[bot]
a862224c00
[create-pull-request] automated change (#4787)
Co-authored-by: larshp <larshp@users.noreply.github.com>
2021-05-24 12:55:50 +02:00
abap-weasel
30674e1e69
Release serialization resources (fixes #4774) (#4775)
* Release serialization resources (fixes #4774) 

Release serialization resources to prevent dump #4774 for export of large packages

* Free files after parallelization

* transfer files one by one

* Update src/objects/core/zcl_abapgit_serialize.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* fix lint, missing fs declaration

* index access on delete lt_found

* Update src/objects/core/zcl_abapgit_serialize.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* cleanup: index variable not required

* rollback to original APPEND LINES

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-20 11:33:41 +02:00
Marc Bernard
946180abda
Enhanced error handling for git transport protocol (#4778)
Git report status is now properly parsed for unpack and command status. Also includes UTs.

Closes #4776

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-20 11:31:48 +02:00
Marc Bernard
e42e502d7d
Add support pack to debug info (#4779)
* Add support pack to debug info

* Add get_basis_release

* Lint

* Structure

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-20 11:30:05 +02:00
Marc Bernard
85cdff8de7
Fix menu hover background (#4768)
* Fix menu hover background

In default theme, the background color when hovering over menu items was bearly visible in HTML GUI and not visible at all in Win GUI.

The fix explicitly set the background color so both GUIs look the same.

* Keep subitem highlight

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-20 07:25:11 +02:00
Marc Bernard
c2e9e58319
Enhance "Force Pull" to become "Selective Pull" (#4733)
* Enhance "Force Pull" to become "Selective Pull"

With this PR you can now peform a selective pull. Yay!

- Changes "Force Pull" to show *all* changed objects in the usual "Overwrite Popup". This allows you to select individual objects to be pulled no matter if they were changed locally or remotely.
- Does *not* change the regular "Pull" logic

Closes #413, #4282

* Combine delete and overwrite popups

* Add icons to abaplint.json

* Change if to case

* Add icons to abaplint.json

* Enhance UTs

* show_icon

* Show icon

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-20 06:19:00 +02:00
Marc Bernard
7edc45a7fe
Enhance "Debug Info" (#4767)
- Differentiate between Developer and Standalone versions
- Add link to contribution guidelines
- Add listing of user exits with implementation status (based on include for standalone, class for developer version)
- Add feature to save debug info output as HTML page which can be used for attaching to Github issues

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-14 12:06:25 +02:00
Marc Bernard
71006ab149
Avoid duplicates in data serialize (#4763)
Serialize data to internal table with unique key corresponding to the database table

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-14 11:12:25 +02:00
Marc Bernard
0d993d4854
Add user exit for event handler (#4766)
* Add user exit for event handler

Closes #4722

* Remove debuginfo change

* Update docs

* Update docs

* fix typo

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-14 11:01:53 +02:00
Marc Bernard
4d9d7fb37e
Remove adjust_namespaces (#4760)
* Remove adjust_namespace

Method is obsolete since namespace of object is already adjusted in `zcl_abapgit_filename_logic=>file_to_object`

* Remove adjust_namespace

* Remove bracket

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-14 10:55:46 +02:00
Marc Bernard
ce677e449f
INTF: Fix check if interface exists (#4759)
As mentioned in #4673, the existence check for interfaces is not correct and actually checking for classes. The PR will correct the check.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-14 10:28:35 +02:00
Marc Bernard
7376c7bb6e
Adjust case of menu item (#4764)
Change to title case
2021-05-12 18:26:57 +02:00
Marc Bernard
d19b431287
APACK use constant (#4765)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-12 18:18:47 +02:00
Lars Hvam
a884259f6d
use fewer DDIC types (#4757) 2021-05-12 18:16:31 +02:00
Jacek W
8afae74228
Add "Only my changes" option (#4748)
New option "Only my changes" in "Filter" menu in "Diff" page for showing only changes for the current user.
2021-05-12 18:13:26 +02:00
Frederik Hudák
50bd3941e0
Change default width of abapgit (#4751)
* Change default width of abapgit

* Center settings forms
2021-05-12 18:10:33 +02:00
Lars Hvam
212fcb779e
LOG: remove RC field (#4746)
closes #4634
2021-05-09 10:58:31 +02:00
Edo von Glan
8fc1ab45f0
Replace GET_R3TR_OBJECT_FROM_LIMU_OBJ (#4749)
* Replace GET_R3TR_OBJECT_FROM_LIMU_OBJ, fixes #4715

Replaced with TR_CHECK_TYPE. Only tested locally (with a copy of the method in a separate program), not in full ABAPGit context.

* forgot the additional DATA declarations

* Ignore deleted objects

as requested by Marc Bernard

* remove whitespace at end

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-09 10:54:26 +02:00
Lars Hvam
10a89c160b
1.108.0 (#4758)
* 1.108.0

* update changelog
2021-05-09 10:52:04 +02:00
Marc Bernard
9f94f339aa
INTF: Refactor to fix "permission error" (#4673)
* INTF: Refactor to fix "permission error"

Implements interface deserializer the same way as the class deserializer.

Closes #4672

* Remove types

* Class exists

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-09 10:40:33 +02:00
ThomasPloski
1781290065
Adaptation of SRVD object handler (#4529)
* based on the lastest master

* pretty printer

* fix inline declaration fragments

* fixing method chaining

* Fix: Use boolc instead of IF, negate expression

* remove descriptions

* pretty printer

* empty line in method calls

* Fix: Statement does not exist in ABAPv702

* fix exceptions

* fix Indentation problem

* fix: Statement does not exist in ABAPv702(or a par

* mitigate usage of not existing objects in 702

* remove not existing objects for 702

* indentation issues

* next

* next

* Indentation issues

* next

* fix

* Fix: The EXPORTING keyword can be omitted

* change to constant mc_source_file

* Update zcl_abapgit_object_srvd.clas.abap

* changes regarding mbtools' feedback

* according to mbtools' feedback

* Update zcl_abapgit_object_srvd.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-05-09 10:38:47 +02:00
Marc Bernard
33227e8f4b
Remove obsolete unit tests for settings (#4753)
Closes #4709
2021-05-06 14:30:50 +02:00
Marc Bernard
850d51408a
Fix saving proxy bypass (#4752)
Closes #4728
2021-05-06 06:36:58 +02:00
Lars Hvam
0344f7e360
add write protected icon in overview (#4745)
* add write protected icon in overview

closes #4528

* move to after name
2021-05-05 15:52:36 +02:00
Lars Hvam
5e789531e0
Remove return code for parallel serializer (#4747)
closes #4586
2021-05-05 07:32:38 +02:00
Frederik Hudák
1b74a3f9a8
Enable switching branches from stage screen (#4744)
* Enable switching branches from stage screen

* Update zcl_abapgit_gui_page_stage.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-03 15:56:14 +02:00
Marc Bernard
c9bd8443ee
Add hover hightlight to repo toolbar (#4732)
Highlights links in repo toolbar on hover

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-03 14:47:38 +02:00
Mike Pokraka
788d649feb
Limit size of branch overview (#4726)
* Add support for partial logs (WIP)

* Still trying to handle multiple branch origins

* Error message for too many commits

* Remove PDXX

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-03 14:42:34 +02:00
Lars Hvam
7b336a4a71
cleanup unused local variables (#4739) 2021-05-01 09:51:05 +02:00
fdupret
10b6c550e2
Fix wrong variable used (#4741) 2021-05-01 09:46:14 +02:00
Marc Bernard
1150390bdd
Settings: Adjust background (#4731)
Changes background to secondary color (same as repo top bar)
2021-04-29 17:20:04 +02:00
Marc Bernard
d47c72f429
Remote Settings: Toolbar icon & clean-up (#4724)
* Remote Settings: Clean-up

Continue #4718

- Branch > Switch to PR: removed
- Advanced > Checkout commit: removed
- Advanced > Make Offline / Online: removed menu items and popups
- Advanced > Change Remote: removed menu item and page

* Remove ty_popups

* Remove checkout_commit

* Remove repo_view switch_to_pr

* Remove get_switched

* Add "Edit" icon also for offline

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-27 19:03:06 +02:00
Marc Bernard
0feff94a32
Add icons and update icon docs (#4721)
* Update icon docs

Help, Utilities, Edit, Info, In Progress (Github annotation status), Failure (Github annotation status)

* Add icons

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-27 18:58:00 +02:00
Mike Pokraka
58956a1059
Refactor PDTS into PDXX superclass (#4717)
* Add superclass

* Refactor into PDXX superclass

* Unit tests respect experimental indicator

* Lint

* Lint

* Lint+CHECK misbehaving

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-27 18:53:26 +02:00
Lars Hvam
1b9674e620
git transport: error on empty git reply (#4714) 2021-04-25 10:01:10 +02:00
Marc Bernard
a225e05950
New "Remote" tab in repo settings (#4705)
* New "Switch" tab in repo settings

This PR adds a new tab to the repo settings which combines all options for switching the repository to a different source:

- Switch between "Online" and "Offline"
- Switch to Branch, Tag, Commit, or Pull Request

Note 1: Value help for URL history has not been implemented yet.

Note 2: None of the existing related menu items have been removed yet.

* Clean-up

* Clean-up

* Clean-up

* Clean-up

* Clean-up

* Change to "Remote"

- rename class 
- add "autosave" for on/offline switch
- change "Switch" to "Remote"

* Update on/offline switch

* Update on/offline switch

* Update zcl_abapgit_gui_page_sett_remo.clas.abap

* Grammar

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-25 09:59:00 +02:00
Frederik Hudák
b1c76b9852
DCLS: implement changed_by (#4712) 2021-04-21 08:53:29 +02:00
Mike Pokraka
69ac4fd768
Change some masters to main %26 remove unused parameter (#4710)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-19 17:15:47 +02:00
github-actions[bot]
f264f33b7e
ajson, Automatic Update (#4708)
* [create-pull-request] automated change

* Update ajson_mirror.yaml

Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-18 11:36:07 +02:00
Mike Pokraka
dd6becccbe
Accept remote without HEAD (#4706)
* Accept remote without HEAD

* Update src/git/zcl_abapgit_git_branch_list.clas.testclasses.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-18 11:18:33 +02:00
Marc Bernard
41b301cc11
Fix dump in case of package name conflicts (#4704)
Replaces assert with error message (#4620)
2021-04-16 10:05:14 +02:00
Marc Bernard
f55cdcc253
Refactor filename logic (#4697)
Combines `zcl_abapgit_file_status=>identify_object` and `zcl_abapgit_object_files=>filename` into new class `zcl_abapgit_filename_logic`. This class provides `file_to_object` and `object_to_file` conversion logic similar to what `zcl_abapgit_folder_logic` does for packages and git folders. 

Also includes unit tests which were missing for the old methods.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-15 16:14:53 +02:00
Marc Bernard
f18a8ee82b
Terminology: Inclusive Language - Part 5 (#4702)
* Terminology: Inclusive Language - Part 5

Change of terminology (#4043)

- Replace `get_master_language` with `get_main_language` and remove it

* File Status

* Jump

* Language

* Main language

* Main language
2021-04-15 08:32:09 +02:00
g-back
4c6d407156
Export Package to Files: Fix for Namespaced Packages (#4701)
* escape package only for file name


make package parameter immutable

* fix form id
2021-04-14 12:43:24 +02:00
Marc Bernard
f290658941
Fix HTML for news panel (#4695)
* Fix HTML for news panel

Add missing `<ul>` tag

* Adjust UL

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-14 09:24:02 +02:00
Christian Günter
a3b6ad8d80
fix nbsp (#4677)
fix nbsp

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-14 09:21:26 +02:00
Marc Bernard
23f62b993f
ENHx: Change order for deserialize (#4698)
Enhancements might refer to other objects of the repo so create them after the other objects.

Example: Repo includes enhancement for an exception class. Therefore, the exception class has to be deserialized before the enhancement.
2021-04-13 06:39:34 +02:00
Marc Bernard
eb8812eaac
Show "data" by object in repo view (#4689)
* Show "data" by object in repo view

Continuing on #3441

- "data" is now shown as `TABU` `<table>` in the repo view

* Remove get_item

* Add cmnt

* Update src/objects/core/zcl_abapgit_serialize.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update zcl_abapgit_serialize.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2021-04-12 14:53:09 +02:00
Marc Bernard
631d0fdccb
Refactor status calculation (#4679)
* Fix dump due to package name conflicts

Raises an error message instead of dumping

Closes #4620

* Split calculate_status

* Refactor only

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-10 11:26:31 +02:00
Marc Bernard
7bc767312e
Catch send errors in HTTP client (#4690)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-10 11:17:26 +02:00
Marc Bernard
d9f4ee7a54
Remove BCS usage (#4693)
Closes #4440

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-10 11:13:35 +02:00
Marc Bernard
086a23daca
ODSO: Replace exceptions that exist in SAP_BW only (#4694)
Closes #4692
2021-04-10 10:55:57 +02:00
Marc Bernard
b6db4e2c23
Adjusting to "main" branch (#4691)
* Adjusting to "main" branch

* Adjust filename
2021-04-08 13:02:20 +02:00
Marc Bernard
607ac4f3ab
SOTS: Uninstall with usage reference (#4687)
* SOTS: Uninstall with usage reference

Remove usage references of `SOTS` texts during uninstall

* Add comment

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-08 10:33:13 +02:00
Marc Bernard
cea83ffb86
Improve reuse of HTML viewer (#4688)
* Improve reuse of HTML viewer

Adding optional parameters to allow reuse of HTML viewer in subscreens and allow testing of query parameter table (potential replacement of `zcl_abapgit_html_action_util=>parse...`).

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-07 17:50:31 +02:00
Marc Bernard
cd6da45a12
ENHx: Improve error messages (#4686)
Include reference to previous exception and exception texts in error messages for enhancement implementations (`ENHO`, `ENHC`)
2021-04-07 17:48:53 +02:00
Lars Hvam
1fb55fe3e8
TLOCK performance (#4636)
* add new method get_transports_for_list

* downport

* read tlock into local buffer

* fix

* refactor

* upd

* cleanup

* bugfix

* return data

* refactor staging page to use new logic

* lower case

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2021-04-03 09:06:45 +02:00
Marc Bernard
bf5199b8d2
APACK: Replace interface name with constant (#4684)
* APACK: Replace interface name with constant

Closes #4248

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-03 08:59:44 +02:00
Marc Bernard
de6f8b9bbc
Ignore unit test if experimental features are not enabled (#4683)
Closes #4678

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-03 08:47:22 +02:00
Marc Bernard
2a99c742eb
Add header for status column in repo view (#4680)
* Add header for status column in repo view

* Sort status

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-01 17:12:54 +02:00
Marc Bernard
b6e7efd75b
New online repo: Replace "clone" with "create" (#4682)
Closes #4681
2021-04-01 17:11:11 +02:00
Alexander Tsybulsky
e5e558a312
Log refactoring, part 1 (#4676)
* log: new features

* log in exception

* log via gui_services

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-27 10:57:57 +01:00
Marc Bernard
56a0dca134
Refactor: Objects Class (#4664)
* Refactor: Objects Class

Splits `zcl_abapgit_objects` into smaller classes

Moves the following methods and related test cases:

`zcl_abapgit_objects_check`
- `deserialize_check`
- `warning_overwrite_find`
- `warning_package_find`
- `checks_adjust`
- `warning_overwrite_adjust`
- `warning_package_adjust`

`zcl_abapgit_files_deserialize`
- `files_to_deserialize`
- `filter_files_to_deserialize`
- `prioritize_deser`
- `adjust_namespaces`

* PP

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-27 10:46:38 +01:00
Marc Bernard
fd49e8dbe6
No changes during upgrade or locked system/client (#4674)
In addition to the client setting (repository objects modifiable or not, scc4), abapGit will not allow changes to any local objects, if

- system is set to "not modifiable" (se03)
- system is running an upgrade
- system is a shadow system

Closes #4267

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-27 10:29:38 +01:00
Mike Pokraka
624616674c
Replace SELECT * with field list (#4675) 2021-03-27 09:07:08 +01:00
Marc Bernard
73dde20557
Add warning if namespace is not modifiable (#4669)
* Add warning if namespace is not modifiable

Closes #4648

* If

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-26 09:11:35 +01:00
Marc Bernard
0c2f060445
Fix namespace check (for DOCT objects) (#4671)
Improve regex to avoid conflict with object names that contain multiple `/`

Closes #4670
2021-03-26 06:45:48 +01:00
Marc Bernard
8f0532d015
ENHC: Fix error when updating object (#4667)
If the composite enhancement already exists, trying to update it fails with error "Error while creating enhancement implementation"

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-25 12:19:34 +01:00
Marc Bernard
18d484af39
PROG: Refactor deserialize and fix inactive code (#4657)
* PROG: Refactor deserialize and fix inactive code

This is a follow-up to #4500, #4509, #4518

- Split `ZCL_ABAPGIT_OBJECTS_PROGRAM->DESERIALIZE_PROGRAM` into smaller methods
- `INSERT_PROGRAM` now uses standard `RPY_PROGRAM_INSERT` and only does `INSERT REPORT` in exceptional cases like function groups (see below)
- Special case of Code Inspector variants is handled by `ZCL_ABAPGIT_OBJECT_PROG->DESERIALIZE_WITH_EXT` since these aren't actual programs (but includes containing data)

Using the standard function fixes the issue of inactive code that can't be accessed after a pull. This used to happen, for example, when a program contained syntax errors due to missing objects.

* Update zcl_abapgit_objects_program.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-25 07:56:20 +01:00
Marc Bernard
4c8f7fe117
ENHO: Clear fields for exceptions (#4666) 2021-03-24 14:55:11 +01:00
g-back
eee6b00378
Minor fixes/changes (#4665)
* remove assert, remove unused variable

* update documentation, follow-up to #4663
2021-03-24 13:34:02 +01:00
Kjetil Kilhavn
cfcee287a8
Fix for Java GUI so new repo can be defined (#4655)
* Fix for Java GUI so new repo can be defined

The HTML demo programs are able to pass values from a form, so why does abapGit not work with Java GUI?
I've been trying to figure this out. The key to a break-through was not any fancy code analysis, it was "brute force".
I added a method in ZCL_ABAPGIT_HTML_FORM to replace the generated HTML by a copy of the resulting HTML. Then I removed things until POST-data was filled, and added things back until it broke again.

The main issue was of course the complete lack of POST-data for the event.
This is solved by adding an action attribute to the form element and removing the form-action attribute from the 'default' submit button.

The biggest surprise was that radion buttons don't work as they should. Values are returned as if both radio buttons (in the new online repository form) are checked - which of course is not possible. I tried enabling the query table in the HTML viewer just in case this was specific to the POST-data, but no such luck, it is probably a problem with the HTML viewer itself. You won't find any samples from SAP with radio buttons either.
The bug is possibly fixed by the patch in Note 2832978.

The solution is far from perfect, but at least it is now possible to add new repositories in Java GUI.
The most annoying problem that remains is that if a dialog is opened to select a package or branch the existing input data are lost. One step at a time though...

* Update src/ui/zcl_abapgit_html_form.clas.abap

Linter fix

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Single-parameter calls on one line

One extended line, mind you...

* One argument per line - when possible

Don't break the string expression up over more lines thna neessary.

* Keep line length under 120 characters

* Playing catch-up

Fixing the conflict after another pull-request was merged

* Catch up with main branch

I didn't understand from the conflict resolution view on github the total difference between main and my fork. Looked at the source file and it became clear. 
So hopefully this is the last commit... (and hopefully that won't be "famous last words")

* Time to learn about rebase...

Removed duplicate statement to get number of rows

* Conflicting line reset

Reset to main
<<<<<<< kjetil-kilhavn/javagui-fix
          ii_html->add( |<td><input type="text" name="{ lv_cell_id }" id="{ lv_cell_id }"|
                     %26%26 | value="{ lv_value }"{ lv_readonly }></td>| ).
=======
          ii_html->add( |<td><input type="text" name="{ lv_cell_id }" id="{
                        lv_cell_id }" value="{ lv_value }"{ lv_readonly }></td>| ).
>>>>>>> main

Now, may I have all green lights please?

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-24 12:55:53 +01:00
Marc Bernard
a68cbbd5ce
Refactor "Background Mode" to HTML Form (#4663)
* Refactor "Background Mode" to HTML Form

ref #4171

- Moved "Background Mode" from "Advanced" menu to "Repo Settings"
- Changed Bckg Setting and Bckg Run to new HTML pages

* Add back_toolbar
2021-03-24 12:50:53 +01:00
Marc Bernard
18c9b404f1
Empty tables in HTML forms (#4658)
Previously if there were no data rows, it would render just the column headers of the table. 

After this change, it shows "Not available".

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-23 06:49:04 +01:00
Marc Bernard
1104c88e48
Data deserialize (#4654)
* Data deserialize

Continuing on #3441 

- Fixes issue with namespaced tables 
- Adds deserialize of table content during pull but does NOT persist changes to database

`zcl_abapgit_repo->deserialize` now contains the following call to deserialize "data":

```abap
    zcl_abapgit_data_factory=>get_deserializer( )->deserialize(
      ii_config  = get_data_config( )
      it_files   = get_files_remote( )
      iv_persist = abap_false ). "<<no persisting, just test for now
```

Closes #4650

* Fixes and max record check

* Get result preview

* Split deser/actualize

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-23 06:40:09 +01:00
Marc Bernard
e143ec7f70
SOTS: Fix error during deserialize (#4660)
Error "The concept will be created in the non-original system" (`SOTR_MESS  137`) 

It's not an error (see function `SOTR_STRING_CREATE_CONCEPT`) and has been removed.
2021-03-23 06:34:42 +01:00
Lars Hvam
3193550f66
1.107.0 (#4656)
* 1.107.0

* v1.107.0
2021-03-22 13:27:31 +01:00
g-back
1cbda2f2ae
Refactor "Export Package to ZIP" to HTML Form (#4652)
* refactor export package to zip to HTML form

* change literal to constant

* downport statement

* remove popup package_export

* reorder methods, unify whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-22 13:17:54 +01:00
Lars Hvam
cac2de1ced
user exit: wall messages (#4653)
* wall messages

closes #4530

* update docs
2021-03-22 13:15:03 +01:00
Jānis B
59479570c5
Change DDIC activation mode (#4503)
* Fixes DDIC activation

The changes mimic the behavior of CTS Activatin Job as of 7.40 SP 23

* fixes Activation of dependant DDIC (#4496)

The change attempts to mimic behaviour of SAP CTS DDIC Mass Activation Job

* Revert to DDMODE = 'O'

Reverts to activation mode "in original" system; adds "forced activation" (FRCACT = abap_true)

* restore variable definitions

* and Pretty Printer

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-22 13:12:49 +01:00
Daniel Wegner
193ad660fd
Respect wildcard characters in proxy bypass settin (#4649)
Co-authored-by: Daniel Wegner <d.wegner@fis-gmbh.de>
2021-03-18 19:08:02 +01:00
Marc Bernard
56bd2b1b13
Add measures to repo stats (#4646)
* Add measures to repo stats

- Lines in ABAP Files
- Lines of Code in ABAP Files (no empty or comment lines)

* Split read_stats

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-17 07:17:02 +01:00
Lars Hvam
11fd111572
move perf test option to new repo (#4645)
* move perf test option to new repo

Moving the performance test option to separate repository,
https://github.com/abapGit/performance-test

I guess this feature is not used very often, it will reduce the overall code size, and instead of refactoring these popups to HTML they can stay ALVs in the new repo

* fixes
2021-03-17 07:12:59 +01:00
Lars Hvam
630012aea9
refactor presist check to persist level (#4644)
The old code called the REPO service class to check if a repo exists, to better encapsulate the packages, the check will now stay inside the persistence package
2021-03-17 07:10:31 +01:00
Lars Hvam
e31e641f10
overview page, dont display ".git" (#4632)
* overview page, dont display ".git"

dont display ".git" in the urls in the overview page, to save a bit more horizontal space

also see #4539

* dont use regex
2021-03-16 16:51:04 +01:00
Lars Hvam
5a121a2174
perf test, dont look for current package (#4642)
the user can input the package anyhow

decouples the perf test option from gui #4639, plus will make it easier to implement #4641
2021-03-15 15:54:56 +01:00
Lars Hvam
16ca0fef77
ZCL_ABAPGIT_GUI delete unused GO_PAGE (#4640) 2021-03-15 15:30:21 +01:00
Lars Hvam
f108143a90
add ORDER BY (#4629)
* add ORDER BY

* wdcc, add ORDER BY

* wapa add order by

* udmo, add order by

* tobj, add order by

* stvi, add order by

* CHAR, add order by

* CMOD, add order by

* dial, order by
2021-03-15 15:25:02 +01:00
Lars Hvam
70fdc8771e
CTS API: remove unused iv_resolve_task_to_request (#4633) 2021-03-13 13:29:05 +01:00
g-back
72f34f5bdf
Refactor "Object to Files" to html form (#4623)
* start conversion from popup to html form

* replace magic with constants

* revert label

* restructure to gui component


modify export object logic

* adjust whitespace

* remove test_changed_by functionality

* remove popup_object

Co-authored-by: Goran Back <g.back@geringhoff.de>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-12 12:31:17 +01:00
Marc Bernard
a1cc7f8668
CLAS: Fix several issues related to class includes (#4510)
* CLAS: Remove test class include

Once unit tests are disabled, the test class include is now completely removed (before it might have still contains obsolete code).

Closes #4460

* Reverse pp

* Update 6 objects

* Typo

* Typo

* Revert

* Revert

* Revert

* Revert

* Revert

* Lint

* Update zcl_abapgit_oo_class.clas.abap

* Move add_to_activation

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-12 07:05:47 +01:00
Mike Pokraka
bb0591f12e
Update unit test to match changed message (#4631) 2021-03-12 07:02:25 +01:00
g-back
71c4849ae5
Minor Fixes (#4627)
* remove exception from signature, remove comment

* change search help, try fieldname first

* enable lang switch when multiple tcodes are assgnd
2021-03-11 14:51:48 +01:00
Lars Hvam
8dc1156d75
Apack migration, Suppress dialog (#4616)
#4612
2021-03-10 07:31:18 +01:00
Lars Hvam
26c81be9fd
Refactor "Change Remote" to html form (#4617)
* Refactor "Change Remote" to html form

* upd

* cleanup

* less whitespace

* update logic and descriptions
2021-03-10 07:29:13 +01:00
Marc Bernard
f28d3e9441
CI Tests: Small improvements (#4618)
- Allow passing of longer test repo names (len > 4)
- Raise errors after each test phase
2021-03-09 17:00:36 +01:00
yellappam
0f2020b5c1
Unsupported object count in repo statistics (#4601)
* Add unsupported object count in repo statistics

* lint fix: Keep single parameter on one line

* Fix indentation

* Undo changes to TADIR and DEFINITIONS

Undo changes to ZCL_ABAPGIT_TADIR and ZIF_ABAPGIT_DEFINITIONS

* Refactor code

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-09 12:13:10 +01:00
Christian Günter
d7e43fc0b9
Diff calculation: improve performance (#4603)
* Diff calculation improve performance

* optimize table access

Co-authored-by: Christian Günter <Christian.Guenter@zuerich.ch>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-07 12:25:10 +01:00
Lars Hvam
72f08d64b1
refactor, remove use of CNHT_POST_DATA_LINE (#4607) 2021-03-07 12:18:20 +01:00
Lars Hvam
d7f74bd49c
zif_abapgit_poups cleanup (#4608)
* zif_abapgit_poups cleanup

delete method POPUP_TO_INFORM

* delete method POPUP_PROXY_BYPASS
2021-03-07 12:15:26 +01:00
Jakub Filak
cce8660054
objects: do not consider only native objects as supported (#4611)
After the pull request:
https://github.com/abapGit/abapGit/pull/4589

Objects supported by abapGit-plugins are not deserialized and
all are reported as not supported.

Closes #4610

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-06 22:31:49 +01:00
Lars Hvam
043d8e1ef2
zcl_abapgit_time, rounding not needed (#4609)
changed the type to an integer, then the rounding is not needed

minor change, more simple code
2021-03-06 16:06:33 +01:00
Alexander Tsybulsky
17eac7b6c3
Strip XML details user exit (#4599)
* exit draft

* call exit

* linter fix

* PRE_CALCULATE_REPO_STATUS docs

* settings UI

* wire status calculation and repo settings

* uppercase

* diff rendering fix

* adjust docs

* adjust docs

* Remove settings

* more docs adjustments

* pass repo meta data into the exit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-06 09:35:35 +01:00
Lars Hvam
a77160e58c
refactor, remove bcs and solix usage (#4605)
* refactor, remove bcs and solix usage

* DEFAULT KEY
2021-03-06 08:56:02 +01:00
Lars Hvam
393771e6ef
allow switching branches in write protected repos (#4595)
* allow switching branches in write protected repos

* fix
2021-03-06 08:43:18 +01:00
yellappam
1a94c9a0f0
TYPE: Serialize active version (#4593)
* TYPE: Serialize active version

When a new type-pools is created, SAP creates active version by default. SY-SUBRC is always set to 0 for the first function module call as there is always an active version hence, second function will never be called. Remove the second call.

* Multiple changes

Check existence of the object using TADIR entry
If the active object doesn't exist, show proper message

* Existence check using PROGDIR

* Replace SELECT..ENDSELECT

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-04 08:49:44 +01:00
yellappam
09353951eb
Group unsupported object type messages (#4589)
* Group unsupported messages per object type

When number of unsupported objects increase in a package, user needs to scroll through the long list of messages. This change groups messages per object type reducing the number of messages. Also, the filtering before serialization is good in terms of effective work process utilization( in parallel mode ).

* Replace LINE_EXISTS with READ TABLE

* Cache the supported object types

* Show object name 

If there is only one object name for the unsupported object type, show the name.

* Spelling: "object(s)" to "objects"

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-03 05:36:21 +01:00
Christian Günter
011dfc6590
Distinguish repo and file diffs to fix d-hotkey (#4591) 2021-03-03 05:30:21 +01:00
Marc Bernard
8a0af2fc67
DDIC: Error message in case of "new" versions (#4584)
In case DDIC objects exist as "new" version only , the system will now raise an error message to alert the user that "No active version was found". 

Note: The log will disappear after some navigation and such objects will not be included in the repo view if they only exist locally (until they are activated).
2021-03-02 17:38:26 +01:00
Alexander Tsybulsky
3df4863feb
LXE langs refactoring (#4494)
* main refactoring part

* linter fix

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-01 07:02:04 +01:00
sandraros
8edc8736f7
Fix pull clasenh "file emxxx not found" #4515 (#4552)
* Fix #4515

Fix #4515 by serializing new TAB_INCLUDES to contain include numbers of new methods of classes.

* Last fix before pull request

* files named "em_<methodname>" instead "emxxx"

* editorder without gaps

* Cleanup commented out line

* fixes abaplint

Co-authored-by: sandra rossi <sandra.rossi@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-28 19:40:54 +01:00
Marc Bernard
da43c34fc4
DEVC: Unlock in case of errors (#4561)
* DEVC: Unlock in case of errors

If a package object cannot be deleted or deserialized properly, it remains locked.

The change unlocks the object in these cases.

* Update set_lock

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-28 17:16:33 +01:00
Marc Bernard
0392543ff5
AVAR: Unlock after deserialize (#4560)
* AVAR: Unlock after deserialize

* Dequeue

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-28 17:07:15 +01:00
Lars Hvam
99b3168666
1.106.0 (#4570)
* 1.106.0

* v1.106.0
2021-02-28 11:01:35 +01:00
Marc Bernard
f8076e9ca2
TABL: Remove field position from serialization (#4508)
* TABL: Remove field position from serialization

It's not necessary to serialize field position (`DD03P-POSTION`). Fields can simply be numberred sequentially during deserialize.

This avoid issues with include structures that have different number of fields in original and target systems.

Closes #4506

* Clear tabname, ddlanguage

* Lint

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Clear dd08v-ddlanguage

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-28 10:47:16 +01:00
Lars Hvam
09ce51e646
WDCC fix dump (#4563)
* WDCC fix dump

* Update zcl_abapgit_object_wdcc.clas.abap
2021-02-28 10:09:58 +01:00
Marc Bernard
7da94f396d
Fix jump to objects with special characters (#4558)
Fixes jump to an object in case the object name contains escaped characters

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-24 05:55:23 +01:00
Marc Bernard
db61b57b80
DEVC: Avoid syntax check warning (#4559)
* DEVC: Avoid syntax check warning 

Add pragma

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-24 05:53:34 +01:00
Lars Hvam
7112c4ff3a
WDCC serialization, fix dump (#4557)
in case the xml is empty, skip the pretty print, this will avoid a short dump during pretty printing
2021-02-24 05:51:28 +01:00
Lars Hvam
4a30f00a7e
HTML, minor performance? (#4553)
* HTML, minor performance?

@FreHu can you try this, to see if the performance is a few ms better?

* upd
2021-02-22 06:51:24 +01:00
Frederik Hudák
357203034c
zif_abapgit_persist_repo~update_metadata - don't load all repositories (#4554)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-22 06:49:15 +01:00
Lars Hvam
b7d6870077
parsing git branch list, throw errors (#4547)
* parsing git branch list, throw errors

closes #4523

* downport

* fix whitespace

* bugfix
2021-02-21 16:21:34 +01:00
Frederik Hudák
add83f5b94
Repo overview performance improvements (#4541)
* Repo overview performance improvements

* Rework map_repo_list_to_overview

* Reduce usages of get_key

* Fix inline data

* Don't load package descriptions in repo overview

the select is expensive

* suppress titles for non-favorite repositories

* lint

* Update src/ui/zcl_abapgit_gui_page_repo_over.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* optimize render_repo_palette

* Optimize gui_router

* Update zcl_abapgit_gui_page_repo_over.clas.abap

* Update zcl_abapgit_migrations.clas.abap

* remove unused variable

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-21 11:29:01 +01:00
Frederik Hudák
bbeb1e7a58
Remove user setting migration (#4551) 2021-02-21 09:26:31 +01:00
Lars Hvam
155044e2a6
GET_REPO_SHOW dont lookup empty key (#4550)
if the key is empty, dont try looking it up
2021-02-20 20:22:54 +01:00
Frederik Hudák
e68feff2e1
Main page - disable hover info for package/user links (#4545)
* Main page - Only show hover info for favorites

in package, user links

suppress titles for non-favorite repositories

* always suppress loading titles in repo overview

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-20 17:22:25 +01:00
Frederik Hudák
982679b40d
Remove local_dot_abapgit migration (#4543)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-20 17:18:34 +01:00
Frederik Hudák
c3012513b3
Optimize performance of switching branches (#4548) 2021-02-20 17:16:50 +01:00
Lars Hvam
40cd29297d
overview page, dont display "https://" (#4539)
* overview page, dont display "https://"

dont display "https://" or "http://" in overview page

delete unused method HAS_FAVORITES

* add title
2021-02-20 10:28:02 +01:00
yellappam
338cf6a358
Background logic to log exception and continue (#4534)
When executing the background logic if a repo processing fails, then log the error and continue processing with next repository.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-20 10:17:43 +01:00