Commit Graph

3484 Commits

Author SHA1 Message Date
Christian Günter
b994382f78 Improve error information - follow up Part 2 (#2814)
- Cleanup JS
- Delete superflous functions and methods
2019-08-03 04:24:03 -07:00
Christian Günter
5cd2044745 Serialzie: Improve exception handling (#2831) 2019-08-02 22:06:23 -07:00
Alexander Tsybulsky
e379dd3cfe Completely dynamic JS hints (#2825)
* draft rewrite hint to be dynamic

* linter fixes

* remove color setting

* remove backspace and esc handling

* close dropdowns

* return some comments in JS

* linter fixes

* Fix hint for dropdown first time + alw close drdwn
2019-08-02 07:45:27 -07:00
ThomasPloski
d623d20d03 Improve object handler for CDS metadata extension (DDLX) (#2816)
* fixes issue #2815

The existing object handler for CDS metadata extension (DDLX) has been reviewed by an expert.
Doing this, the following feedback has been provided:

enable existing logging capability
include environment specific logic (e.g. import of an inactive version)
improve exception handling so that the related object information can be displayed in log
assign package information to handle abap language version ina proper way
adapt lock object

* fixes saplint issues

* fixes saplint issues

* fixes saplint issues

* extract dependency injection for TADIR_INSERT

* fixes saplint issues

* zcl_abapgit_environment.clas.testclasses.abap set to master version

* changes related to code review

* redo changes

* redo changes

* back to master version
2019-08-02 07:26:55 -07:00
Lars Hvam
88a5b4cd50
update to latest abaplint (#2829)
* update to latest abaplint

* Update package.json
2019-08-02 01:32:14 -07:00
Lars Hvam
cd87c97be7
environment, add tests and fix dump (#2827) 2019-08-02 01:21:03 -07:00
Lars Hvam
8d87beea60
tutorial is just a view, no need to implement intf (#2823) 2019-08-01 03:17:59 -07:00
ThomasPloski
a5ebe60642 Refactoring of ZCL_ABAPGIT_ENVIRONMENT (#2826)
* Refactoring of ZCL_ABAPGIT_ENVIRONMENT #2810

* fixes saplint issues

* fixes saplint isues

* fixes saplint issues

* fixes issue based on review

* align zcl_abapgit_objects.clas.abap to master

* add the test class again
2019-08-01 02:49:59 -07:00
sandraros
3f05693262 UI Dark Theme #2610 (#2787)
* UI Dark Theme #2610

Proposal - Right now, only the first obvious screens were checked, and there are still a few issues with them.

* CSS cleanup of unused elements
2019-08-01 00:57:30 -07:00
Lars Hvam
6f37ba37dd
fixes #2822 (#2824) 2019-07-31 00:55:08 -07:00
Lars Hvam
48222ca050
indentation fixes (#2820)
* indentation fixes

* fixes
2019-07-31 00:49:10 -07:00
Alexander Tsybulsky
d8b3034a30 close button css fixes (#2819) 2019-07-31 00:44:59 -07:00
Lars Hvam
d42bb98662
fixes #2808 (#2818)
fixes #2808
2019-07-31 00:41:01 -07:00
Alexander Tsybulsky
29c45a7e7c more convenient html pp comment (#2817) 2019-07-31 00:36:51 -07:00
Christian Günter
50a6cf8ac9 Improve error information - follow up Part I (#2813)
* Improve error information - follow up Part I

- Bug: remove errorenous regex
- Add tooltip for message id and message class

* Replace text of message link
2019-07-30 05:04:00 -07:00
Christian Guenter
50cc8b810f Better error message 2019-07-30 03:05:39 -07:00
Christian Günter
5081ddf7d0 Improve error information - HTML error message (#2775)
* Improve error information

With this commit errors that are raised with zcx_abapgit_exception=>raise
and issued with message are enriched with two additional functions.

1) Go to source
Navigates to the source code position where zcx_abapgit_exception=>raise
is called

2) Callstack
Shows a popup with the full callstack and the possibility to navigate to
the source of each line with double click

This feature requires the full abapGit repository. Without nothing
changes.

* issue messages directly

* zcx_abapgit_exception: adapt callstack handling

- callstack as attribute
- export callstack to ABAP memory only when SAPGui is available

* rename memory id

* Add comment why we don't delete callstack from MEM

* cleanup

* first try html error display

* add some comments

* add longtext

* goto_source and callstack implemented

* part 2

* remove

* fix

* add close button

* fix long classname

* fix linter

* add jump to SE91

* fix lintmr

* fix and cleanup

* fix linter

* fix linter

* fix eslint

* fix linter

* remove message class

* remove superfluous constant

* add missing method implementation

* refactor

* add hotkey for message longtext toggling

* hotkey 2

* refactor + resize callstack popup

* Refactoring: simplify control flow

* fix goto callstack for merged abapGit

* refactor: simplify control flow

* Refactoring: introduce message helper

* fix linter

* remove TODO pragmas

* ren. render meth + move zcl_abapgit_gui_chunk_lib

* refactoring: simplify control flow

* simplify exception handling

* refactor

* refactor

* refactor

* remove duplication

* Rename method

* rename method

* remove superfluous constant

* call ZCL_ABAPGIT_MESSAGE_HELPER dynamically

* cleanup

* Improve UX

* fix linter

* remove hotkey
2019-07-28 03:46:53 -07:00
Johan Wigert
b068ddcaa3 Fix for issue #2772 (#2806)
* Update zcl_abapgit_transport_objects.clas.abap

* Update zcl_abapgit_transport_objects.clas.testclasses.abap

* Update zcl_abapgit_transport_objects.clas.testclasses.abap

* Update zcl_abapgit_transport_objects.clas.abap

* Update zcl_abapgit_transport_objects.clas.abap

* Update zcl_abapgit_transport_objects.clas.abap
2019-07-21 21:30:17 -07:00
Hector Martinez
6b5fbd52fd adds serialization of FUGR text pool translations (#2780) (#2790)
* fix for issue #2747

* fixes issue #2746

* adds serialization of function groups text pool translations

* whitespace fixes
2019-07-21 03:35:11 -07:00
Sdfraga
ddcc1ee3c6 Proxy port length (#2800)
* Ensure Proxy Port has 4 digit length

* Ensure Proxy Port has 4 digit length
2019-07-18 07:12:25 -07:00
Christian Guenter
24e319cc68 Downport 2019-07-18 07:07:20 -07:00
Łukasz Pęgiel
63c8e4808c add log for Offline install (#2798)
* add log for Offline install

* white space
2019-07-17 08:17:09 -07:00
Lars Hvam
998815f6fb
closes #2791 (#2792)
another quick fix for the staus codes, #2791
2019-07-17 01:06:12 -07:00
Christian Guenter
1a9d1b3d08 Patch: delete all lines removes the file 2019-07-17 00:58:31 -07:00
Lars Hvam
1dbd4d1912
Refactoring types (#2785)
* align use less different types

* refactor

* updates
2019-07-15 09:33:37 -07:00
larshp
2db46137fc #2783, update error description 2019-07-14 23:31:33 -07:00
Hector Martinez
699e4fd65c fixes issue #2746 (#2776)
* fix for issue #2747

* fixes issue #2746
2019-07-12 02:00:17 -07:00
Alexander Tsybulsky
d1c266c3fc ui docs (#2774) 2019-07-12 01:53:33 -07:00
Frederik Hudák
777445002a Revert behavior of second back button (#2779)
* Revert behavior of second back button

* Leave clearing of stack on go home
2019-07-10 21:28:20 -07:00
Frederik Hudák
0299fb61c7 Consistent sort ordering of files (#2778) 2019-07-10 00:37:09 -07:00
Lars Hvam
ce84d2455f
additional gateway support (#2771)
* additional gateway support

* Update ref-supported.md
2019-07-07 23:38:55 -07:00
Lars Hvam
f662348b05 update abaplint link 2019-07-06 04:29:24 -07:00
Lars Hvam
f88237f411
remove double spaces (#2770)
* remove double spaces

* whitespace
2019-07-02 20:54:35 -07:00
Lars Hvam
c84b209944
Minor lint updates (#2766)
* remove some double space

* update abaplint to latest

* fixes
2019-07-01 22:08:54 -07:00
Alexander Tsybulsky
df0aca8272 Improve css preprocessing (#2765)
* improve assetman get_text_asset

* move css_processor to ui_core, reuse get_text_asse

* fix %26 refactor UTs

* zcl_abapgit_gui_html_processor

* if fix

* replace core logic

* comment finetuning

* linter fixes

* more linter fixes

* fix UTs, based on review
2019-07-01 20:53:43 -07:00
Christian Guenter
1f52d8b2c7 TR request jump: fallback to SAPGUI 2019-07-01 20:50:06 -07:00
Hector Martinez
3e53360722 fix for issue #2747 (#2760) 2019-06-28 23:06:07 -07:00
Frederik Hudák
f5d421e399 ADT jump for package link and transports (#2758)
* ADT jump for package links

* Also handle transport requests/tasks

* fix abaplint
2019-06-28 23:02:37 -07:00
Lars Hvam
f6e8332754
Cleanup (#2753)
* refactor IF

* fix some indentation

* indentation fixes

* indentation fixes

* indentation

* indentation
2019-06-25 03:02:51 -07:00
Fabian Lupa
7f04d59bf9 Belize theme (#2733)
* Add Belize theme

* Implement polyfill for CSS variables

* Fix CSS variables with spaces in values

* Always load default theme and add others on top

* Adjust theme CSS for use with variables

* Support variables referencing variables in CSS

* Adjust themes

* Add font size to theme

* Skip asset registration for unused themes

* Unify theme greyscale

* Refactor CSS preprocessor

* Refactor CSS preprocessor, add basic tests

* Fix linter issues

* Always load theme asset

Otherwise switching does not work
2019-06-25 03:02:40 -07:00
Lars Hvam
500f469835
1.88.0 (#2751)
* 1.88.0

* v1.88.0
2019-06-21 23:19:02 -07:00
Martin Fuchs
4aab0166ac Pass log to deserialization API and show log (#2729)
* Pass log interface for de-serialization

Interface ZIF_ABAPGIT_LOG is now passed for deseriaization API.
This includes:
- Log messages for FUGR: Imported function modules and includes
- Improved error messages for TABL compare
- Log objects w/o changes
- Log is shown in the UI if available ("Log" entry appears if a log exists, no persistence!)
This PR enhances #2534 and #2694

Another important change: In case an object fails (or a single function module in a group fails), the import continues with the next object!

* small pretty printer changes

small pretty printer changes

* fix abaplint issues

reduce line sizes and ensure 7.02 compatibility

* show errors and warnings from pull

Errors and warnings after a pull are now part of the "message list" above the object list in the main screen and will be shown immediately. The new"Log" button shows errors, warnings and success messages on demand.
The log title is now part of the ZIF_ABAPGIT_LOG interface.

* fix abaplint issue

fix abaplint issue
2019-06-21 23:05:10 -07:00
Hector Martinez
a69e313090 fix for issue #2745 (#2749)
* solves issue #2745

* format

* format, now with abaplint
2019-06-21 23:00:05 -07:00
Christian Günter
6b7e4d62dd Improve error handling for delete_tadir (#2741)
* Improve error handling for delete_tadir

* add TODO comment for delete tadir
2019-06-16 09:01:53 -07:00
Frederik Hudák
abc43d4e5a With 'show changes only' enabled, also filter changed files, not just objects (#2740)
* When 'show changes only' enabled, also filter changed files, not just objects

Fixes #2739

* fix whitespace

* Fix syntax error
2019-06-16 04:53:37 -07:00
Christian Guenter
0b78d4c1a8 Downport 2019-06-13 23:18:03 -07:00
Christian Günter
ffc411b8f1 use remote .abapgit if local repo is empty (#2736)
* use remote .abapgit if repo is empty

* use method find_remote_dot_abapgit

* cleanup

* cleanup /2
2019-06-13 23:01:22 -07:00
Frederik Hudák
c679d11d7b Change behavior of second back button to go home (#2679)
* Change behavior of second back button to go home

* Change logic as proposed

* Don't go to tutorial page on exit

* Final changes

* Fix abaplint
2019-06-13 22:59:18 -07:00
larshp
f8c017a8de replace conversion exit usage #2716 2019-06-11 10:46:15 -07:00
Lars Hvam
5fb5dc552f
workaround #2737
this should make it give a warning instead of a syntax error
2019-06-11 19:29:03 +02:00