Commit Graph

51 Commits

Author SHA1 Message Date
Fabian Lupa
bab9b7ba22
Show tutorial if there are no repos (#3907)
Fixes #3553

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-20 09:40:57 +02:00
Alexander Tsybulsky
555f2f3d0b
html event abstraction, phase 1 (#3900)
* event class, interface and gui

* router adaptation

* rest of the pages

* linter fixes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-19 07:57:39 +02:00
Fabian Lupa
dc5725b49c
Add performance test (#3847)
* Add performance test

* Fix some linter errors

* Refactor free selections to reduce method length

* Performance test add title to result ALV

* Attempt downport

* Downport

* Pretty Printer VS abaplint

* Undo more changes done by pretty printer

* Adjust performance popup title and ALV layout

* Move free sel dialog to global for abapmerge

* Move some type definitions for abapmerge

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-08 10:39:20 +02:00
g-back
3e4ce7bf73
Offline Repos: add ZIP Import/Export to actions (#3823)
* navigate to repo after ZIP import

* add zip import/export action for offline repos

* rename action labels

* change new state to be dependent on current page


change replacing -> new page if action called from repo list
rerender if in repo view

* add some TODOs, see PR discussion

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-08 10:32:17 +02:00
Christian Günter
4af7026e15
Fix: Open repo in master lang. opens repo (#3710)
After this fix is applied the menu "advanced > open in master language" opens the repo directly and doesn't open the repo list.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-06 13:37:48 +02:00
Alexander Tsybulsky
8bc12fef01
tutorial to component (#3704) 2020-08-05 07:47:10 +02:00
Alexander Tsybulsky
07e1f787c6
gui_page cleanups (#3615)
* move test_changed_by from gui_page to services

* kind of linter fix

* move more action to router

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-13 17:42:40 +02:00
Frederik Hudák
d49d0656b0
Top menu improvements (#3590)
* Use icons, add back menu to repo show page

* Event handling

* Abaplint

* Add menu to tutorial page

* Lint

* More icons

* Update tutorial, reorganize button code

* Move icon css

* Fix error

* Fix menu
2020-07-09 09:12:58 +02:00
Jaime Rodriguez Capote
f8d74cc928
Fix open url in repo view (#3581)
* Fix open url in repo view

* Move call_browser to gui_router
2020-07-04 12:35:38 +02:00
Marc Bernard
7ce457dc8d
Fix user settings containing invalid repo key (#3569)
* Update zcl_abapgit_persistence_user.clas.abap

* Fix dump when last repo is invalid

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-01 15:24:33 +02:00
Frederik Hudák
961afa37f8
Fix error after removing/uninstalling repo (#3572)
Main and repo are no longer one page, so the `re_render` action does not make sense anymore. `new_page_replacing` is used instead of `new_page` so you cannot navigate back to the removed repo.
2020-07-01 15:10:39 +02:00
Alexander Tsybulsky
f5dfd328f5
Dialogs: add online repo HTML form (#3533)
* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks
2020-07-01 08:16:52 +02:00
Frederik Hudák
32cf59ca1e
Repo overview as main page (#3498)
* Add main menu, toggle favorites

* Make abapgit logo go to overview

* Remove favorite repo links

* Fix remember filter

* Separator between filters

* Remove unused code

* Repo overview to main page

* Fix errors

* Fix naming

* Downport js

* Add separator

* remove unrelated changes

* Fix spacing

* Add package link

* Fix orderby dumping

* Only show tutorial with no favorites

Still have to do something about empty table

* Move abapgit installation info to debug info

* Improve tutorial, resolves #3497

* Add branch switch link

* Reduce line length

* Revert temporary hack

* Working version of removing logo

* No longer show tutorial in repositories

* Code cleanup

* More cleanup, rename tutorial to page

* Fix

* Force order by favorite

* Add checkmark icons

* View repo to page, rework menu

* Fix build

* Return logo

* Fix hotkeys on repo page, rename to page

* Fix show last repo, cleanup

* Abaplint

* Rollback js reformat

* Fix tutorial title, hotkeys

* Try resolve strange situation with PR

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-29 16:34:59 +02:00
Lars Hvam
d36b43defe
line break parameters (#3444)
* line break parameters

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* fix
2020-06-04 15:10:35 +02:00
Frederik Hudák
2886c00592 Fix syntax error in gui_router
Somehow lost this change from #3378. The class no longer exists.
2020-05-21 06:58:26 +02:00
Frederik Hudák
be260435f5
Move explore link (#3378)
* Move explore link

* Update zcl_abapgit_services_abapgit.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-20 19:47:42 +02:00
Frederik Hudák
3335317278
Remove page playground (#3375)
* Remove page playground

* Remove constant
2020-05-20 18:28:03 +02:00
Marc Bernard
aa71ed52ae
Set filter for file open and save dialogs / Add new setting for default commit comment (#3371)
* Set filter for file open and save dialogs

Set the file filter dropdown and default to *.ZIP in file open and save dialogs

* Add new setting for default commit comment

New abapGit setting to define a default for the comment used for commits. Object and/or filename can added to the comment automatically, which works similar to GitHub if a single file is changed. If multiple objects are changed, then object/file count is included in the default for the comment.

* Update CLAS ZCL_ABAPGIT_GUI_PAGE_COMMIT

* Fix text for $object

Fixed case when one object with multiple files was changed

* Pretty print

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-20 12:37:58 +02:00
Alexander Tsybulsky
0eb22a0c87
Gui refactor, part 1 (#3289)
* gui component and event registering

* remove iv_prev_page from event_handler if

* constructors raising zcx_abapgit_exception

* get_gui_services - UT friendly

* linter fixes

* more linter fixes

* zif_gui_services stub all methods

* linter fix

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-07 10:30:43 +02:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
Christian Günter
a40e7f1bbc new function 'add all objects to transport request' (#2942)
* new function 'add all objects to transport req'

* enable cancel
2019-10-06 00:21:51 -07:00
Christian Günter
5081ddf7d0 Improve error information - HTML error message (#2775)
* Improve error information

With this commit errors that are raised with zcx_abapgit_exception=>raise
and issued with message are enriched with two additional functions.

1) Go to source
Navigates to the source code position where zcx_abapgit_exception=>raise
is called

2) Callstack
Shows a popup with the full callstack and the possibility to navigate to
the source of each line with double click

This feature requires the full abapGit repository. Without nothing
changes.

* issue messages directly

* zcx_abapgit_exception: adapt callstack handling

- callstack as attribute
- export callstack to ABAP memory only when SAPGui is available

* rename memory id

* Add comment why we don't delete callstack from MEM

* cleanup

* first try html error display

* add some comments

* add longtext

* goto_source and callstack implemented

* part 2

* remove

* fix

* add close button

* fix long classname

* fix linter

* add jump to SE91

* fix lintmr

* fix and cleanup

* fix linter

* fix linter

* fix eslint

* fix linter

* remove message class

* remove superfluous constant

* add missing method implementation

* refactor

* add hotkey for message longtext toggling

* hotkey 2

* refactor + resize callstack popup

* Refactoring: simplify control flow

* fix goto callstack for merged abapGit

* refactor: simplify control flow

* Refactoring: introduce message helper

* fix linter

* remove TODO pragmas

* ren. render meth + move zcl_abapgit_gui_chunk_lib

* refactoring: simplify control flow

* simplify exception handling

* refactor

* refactor

* refactor

* remove duplication

* Rename method

* rename method

* remove superfluous constant

* call ZCL_ABAPGIT_MESSAGE_HELPER dynamically

* cleanup

* Improve UX

* fix linter

* remove hotkey
2019-07-28 03:46:53 -07:00
Christian Guenter
1f52d8b2c7 TR request jump: fallback to SAPGUI 2019-07-01 20:50:06 -07:00
Frederik Hudák
f5d421e399 ADT jump for package link and transports (#2758)
* ADT jump for package links

* Also handle transport requests/tasks

* fix abaplint
2019-06-28 23:02:37 -07:00
Martin Fuchs
4aab0166ac Pass log to deserialization API and show log (#2729)
* Pass log interface for de-serialization

Interface ZIF_ABAPGIT_LOG is now passed for deseriaization API.
This includes:
- Log messages for FUGR: Imported function modules and includes
- Improved error messages for TABL compare
- Log objects w/o changes
- Log is shown in the UI if available ("Log" entry appears if a log exists, no persistence!)
This PR enhances #2534 and #2694

Another important change: In case an object fails (or a single function module in a group fails), the import continues with the next object!

* small pretty printer changes

small pretty printer changes

* fix abaplint issues

reduce line sizes and ensure 7.02 compatibility

* show errors and warnings from pull

Errors and warnings after a pull are now part of the "message list" above the object list in the main screen and will be shown immediately. The new"Log" button shows errors, warnings and success messages on demand.
The log title is now part of the ZIF_ABAPGIT_LOG interface.

* fix abaplint issue

fix abaplint issue
2019-06-21 23:05:10 -07:00
Thomas B
84042f1370 Enhance 'Transport to ZIP' to process multiple transport requests (#2683)
* New Program : Mass Transport to local zip file

Create new program ZMASSGIT in order to convert multiple tranport request to local zip files ( by giving output folder ).
Timestamped subfolder will be created in the input folder.

* Add files via upload

* Update zmassgit.prog.abap

* Add files via upload

* Add files via upload

* Delete zmassgit.prog.xml

* Delete zmassgit.prog.abap

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.abap

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.xml

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.abap

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.xml

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipscr.abap

* Rename zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipscr.xml to src/zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipscr.xml

* Rename zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2ziptop.abap to src/zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2ziptop.abap

* Rename zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2ziptop.xml to src/zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2ziptop.xml

* Rename zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.abap to src/zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.abap

* Rename zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.xml to src/zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.xml

* Rename zabapgit_masstransp2zip.fugr.xml to src/zabapgit_masstransp2zip.fugr.xml

* Rename zabapgit_masstransp2zip.fugr.z_abapgit_transports_2_zip.abap to src/zabapgit_masstransp2zip.fugr.z_abapgit_transports_2_zip.abap

* Rename zcl_abapgit_transport_mass.clas.abap to src/zcl_abapgit_transport_mass.clas.abap

* Rename zcl_abapgit_transport_mass.clas.xml to src/zcl_abapgit_transport_mass.clas.xml

* Delete zcl_abapgit_zip.clas.abap

* Delete zcl_abapgit_zip.clas.xml

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Update zcl_abapgit_zip.clas.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.abap

* Update zcl_abapgit_transport_mass.clas.xml

* Update zcl_abapgit_transport_mass.clas.abap

* Update zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.abap

* Update zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.xml

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.abap

* Update zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.abap

* New version without function group

* Cleanup

* Abaplint

* AbapLint Fixes

* Remove plugins objects from master

* Skip log flag in ZIP export

* Popup to ask the Export logic ( FULL / PREFIX ..)

* line length for abaplint

* Refactoring of code

Avoid redundancy of code and remove unused constant.

* Reduce line 50 length for abaplint ( < 120 )

* Change by the review of code

Refactoring of code

* AbapLint Fix
2019-06-11 08:57:08 -07:00
Alexander Tsybulsky
ecc1c85ee7 GUI subclass zcx_abapgit_cancel from zcx_abapgit_exception (#2576)
* subclass zcx_abapgit_cancel from zcx_abapgit_excep

* upper case
2019-03-26 23:51:38 -07:00
Alexander Tsybulsky
2ab4ae9f26 Refactor GUI interfaces (#2540)
* refactor gui interfaces

* delete zif_abapgit_gui_router

* move zif_abapgit_gui_page_hotkey to ui

* linter fixes
2019-03-17 01:42:41 -07:00
Lars Hvam
f9318305e9
Minor fixes (#2532)
* minor fixes regarding unused variables

* minor code inspector fixes
2019-03-15 05:54:39 -07:00
Alexander Tsybulsky
9b38d79cce GUI CORE, move constants (#2526)
* zcl_abapgit_gui constants

* renames in all classes

* zif_abapgit_html

* zif_abapgit_html related renames

* remove gui->free for now
2019-03-15 02:22:08 -07:00
larshp
dcaf585d47 move file_download to ui package
move file_download to ui package, part of #2510

the zip class should ideally work without frontend interaction, and just provide/parse the raw xstrings, this way it can be reused across different frontend technologies
2019-03-15 01:52:42 -07:00
sbcgua
60bf29dd38 refactor zcl_abapgit_zip (#2241)
* zip->load

* remove import and file_upload

* linter fix

* minor fix
2018-12-30 08:06:16 +01:00
sbcgua
4dee27fc1e Gui internals refactoring (#2180)
* GUI internals refactoring

* unify string conversion calls part1
2018-12-04 06:33:35 +01:00
Lars Hvam
f3702fc5a4
router: refactor on_event to multiple methods (#2140)
* router: refactor on_event to multiple methods

* bugfix
2018-11-25 07:12:43 +01:00
Alexander Tsybulsky
558ece49c5 2-step zip import 2018-11-23 05:57:42 +01:00
Fabian Lupa
b08ee6a498 CTS integration (#2061)
* Implement facade for Change Transport System

* Render lock item in VIEW_REPO

* Add jump to SE01

* Display transport on stage page

* Optimize transport read on stage page

* Error handling CTS

* Fix indentation

* Disable transport column for local packages

* Code review changes
2018-11-09 05:36:44 +01:00
Lars Hvam
fa39fcd43f
Code inspector fixes (#1997)
* pretty print

* definitions to top of routine

* space before .

* omit parameter names where possible

* double space after if

* remove pseudo comments where possible
2018-10-12 07:56:27 +02:00
Christian Günter
0fa50309a1 Staging smaller chunks of code like git add -p (#1842)
* Staging smaller chunks of code like git add -p

With this commit a new feature which works similar to git add -p
is added. We are now able to patch, which means that we can
commit on line basis. And are not restricted anymore to commit
only on file basis.

* move get_page_patch to stage page

* Refactor JS

* Refactor JS
2018-09-08 08:58:25 +02:00
Johannes Konings
d25bfaf725 fix some naming conventions
https://github.com/larshp/abapGit/issues/1132
2018-08-17 09:24:22 +02:00
Christian Günter
400846e036 Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER #1775 (#1776)
* Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER

* catch exception if interfaces doesn't exist

Catch exception if IF_OO_SOURCE_POS_INDEX_HELPER doesn't exist
2018-08-06 15:11:40 +02:00
Lars Hvam
bca3fd6002
help, rename wiki to documentation (#1751)
* remove ENDMETHOD comments

* help, rename wiki to documentation

help, rename wiki to documentation

remove action from router and action definitions
2018-08-05 08:08:28 +02:00
Christian Guenter
a72edf9725 Remove 'Stage' from diff page
After this commit is applied it's no longer possible to stage
at the diff page. This simplifies the screen flow.
2018-08-04 09:49:23 +02:00
larshp
21bd0ec64c remove link to plugins #1449
remove link to plugins #1449
2018-07-07 08:33:52 +00:00
Christian Guenter
6dfb6316c6 Repository overview page 2018-07-01 16:47:28 +02:00
christianguenter2
ea798193d0 Block commit/push if code inspection has errors
- new local setting to set check variant
- new local setting to block pull if code inspector check fails
- check is executed before staging
- new page to display code inspector results
2018-06-28 13:21:29 +02:00
christianguenter2
4662883723 Introduce ZIF_ABAPGIT_POPUPS
- create popups with factory ZCL_ABAPGIT_UI_FACTORY
- inject test doubles with injector class ZCL_ABAPGIT_UI_INJECTOR
2018-06-15 11:21:48 +02:00
Christian Guenter
2c80628de3 implement annotated tags 2018-05-26 22:16:43 +02:00
Lars Hvam
e2b430779d
clone without pull #832 (#1371)
* create online without pull #832

* update tutorial

* fix indentation
2018-05-11 10:14:51 +02:00
Lars Hvam
b9cc65017f
Code inspector (#1272)
* code inspector

+ delete unused methods
+ move methods to private
+ remove commented code

* few more
2018-03-28 08:08:20 +02:00
Lars Hvam
936e500f0e
cleanup persistency package (#1270)
* ZCL_ABAPGIT_PERSIST_MIGRATE cleanup old migration

* delete ZCL_ABAPGIT_SERVICES_DB

by refactoring use to GUI pages

* pretty settings in db overview page
2018-03-26 13:54:05 +02:00