Commit Graph

53 Commits

Author SHA1 Message Date
Lars Hvam
bb9462f979
new class zcl_abapgit_ui_core_factory (#7194) 2025-04-08 07:10:40 +02:00
Marc Bernard
03dfdb072c
Fix extended check issues - Part 4 (#7089)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2024-12-05 17:41:31 +01:00
Alexander Tsybulsky
3bfb2be6ab
Where used page (#6897) 2024-04-19 07:51:59 +02:00
Francisco Milán
105a202f8c
Fix typos within the code base (#6858) 2024-03-16 10:24:16 +01:00
francisco-milan
bac2666e51
Fix typos and adjust comments within the codebase (Cont'd) (#6786) 2024-02-01 08:21:41 +01:00
Marc Bernard
caaa543b37
Refactor: Naming of class constants (#6529) 2023-10-04 09:20:07 -04:00
Fabian Lupa
a13798408d
Move up ON_EVENT exit call (#6498)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-09-18 11:37:16 -04:00
Lars Hvam
6369c57c56
decouple emergency mode from ui core (#6364) 2023-07-22 15:45:12 +02:00
Alexander Tsybulsky
e2b2f1712d
Refactoring in settings-remote (WIP) (#6300)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-06-01 17:39:41 +02:00
Marc Bernard
84e5883cd8
Consolidate GUI actions (#6296) 2023-05-23 18:03:31 +02:00
Alexander Tsybulsky
a660f0114e
Modals unification, in-page, own page, better abstraction, on example of settings_remote page (#6277)
Co-authored-by: Marc Bernard <marc@marcbernardtools.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: lars <larshp@hotmail.com>
2023-05-21 14:44:04 +02:00
Alexander Tsybulsky
abf5bd268b
Refactoring of DB pages, and new UI features (#6134) 2023-03-14 18:04:30 +01:00
Lars Hvam
e325a4ba92
refactor: remove use of w3htmltab (#6063) 2023-02-13 07:27:38 +01:00
Lars Hvam
5e070bdc24
zif_abapgit_html_viewer do abstraction (#6037) 2023-02-04 09:57:30 +01:00
Lars Hvam
9675ad6007
Replace use of type W3URL with string (#4874)
* replace W3URL with string

* fixes

* ASSERT strlen( iv_url ) <= 250.
2021-07-21 11:41:56 +02:00
Christian Günter
6f8e3f45fa
Set focus: fix code inspector warning + improve error handling (#4843)
* Set Focus: fix code inspector warning 

+ improve error handling

* fix method signature
2021-06-14 10:58:01 +02:00
Marc Bernard
f857194037
Focus HTML control on abapGit startup (#4817)
* Focus HTML control on abapGit startup 

`cl_gui_control=>set_focus` must be called during PBO. Maybe there's a nicer way to pass the HTML control to the PBO.

* Move to output form

* Set focus

* Add autofocus
2021-06-09 17:24:59 +02:00
Alexander Tsybulsky
e5e558a312
Log refactoring, part 1 (#4676)
* log: new features

* log in exception

* log via gui_services

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-27 10:57:57 +01:00
Lars Hvam
16ca0fef77
ZCL_ABAPGIT_GUI delete unused GO_PAGE (#4640) 2021-03-15 15:30:21 +01:00
Lars Hvam
da53a04abb
zif_abapgit_html_viewer: refactor CNHT_POST_DATA_TAB & CNHT_QUERY_TABLE (#4499)
* zif_abapgit_html_viewer

* fix syntax
2021-02-12 11:05:46 +01:00
Marc Bernard
40331ee80f
Follow-up HTML viewer exceptions (#4404)
* Follow-up HTML viewer exceptions

Properly catch HTML viewer exceptions (follow-up #4396) to avoid dumps

* Add exception

* Add exception

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-12 08:54:03 +01:00
Lars Hvam
89c77d9e6b
zif_abapgit_html_viewer, change to class based exc (#4396)
* zif_abapgit_html_viewer, change to class based exc

#4381, part A

* catch
2021-01-11 09:59:26 +01:00
Marc Bernard
552024ac3f
UI: Improvements for setting pages (#4229)
* UI: Improvements for setting pages

- Better navigation between settings pages
After jumping between setting pages, the back button will go to last page before navigating to the settings (ie "back with bookmark")
- Add commit work

* Lint + router

* Jump repo view to settings

* Lint

* Conflict

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-26 11:54:49 +01:00
Marc Bernard
9e385c264e
UI: Add help buttons to "New Online/Offline" (#4189)
* UI: Add help buttons to "New Online/Offline"

- Add help button to both dialogs linking to docs.abapgit.org
- Clicking the button brings up the documentation inside the GUI HTML viewer
- Enhancement to `zcl_abapgit_gui` and `zcl_abapgit_html_viewer_gui` to properly handle 'Back' when navigating through Internet pages

* Open help in external browser

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-18 07:33:00 +01:00
Lars Hvam
c4f75fc5a8
ZCL_ABAPGIT_CONVERT refactor (#4161)
* ZCL_ABAPGIT_CONVERT  refactor

this removes calls to function modules, replacing with class based equivalents, or all custom ABAP implementations

* rename local variables
2020-11-12 09:00:32 +01:00
Marc Bernard
bdc44f7476
Remove self-references (#4115)
* Remove self-references

Remove unnecessary self-references (me->)

https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-method

* 702: Fix syntax error

No chaining with EXPORTING & CHANGING

* remove addiontal me, update abaplint config

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:25:27 +01:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
Alexander Tsybulsky
555f2f3d0b
html event abstraction, phase 1 (#3900)
* event class, interface and gui

* router adaptation

* rest of the pages

* linter fixes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-19 07:57:39 +02:00
Marc Bernard
475f67d1d8
Remove trailing spaces in HTML output (#3893)
* Remove trailing spaces from html

* Return string size
2020-09-17 17:07:46 +02:00
Lars Hvam
9f396366cd
gui refactoring, for web edition (#3890)
* put cl_gui_html_viewer behind an interface

* cleanup

* injectable html viewer

* method_parameter_names, exclude zif_abapgit_html_viewer

* fix whitespace

* public get_asset_manager

* Update abaplint.json

* add prefixes
2020-09-16 12:39:23 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Marc Bernard
fe95dc7e5f
abapGit Emergency Mode (#3756)
* abapGit Emergency Mode

On rare occasions, it is necessary to edit the abapGit settings to overcome an issue (example: https://github.com/larshp/abapGit/issues/3701). 

This enhancement allows you to start abapGit in "emergency mode", which directly shows the "Database Utility" for you to view or edit any setting. 

How to start abapGit in "Emergency Mode":

1. Go to transaction SU3 to maintain your user profile
2. Maintain parameter DBT with value "ZABAPGIT" (all-caps).
3. Start abapGit
4. After exiting abapGit, go back to SU3 and remove parameter DBT

* Update ref-database-util.md

* Add files via upload

* Update ref-database-util.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-22 09:55:33 +02:00
Lars Hvam
867c74701f
remove some unused variables (#3719)
* remove some unused variables

* more unused
2020-08-09 08:44:54 +02:00
Shai
15f55276e1
Fix issue 3597 (#2 try) (#3601)
* Fix issue 3597 (#2 try)

When abapGit is being executed on SAP GUI for HTML, all the links don't work (don't do anything because SAPEVENT isn't being passed back to the application server).

* Fix build errors of previous commit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-11 08:28:41 +02:00
Lars Hvam
aec7468aad
Type Hunting (#3414)
* Type Hunting

* update

* update

* flag
2020-05-26 05:55:28 +02:00
Alexander Tsybulsky
5c4c0b882e
Gui refactoring - part 5 (#3403)
* refactor mi_gui_services to getter

* zif_html->set_title (for debug of postponed parts)

* add set_title to all postponed parts

* gui optional rollback on error

* forgotten gui_services call

* docs

* remove gui_page redirect #3404

* forgotten html~set_title in hotkey class

also renamed render_js_part into render_scripts for unification and reuse register_deferred_script - this is why I lost it int the first place

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-24 10:42:06 +02:00
Alexander Tsybulsky
310d8673dd
Gui refactoring, chapter 3 (#3355)
* zcl_abapgit_html_parts primitive

* integrate parts in GUI

* bughunting and renames

* scripts collection, move hotkeys js to parts

* linter fixes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-13 12:58:43 +02:00
Alexander Tsybulsky
c056076170
Gui refactoring 2 (#3338)
* hotkeys refactoring: draft logic

- new interfaces
- gui services binding
- move render to zcl_hotkeys
- move global hotkeys to hotkeys class
- remove unnecessary stuff from gui_page

* implement zif_abapgit_gui_hotkeys in rel.pages

* settings page draft

* remove zif_abapgit_gui_page_hotkey

* linter fixes

* finalize rendering logic

* finalize settings

* linter fix

* sorting tweak

* fix abapgit_full work

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-05-08 10:26:54 +02:00
Alexander Tsybulsky
0eb22a0c87
Gui refactor, part 1 (#3289)
* gui component and event registering

* remove iv_prev_page from event_handler if

* constructors raising zcx_abapgit_exception

* get_gui_services - UT friendly

* linter fixes

* more linter fixes

* zif_gui_services stub all methods

* linter fix

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-07 10:30:43 +02:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
Lars Hvam
eb7e819b25 refactoring, delete unused variables and methods (#3203)
* zlib

* xml

* processor

* shi5

* remove unused filter parameter

* pinf cleanup

* ssfo delete empty method

* highlighter

* gui page res, remove unused

* remove unused in diff class

* adt link

* gui, remove 2 unused parameters

* branch overview
2020-02-09 09:38:17 +01:00
Christian Guenter
bae1e21c5b Refactoring: Delete unused variables 2020-01-13 18:41:52 +01:00
Lars Hvam
b42f3bc485
Refactoring (#3134)
* fully type constants

* moving to single line

* move to single line

* enable keep_single_parameter_on_one_line
2019-12-28 12:11:32 +01:00
Christian Günter
5081ddf7d0 Improve error information - HTML error message (#2775)
* Improve error information

With this commit errors that are raised with zcx_abapgit_exception=>raise
and issued with message are enriched with two additional functions.

1) Go to source
Navigates to the source code position where zcx_abapgit_exception=>raise
is called

2) Callstack
Shows a popup with the full callstack and the possibility to navigate to
the source of each line with double click

This feature requires the full abapGit repository. Without nothing
changes.

* issue messages directly

* zcx_abapgit_exception: adapt callstack handling

- callstack as attribute
- export callstack to ABAP memory only when SAPGui is available

* rename memory id

* Add comment why we don't delete callstack from MEM

* cleanup

* first try html error display

* add some comments

* add longtext

* goto_source and callstack implemented

* part 2

* remove

* fix

* add close button

* fix long classname

* fix linter

* add jump to SE91

* fix lintmr

* fix and cleanup

* fix linter

* fix linter

* fix eslint

* fix linter

* remove message class

* remove superfluous constant

* add missing method implementation

* refactor

* add hotkey for message longtext toggling

* hotkey 2

* refactor + resize callstack popup

* Refactoring: simplify control flow

* fix goto callstack for merged abapGit

* refactor: simplify control flow

* Refactoring: introduce message helper

* fix linter

* remove TODO pragmas

* ren. render meth + move zcl_abapgit_gui_chunk_lib

* refactoring: simplify control flow

* simplify exception handling

* refactor

* refactor

* refactor

* remove duplication

* Rename method

* rename method

* remove superfluous constant

* call ZCL_ABAPGIT_MESSAGE_HELPER dynamically

* cleanup

* Improve UX

* fix linter

* remove hotkey
2019-07-28 03:46:53 -07:00
Alexander Tsybulsky
df0aca8272 Improve css preprocessing (#2765)
* improve assetman get_text_asset

* move css_processor to ui_core, reuse get_text_asse

* fix %26 refactor UTs

* zcl_abapgit_gui_html_processor

* if fix

* replace core logic

* comment finetuning

* linter fixes

* more linter fixes

* fix UTs, based on review
2019-07-01 20:53:43 -07:00
Lars Hvam
f6e8332754
Cleanup (#2753)
* refactor IF

* fix some indentation

* indentation fixes

* indentation fixes

* indentation

* indentation
2019-06-25 03:02:51 -07:00
Fabian Lupa
7f04d59bf9 Belize theme (#2733)
* Add Belize theme

* Implement polyfill for CSS variables

* Fix CSS variables with spaces in values

* Always load default theme and add others on top

* Adjust theme CSS for use with variables

* Support variables referencing variables in CSS

* Adjust themes

* Add font size to theme

* Skip asset registration for unused themes

* Unify theme greyscale

* Refactor CSS preprocessor

* Refactor CSS preprocessor, add basic tests

* Fix linter issues

* Always load theme asset

Otherwise switching does not work
2019-06-25 03:02:40 -07:00
Frederik Hudák
c679d11d7b Change behavior of second back button to go home (#2679)
* Change behavior of second back button to go home

* Change logic as proposed

* Don't go to tutorial page on exit

* Final changes

* Fix abaplint
2019-06-13 22:59:18 -07:00
Alexander Tsybulsky
2fdff035be unify convert utils, part1 2019-04-24 07:59:06 -07:00
Alexander Tsybulsky
d22f5af1ab rewrite gui error handler 2019-03-28 22:57:39 -07:00