Commit Graph

1689 Commits

Author SHA1 Message Date
Lars Hvam
1abce8e84c
Merge pull request #1564 from EduardoCopat/1280
validate sub and super packages from installed repos
2018-07-06 14:29:36 +02:00
larshp
6db1b2fbfa pretty print 2018-07-06 12:20:01 +00:00
Lars Hvam
0fa0c3bfe9
Merge pull request #1534 from christianguenter2/issue_1533
delete empty packages
2018-07-06 14:13:47 +02:00
COPAT
e3676de797 validate sub and super packages from repos
validate sub and super packages from repos
2018-07-05 23:35:29 +02:00
Christian Guenter
ad5ae2a185 delete empty packages 2018-07-05 23:19:32 +02:00
Michael Käsemann
28a1554526 Limit Progress Indicator Updates
Fixed an issue with the progress indicator updates, where updates of the progress indicator would flush the message queue of SAP GUI and cause a GUI crash or hang.
The problem is described in SAP note #2084109 and seems to occur for large repositories (especially after installing SAP GUI 7.50 PL6)
2018-07-05 13:55:59 +02:00
Lars Hvam
6f54a1e9ff
Merge pull request #1553 from flaiker/requirements-ui
Add UI for requirements in repo settings
2018-07-03 07:45:29 +02:00
Lars Hvam
55c77d55f3
Merge pull request #1551 from christianguenter2/issue_1544
add created_by and created_at to repo xml
2018-07-02 19:55:52 +02:00
Lars Hvam
18709bdf74
Merge pull request #1550 from christianguenter2/issue_1543
New repository overview page
2018-07-02 19:50:17 +02:00
Lars Hvam
f1786cb405
Merge pull request #1541 from larshp/issue_1539
Delete PARA after DTEL, #1539
2018-07-02 17:29:53 +02:00
Lars Hvam
b39bab5363
Merge pull request #1538 from larshp/issue_1537
TABL: check existence before SELECTing
2018-07-02 17:29:38 +02:00
Christian Guenter
59128df664 downport code inspector page 2018-07-02 10:38:23 +00:00
Fabian Lupa
127f5a3c9c Remove unused action decode methode 2018-07-02 00:51:38 +02:00
Fabian Lupa
43e91a6296 Add UI for requirements in repo settings
Fixes #1547
2018-07-01 18:27:07 +02:00
Christian Guenter
1c59b131b7 add created_by and created_at to repo xml 2018-07-01 15:53:56 +00:00
Christian Guenter
6dfb6316c6 Repository overview page 2018-07-01 16:47:28 +02:00
Christian Guenter
31fb79f915 Fix naming in file_status 2018-06-30 09:27:46 +00:00
larshp
bd7313b472 Delete PARA after DTEL, #1539 2018-06-28 13:49:32 +00:00
Christian Guenter
10b29556f7 fix bug in run_code_inspection 2018-06-28 13:47:07 +00:00
larshp
dcc765d013 TABL: check existence before SELECTing 2018-06-28 13:11:42 +00:00
larshp
f1ffa6eb26 fix FUGR locking problem
plus show sy-subrc in case of errors from RPY_DYNPRO_INSERT
2018-06-28 12:29:29 +00:00
larshp
eeb07b0e3f 1.70.0 2018-06-28 12:03:30 +00:00
Lars Hvam
52fb9858ff
Merge pull request #1532 from christianguenter2/1460
move db util pages to separate package
2018-06-28 13:41:58 +02:00
Lars Hvam
4e4dac57dc
Merge pull request #1529 from christianguenter2/exp_WAPA_better_diff
WAPA: better delta handling
2018-06-28 13:41:15 +02:00
Lars Hvam
cda961dbe1
Merge pull request #1527 from christianguenter2/tag_popups
tag popups: dependency injection
2018-06-28 13:33:55 +02:00
christianguenter2
ea798193d0 Block commit/push if code inspection has errors
- new local setting to set check variant
- new local setting to block pull if code inspector check fails
- check is executed before staging
- new page to display code inspector results
2018-06-28 13:21:29 +02:00
christianguenter2
557ae3279f move db util pages to separate package 2018-06-28 12:04:25 +02:00
Christian Guenter
a3d26b9901 WAPA: better delta handling 2018-06-26 11:01:42 +02:00
Christian Guenter
fb91909947 tag popups dependency injection 2018-06-25 11:15:46 +02:00
Lars Hvam
307c1395d2
Merge pull request #1523 from christianguenter2/issue_437
Implement IS_LOCKED for W3*, TTYP, TRAN, SSFO, SSST
2018-06-21 14:28:35 +02:00
Lars Hvam
016e66244d
Merge pull request #1522 from christianguenter2/issue_1521
Delete: check if any object is locked
2018-06-21 14:28:01 +02:00
Lars Hvam
f79e4b7f7b
Merge pull request #1520 from christianguenter2/issue_1512
add commit to toggle_favorites
2018-06-21 14:27:44 +02:00
christianguenter2
002f5ba73d Implement IS_LOCKED for W3*, TTYP, TRAN, SSFO, SSST 2018-06-19 18:05:09 +02:00
Christian Guenter
79a0a8fa85 Delete: checks if any object is locked 2018-06-19 13:32:25 +00:00
Christian Guenter
e167464f1d add commit to toggle_favorites 2018-06-19 11:24:00 +00:00
larshp
fa94fa8ea1 unexpected folder structure #1425
treat objects as non existing when outside the starting folder
2018-06-19 08:16:55 +02:00
Lars Hvam
145a82e9ef
Merge pull request #1518 from christianguenter2/issue_1514
Dependency injection for ZCL_ABAPGIT_SAP_PACKAGE
2018-06-18 15:46:34 +02:00
larshp
cac21f2b37 CHAR: implement is_locked 2018-06-18 15:41:13 +02:00
Christian Guenter
36f257f0bb Dependency injection for ZCL_ABAPGIT_SAP_PACKAGE 2018-06-18 15:37:16 +02:00
Lars Hvam
b6894a5e67
Merge pull request #1517 from christianguenter2/issue_437
Block pull if any of deserialized object is locked
2018-06-18 15:32:07 +02:00
Lars Hvam
838769d0bc
Merge pull request #1516 from FreHu/master
Fixed error message when committing without author name
2018-06-18 15:23:47 +02:00
Lars Hvam
b071d6e837
Merge pull request #1513 from larshp/char
CHAR support, #1511
2018-06-18 15:22:49 +02:00
christianguenter2
6521d09470 Block pull if any of deserialized object is locked 2018-06-18 14:18:58 +02:00
Frederik Hudák
7e4285c1a8 Fixed error message when committing 2018-06-18 09:21:51 +02:00
larshp
1290dcec93 CHAR support, #1511 2018-06-17 12:29:29 +00:00
larshp
9f75d6bd2b refresh repo cache after deletion #1482 2018-06-17 08:23:56 +00:00
larshp
a1e23739b2 1.69.1 2018-06-17 07:58:52 +00:00
Lars Hvam
07955081eb
Merge pull request #1508 from larshp/status
file_status, more testing
2018-06-17 09:50:43 +02:00
Lars Hvam
ad0d06e4d0
Merge pull request #1507 from larshp/issue_1502
TABL: consider DD12L in changed_by #1502
2018-06-17 09:50:14 +02:00
Lars Hvam
4ae6a8cabb
Merge pull request #1506 from christianguenter2/popup_interface2
Introduce ZIF_ABAPGIT_POPUPS
2018-06-17 09:50:01 +02:00
christianguenter2
4662883723 Introduce ZIF_ABAPGIT_POPUPS
- create popups with factory ZCL_ABAPGIT_UI_FACTORY
- inject test doubles with injector class ZCL_ABAPGIT_UI_INJECTOR
2018-06-15 11:21:48 +02:00
larshp
a366fed833 file_status, more testing
old broken test removed
2018-06-15 09:20:42 +00:00
larshp
d8a5f395ea TABL: consider DD12L in changed_by #1502 2018-06-15 08:12:42 +00:00
larshp
9352ddbf3f SEO_CS_CACHE downport #1414 2018-06-15 07:29:13 +00:00
Lars Hvam
4f59c42fb4
Merge pull request #1501 from christianguenter2/issue_1390
Introduce injector class
2018-06-15 09:10:03 +02:00
Christian Guenter
6a9acb8a1b add injector class 2018-06-14 20:33:34 +02:00
Christian Guenter
7b9578a11b implement missing interface methods 2018-06-14 18:25:00 +00:00
Lars Hvam
eec7a7d096
refactor file status unit tests (#1499)
* refactor file status unit tests

one method per check
tests in ltcl_file_status2 now successful

* more tests

add helper class
2018-06-14 08:13:37 +02:00
Lars Hvam
602bdf6d96
Merge pull request #1498 from christianguenter2/issue_1494
SSFO deserialization: catch cx_ssf_fb
2018-06-14 06:29:05 +02:00
Lars Hvam
b7fc27cfcf
Merge pull request #1497 from christianguenter2/issue_1493
Pass log object to user exit method change_tadir
2018-06-14 06:28:46 +02:00
Lars Hvam
b71b96fc9f
Merge pull request #1496 from larshp/repo_srv
interface for ZCL_ABAPGIT_REPO_SRV
2018-06-14 06:27:51 +02:00
Lars Hvam
de23d5bf95
Merge pull request #1484 from larshp/issue_1390
first dependency injection, TADIR #1390
2018-06-14 06:27:04 +02:00
Christian Guenter
ce89e75eb9 SSFO deserialization: catch cx_ssf_fb 2018-06-13 19:39:35 +00:00
Christian Guenter
a38d9feaff Pass log object to user exit method change_tadir 2018-06-13 19:15:53 +00:00
larshp
45aa71f2da interface for ZCL_ABAPGIT_REPO_SRV 2018-06-13 17:28:56 +02:00
Lars Hvam
b7c045210b
Merge pull request #1490 from filak-sap/issue_1446
Use the required transport type
2018-06-13 06:53:54 +02:00
Jakub Filak
fb6efabfb9 tp: use the correct transport type in the tr popup
We are developing in an infinity system which is somehow cloned into a
new releases system. When we need to backport a bug fixes we do
cherry-pick the commits and pull them the release system. However, in
those systems we need to use the task type Repair.

Hence, we need to overwrite the default value of the parameter
wi_task_type of the function TRINT_ORDER_CHOICE which is 'S'
(Development/Correction) with the value 'R'.

I use the function TRINT_GET_REQUEST_TYPE and for the sake of simplicity
I assume that it is enough to know the transport type of the repository
package - in other words, it is no necessary to check every deserialized
object.

Related to #1446
2018-06-12 13:33:49 +02:00
Jakub Filak
56c58b7a29 SAP Package: add the method get_transport_type
For the parameters WI_ORDER_TYPE and WI_TASK_TYPE of the function
TRINT_ORDER_CHOICE called from the method popup_transport_request
of the class zcl_abapgit_popups.

Sometimes we need a repair task but the function TRINT_ORDER_CHOICE
searches for Development/Correction tasks.

I hope that we can decide what task type is needed by a package (DEVC).

Related to #1446
2018-06-12 13:33:49 +02:00
Lars Hvam
f846f250a6
Merge pull request #1492 from christianguenter2/1355
disable "no changes" for offline projects
2018-06-12 08:42:20 +02:00
Christian Guenter
a62eae188a disable "no changes" for offline projects 2018-06-11 14:49:20 +00:00
larshp
334ce44c0d DDLS: fix dump #1488 2018-06-11 12:03:59 +02:00
Christian Guenter
3e3cd365a8 Quick fix: duplicate type definition 2018-06-10 17:51:21 +00:00
larshp
4e67e884de first dependency injection #1390
* extract public methods of ZCL_ABAPGIT_TADIR to new interface
* create factory ZCL_ABAPGIT_FACTORY
* refactor existing calls
2018-06-10 12:11:48 +00:00
Lars Hvam
fbadb3537b
Merge pull request #1481 from christianguenter2/tadir_userexit
New exit: change_tadir
2018-06-10 13:57:28 +02:00
larshp
4219c6d162 cl_aunit_assert is obsolete 2018-06-10 11:45:39 +00:00
Christian Guenter
c7179ed509 new exit: change_tadir 2018-06-10 10:59:00 +02:00
larshp
dcf423bc09 main package is also part of repo #1477 2018-06-10 06:24:13 +00:00
larshp
806fbe1a69 1.69.0 2018-06-09 09:54:20 +00:00
Lars Hvam
6af7b9730e
Merge pull request #1476 from christianguenter2/1355
fix gui: show changes only
2018-06-09 11:51:00 +02:00
Lars Hvam
745a10af71
Merge pull request #1474 from christianguenter2/1471
fix checkout annotated tags
2018-06-09 11:50:39 +02:00
Lars Hvam
bd1fefd41d
Merge pull request #1468 from filak-sap/issue_1446_check_ddls
Mass activation: re-check DDIC objs in transport
2018-06-09 11:50:25 +02:00
Lars Hvam
63318afa88
Merge pull request #1465 from christianguenter2/1464
set new remote: supply remote SHA1
2018-06-09 11:49:45 +02:00
Lars Hvam
3e61a0fdfa
Merge pull request #1430 from juancarlosrodriguezf/master
FORM: Error of duplicity because SPRAS is case sensitive
2018-06-09 11:49:19 +02:00
Christian Guenter
8ddeacade5 fix gui show changes only 2018-06-08 08:35:20 +02:00
Christian Guenter
6afa45c5ed fix checkout annotated tags 2018-06-07 21:05:11 +02:00
Lars Hvam
9f5eebf404
Merge pull request #1472 from christianguenter2/1440
Deactivate pull after switching branches and tags
2018-06-07 20:38:45 +02:00
Christian Guenter
8074aa3272 COMMIT WORK AND WAIT after switching tags 2018-06-07 17:30:43 +00:00
Christian Guenter
c32306f54c deactivate pull after switching branches 2018-06-07 17:01:14 +00:00
Jakub Filak
17b808c8a5 Mass activation: re-check DDIC objs in transport
DDLS objects are not cheked in a transport in their deserialize method.
The parallel activation does not call RS_WORKING_OBJECTS_ACTIVATE which
checks in the activated object in a transport.
Therefor, DDLS objecst are never checked in a transport when
the parallel activation is in place (the option experimental features
is enabled - which is enabled by default on all our systems).

I wanted to use TRINT_OBJECTS_CHECK_AND_INSERT because this function
is used by ADT:

CL_WB_ADT_REST_RESOURCE~post
    CL_WB_ADT_REST_RESOURCE_DATA
    ~if_wb_adt_rest_resource_data~get_transport_key
        CL_WB_OBJECT~get_transport_key -> PGMID%3DR3TR, OBJTYPE%3DDDLS
    CL_WB_ADT_REST_RESOURCE~lock
        CL_WB_ADT_REST_RESOURCE~check_obj_in_transport_request
            CL_ADT_CTS_MANAGEMENT~check_objects_in_request
                CL_ADT_CTS_MANAGEMENT~LCL_DB_PERSISTENCE~check_objects
                    CALL FUNCTION CTS_WBO_API_CHECK_OBJECTS
                        CALL FUNCTION TRINT_WBO_IMPL_CHECK_OBJECTS
                            SAPLCTS_WBO_API_IMPL /
                            LCTS_WBO_API_IMPLF06 /
      FORM CALL_OBJECTS_CHECK_AND_INSERT
                                CALL FUNCTION
                                TRINT_OBJECTS_CHECK_AND_INSERT


But it is not enough to call this function, hence, I use RS_CORR_INSERT
which was mentioned by @larshp in our slack conversation. The function
internally use calls TRINT_OBJECTS_CHECK_AND_INSERT.

I tested this patch with modification of a CDS view and also with 
adding a new CDS view.

Closes #1466
2018-06-07 16:10:23 +02:00
juancarlosrodriguezf
857947b03d
Use the 2-character code for language. Downwards compatibility.
Check first the new 2-character file name, if fail, use the old name.
2018-06-07 12:02:24 +02:00
Christian Guenter
41d09125d4 set new remote: supply remote SHA1 2018-06-07 11:01:56 +02:00
larshp
61fb07bffc 1.68.3 2018-06-06 14:44:22 +00:00
Lars Hvam
2f2712d146
Merge pull request #1463 from christianguenter2/1088_01
redesign create tag page
2018-06-06 16:40:00 +02:00
Lars Hvam
21889dddf7
Merge pull request #1462 from filak-sap/issue_1427
TABL: ignore the unused field RESERVEDTE
2018-06-06 16:38:32 +02:00
Lars Hvam
5baeaf070c
Minor changes (#1461)
* remove double space after IF

* remove accesses to table bodies

* remove parameter name where possible

* identical code in conditions
2018-06-06 16:24:15 +02:00
Lars Hvam
12c48ebb50
fix dump #1457 (#1459) 2018-06-06 16:23:36 +02:00
Lars Hvam
41344dec3a
news feature #1450 (#1453)
now works for both "/abapGit" and "/abapGit.git" urls
2018-06-06 16:23:23 +02:00
Lars Hvam
aff81df37e
FUGR: force update of where-used #1441 (#1452)
Updates the where-used after deletion for all includes
2018-06-06 16:23:03 +02:00
Christian Guenter
319abf5b7b redesign create tag page 2018-06-06 14:20:22 +02:00
Jakub Filak
e71358f744 tabl: ignore the unused field RESERVEDTE
The short description contains "(unused)".
For some strange reason, I saw that field set to D in one of our sandbox
systems.

Addresses the issue #1427.
2018-06-06 08:03:51 +02:00