Commit Graph

16 Commits

Author SHA1 Message Date
Marc Bernard
c1873f6bbc
Clean-up unnecessary_pragma (#6565) 2023-10-25 09:07:18 -04:00
Lars Hvam
83b554f75e
refactor call to TEXT_SPLIT (#6366) 2023-07-23 11:10:18 +02:00
Lars Hvam
aac1a14830
exception: clean up unit test (#6078) 2023-02-21 07:24:19 +01:00
Marc Bernard
6485ec50c1
Refactor: MESSAGE ... INTO (#6008) 2023-01-25 09:55:41 +01:00
Fabian Lupa
1052ce6e85
Support direct longtexts in exceptions (#5592)
* Support direct longtexts in exceptions

as opposed to already supported indirect T100-based longtexts

* Lint

* Remove direct longtext variable support

* Add unit tests for exception longtext

* Add longtext message to language mismatch error

* Fix missing preserve_newline handling

* Adjust longtext display in error message box

- Convert newlines to html line breaks
- Indicate if a longtext is available on hover

* Fix duplicate preserve newline handling

* Adjust exception longtext rendering

Render linebreaks as html paragraphs

* Align error message box buttons to bottom right

so they do not move on hover when a longtext is available

* Refactor exception unit tests

* Skip failing transpiled tests

* Adjust longtext indicator for error message

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-06-05 18:40:34 +02:00
Marc Bernard
b331de6bc7
Naming of class constants (#4945)
* Naming of class constants

This is in preparation of enforcing a naming convention for constants in classes/interfaces. At the end, the following lint rule shall be set:

```json
    "class_attribute_names": {
      "constants": "^C_.+$",
...
    },
```

After this, the only remaining constants not following this rule are in `zcl_abapgit_version`.

* Update zif_abapgit_dot_abapgit.intf.abap

* Update zcl_abapgit_gui_chunk_lib.clas.abap

* Update zcl_abapgit_gui_router.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-14 16:47:48 +02:00
victorizbitskiy
73496a2755
Refactor: Exception handling #4852 (#4869)
https://github.com/abapGit/abapGit/issues/4852
2021-07-13 09:13:25 +02:00
Lars Hvam
7c1753613a
remove use of cl_message_helper (#4205) 2020-11-19 15:22:36 +01:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
Marc Bernard
42c909e688
Refactor: Remove dynamic instantiation of ZCL_ABAPGIT_MESSAGE_HELPER (#3966)
* Refactor: Remove dynamic instantiation of ZCL_ABAPGIT_MESSAGE_HELPER

Consolidate `ZCL_ABAPGIT_MESSAGE_HELPER` features into `ZCX_ABAPGIT_EXCEPTION` and removes helper.

* Remove helper

* Pretty

* Update chunk_lib

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-05 16:50:36 +02:00
Lars Hvam
d36b43defe
line break parameters (#3444)
* line break parameters

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* fix
2020-06-04 15:10:35 +02:00
larshp
6385caade6 fix whitespace and other minor changes 2018-12-20 09:23:01 +01:00
larshp
61087aa131 unit test, one method per case 2018-11-25 09:24:45 +01:00
Fabian Lupa
8186964ef0 Backport ZCX_ABAPGIT_EXCEPTION to 7.02
Co-authored-by: Tapio Reisinger <tr@erp-bt.de>
2018-03-17 13:01:37 +01:00
Fabian Lupa
eac56ae802 Fix exception texts (fixes #1242) 2018-03-17 12:51:29 +01:00
Fabian Lupa
889106b68b Improve error messages (#1213)
* Add T100 support to ZCX_ABAPGIT_EXCEPTION

* Use T100 error messages in DEVC

* Replace zcx_abapgit_exception->text with get_text

* Use SE24 generated constructor in T100 exception
2018-03-10 13:27:09 +01:00