Commit Graph

9 Commits

Author SHA1 Message Date
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
Mauricio Lauffer
a9a505faf4
Prefer RETURNING to EXPORTING (#3204)
* refactor: Prefer RETURNING to EXPORTING

* refactor: Prefer RETURNING to EXPORTING
2020-02-11 10:20:45 +01:00
Christian Guenter
bae1e21c5b Refactoring: Delete unused variables 2020-01-13 18:41:52 +01:00
Lars Hvam
e201bf566f
remove class prefixes if its current class (#3137)
* remove class prefixes if its current class

* Update abaplint.json
2020-01-06 13:20:19 +01:00
Lars Hvam
b42f3bc485
Refactoring (#3134)
* fully type constants

* moving to single line

* move to single line

* enable keep_single_parameter_on_one_line
2019-12-28 12:11:32 +01:00
Christian Günter
56e2ef3983 Fix: Preserve spaces in error messages (#3128)
* Fix: Preserve spaces in error messages

* cleanup + fix linter
2019-12-19 10:30:22 +01:00
Lars Hvam
48222ca050
indentation fixes (#2820)
* indentation fixes

* fixes
2019-07-31 00:49:10 -07:00
Christian Günter
50a6cf8ac9 Improve error information - follow up Part I (#2813)
* Improve error information - follow up Part I

- Bug: remove errorenous regex
- Add tooltip for message id and message class

* Replace text of message link
2019-07-30 05:04:00 -07:00
Christian Günter
5081ddf7d0 Improve error information - HTML error message (#2775)
* Improve error information

With this commit errors that are raised with zcx_abapgit_exception=>raise
and issued with message are enriched with two additional functions.

1) Go to source
Navigates to the source code position where zcx_abapgit_exception=>raise
is called

2) Callstack
Shows a popup with the full callstack and the possibility to navigate to
the source of each line with double click

This feature requires the full abapGit repository. Without nothing
changes.

* issue messages directly

* zcx_abapgit_exception: adapt callstack handling

- callstack as attribute
- export callstack to ABAP memory only when SAPGui is available

* rename memory id

* Add comment why we don't delete callstack from MEM

* cleanup

* first try html error display

* add some comments

* add longtext

* goto_source and callstack implemented

* part 2

* remove

* fix

* add close button

* fix long classname

* fix linter

* add jump to SE91

* fix lintmr

* fix and cleanup

* fix linter

* fix linter

* fix eslint

* fix linter

* remove message class

* remove superfluous constant

* add missing method implementation

* refactor

* add hotkey for message longtext toggling

* hotkey 2

* refactor + resize callstack popup

* Refactoring: simplify control flow

* fix goto callstack for merged abapGit

* refactor: simplify control flow

* Refactoring: introduce message helper

* fix linter

* remove TODO pragmas

* ren. render meth + move zcl_abapgit_gui_chunk_lib

* refactoring: simplify control flow

* simplify exception handling

* refactor

* refactor

* refactor

* remove duplication

* Rename method

* rename method

* remove superfluous constant

* call ZCL_ABAPGIT_MESSAGE_HELPER dynamically

* cleanup

* Improve UX

* fix linter

* remove hotkey
2019-07-28 03:46:53 -07:00