Commit Graph

5127 Commits

Author SHA1 Message Date
Marc Bernard
c88e1aba5d
AFF: Fix exception handling (#5609)
Catch exceptions when calling `TADIR` deletion

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-06-02 10:06:01 +02:00
Marc Bernard
380f297bc7
DSYS: Fix exceptions (#5608)
Replace exceptions with correct names
2022-06-01 11:18:22 +02:00
Marc Bernard
1a394ff173
INTF: Remove syntax warning (#5607)
Replaces with exception with parent
2022-06-01 10:33:57 +02:00
Lars Hvam
24deed4d60
update npm dependencies (#5605) 2022-06-01 08:05:55 +02:00
Fabian Lupa
799334dfe2
Add exposure to workflow class attributes (#5603)
* Add exposure to workflow class attributes

* Add constant seoc_state_implemented to abaplint

* Also add seoc_state_implemented to ci/abaplint

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-31 20:33:17 +02:00
Fabian Lupa
c04f7b8d7f
Show installation flavour in footer (#5604) 2022-05-31 18:02:02 +02:00
Marc Bernard
a0bd3a903c
INTF: Add to deletion transport and fix locking (#5562)
- Add object to transport on deletion
- Unlock object (proxy interface) in case of errors
2022-05-31 17:42:58 +02:00
Marc Bernard
36ce3944ae
Repo view: Source system not part of item sig (#5599)
Source system is not part of item signature but supplemental info for item.

Follow-up to #5514
2022-05-31 13:40:41 +02:00
Marc Bernard
bcf01fbfb0
Refactor: Create Tag (#5591)
* Refactor: Create Tag 

Replaces the old style page with a nice HTML form for creating a new tag.

* Update validation

* Allow empty comment and tagger

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-31 09:48:03 +02:00
Gregor Wolf
276ad4e808
Exclude technical language from intf, clas, prog, dtel, doma and tabl (#5598)
* exclude technical language from DOMA

* exclude technical language from DTEL

* exclude technical language from TABL

* exclude technical language from CLAS

* exclude technical language from PROG

* exclude technical language from INTF

* fix abaplint issue: Place pragma at end of statem.

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-05-30 12:18:32 +02:00
Christian Günter
5e7cf0b27e
LXE: Downport (#5597)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-30 10:12:26 +02:00
Fabian Lupa
cbaf3711b4
Exclude technical languages (#5601)
from get_installed_languages in lxe_texts
2022-05-29 14:50:28 +02:00
Marc Bernard
e149594dae
Refactor: is_active logic (#5557)
- Move `is_active` from `zcl_abapgit_objects_super` to `zcl_abapgit_objects_activation`
- Consolidate `is_ddic_type` logic
- Add unit tests for `zcl_abapgit_objects_activation`
2022-05-29 09:47:39 +02:00
Fabian Lupa
288e1008dd
Fix object deletions not working (#5594)
Package is now required for CLAS deletion for RS_CORR_INSERT but was not correctly determined for object deletions because of different field names when using MOVE-CORRESPONDING and another missing assignment.

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-05-28 16:52:33 +02:00
Gregor Wolf
143f7d4d3b
fix: exclude Translation Object Detective language for MSAG objects (#5596)
* fix: exclude Translation Object Detective language

Excludes Translation Object Detective language from serialization
Provides a solution for object type MSAG in issue #5595

* fix: Contains non 7 bit ascii character

* fix: exclude also Pseudo Translation

* refactoring based on the PR suggestion

* fix abaplint issues

* fix further abaplint issues
2022-05-28 12:00:15 +02:00
Marc Bernard
ddd7e47425
Refactor: Commit list popup (#5569)
* Refactor: Commit list popup

- Move popup for selecting a commit to `zcl_abapgit_popup`
- Allow to skip sorting of commits in `zcl_abapgit_git_commit` which often led to "too many commits" error (on GitHub you get the 300 most recent commits)

Popup will be used in `zcl_abapgit_gui_page_sett_remo` and `zcl_abapgit_gui_page_tags` (separate PR)

* Fix test classes

* Replace popup in remote settings

* Remove type

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-24 16:43:46 +02:00
Marc Bernard
ca5023c6d0
CLAS: Add to deletion transport (#5563)
Fix missing transport entry
2022-05-23 18:16:22 +02:00
Marc Bernard
5ae7f618f3
Repo view: Source system for packages/namespace (#5587)
Follow-up to #5514
2022-05-23 15:30:11 +02:00
Marc Bernard
1dd5ebcb42
Fix dump for repos using data tables (#5581)
* Fix dump for repos using data tables

Fixes dump in `zcl_abapgit_data_util` in case the data table does not exist yet.

* Method

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-23 13:50:44 +02:00
NicolasBusson
a8ecd8fb77
Fix dump ASSERTION_FAILED during table content deserialization (#5586)
* Data import: fix dump ITAB_DUPLICATE_KEY

System dumps during serialization of customizing table comprizing of include structures. Example: WCFC_GIL_COMPROP.

* Fix error "Object type TABU is not supported"

* Fix date format incorrect during serialization

* Fix /data/ serialization package issue

* Commit table content after deserialization

* Cleaning some code

* Rollback code change concerning /data/ folder

Doesn't seem to be necessary in the end...

* Renamed variable <tab> to <lt_tab>

* Fix ASSERTION_FAILED table content deserialization

Issue https://github.com/abapGit/abapGit/issues/5585

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-23 10:35:19 +02:00
github-actions[bot]
0e5e3b0cf5
ajson, Automatic Update (#5584) 2022-05-23 09:38:34 +02:00
Lars Hvam
2ffdab2526
Update ajson_mirror.yaml (#5583) 2022-05-23 09:13:59 +02:00
Marc Bernard
97631dd2fe
SICF: Display object name in upper case (#5547)
Align case of object name with other object types
2022-05-21 08:39:38 +02:00
Marc Bernard
7258fdc315
Repo view: Show icon for different source system (#5514)
In case an objects originates from a different system (`<> sy-sysid`), an icon will be shown after the object. On hover, you can see the id of the original system. 

Closes https://github.com/abapGit/abapGit/issues/3865
2022-05-21 08:13:41 +02:00
Marc Bernard
ba425e0318
Repo stats: don't count lines of ignored files (#5576)
Size and lines of code incorrectly included files that are ignored (outside of `/src/`).
2022-05-19 19:35:13 +02:00
Marc Bernard
3a27ff760f
Uninstall: Fix order for dependencies (#5559)
- Set order for uninstalling `WEBI`, `SPRX`, `IOBJ`, `ODSO`, and `PINF`
2022-05-19 11:03:58 +02:00
Marc Bernard
6a84341a27
PINF: Fix error when changing packages (#5560)
- Set parent package for package interface elements
- Raise error in case of mismatched packages
2022-05-19 10:47:15 +02:00
Marc Bernard
eaeba0f1cb
Fix syntax error in systems with BW (#5572)
abapGit should support systems without SAP_BW component. Therefore, references to BW data types have to be replaced by generic types and BW classes have to be replaced by dynamic calls.

Follow-up to #5556

Closes #5565
2022-05-18 22:10:38 +02:00
Marc Bernard
297708b054
Repo view: fix "order by transport" dump (#5571)
* Repo view: fix "order by transport"

Partly regression of #5323

Closes #5570

* Add flag

* Improve sort
2022-05-18 21:25:43 +02:00
Lars Hvam
9f048abeff
CHAR: take only serialize main language into accou (#5566)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-05-18 18:04:40 +02:00
Marc Bernard
6d2510c84e
Fix tag popup message (#5567)
Tag popup is used for delete and switch therefore the message must be moved to the switch method.
2022-05-18 17:54:15 +02:00
Marc Bernard
ee2c77e6af
Refactor: Email validation (#5568)
Move `is_valid_email` to utitlity class for reuse
2022-05-18 17:42:45 +02:00
Marc Bernard
38f99380da
FDT0: Add check of local/transportable apps (#5561)
It's not possible to import local apps into transportable packages or vice versa. The check raises corresponding error messages (and avoids a slew of cryptic errors you would get otherwise).

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-18 15:04:01 +02:00
Marc Bernard
1af60a9f42
SSFO: Avoid side-effect in is_active (#5564) 2022-05-18 14:37:53 +02:00
Christian Günter
722a954c43
Improve error message for language mismatch (#5544)
* Improve error message for language mismatch

* refactor

* refactor

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-17 13:31:25 +02:00
Marc Bernard
5802f0df37
CHDO: Fix deletion of TADIR entries (#5555)
Test mode needs to be set explicitly to false.
2022-05-16 08:26:18 +02:00
Marc Bernard
ff0fc72891
IOBJ/ODSO: Fix errors if objects exist already (#5551)
Implementation worked only for new objects (argh)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-11 12:38:20 +02:00
Marc Bernard
b0a31b0e3b
IAxx: Fix locking of objects (#5545)
Fixes missing locking and unlocking of `IARP`, `IASP`, and `IATU` (other `IAxx` objects are ok)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-11 09:45:56 +02:00
Marc Bernard
d4a69e160a
SHI3: Fix exists check (#5546)
Skip buffer and read object status from DB
2022-05-10 12:03:51 +02:00
Marc Bernard
db91c9bb08
ASFC,SPLO,SPPF: Fix missing transport entry (#5541)
In certain cases, the default transport set by abapGit does not work and there's no API to pass the transport for the object type. Therefore, we need to set the transport via ABAP memory (similar to setting the default package).

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-09 08:11:49 +02:00
Marc Bernard
5127bfdb9d
DDIC: Improve active/inactive check (#5486)
* DDIC: Improve active/inactive check

Use `is_active_ddic` (function `DDIF_STATE_GET`) for all DDIC object types. This is more accurate than the current method (function `RS_INACTIVE_OBJECTS_WARNING`) since it detects newly created but not active objects as well.

* Fix const

* Remove "no active version" error

* Update comment

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-09 08:08:32 +02:00
Marc Bernard
a96fed4b26
ENHC: Fix diffs due to OTR (#5538)
`cl_enh_composite` already handles OTR shorttext and there's no need to use `zcl_abapgit_sotr_handler`.

Update test case:
https://github.com/abapGit-tests/ENHC

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-07 10:04:14 +02:00
Marc Bernard
882a64cb68
UDMO: Fix wrong parameter value (#5540)
* UDMO: Fix wrong parameter value and exceptions

- `mode` is char 1
- fix exception overlap

* subrc

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-07 09:49:15 +02:00
Marc Bernard
13b12e6087
Improve error handling during activation phase (#5506)
When the "Activation Popup" is turned off in "Personal Settings", any errors during activation will lead to "Activation cancelled. Check the inactive objects" which is not very helpful.

The change will add the errors to the abapGit log. 

It will also handle the special case when activation of includes leads to error "Include is used in multiple main programs" (EU 404). In such case, you can turn on the activation popup and repeat the abapGit process successfully.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-07 09:29:19 +02:00
Lars Hvam
f0b3c96474
Align pragma style (#5535) 2022-05-07 09:08:34 +02:00
Marc Bernard
2af39232e6
AVAS,CHDO,DDLS,SPRX: Add objects to transport (#5542) 2022-05-06 12:39:47 +02:00
Marc Bernard
d993a081fa
AMSD: Fix "Step DDIC is only for DDIC objects" (#5539)
AMSD is not supported by mass activation. Assigns AMSD to "Step ABAP"
2022-05-06 12:10:36 +02:00
Lars Hvam
5a5630c198
update to latest npm packages (#5501)
* update to latest npm packages

* update

* update abaplint config to latest
2022-05-06 09:10:03 +02:00
Marc Bernard
73c9763a15
Fix "DB delete failed" (#5534) 2022-05-05 17:11:26 +02:00
Marc Bernard
1b4582bc03
Fix commit message encoding (#5508)
* Fix commit message encoding

- Properly encode % and & symbols
- Add unit test for special characters

Closes https://github.com/abapGit/abapGit/issues/2448

* Exclude testclass

* Comment

* update to 2.0.17

* update to 2.0.18

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-05 15:29:38 +02:00