Commit Graph

37 Commits

Author SHA1 Message Date
Lars Hvam
a0c37350a9
use zcl_abapgit_convert for language code conversion (#6382)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-08-13 13:51:10 -04:00
Lars Hvam
a8bce57373
move get_jumper() to new objects factory (#6363) 2023-07-23 15:07:06 +02:00
Marc Bernard
39d2e88be3
Enhance Serializer Interface - Follow-up (#6233) 2023-04-20 17:34:03 +02:00
Marc Bernard
5f1dc6d5e0
Enhance Serializer Interface (#6229) 2023-04-20 16:20:01 +02:00
Marc Bernard
25bbbf89cd
Refactor: Remove delete_tadir flag (#5949)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-01-06 15:56:12 +01:00
Marc Bernard
0ab3ee0a06
Remove aliases from object classes (#5588) 2022-06-04 10:33:42 +02:00
Lars Hvam
f0b3c96474
Align pragma style (#5535) 2022-05-07 09:08:34 +02:00
Christian Günter
2ba6151355
JUMP: Switch execution order - first specific then generic (#5357)
* Switch jump order

* fix DDLS

* fix SHI3
2022-02-18 05:48:36 +01:00
Marc Bernard
074ae5a69b
Refactor: Calling batch input (#5252)
* Refactor: Calling batch input

Standardizes calling batch input API and handling errors.

* Fix indent

* Add new window

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-10 09:27:17 +01:00
Marc Bernard
ac8bde9f6c
Fix use of sy-langu in object serializers (#4807)
* Fix use of sy-langu in object serializers

- Replace sy-langu variable with mv_language
- Replace sy-langu type with langu (makes it easier to spot sy-langu)
- Enhance generic serializer to use mv_language
- Add unit tests to generic serializer 
- Adjust and simplify serializers that are based on generic class

Closes #2080

* Update scvi+ueno

* Revert scvi

* Langu

* Langu

* Langu

* Langu

* Langu

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-06-01 13:02:42 +02:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
g-back
7871d23fef
XML Input/Output: Remove Aliases (#3898)
* change XML reference to interface

* remove aliases from XML in/out classes

* change XML references to interfaces
2020-09-18 14:01:44 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
Lars Hvam
75812fb17b
less prefixes (#3144) 2020-01-11 09:24:36 +01:00
Lars Hvam
e201bf566f
remove class prefixes if its current class (#3137)
* remove class prefixes if its current class

* Update abaplint.json
2020-01-06 13:20:19 +01:00
Lars Hvam
28e052dbce
serialization, FORM fixes (#2950)
* FORM, tdlines duplicated, closes #2949

* FORM, set TDVERSION to constant, closes #2935
2019-10-07 22:44:50 -07:00
Martin Fuchs
9f2db446b1 simplified GET_DESERIALIZE_STEPS
Since all object handler contains exactly the same CASE statement for STEP definition, I would recommend that each object handler simply returns the STEP he belongs to.
This fix should "simply" issue #2499.
2019-05-05 00:57:52 -07:00
GoWa
21527528c6 call redefined method of IF 2019-03-12 21:49:15 -07:00
larshp
25f6284493 implement GET_DESERIALIZE_STEPS
this is a quick fix, field LATE_DESER will be removed in future
2019-03-12 07:37:56 -07:00
Lars Hvam
3213d0c2dd
Deserialization performance, refactor COMPARE_TO_REMOTE_VERSION (#2438)
* core part refactored #2436

* indentation

* fix implementations

* delete ZCL_ABAPGIT_COMPARISON_NULL

* pretty print

* Update serializers.md

* downport
2019-02-20 22:20:24 -08:00
Lars Hvam
25d4c9ea07
Remove HAS_CHANGED_SINCE #1021 (#2401)
* core part removed

* remove method implementations
2019-02-15 06:51:57 -08:00
Lars Hvam
3f494f091f
Use built-in types (#2306)
* remove uses of DTEL BOOLEAN

* remove uses of DTEL BOOLE_D

* remove uses of DTEL FLAG

* remove uses of DTEL SAP_BOOL

* remove uses of DTEL XFELD

* Update zcl_abapgit_popups.clas.abap
2019-01-20 07:59:24 +01:00
Lars Hvam
610c48d51f
Remove commented code (#2285)
* delete commented code

* delete commented code

* commented code
2019-01-13 10:28:18 +01:00
larshp
e0841e3bec indentation and se80 reorderings
no logic changes
2018-12-26 06:35:55 +01:00
CCapa
13f84140f4 Sapscript : sequence of Windows in tdlines files (#2191)
* Sapscript : sequence of Windows in tdlines files

Hello Lars,

You can find a code modification in the method _read_form of class zcl_abapgit_object_form related to the issue #2188
I have added a logic to sort by windows name the contains of the internal table ET_LINES . It allows to have always thre same sequence of  windows code in the file (xxxxxxxxxxgit.form.tdlines). Then file comparison will work with all export.

Regards
Christophe

* Sapscript : sequence of Windows in tdlines files

Hello Lars,

I have moved the code to a new private method _sort_tdlines_by_windows
But I don't add 'ASSERT sy-subrc = 0.'. 
The reason is that during my tests I found some windows in the form without elements inside (windows is not used anymore but it sill exists. The devlopper ddin't remove it). In this case the result of the ASSERT is a dump.
Using the loop from SY-TABIX there is no risk. If no entry exists in the internal table then the loop is not executed.

if needed I can add the following condition before doing the loop :
       IF line_exists( lt_lines[ tdformat = lv_elt_windows
                                tdline = ls_form_windows-tdwindow ] ).
Christophe

* Sapscript : sequence of Windows in tdlines files

I have done the adjustments for the CLEAR and to be  compatible with 702

Christophe

* Sapscript : sequence of Windows in tdlines files

Whitespace at end of line removed
2018-12-08 13:26:09 +01:00
Christian Günter
36fccd3b52 Fix TADIR handling #2066 (#2078)
* AUTH + FORM: delete tadir

* SFBS + SFBF: delete tadir

* SFSW: synchronous deletion
2018-11-10 08:11:22 +01:00
Domi Bigl
cf05295170 mark inactive objects in repo list #1943 (#2017)
* mark inactive objects in repo list

Inactive object are marked in the repo list
The sort order for changed files is not changed
unchanged inactive files come right after the changed files

* move acitve check to object interface

* add is_active for objects up to F

* add is_active for objects up to P

* add is_active for objects up to T

* add is_active for objects up to X

all core object implement (except SSFO) the standard active check via FM RS_INACTIVE_OBJECTS_WARNING now

* add is_active to plugins bridge - always active

* finish object interface implementation + objects

* add is_active for offline with object interface

* rename returning to RV_

* use returning for serialize

* cleanup, PP, UT
2018-10-31 15:54:57 +01:00
Christian Günter
aa7a5fd01f FORM: record transport request 2018-09-21 09:12:03 +02:00
Lars Hvam
4fa485bf96
Remove superfluous spaces (#1712)
* remove spaces

* remove spaces

* remove spaces

* remove double space
2018-07-29 10:08:54 +02:00
Frederik Hudák
c4639f65ce Removed endmethod and endclass comments - objects folder 2018-07-28 10:10:16 +02:00
Christian Günter
394ea52d61 More is_locked: ENHO, FORM, SFPF, SFPI (#1646) 2018-07-17 07:40:01 +02:00
Johannes Konings
e34d80214e zcl_abapgit_object_form naming convention #1132 (#1628)
* typo corrected "Guide for installing bundle"

* zcl_abapgit_factory naming convention

https://github.com/larshp/abapGit/issues/1132

* zcl_abapgit_object_form naming convention 

https://github.com/larshp/abapGit/issues/1132
2018-07-13 04:30:30 +02:00
christianguenter2
6521d09470 Block pull if any of deserialized object is locked 2018-06-18 14:18:58 +02:00
juancarlosrodriguezf
857947b03d
Use the 2-character code for language. Downwards compatibility.
Check first the new 2-character file name, if fail, use the old name.
2018-06-07 12:02:24 +02:00
juancarlosrodriguezf
c7224bdc26
Error of duplicity because SPRAS is case sensitive
Old code generate error of duplicity because SPRAS is case sensitive, but the name of files not.

New code use the 2-caracteres code for language.

Examples (T002):

SPRAS: 'C' -> LAISO: CS -> 'Czech'
SPRAS: 'c' -> LAISO: CA -> 'Catalan'
2018-05-31 14:54:13 +02:00
Lars Hvam
f14ac831ba
Objects to global (#1187)
* add global classes for objects

* fix metadata

* comment old code

fix serializer class
move missing interfaces

* keep objects and bridge as local

* fix syntax errors

and remove SICF -> tadir dependency, instead tadir -> SICF

* remove dependency TABL -> lcl_popups

* fix indentation

* remove old includes

* fix parser errors

* fix deserializing
2018-02-11 09:16:16 +01:00