Commit Graph

22 Commits

Author SHA1 Message Date
Marc Bernard
8022eafdab
generic object handler: fix special cases (#6444) 2023-08-29 16:29:53 -04:00
Lars Hvam
89f715ed5f
generic object handler: fix unit test (#6399)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-08-23 07:51:08 +02:00
Lars Hvam
05c12aacc9
remove use of seok_pgmid_r3tr & refactor class constructor (#6347) 2023-07-28 06:03:51 +02:00
Marc Bernard
6b6d149cc7
Refactor adding entries to transport (#6232)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-04-23 10:00:35 +02:00
Lars Hvam
a379be196a
AQBG support - ABAP Query: User group (#6155)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-03-17 14:18:29 +01:00
Marc Bernard
25bbbf89cd
Refactor: Remove delete_tadir flag (#5949)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-01-06 15:56:12 +01:00
yellappam
e50a7dcc3c
Clear metadata fields (#5464)
* Add zcl_abapgit_rule and zif_abapgit_rule

* Insert clear and fill logic

* Pass rule to the generic serializer in IWSG class

* Remove extra space

* Remove inline declaration

* Format the code

* Replace CHECK with IF

* Rename class/interface

* Multiple changes

Rename method name
Change method signature
Remove clear field

* loop over all fields of given fields

* Align method call parameters

* Remove class reference for member

* Use string template to convert to type

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-04-26 16:33:21 +02:00
Marc Bernard
250feae861
Add transport for deletions in generic serializer (#5434)
Closes #5421

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 16:41:03 +02:00
Marc Bernard
ac8bde9f6c
Fix use of sy-langu in object serializers (#4807)
* Fix use of sy-langu in object serializers

- Replace sy-langu variable with mv_language
- Replace sy-langu type with langu (makes it easier to spot sy-langu)
- Enhance generic serializer to use mv_language
- Add unit tests to generic serializer 
- Adjust and simplify serializers that are based on generic class

Closes #2080

* Update scvi+ueno

* Revert scvi

* Langu

* Langu

* Langu

* Langu

* Langu

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-06-01 13:02:42 +02:00
Marc Bernard
73576ee60e
Improve error messages (#4472)
* Improve error messages

Pass T100 messages to UI/log

* T100 errors

* APACK

* OO

* DEVC

* DRUL

* DTDC

* SRVB

* OBJS

* Program

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-03 16:31:55 +01:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Lars Hvam
f582225bf8
start refactoring to use XML interfaces (#3796)
* start refactoring to use XML interfaces

#3531

* TABL + TRAN + UDMO + UENO

start using the interfaces for xml instead of class references
2020-08-26 06:50:47 +02:00
Lars Hvam
d36b43defe
line break parameters (#3444)
* line break parameters

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* fix
2020-06-04 15:10:35 +02:00
Lars Hvam
b42f3bc485
Refactoring (#3134)
* fully type constants

* moving to single line

* move to single line

* enable keep_single_parameter_on_one_line
2019-12-28 12:11:32 +01:00
Lars Hvam
714fe7202d
whitespace fixes (#2964)
* whitespace fixes

* fix sql compare operators
2019-10-11 02:50:16 -07:00
Lars Hvam
1dbd4d1912
Refactoring types (#2785)
* align use less different types

* refactor

* updates
2019-07-15 09:33:37 -07:00
larshp
4169d1045a generic serializer: order by primary key #2682 2019-05-29 23:53:50 -07:00
larshp
4a4f556e21 Generic: only unique tables 2019-04-24 07:58:07 -07:00
Martin Fuchs
6e860f53da Avoid DYNPRO_SEND_IN_BACKGROUND while ADT Pull (#2634)
* Avoid DYNPRO_SEND_IN_BACKGROUND while ADT Pull

When ADT (aka ABAP in Eclipse) is used to trigger a pull request, there is no SAPGUI available in the backend system. Whenever a dynpro is called, a DYNPRO_SEND_IN_BACKGROUND short dump occurs.
This commit fixes issue #2632.
Additional remark: In case of a private repository, username and password are passed to the backend system. The ADT backend coding handles this via class ZCL_ABAPGIT_DEFAULT_AUTH_INFO. To avoid sending a password dialog in the backend system (class CL_ABAPGIT_PASSWORD_DIALOG), ZABAPGIT coding needs to be adjusted to take over user/pw from ZCL_ABAPGIT_DEFAULT_AUTH_INFO. I know this is not nice and it would be better to have ZCL_ABAPGIT_DEFAULT_AUTH_INFO in ZABAPGIT. Even the best solution would be to re-use ZCL_ABAPGIT_LOGIN_MANAGER, but I would recommend to refactor this in a new pull request later on...

* Fix abaplint identiation failure 

Fix abaplint identiation failure

* Rest ZCL_ABAPGIT_PASSWORD_DIALOG

Rest ZCL_ABAPGIT_PASSWORD_DIALOG to prelimiary version. 
To be changed in a different pull request....
2019-04-16 22:21:46 -07:00
Jakub Filak
6a01862cd6 Avoid use of the RS package in BASIS systems (#1874)
* objects: use a different constant for 'R3TR'

The constant rs_c_pgmid_r3tr comes from the package RS which is not
available in pure BASIS systems.

The constant seok_pgmid_r3tr comes from the package SEOK and abapGit is
already using another constants from this package - seok_access_*.

Related to #1826

* objects: replace rs_c_true with abap_true

The constant rs_c_true comes from the package RS which is no available
in pure BASIS systems.

I believe that the constant rs_c_true was used by mistake.
The constant was assigned to a variable which is of the type abap_bool
and the variable is initialized with abap_false.

Related to #1826
2018-08-29 12:36:16 +02:00
ThomasPloski
6ea0c465f4 fixes issue #1621 (#1640) 2018-07-14 06:51:20 +02:00
Lars Hvam
7d7def95a5
Generic object handler + ASFC support #1578 (#1590)
* scaffolding #1578

* generic object handler #1578

* fix linter errors
2018-07-10 16:39:49 +02:00