Commit Graph

118 Commits

Author SHA1 Message Date
Marc Bernard
787bc605b0
Propagate codepage conversion errors (#5638) 2022-06-23 07:12:25 +02:00
Marc Bernard
2855e7e7bf
Small git utils improvements (#5611)
* Small git utils improvements

- Saves ~20ms per call of `length_uft8_hex`
- Improve test coverage

* Update test

* Update abap_transpile.json

* no skip, fixed

* Update test

* Update abap_transpile.json

* update

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-06-05 14:37:57 +02:00
Marc Bernard
ddd7e47425
Refactor: Commit list popup (#5569)
* Refactor: Commit list popup

- Move popup for selecting a commit to `zcl_abapgit_popup`
- Allow to skip sorting of commits in `zcl_abapgit_git_commit` which often led to "too many commits" error (on GitHub you get the 300 most recent commits)

Popup will be used in `zcl_abapgit_gui_page_sett_remo` and `zcl_abapgit_gui_page_tags` (separate PR)

* Fix test classes

* Replace popup in remote settings

* Remove type

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-24 16:43:46 +02:00
Christian Günter
f178b2539f
zcl_abapgit_git_commit, update shorttext (#5316)
* update shorttext

* remove shorttext sync
2022-02-02 09:28:25 +01:00
Marc Bernard
65dd5f7568
Update object descriptions - Part 1 (#5314) 2022-02-02 07:31:54 +01:00
Christian Günter
13c4d57dd3
Patch: enable new view options similar to Diff (#5162)
* enable new view options on patch page

* add unit test

* new constant for unchanged lines
2021-11-26 07:41:57 +01:00
Lars Hvam
2bee3c8253
remove unused variables (#5107)
* remove unused variables

* rm

* rm

* rm

* rm

* rm
2021-11-05 15:20:56 +01:00
Lars Hvam
e7e8af832e
align package descripions (#4939)
prefix all package descriptions with "abapGit - "
2021-09-10 10:58:36 -04:00
Lars Hvam
e6bac818cf
git transport: add unit test for parse() (#4889) 2021-08-03 10:33:24 +02:00
Lars Hvam
ddcb538ccd
get_null(), fix syntax error (#4890) 2021-08-03 10:27:24 +02:00
Lars Hvam
2bde0ce55a
simplify get_null() + git branch list: add unit test (#4886)
add unit test which parses the response from hex, ie. containing a real null value

simplify get_null() method, it only returns 1 character, but 2 characters are calculated
2021-08-03 06:47:16 +02:00
Lars Hvam
8068e8fb0e
git transport: move constants to method (#4877)
the constants are only used locally in the method, the definitions have been moved to the method instead of the private section of the class
2021-07-22 06:56:40 +02:00
Christian Günter
53dec3d2e8
Improve secondary key access (#4801) 2021-05-31 07:47:30 +02:00
Christian Günter
9c8e566e58
git transport: fix check report status for GitLab and Bitbucket (#4796) 2021-05-28 06:14:28 +02:00
Christian Günter
1fa51e7c0a
Checkout commit: Improve error message (#4793)
Checkout commit: Improve error message.
Checking out commits is currently limited to branches with less than 99 commits. If this limit is reached a message appears saying 'No commits are available in this branch.'.
After this commit is applied the error message is 'Cannot find initial commit. Too many commits. Action not possible.'.
2021-05-27 14:54:56 +02:00
Marc Bernard
946180abda
Enhanced error handling for git transport protocol (#4778)
Git report status is now properly parsed for unpack and command status. Also includes UTs.

Closes #4776

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-20 11:31:48 +02:00
Mike Pokraka
788d649feb
Limit size of branch overview (#4726)
* Add support for partial logs (WIP)

* Still trying to handle multiple branch origins

* Error message for too many commits

* Remove PDXX

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-03 14:42:34 +02:00
Lars Hvam
7b336a4a71
cleanup unused local variables (#4739) 2021-05-01 09:51:05 +02:00
Lars Hvam
1b9674e620
git transport: error on empty git reply (#4714) 2021-04-25 10:01:10 +02:00
Mike Pokraka
69ac4fd768
Change some masters to main %26 remove unused parameter (#4710)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-19 17:15:47 +02:00
Mike Pokraka
dd6becccbe
Accept remote without HEAD (#4706)
* Accept remote without HEAD

* Update src/git/zcl_abapgit_git_branch_list.clas.testclasses.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-18 11:18:33 +02:00
Lars Hvam
b7d6870077
parsing git branch list, throw errors (#4547)
* parsing git branch list, throw errors

closes #4523

* downport

* fix whitespace

* bugfix
2021-02-21 16:21:34 +01:00
Lars Hvam
5e2d8de52a
/git/, put method get_length under test (#4224)
* /git/, put method get_length under test

add unit tests for method get_length

the method will probably be refactored sometime in the future, I think the bit manipulation can be replaced with some hex, div and bit-mask magic

* fix tabs
2020-11-24 08:02:39 +01:00
Lars Hvam
381d40e35a
ZCL_ABAPGIT_HASH add shorthand methods (#4220)
This adds shorthand methods for the SHA1 calculation of the different git artifacts.
More logic in ZCL_ABAPGIT_HASH, but easier to read and less application logic.
2020-11-23 14:30:31 +01:00
Lars Hvam
266ffb2a7c
/git/: remove unused param, add unit test (#4124)
UPLOAD_PACK_BY_BRANCH
- remove unused parameter EO_BRANCH_LIST

add unit test to ZCL_ABAPGIT_GIT_UTILS
2020-11-03 08:47:12 +01:00
Lars Hvam
df652f0436
delete various unused local variables (#4126) 2020-11-03 08:43:04 +01:00
Marc Bernard
bdc44f7476
Remove self-references (#4115)
* Remove self-references

Remove unnecessary self-references (me->)

https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-method

* 702: Fix syntax error

No chaining with EXPORTING & CHANGING

* remove addiontal me, update abaplint config

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:25:27 +01:00
mariusraht2
761bbe51af
ZCL_ABAPGIT_GIT_COMMIT: get_by_branch should return parent commit hash too (#4069)
* Implementation

* Turn exporting to returning parameter

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-27 10:01:15 +01:00
mariusraht2
9efa0c916a
Implementation (#4067) 2020-10-27 08:04:51 +01:00
mariusraht2
7ffb4ff91d
Move commit-specific methods from ZCL_ABAPGIT_BRANCH_OVERVIEW to new class ZCL_ABAPGIT_GIT_COMMIT (#4026)
* Implementation

- Create new class ZCL_ABAPGIT_GIT_COMMIT
- Move commit-specific methods from ZCL_ABAPGIT_BRANCH_OVERVIEW to ZCL_ABAPGIT_GIT_COMMIT
- Change methods visibility (from private to public) and type (from instance to class method)

* Remove ##NO_TEXT

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Rename get to get_from_remote

* abapLint: Remove space

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* abapLint

- Remove space
- Remove unused type in ZCL_ABAPGIT_BRANCH_OVERVIEW

* abapLint: Remove space

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Remove obsolete class attribute

* Separate get_by_branch and get_by_commit

* Remove duplicate char

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Remove iv_repo_name; replace its usage by url

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-19 11:24:38 +02:00
mariusraht2
a366e024ea
full_tree: Rename iv_branch to iv_parent (#4041)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-18 09:04:55 +02:00
mariusraht2
53adc30708
Add pull_by_commit (#4023)
* Implementation

* Clean-up

* Remove iv_branch

* abapLint

* Remove optional for iv_commit_hash

* Change method parameters

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-16 12:30:43 +02:00
mariusraht2
90b0f9fae5
upload_pack_by_commit: Be able to get remote objects by any commit hash (#3836)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Delete pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Rename upload_pack to upload_pack_by_branch

* Renamed missed references

* Introduce new method upload_pack_by_commit

* abapLint: Removed forbidden pragmas/comments

Forbidden pseudo comment
Forbidden pragma

* Replaced numc2 by n length 2

* Removed unneccessary changes of pretty printer

* Removed restriction of deepen_level

* N alone is of length 1 and not numeric

* abapLint

* Remove branch name

* Merge redundant source code into upload_pack

* Make upload_pack private

* abapLint

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/git/zcl_abapgit_git_transport.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Omit receiving

* Omit exporting

Co-authored-by: mariusraht1 <mariusraht+1@gmail.com>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2020-10-13 15:58:39 +02:00
mariusraht2
a8df9c286f
upload_pack_by_branch: Replace deepen with deepen_level (#3835)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Delete pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Replaced deepen boolean with deepen_level

* Replaced numc2 by n length 2

* Removed restriction of deepen_level

* N alone is of length 1 and not numeric

Co-authored-by: mariusraht1 <mariusraht+1@gmail.com>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-09 09:50:00 +02:00
mariusraht2
6f130d0edc
Client must send an empty packfile (#3856) 2020-09-09 08:39:05 +02:00
Marc Bernard
c09cc67c83
Fix startup of repo view (#3831)
* Update error msg

* Fix login popup errors and cancelation

* Remove validate/reset methods

* Lint

* Rename iv_repo_online to io_repo_online

* Change to error in status bar

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-04 09:32:38 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
mariusraht2
3a75ade563
Rename upload_pack to upload_pack_by_branch (#3818)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Delete pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Rename upload_pack to upload_pack_by_branch

* Renamed missed references

Co-authored-by: mariusraht1 <mariusraht+1@gmail.com>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-01 16:23:30 +02:00
Marc Bernard
af5b898a37
Refactor branch constants (#3784)
* Branch constants

* Refactor branch constants

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-24 11:25:46 +02:00
Marc Bernard
e4bafbe715
Validate if branch exists when displaying repo (#3749)
* Validate if branch exists when displaying repo

* Validate if branch exists when displaying repo

* Lint

* Lint and 702

* Lint

* Rename validate_branch to validate

* Fix msg and branch display name

* Move msg to UI layer

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-08-24 11:15:46 +02:00
fdupret
511090d63d
Handle "invalid committer" error (#3774) 2020-08-20 17:56:40 +02:00
Lars Hvam
f878f3b4c3
remove some double spaces (#3740) 2020-08-16 08:24:12 +02:00
Lars Hvam
d36b43defe
line break parameters (#3444)
* line break parameters

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* fix
2020-06-04 15:10:35 +02:00
Lars Hvam
aec7468aad
Type Hunting (#3414)
* Type Hunting

* update

* update

* flag
2020-05-26 05:55:28 +02:00
Marc Bernard
3620e12ee9
Fix CX_SY_RANGE_OUT_OF_BOUNDS dump (#3394)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-23 11:53:02 +02:00
larshp
2d168e170b move stage structures to interface #3377 2020-05-21 07:25:54 +02:00
germanysources
47a2332cc7
encode and decode signed commits (#3373)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-20 12:42:38 +02:00
Lars Hvam
eb7e819b25 refactoring, delete unused variables and methods (#3203)
* zlib

* xml

* processor

* shi5

* remove unused filter parameter

* pinf cleanup

* ssfo delete empty method

* highlighter

* gui page res, remove unused

* remove unused in diff class

* adt link

* gui, remove 2 unused parameters

* branch overview
2020-02-09 09:38:17 +01:00
GB
4b35d98e5d remove macro, replace with method calls 2020-02-03 09:13:31 +01:00
Lars Hvam
7aea72f63a
git pack, remove macros #3170 (#3191) 2020-02-03 06:57:53 +01:00