Commit Graph

571 Commits

Author SHA1 Message Date
Marc Bernard
cc6a207926
DDLS: Uninstall CDS views even if references exist (#4149)
Uninstall will now remove CDS views even if they are referenced in other views.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-12 08:48:48 +01:00
Marc Bernard
b25a67acea
Terminology: Inclusive Language - Part 2 (#4159)
* Terminology: Inclusive Language - Part 2

Change "Master Language" to "Main Language" in UI and comments (documentation and variables next)

* Docs

* Docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-11 10:36:38 +01:00
Marc Bernard
098682dcbb
PROG: Remove inactive sources during uninstall (#4141) 2020-11-07 09:24:34 +01:00
Lars Hvam
a53776ab5a
delete unused method in ZCL_ABAPGIT_OBJECT_CHDO (#4130)
* delete unused method

delete unused method GET_GENERIC in class zcl_abapgit_object_chdo

* enable rule unused_methods
2020-11-03 14:55:01 +01:00
Mike Pokraka
c1b2cf10a0
Update unit tests to use CI (#4106)
* Update unit tests to use CI

* Make test repo configurable

* Remove local tests and use CI

* Lint fixes

* Replace local tests with CI

* Add Type Group constants to abaplint

* Update constants and replace assert_true

* Revert constants

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-03 08:49:22 +01:00
Lars Hvam
c2492dd47e
delete unused methods (#4125)
* ZCL_ABAPGIT_REPO_FILTER

delete ZCL_ABAPGIT_REPO_FILTER->GET_PACKAGE
ZCL_ABAPGIT_REPO_FILTER delete MV_PACKAGE

* testclass, delete method given_fstate

* delete ZCL_ABAPGIT_GUI_PAGE_PATCH->IS_EVERY_CHANGE

delete method delete ZCL_ABAPGIT_GUI_PAGE_PATCH->IS_EVERY_CHANGED_LINE_PATCHED

* delete ZCL_ABAPGIT_OBJECTS_SUPER->CHECK_TIMESTAMP
2020-11-03 08:45:21 +01:00
Lars Hvam
df652f0436
delete various unused local variables (#4126) 2020-11-03 08:43:04 +01:00
Marc Bernard
f6cd2e12bd
Fix DDIC activation issues (#4111)
* Fix DDIC activation issues

- Avoid double activation of DDIC objects in case of "LATE" processing
- Derive DDIC id for XINX and MCID (same as for INDX)

Closes #4103

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:40:33 +01:00
Marc Bernard
e7b5281dde
Remove todo about unknown user id (#4113)
It's not feasible to use transports to determine who changed an object last (see https://github.com/abapGit/abapGit/pull/4056#issuecomment-719956576).

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:33:30 +01:00
Marc Bernard
20c1dc0bda
Remove obsolete late_deser from metadata (#4116)
The field `late_deser` in `ZIF_ABAPGIT_DEFINITIONS=>ty_metadata` is obsolete:

```abap
  TYPES:
    BEGIN OF ty_metadata,
      class        TYPE string,
      version      TYPE string,
      late_deser   TYPE abap_bool, " refactor: can be removed later. replaced by steps
      delete_tadir TYPE abap_bool,
      ddic         TYPE abap_bool,
    END OF ty_metadata .
```

The PR removes the remaining usage with one exception: `ZCL_ABAPGIT_OBJECTS_BRIDGE->GET_DESERIALIZE_STEPS` still depends on the field. In order to remove it completely, the plug-in interface `zif_abapgitp_plugin` (https://github.com/abapGit/abapGit-Plugins/blob/master/src/zif_abapgitp_plugin.intf.abap) will have to be changed.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:30:55 +01:00
Marc Bernard
dd37881589
702: Fix syntax error and missing check variant (#4117)
* 702: Downport 

No chaining with CHANGING

* 702: Downport

* Syntax check variant

* Too many fields warning

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:29:09 +01:00
Marc Bernard
bdc44f7476
Remove self-references (#4115)
* Remove self-references

Remove unnecessary self-references (me->)

https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-method

* 702: Fix syntax error

No chaining with EXPORTING & CHANGING

* remove addiontal me, update abaplint config

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:25:27 +01:00
Mike Pokraka
9cc515340a
Add option to specify own repo path (#4107)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-30 09:58:34 +01:00
Marc Bernard
92ba04d00e
TABL: Fix "exists" check (#4105)
Tables could exist in "new" (or other) version that is not included in nametab.
2020-10-30 09:53:54 +01:00
Philipp R
27aca4b382
Remove System Id from SOTR object type (#4104)
Co-authored-by: Rembold Rembold <philipp.rebold@sap.com>
2020-10-29 18:58:54 +01:00
Christian Günter
d14393dac5
TABL: Skip data check for GTTs (#4075)
* TABL: Skip data check for GTT

fixes #4074

* undo case change

* TABL: use fm DD_EXISTS_DATA for data check

* remove formatting change

* Data existence check only for DB tables

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-28 06:45:04 +01:00
Marc Bernard
caea4865bf
Integration of unit test with CI (#3993)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-27 08:15:52 +01:00
Frederik Hudák
d04b1b057c
DEVC - Clear obsolete fields (#4054)
* DEVC - Clear obsolete fields

* Remove on deserialize side
2020-10-22 19:04:41 +02:00
Lars Hvam
958c894d4b
issue #4032, downport (#4033) 2020-10-16 08:36:23 +02:00
Marc Bernard
4ebde6d1a3
CLAS: Avoid unnecessary serialize of testclasses include (#4013)
* CLAS: Avoid unnecessary serialize of testclass file

Unit tests are only functional if the corresponding flag is set (`seoclassdf-with_unit_tests`). Therefore, if the flag is not set, there's no need to serialize this include.

* Added version to select

* Switch to seo function

* Set  mv_skip_testclass

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-14 09:38:29 +02:00
Marc Bernard
5068e7553c
CLAS: Performance APACK (#4016)
- Replace `select count` with `select single`
- Remove unnecessary loops
- Keep SAP apack manifest during deserialize (if available)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-13 16:49:21 +02:00
Lars Hvam
f6ad8c668d
XSLT, fix syntax error (#4019) 2020-10-13 16:06:55 +02:00
Marc Bernard
b2790bc1a2
XSLT: Fix activation sequence (#4017)
* XSLT: Fix activation sequence

Save first, then activate (and no need for activation queue)

* Add error handling
2020-10-13 10:43:23 +02:00
Marc Bernard
5a0acf7a5a
SHMA: Auto generate (#4005)
Automatically generate area class after deserializing. Closes https://github.com/abapGit/abapGit/issues/1201

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-09 13:13:22 +02:00
Marc Bernard
c0192df9ec
Close some minor ToDos (#3995)
* Close some todos 

FUGR does not have any class includes

* Remove huh?

* Move WDYN activation to serializer

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-09 13:11:24 +02:00
Marc Bernard
784975fefc
Update object serializer descriptions (#4006)
Helps to identify the object type of a serializer class

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-09 12:58:31 +02:00
Lars Hvam
7339e0ec47
delete ltcl_dangerous (#3984) 2020-10-07 09:02:36 +02:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
Harry Abrahams
6360ccd08a
Fix for SFPF Clear CACHE_INFO (#3954)
* Clear CACHE_INFO

#3868

* Indentation corrections

* Add Spaces for Parameters

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-05 16:44:28 +02:00
Marc Bernard
24436879b6
Improvements for uninstall (#3959)
* Improvements for uninstall

Uninstall now catches exceptions and tries up to 3 times to remove an object. Exceptions are only raised if after 3 tries some objects still remain. 

Tested with https://github.com/larshp/abapPGP

Closes https://github.com/abapGit/abapGit/issues/379 and https://github.com/abapGit/abapGit/issues/3949, and probably #3228

* Add SHLP

also ordered when by priority

* Conflict

* Move counter

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-03 09:17:11 +02:00
Marc Bernard
9704ce6708
Fix ZIF_ABAPGIT_OBJECT~EXISTS methods (#3967)
* Fix ZIF_ABAPGIT_OBJECT~EXISTS methods

* Fix EXISTS

* CMPT

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-02 10:23:00 +02:00
Marc Bernard
ef234a20fb
New object type CMOD - Customer Enhancement Project (#3947)
* New object type CMOD - Customer Enhancement Project

Test repo https://github.com/abapGit-tests/CMOD

* CMOD

* boolc

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update src/objects/zcl_abapgit_object_cmod.clas.abap

Co-authored-by: g-back <27279305+g-back@users.noreply.github.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: g-back <27279305+g-back@users.noreply.github.com>
2020-10-01 09:49:48 +02:00
Marc Bernard
1e93c1d3d3
Fix syntax errors in 702 (#3962)
Only relevant if trying to run dev version in 702
2020-09-29 19:28:42 +02:00
pokrakam
85fe733171
Object type PDTS - Workflow Task (#3711)
* Adapt trial code from christianguenter2

* Add changed_by

* Adapt trial code from christianguenter2

* Add changed_by

* Add unit test mock class

* Update unit tests

* Unit tests %26 lint fixes

* De-Linting

* More lint fixes

* More lint experimenting

* More de-linting

* Update unit tests

* Turnaround test (WIP)

* More XML turnaround testing

* Turnaround test now working

* Clean up code

* Enable experimental mode

If we want to merge into master, it will only run for daredevil experimentalists

* Update src/objects/zcl_abapgit_object_pdts.clas.testclasses.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update src/objects/zcl_abapgit_object_pdts.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* 702 compatibility

* More 702 compatibility

* Removed container texts and system elements

Temporary(?) measure as they are being too troublesome, changing XML on successive serializations and suchlike.

* Caught exception

* General refactoring

* Remove NOTEXT pragmas and directives

* De-linting

* Remove diff in transport class

* Refactoring WIP

* Refactoring - WIP

* Refactor serialization

* De-lint

* Update container serialization

* Refactor deserialization WIP

* Object type PDTS - Workflow Task (experimental)

* Object PDTS Alpha version

* De-lint

* Correct CI dependency issues

* Check for critical unit test setting

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-29 07:41:35 +02:00
Marc Bernard
404a08fdb2
New object type WDCA - Web Dynpro Application Configuration (#3941)
* WDCA

* WDCA

* Dependencies

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-29 07:35:32 +02:00
Marc Bernard
1f3abfd8ec
New object type AVAR - Activation Variant (#3944)
* AVAR

* AVAR

* Delete zcl_abapgit_object_avar.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-27 11:15:29 +02:00
Marc Bernard
b940572f2a
Fix deserialize of TABL with foreign keys (#3945)
Activation of foreign keys now uses with same logic as #3545:
- remove keys during DDIC phase
- add keys during LATE phase

Closes #3867

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-27 11:12:15 +02:00
Marc Bernard
dc9773bee9
Fix handling of T100 exceptions (#3943)
* Fix errors raised during deletion

* Fix error handler

* Harmonize top and bottom message banners

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-27 10:56:08 +02:00
Lars Hvam
1c1b04fbe9
update lint config, minor refactors (#3948) 2020-09-27 09:24:31 +02:00
Lars Hvam
fff8f1b237
new URL, updates (#3936)
* Update build.yml

* docs, update urls

* code, update links
2020-09-24 09:42:52 +02:00
Lars Hvam
03724484f1
use boolc (#3920) 2020-09-23 12:28:13 +02:00
Marc Bernard
df0eaf32ce
SHI3: Deserialized buffermode (#3923) 2020-09-22 08:17:28 +02:00
Lars Hvam
015800b45b
Less DDIC references (#3905)
* remove uses of CHAR30

* Update abaplint.json

* add basic unit test for ZCL_ABAPGIT_MESSAGE_HELPER

* replace uses of char50

* fix name

* Update abaplint.json

* use sy-uname instead of uname

in ZCL_ABAPGIT_USER_MASTER_RECORD
2020-09-21 07:39:22 +02:00
Marc Bernard
c264588ab2
SHI3: Fix "IMG structure ID still used" (#3901)
Follow-up

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-19 07:59:21 +02:00
Fabian Lupa
143a7ccc1c
Downport, fixes #3897 (#3899) 2020-09-19 07:54:36 +02:00
g-back
7871d23fef
XML Input/Output: Remove Aliases (#3898)
* change XML reference to interface

* remove aliases from XML in/out classes

* change XML references to interfaces
2020-09-18 14:01:44 +02:00
g-back
c05af1163f
XML Refactoring: zif_abapgit_object et al. (#3895)
* change xml references

* change xml reference, remove type definition


deleted type already exists in zif_abapgit_definitions

* change XML references

* change indentation

* fix indentation

* fix ident pt. 3

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-17 17:24:32 +02:00
Lars Hvam
b4169ff4b6
update lint config, plus remove identical condition (#3892) 2020-09-16 15:51:12 +02:00
g-back
6f8147036e
XML Refactoring: Various Objects (#3891)
* change xml references

* change xml reference
2020-09-16 15:23:14 +02:00
g-back
4dde63360e
XML Refactoring: Comparator/OO_Object_FNC (#3888)
* change xml references to interfaces


changed reference in interfaces:
- zif_abapgit_comparator
- zif_abapgit_oo_object_fnc

* change reference of xml in dependent objects

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-16 12:43:40 +02:00