Commit Graph

40 Commits

Author SHA1 Message Date
Christian Guenter
d4cd7e2639 ZCL_ABAPGIT_OBJECTS: optimize with sec.key 2019-01-13 10:28:06 +01:00
Lars Hvam
c9252b1b2a
CLAS cleanup (#2204)
* cleanup old experimental CLAS

* Move ZCL_ABAPGIT_OO_CLASS_NEW to _CLASS
2018-12-17 08:17:07 +01:00
Lars Hvam
54e0155891
parallel: refactoring, #2121 (#2122)
* parallel: refactoring, #2121

* move cache handling outside of main loop

* fix error found by abaplint
2018-11-22 05:07:49 +01:00
Christian Günter
ea29dc8c03 Fix deserialization with unsupported object type 2018-11-17 06:23:30 +01:00
Christian Günter
dc173ad906 DCLS: Fix activation error + TADIR handling + late deserialization #2051 (#2085)
* DCLS: Fix activation and move to late deser.

* DCLS: improve tadir handling + activation
2018-11-11 06:32:56 +01:00
Christian Guenter
997ca1d139 Fix dupl. deserialization + add unit tests 2018-11-10 08:08:40 +01:00
Lars Hvam
06616580eb
Naming conventions (#2059)
* fix naming conventions

* naming conventions
2018-11-07 12:50:20 +01:00
Lars Hvam
89e5010fd0
Naming conventions fixes, #2053 (#2058)
* fix more naming conventions

* more naming conventions fixes
2018-11-07 12:05:27 +01:00
larshp
788a7fedb9 naming conventions #2053 2018-11-07 09:00:12 +01:00
Domi Bigl
cf05295170 mark inactive objects in repo list #1943 (#2017)
* mark inactive objects in repo list

Inactive object are marked in the repo list
The sort order for changed files is not changed
unchanged inactive files come right after the changed files

* move acitve check to object interface

* add is_active for objects up to F

* add is_active for objects up to P

* add is_active for objects up to T

* add is_active for objects up to X

all core object implement (except SSFO) the standard active check via FM RS_INACTIVE_OBJECTS_WARNING now

* add is_active to plugins bridge - always active

* finish object interface implementation + objects

* add is_active for offline with object interface

* rename returning to RV_

* use returning for serialize

* cleanup, PP, UT
2018-10-31 15:54:57 +01:00
Frederik Hudák
1bb195b344 Removed the rest of endmethod/endclass comments 2018-10-18 07:27:27 +02:00
Christian Guenter
898efade3e JUMP: check if object exists 2018-10-13 10:00:42 +02:00
Alexander Tsybulsky
ef2b90c0a9 Dump on assert rv_user, fix #1960 2018-10-12 07:56:14 +02:00
Domi Bigl
f61eb50dbf Code inspector results do not respect 'Jump to ADT first' setting #1892 (#1903)
* enable ADT jump from CI result

* enable ADT jump from CI result for all objects

* cleanup + PP

* cleanup + PP + save/activate in ADT

* remove commented code
2018-09-16 10:05:38 +02:00
Johannes Konings
d25bfaf725 fix some naming conventions
https://github.com/larshp/abapGit/issues/1132
2018-08-17 09:24:22 +02:00
larshp
49ee796fc9 move responsibility for SHA1 calc
move responsibility for SHA1 calculation, in preparation for parallel object serialization move calculation
2018-08-13 18:35:08 +02:00
larshp
f0fb0f0470 TADIR performance
TADIR performance #1756

All usages of TADIR aligned to use the same structure. 
DELFLAG added in the structure.
2 identical structure definitions deleted.

todo: test this PR works after abapmerge has run
2018-08-06 15:39:15 +02:00
Michael Käsemann
b3679f0868 Added Buffering to ZCL_ABAPGIT_FOLDER_LOGIC (#1723)
* Added Buffering to ZCL_ABAPGIT_FOLDER_LOGIC

- Converted ZCL_ABAPGIT_FOLDER_LOGIC=>PACKAGE_TO_PATH and ZCL_ABAPGIT_FOLDER_LOGIC=>PATH_TO_PACKAGE to instance methods, so they can work with buffered data when constructiing path information. This gives a performance advantage in repos with a depp tree structure and multiple leaf packages
- Adapted all calling code to use an instance of ZCL_ABAPGIT_FOLDER_LOGIC instead of the previously available static methods
- Where applicaple PACKAGE_TO_PATH and PATH_TO_PACKAGE were called in an instance of ZCL_ABAPGIT_FOLDER_LOGIC, which was instanced outside of a processing loop and thus profited from the introduced buffering

* Fixed errors

* Removed obsolete coding artifacts

Removed an obsolete parameter, that accidentally got merged into the code when building the pull request

* Forwarded FOLDER_LOGIC instance to recursed calls

Forwarded ZCL_ABAPGIT_FOLDER_LOGIC instance to subsequent BUILD calls to make use of buffering, until the optimizations in #1725 are in place.
2018-07-31 12:19:29 +02:00
Christian Günter
67b7f74911 Fix: warning package shown twice (#1644) 2018-07-17 07:28:57 +02:00
Christian Günter
4f9f47cd59 Set transport request if needed during uninstall or reset local (#1596)
* delete checks: set transport request if needed

this ensures that the transport request is set when deleting objects.
E.g. uninstalling the repositoy or reset local.

* separate type for delete checks
2018-07-11 16:18:08 +02:00
larshp
583397ff31 avoid duplicate objects in reset local #1552
avoid duplicate objects in reset local #1552
2018-07-07 07:56:07 +00:00
Christian Guenter
a3d26b9901 WAPA: better delta handling 2018-06-26 11:01:42 +02:00
Christian Guenter
79a0a8fa85 Delete: checks if any object is locked 2018-06-19 13:32:25 +00:00
Christian Guenter
36f257f0bb Dependency injection for ZCL_ABAPGIT_SAP_PACKAGE 2018-06-18 15:37:16 +02:00
christianguenter2
6521d09470 Block pull if any of deserialized object is locked 2018-06-18 14:18:58 +02:00
Lars Hvam
de23d5bf95
Merge pull request #1484 from larshp/issue_1390
first dependency injection, TADIR #1390
2018-06-14 06:27:04 +02:00
Jakub Filak
fb6efabfb9 tp: use the correct transport type in the tr popup
We are developing in an infinity system which is somehow cloned into a
new releases system. When we need to backport a bug fixes we do
cherry-pick the commits and pull them the release system. However, in
those systems we need to use the task type Repair.

Hence, we need to overwrite the default value of the parameter
wi_task_type of the function TRINT_ORDER_CHOICE which is 'S'
(Development/Correction) with the value 'R'.

I use the function TRINT_GET_REQUEST_TYPE and for the sake of simplicity
I assume that it is enough to know the transport type of the repository
package - in other words, it is no necessary to check every deserialized
object.

Related to #1446
2018-06-12 13:33:49 +02:00
larshp
4e67e884de first dependency injection #1390
* extract public methods of ZCL_ABAPGIT_TADIR to new interface
* create factory ZCL_ABAPGIT_FACTORY
* refactor existing calls
2018-06-10 12:11:48 +00:00
Lars Hvam
5baeaf070c
Minor changes (#1461)
* remove double space after IF

* remove accesses to table bodies

* remove parameter name where possible

* identical code in conditions
2018-06-06 16:24:15 +02:00
Christian Guenter
35ec1085e2 Only show transport popup when needed 2018-05-10 21:48:36 +02:00
Christian Guenter
582a3ab02a refactor transport popup 2018-05-08 19:09:30 +02:00
Lars Hvam
3b09bdba29
fix SUPPORTED_LIST (#1293)
* fix SUPPORTED_LIST

* and fail unit test if nothing is supported

* moved test objects to abapGit organization
2018-04-03 16:22:03 +02:00
Lars Hvam
3f1b29c01f
fixes #1282 (#1283)
refactor overwrite object from other package popup to UI
2018-03-30 06:59:29 +02:00
Lars Hvam
7152b4281a
Refactoring (#1279)
* URL: rename and add validation method

plus validate url in NEW_ONLINE

* optimize select

* move write protection check

* start refactoring gui away from deserializati/pull

* mvoe ZCL_ABAPGIT_SERVICES_ABAPGIT to UI

* delete ZCL_ABAPGIT_SERVICES_BKG

moved to GUI page

* move ZCL_ABAPGIT_SERVICES_GIT to UI

* move ZCL_ABAPGIT_SERVICES_REPO to UI

* fix indentation

* overwrite popup refactored to UI
2018-03-29 14:29:03 +02:00
Lars Hvam
f17985b27e
Add option for "Only local objects", issue 1260 (#1268)
* refactor write protect and ignore subpackages

to local settings structure, this makes it a lot easier to exetend, plus adds structure

* delete method GET_MASTER_LANGUAGE

* add local settings to repo settings page

* add setting for only local objects #1260
2018-03-26 12:23:01 +02:00
Christian Günter
49eacbe701 Downport 2018-03-19 13:26:32 +00:00
Christian Günter
dc14fa22df Fix deserialization dependency ENHO -> ENHS 2018-03-08 10:36:39 +00:00
Lars Hvam
803148fa0f
fix some naming conventions #1132 (#1211) 2018-02-17 13:55:12 +01:00
Lars Hvam
323881f606
lcl zip (#1206)
* lcl_zip to global

* lcl_transport to global

* lcl_transport_2_branch to global

* lcl_merge to global

* lcl_migrations to global

* lcl_news to global

* lcl_repo_content_list to global

* move test to global class

* clean up empty includes
2018-02-15 15:50:51 +01:00
Lars Hvam
18ea5d637c
lcl_repo (#1205)
* lcl_repo and more to global

* cleanup includes

* fix indentation
2018-02-15 15:10:13 +01:00