Commit Graph

3580 Commits

Author SHA1 Message Date
Alexander Tsybulsky
d501afdf83 downport (#3026) 2019-11-01 17:25:44 +01:00
Frederik Hudák
509a69e480 'Duplicates' error: show duplicate object names (#3024)
* 'Duplicates' error: show duplicate object names

* Update zcl_abapgit_objects.clas.abap

* Update zcl_abapgit_objects.clas.abap
2019-11-01 17:22:04 +01:00
Lars Hvam
dca54d2590
refactoring public attributes (#3023)
* testclass for testing and remove public attr

* refactor public vars in local class

* rename
2019-11-01 17:07:17 +01:00
Lars Hvam
9c6bba620c
1.91.0 (#3019)
* 1.91.0

* Update changelog.txt
2019-10-31 15:16:45 +01:00
Italo N
7d587e1a1a Issue #2957 (#2975)
But It's generate a lot of DIFF, when XML remote has the INDEX filled.
2019-10-31 15:07:59 +01:00
Frederik Hudák
04e196b816 Improve branching messages (#3018)
Mention name of branch which was just deleted/switched to.
2019-10-31 14:35:29 +01:00
Alexander Tsybulsky
4f3bd19a8b stage UX improvements: ctrl-enter, autoadd deleted, remote state bugfix (#3007)
* stage: ctrl-enter, autoadd deleted

* linter fix

* eslint fix

* review fixes
2019-10-31 14:29:23 +01:00
Lars Hvam
dbe484e124 disable no_public_attributes, temp workaround 2019-10-31 12:49:10 +01:00
Christian Guenter
99761e37c9 Links: add tooltip with hotkey 2019-10-31 08:42:37 +01:00
Johan Wigert
df303d2cc6 Object should be removed, but has NO deletion flag in transport (#3009)
* Update zcl_abapgit_transport_objects.clas.abap

* Update zcl_abapgit_transport_objects.clas.testclasses.abap
2019-10-30 06:50:16 +01:00
larshp
d0e3956df8 update to latest 2019-10-27 12:05:47 +01:00
Alexander Tsybulsky
1af5648e5f Diff state at stage and commit pages (#3003)
* state at stage and commit pages

* review fix
2019-10-27 11:26:59 +01:00
Italo N
f4c8d13a2c Bug - PROG name contain '%3D' (#2980)
Issue #2923
2019-10-27 11:19:32 +01:00
Christian Günter
c99ff03253 FTGL: feature toggle (#3004)
* FTGL: feature toggle

* update ref-supported

* Update ref-supported.md
2019-10-27 08:46:57 +01:00
Lars Hvam
1101e91b40
docs: add IAXU as supported (#3000) 2019-10-25 06:56:03 +02:00
Alexander Tsybulsky
af97a51fa5 commit selected button (#2993) 2019-10-25 06:46:01 +02:00
mariusraht2
3900842392 Add object type IAXU (#2978)
* Possible Solution #1

* Update zcl_abapgit_objects_super.clas.xml

* abapLint

* Removed german language flag

* Fixes

* Removed flag for german language

* Removed test code

* abapLint

* Implemented suggestions from PR

> mo_xml_api is just local now
> li_service removed
> implemented exception handling for calls of xml api methods set_changeable, delete and save
> integrated sy-subrc into all exception calls
> wrote update routine if IAXU object already exists (object will be deleted first and after that local method save is called)

* abapLint

* abapLint

* String template, restructured api methods

* Remove descriptions

* abapLint

* Fixed issues after restructuring api methods calls

* Alternative error handling for existence check

* Use api existence check instead of load

* Fixed some bugs
2019-10-24 05:53:12 +02:00
Alexander Tsybulsky
fc2c803be5 me filter 2019-10-22 15:27:28 +02:00
larshp
523ab5c862 refactor CONSTANT definition 2019-10-20 14:51:34 +02:00
Alexander Tsybulsky
2422bb726c update readme (#2984) 2019-10-18 16:57:26 +02:00
David Scheiklies
f4e33039d6 Add commit success message (#2979)
* New version of #2973

* Update zcl_abapgit_gui_page_commit.clas.abap
2019-10-16 21:40:17 -07:00
Christian Günter
b7d0f2115e SMTG: OM: Email Template implementation (#2976) 2019-10-15 22:32:03 -07:00
g-back
033b32de7d Repository-Validation: More specific Error Message (#2965)
* add additional read to better specifiy error msg

issue #2914

* add line break in error message
2019-10-15 22:23:23 -07:00
Alexander Tsybulsky
5c10415b28 possibility to export pkg with master lang only (#2966) 2019-10-13 23:02:42 -07:00
Christian Günter
bc082b15b0 Link Hints: fix start value calculation (#2970)
* Link Hints: fix start value calculation

* fix comment
2019-10-13 22:39:56 -07:00
Marcello Urbani
b8cc55ec3f Fixes #2904 dump importing zip (#2963)
* Fixes #2904 dump importing zip

* Fix linting issues
2019-10-12 04:00:10 -07:00
Alex
17a67933e3 Fix for issue #2922 (#2960)
* added a picture for pull from zip

it can then be used in guide-import-zip.md

* Fix for Issue 2922

https://github.com/larshp/abapGit/issues/2922

Added a new test method find_head_closing_tag.
Implemented fix in method zcl_abapgit_gui_html_processor->find_head_offset.

* Removed dont needed Pull_from_zip.png 

Removed dont needed Pull_from_zip.png

* Restored NewLines handling in patch_html

Restored NewLines handling in patch_html

* Fixed some abapLint Warnings

Fixed some abapLint Warnings

* Fixed some abapLint messages

Fixed some abapLint messages
2019-10-12 03:56:28 -07:00
ThomasPloski
dcb4d94275 Support of Baseinfo String for DDLS Object Handler (#2967)
* support of baseinfo string in ddls

* fixes abaplint findings

* fixes abaplint issues
2019-10-11 05:41:01 -07:00
Lars Hvam
714fe7202d
whitespace fixes (#2964)
* whitespace fixes

* fix sql compare operators
2019-10-11 02:50:16 -07:00
Christian Guenter
8bf4b5df4c Page overview: fix order by column mismatch 2019-10-09 21:14:12 -07:00
Lars Hvam
ef0d149fa3
SCP1, sets of sets (#2945)
* SCP1, first few bits

* try this

* fix transport
2019-10-09 01:59:48 -07:00
Alex
934b3635dd Updated contributing.md
Provided a hint for syncing an old fork
2019-10-08 23:32:11 -07:00
Alexander Tsybulsky
f2f82278e7 Serialize master lang only + settings UI improvements (#2954)
* repo settings ui improvements

* serialize_master_lang_only UI

* downport

* connect settings and serialization (MSAG)

* dtel doma tran prog fugr

* linter fixes
2019-10-07 23:03:57 -07:00
Lars Hvam
bed6050437
abaplint: add extra rules (#2953) 2019-10-07 23:00:12 -07:00
Lars Hvam
49df948007
update deps (#2952) 2019-10-07 22:51:15 -07:00
Lars Hvam
d7fd8af1d5
docs: add anchored links, closes #2756 (#2951) 2019-10-07 22:48:28 -07:00
Lars Hvam
28e052dbce
serialization, FORM fixes (#2950)
* FORM, tdlines duplicated, closes #2949

* FORM, set TDVERSION to constant, closes #2935
2019-10-07 22:44:50 -07:00
larshp
90e012a1ae for low number of obj run single thread 2019-10-07 22:41:36 -07:00
Lars Hvam
2b9f7d30c7
1.90.0 (#2946)
* 1.90.0

* v1.90.0
2019-10-06 23:43:48 -07:00
Alexander Tsybulsky
2270b625f7 deploy release tag (#2919) 2019-10-06 23:30:01 -07:00
Jakub Filak
4c3c4e8ea8 objects: work around the protected redefinition shortdump (#2891)
The methods CL_OO_CLASS_SECTION_SOURCE=>SCAN_SECTION_SOURCE calls the
function SCAN_ABAP_OBJECTS_SECTION without the parameter superclsname
which causes that variable scan_result (vse_tabs) holds a broken table of
redefinitions for protected methods which leads into a short dump during
CL_OO_CLASS_SECTION_SOURCE=>REVERT_SCAN_RESULTS.

The problem does not occur for public section because the public section
contains "CLASS ... INHERITING FROM ...", so superclsname gets
populated. It's obvious that the class definition statement is not
present in the protected section.

The crash is reported as DBSQL_DUPLICATE_KEY_ERROR in the program
SAPLSEOR at INSERT_REDEFINITIONS.

The code is the following:

    * first refresh db table
        perform delete_redefinitions
          using inhkey.
        delete adjacent duplicates from redefinitions.
    * insert again
        insert seoredef from table redefinitions.

One might think that the delete statement form clears the table seoredef
but the problem is that the variable inhkey contains the super class
name so no redefinitions are actually removed and the insert statement
attempts to insert the redefinitions without parent class again.

The proper solution is to enhance CL_OO_CLASS_SECTION_SOURCE=>SCAN_SECTION_SOURCE
to pass the super class name to SCAN_ABAP_OBJECTS_SECTION - at least for
the protected section.

However, I am not patient and I am not going to wait for the proper fix
(which the maintainers may refuse).
2019-10-06 23:18:44 -07:00
Christian Guenter
d7e2833483 Warning at stage when not logged on in master lang 2019-10-06 01:12:33 -07:00
Christian Günter
a40e7f1bbc new function 'add all objects to transport request' (#2942)
* new function 'add all objects to transport req'

* enable cancel
2019-10-06 00:21:51 -07:00
Christian Günter
6decda9c07 Refactor zcl_abapgit_gui_view_repo (#2939)
* refactor build branch/tag dropdown

* refactor build advanced dropdown

* refactor build main toolbar

* cleanup

* cleanup

* post merge conflict fixes
2019-10-05 23:17:27 -07:00
BlackmanCC
b49eaab687 fix errorhandling bug #2940 (#2941) 2019-10-05 22:58:52 -07:00
Christian Günter
3905c67edd Order by on repo page (#2933)
* Order by on repo page

* move render_cols_pec to zcl_abapgit_gui_chunk_lib

* cleanup

* cleanup

* first new working version

* fix lint

* add OrderByHelper

* add new feature clear

* rename ICON to CLEAR

* cleanup

* refactor actions

* fix typo in method name

* remove duplication

* rename render_col_spec to render_order_by_table_he

* refactor type

* fix eslint warning

* isoltate repo_tab CSS

* fix non-code and metadata files at the top

* refactor

* cleanup

* new features "diffs first" + remove clear

* refactor

* take directories into account

* cleanup
2019-10-05 22:54:04 -07:00
Martin Fuchs
67ebff3b7c No log messages for local objects after pull (#2932)
* No log messages for local objects after pull

In case a package contains objects that are are not part of the remote repository, the pull log contains messages like "Object (type ) only exists local; no import required". It is not necessary that messages for local object appears in the log. For pull requests, messages for the affected objects (objects to be imported) are sufficient.
This change ir related to issue #2931.

* rename (z)if_abapgit_definitions

rename (z)if_abapgit_definitions
2019-10-05 22:41:02 -07:00
Christian Günter
22d19023e4 NROB: write transport request entry (#2926)
* NROB-serialization: write transport request entry

* switch to corr_insert

* cleanup
2019-09-28 23:41:43 -07:00
Alexander Tsybulsky
f99ee448c3 ci cleanups (#2918)
* ci cleanups

* npm lint -> npm abaplint
2019-09-28 23:36:41 -07:00
Christian Günter
680dbd6b74 DDLS-Serialization: Write transport request entry (#2927) 2019-09-26 01:41:38 -07:00