Commit Graph

1087 Commits

Author SHA1 Message Date
Alexander Tsybulsky
c8636912f1
File status refactoring, part 2 (#6124)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-03-06 19:45:20 +01:00
Marc Bernard
a2278c94da
CLAS: Fix variable name (#6127) 2023-03-03 20:26:31 +01:00
Marc Bernard
6cbc78dc61
Fix ITAB_DUPLICATE_KEY dump during deserialize (#6121) 2023-03-02 21:23:16 +01:00
Alexander Tsybulsky
6fad60afb5
File status refactoring, part 1 (#6114)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-03-02 17:55:22 +01:00
Michael Schäfer
f1d01e394f
assign authorization group during report creation (#6117) 2023-03-02 12:21:56 +01:00
Alexander Tsybulsky
e729c09901
Better pull dialog, Screen status (#6093)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-03-01 20:17:36 +01:00
Lars Hvam
4a68f896b1
json handler: serialize() + deserialize() optional inputs (#6110) 2023-03-01 14:50:59 +01:00
Lars Hvam
b6470787ff
move validate_name() to interface (#6106) 2023-02-28 17:53:01 +01:00
Marc Bernard
3a51dd23b5
CLAS: Fix error when changing redefinitions (#6102)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-02-27 09:44:02 +01:00
Lars Hvam
6e0f600dfd
cleanup: remove some unused variables (#6099) 2023-02-26 17:17:35 +01:00
Lars Hvam
ed1e005463
use TADIR instead of SOBJ_NAME (#6084)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-02-25 10:34:19 +01:00
Lars Hvam
cbfdd5355b
LXE: move ty_lxe_i18n to private section (#6085)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-02-25 10:23:02 +01:00
Christian Günter
115ce57561
CUS0/CUS0 add SORT to avoid diffs (#6088) 2023-02-25 10:18:16 +01:00
Lars Hvam
35f9a05e8c
Refactor: package, add read_responsible() (#6083) 2023-02-24 15:58:25 +01:00
Lars Hvam
17ba24e72a
refactor TDEVCT SELECT to SAP package class (#6081) 2023-02-23 07:38:56 +01:00
Marc Bernard
1ca9a40d67
SHIx: Fix application component hierarchy issues (#6065) 2023-02-10 18:55:21 +01:00
Marc Bernard
1ca12015eb
Refactor: replace newline/crlf with built-in (#6057) 2023-02-09 20:03:07 +01:00
Marc Bernard
f0fa964c25
TABL: Fix activation of secondary indexes (#6055) 2023-02-09 09:27:40 +01:00
Marc Bernard
5351a4b4e8
CLAS: Fix recording of changes in transport (#6047) 2023-02-08 12:45:49 +01:00
Katharina Wurz
d63407db3e
Enable inactive deserialization for DDIC objects (#6045) 2023-02-07 13:59:05 +01:00
Marc Bernard
2e7c2df8eb
Update object descriptions - Part 4 (#6043) 2023-02-06 18:48:47 +01:00
Marc Bernard
a3a5032c41
Update object descriptions - Part 3 (#6042) 2023-02-06 15:38:22 +01:00
Lars Hvam
716111370a
move SOTR defintions to SOTR class (#6033)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-02-03 16:25:27 +01:00
Lars Hvam
773f2f7749
refactor, extract git definitions to git (#6029)
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2023-02-03 11:46:00 +01:00
Lars Hvam
c7f08adde7
fix diffs after description updates (#6027) 2023-02-02 09:53:40 +01:00
Marc Bernard
24e79943f5
Update object descriptions - Part 2 (#6019) 2023-02-02 09:03:51 +01:00
Marc Bernard
71f16d08be
SFBF, SFBS, SFSW: Major bug fixes (#6020) 2023-02-01 10:29:20 +01:00
Lars Hvam
20785fef78
delete, fix dump (#6011) 2023-01-25 20:41:17 +01:00
Marc Bernard
6485ec50c1
Refactor: MESSAGE ... INTO (#6008) 2023-01-25 09:55:41 +01:00
Marc Bernard
95f7844065
TABL,VIEW: Simplify deserialize (#5989) 2023-01-24 10:16:15 +01:00
Marc Bernard
e1c3fcebdb
TOBJ: Improve error messages (#6007) 2023-01-23 11:28:25 +01:00
Marc Bernard
0dfc5eb80c
PDTS: Fix recording in transport (#6000) 2023-01-18 20:39:50 +01:00
Marc Bernard
0adcb13637
SAPC: Fix uninstall errors (#6001) 2023-01-18 19:58:50 +01:00
Marc Bernard
beea59eda5
SHLP: Avoid double activation (#5999) 2023-01-17 11:25:02 +01:00
Marc Bernard
1a5199a5e3
DOMA: Fix domains with custom conversion exit (#5998) 2023-01-17 11:18:35 +01:00
Marc Bernard
6f4f336437
XSLT: Avoid double activation (#5995)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-01-16 17:53:47 +01:00
Uenal Akkaya
f6a1a09b5d
DRUL: Fix compatibility with lower releases (#5991)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-01-16 13:13:44 +01:00
Marc Bernard
db70f3d735
Pull log: Include object counts (#5982)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-01-16 12:59:10 +01:00
Albert Mink
7c46e659e2
Update AFF to new AJSON functionality (#5986)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-01-12 15:14:29 +01:00
Marc Bernard
47dbee1d48
CLAS,INTF: Removing STATE field in XML (#5981)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-01-12 11:36:55 +01:00
Katharina Wurz
c2b8b597aa
Allow Object Types with multiple files in AFF (#5979)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-01-12 10:57:06 +01:00
Marc Bernard
82250202f4
SMIM: Record deletion of objects in transport (#5975) 2023-01-08 22:01:51 +01:00
Marc Bernard
25bbbf89cd
Refactor: Remove delete_tadir flag (#5949)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-01-06 15:56:12 +01:00
Marc Bernard
e716fd6437
Fix "duplicate file error" during pull (#5968) 2023-01-03 15:00:56 +01:00
github-actions[bot]
95389c532b
ajson, Automatic Update (#5966) 2023-01-03 14:47:44 +01:00
Marc Bernard
68ff24c9fc
Prevent pull in case of duplicate files (#5952) 2022-12-26 10:12:50 +01:00
Christian Günter
bd007e2447
add guard clause to prevent long runtimes (#5954)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-12-22 10:46:20 -05:00
Uenal Akkaya
d0167ff97d
DRUL: Use CL_BLUE_SOURCE_OBJECT_DATA2 instead of CL_BLUE_SOURCE_OBJECT_DATA (#5950) 2022-12-16 09:44:33 -05:00
Marc Bernard
323dfbd235
Reorg: Package hierarchy (#5946)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-12-15 12:07:02 -05:00
Marc Bernard
8a0c93e92f
ENHO: Fix error deserializing enhancements (#5943) 2022-12-14 21:18:17 -05:00
Marc Bernard
526162ed6e
PRAG: Fix locking and transport entries (#5939) 2022-12-14 13:10:43 -05:00
Marc Bernard
1b845b4971
AFF: Add NONT and RONT to registry (#5934) 2022-12-14 09:56:05 -05:00
Marc Bernard
273c646940
DOCV,SAMC,SAPC,STYL: Add missing transport entry (#5935) 2022-12-13 18:02:47 -05:00
Christian Günter
97f357f107
Set transport request in local repo settings or user exit (#5916) 2022-12-08 08:45:16 -05:00
Michael Schneider
9d0914675f
Remove static references to cl_oo_source (#5897)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-12-01 16:33:05 -05:00
Michael Schneider
21ed40e4d8
Remove references to cx_oo_clif_scan_error (#5905)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-12-01 12:13:44 -05:00
Marc Bernard
258e6488b4
Fix file to object mapping (#5902)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-12-01 09:03:47 +01:00
Marc Bernard
b958377279
TOBJ: Deletion of logical transport objects (#5873) 2022-11-17 10:19:26 -05:00
Vanessa
5c2e41c488
AFF object NONT (#5866) 2022-11-12 10:47:56 -05:00
Vanessa
bf8c3590a8
AFF object RONT (#5862)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-11-09 11:11:45 -05:00
Marc Bernard
754fe5b5a8
DOCV: Fix dump for namespaced documents (#5855)
* DOCV: Fix dump for namespaced documents

Fix handing of documents in classes UO and UP which use a different namespace logic than DT, IN, MO. 

Regression #5756

Closes #5854

* Doc classes
2022-11-04 12:34:43 -04:00
Marc Bernard
f8ac419f29
Fix "Unexpected package naming" error (#5805)
* Fix "Unexpected package naming" error

Previously, when an object existed in the repo and locally but was *not* included in the package hierarchy of the repository, you would get the following error (when opening the repo):

...

With this PR, log messages will list all objects that are not included in the package hierarchy. When pulling, the popup will show these objects and ask for confirmation to overwrite. I added an icon and description to the "package overwrite" popup similar to the "object selection" popup.

Closes #5728

* Update unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-11-04 08:56:31 -04:00
Marc Bernard
b03a70228f
Improve error message for where-used list update (#5849)
* Improve error message for where-used list update

* Update zcl_abapgit_objects_activation.clas.abap
2022-11-02 09:35:57 -04:00
Marc Bernard
93c8fcfb4f
DOCV: Add object to tadir and transports (#5845)
Fix errors found in CI test
2022-11-01 14:10:06 -04:00
Marc Bernard
8e7c79261d
CLAS,INTF: Catch runtime error during update (#5841)
Prevent dump when deserializing classes and interfaces in case a sub component was changed in a way that standard SAP code does not handle.

References: 
- message `OO_SOURCE_BASED 019`
- SAP Note [2166231](https://launchpad.support.sap.com/#/notes/2166231)
- https://github.com/abapGit/abapGit/issues/5836

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-10-31 08:49:46 -04:00
Katharina Wurz
e4aeff4f04
Small refactoring of zcl_abapgit_aff_registry (#5835) 2022-10-23 14:59:05 +02:00
Marc Bernard
34c07b6f98
Avoid overwriting built-in functions (#5832) 2022-10-20 16:45:31 +02:00
Marc Bernard
24b1bcffa7
Remove cases of modifying syst fields (#5831)
Remove cases of modifying `syst` structure
2022-10-20 16:43:03 +02:00
Lars Hvam
e539fc30e2
update AFF types to latest (#5824) 2022-10-17 16:05:40 +02:00
Lars Hvam
9af402ff9f
INTF cleanup: delete unused methods (#5823) 2022-10-17 15:48:01 +02:00
Lars Hvam
cb66e18738
housekeeping, delete some unused variables (#5825) 2022-10-17 15:25:00 +02:00
Lars Hvam
188c9ed903
dont use I18_A_LANGISO2, its not released (#5822)
* dont use I18_A_LANGISO2, its not released

* use LAISO

* use LAISO
2022-10-14 15:17:44 -04:00
Albert Mink
22214428d7
AFF: More UT for testing deserializing (#5821)
more details in UT
2022-10-13 19:41:26 +02:00
Uenal Akkaya
763fbad76c
DRUL: Use CL_BLUE_SOURCE_OBJECT_DATA instead of CL_DRUL_WB_OBJECT_DATA (#5818)
* Update zcl_abapgit_object_drul.clas.abap

Use in class ZCL_ABAPGIT_OBJECT_DRUL the more generic type CL_BLUE_SOURCE_OBJECT_DATA instead of CL_DRUL_WB_OBJECT_DATA

* Update zcl_abapgit_object_drul.clas.abap

Use in class ZCL_ABAPGIT_OBJECT_DRUL the more generic, similar type CL_BLUE_SOURCE_OBJECT_DATA instead of CL_DRUL_WB_OBJECT_DATA
2022-10-12 09:56:30 -04:00
Albert Mink
27bec52c8a
AFF with namespaces (#5779) 2022-10-10 11:38:47 -04:00
Marc Bernard
67093085f6
CLAS,ENHO: Fix inactive enhancements (#5810)
* CLAS,ENHO: Fix inactive enhancements

When pulling a change to an existing class, existing enhancement where inactivated and the enhancement code deleted. 

This was caused by unnecessarily calling `CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE'` in `zcl_abapgit_oo_class->create`, twice.

The change avoids the second call if the class properties and attributes have *not* been changed. Interfaces are handled the same way. 

Tested with CI tests for classes and interfaces:


Closes #5809

* Clear

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-10-07 15:00:31 -04:00
Patrick Winkler
cda541692f
SMBC: Business Configuration Maintenance Objects (#5812)
* enable SMBC for abapGit

* fix abapLint issues
2022-10-06 09:11:37 -04:00
Marc Bernard
fbeabd6220
ENHO: Unlock objects in cases of errors (#5811) 2022-10-06 10:17:22 +02:00
Christian Günter
86751b6961
VIEW: Add translation support (#5806)
fix linter
2022-10-05 20:11:46 -04:00
Christian Günter
f8564cb679
AFF: Fix existence check (#5803)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-10-04 17:48:11 -04:00
Marc Bernard
35718fbf77
W3xx: Remove unnecessary metadata (#5780)
* W3xx: Remove unnecessary metadata

* Clear metadata

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-10-04 09:47:05 -04:00
Marc Bernard
004885fcc0
FUGR: Add documentation (longtexts) (#5795)
After #5786, Ref #5774

Serialize and deserialize documentation of function group, function modules, and parameters. 

Test case: 
https://github.com/abapGit-tests/FUGR_docu

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-10-04 09:44:03 -04:00
Jon Friesen
954d913191
CLAS,INTF: Support for component documentation (#5575)
* serialization

* full sotr class serialization

* nw 7.02 compatibility

* ensure consistent order

* Second attempt to stage support for CLAS and INTF 

Second attempt to stage support for CLAS and INTF, first attempt did not have changes

* Pretty printed

* Lint compliance part 1

* Lint compliance part 2

* code review remediation plus one bugfix

includes one bugfix - do not write entries in <DOCU_CAT> if there are no lines of text

* Update src/objects/zcl_abapgit_objects_program.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Switch to new method

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Marc Bernard <marc@marcbernardtools.com>
2022-10-04 09:33:38 -04:00
Marc Bernard
e0e3b442a0
Various objects: Add documentation (longtexts) (#5796)
Add documentation (longtexts)

After #5786, Ref #5774

Serialize and deserialize documentation of CHAR, DTEL supplements, SFBF, SFBS, SFSW, TTYP, VIEW, WDYA, XINX

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-10-04 09:18:28 -04:00
Christian Günter
ee4320db6b
fix language dependent unit test (#5799)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-10-04 09:06:41 -04:00
marcushoepfner
3060254d10
Fix subcomponent text deserialization (json) (#5783)
* fix

* Take linters recommendations

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* adapted missing call; fix syntax issue

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-10-04 11:17:04 +02:00
Marc Bernard
d936b8dc0b
Prepare processing longtexts for sub components (#5786) 2022-10-04 08:09:56 +02:00
Marc Bernard
fcdb07a7a6
TABL: Fix deserialize if foreign key exists (#5773) 2022-10-02 09:19:33 +02:00
Marc Bernard
16656d8141
CLAS: Fix pull for deleted interface methods (#5768)
* CLAS: Fix pull for deleted interface methods

In case an interface method was deleted, pulling a class that had implemented such method would not delete the implementation. This resulted in a diff and manual effort to remove the method (or repair the class).

The fix will compare the implemented methods and trigger the repair if necessary.

Closes #5578

* Update zcl_abapgit_oo_class.clas.abap

* return all includes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-09-26 11:20:17 -04:00
Fabian Lupa
77fea02b45
Force usage of local object handler classes (#5778) 2022-09-26 06:50:16 -04:00
Marc Bernard
f1c1aad740
Delete obsolete longtexts on pull (#5751)
* Delete obsolete longtexts on pull

Longtexts that exist in the system but not in the remote repository are deleted when pulling.

Closes #5202

* Refactor

* Constant

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-09-23 09:57:44 -04:00
Marc Bernard
b18586ba32
CLAS,INTF: Add missing shorttexts (#5755)
* CLAS,INTF: Add missing shorttexts

Serializes shorttexts for sub components (like method and event parameters).

Preparation for https://github.com/abapGit/abapGit/pull/5718

New test cases:

https://github.com/abapGit-tests/INTF_docu
https://github.com/abapGit-tests/CLAS_docu

* Clear/set class/interface name for shorttexts

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-09-15 11:34:32 -04:00
Marc Bernard
0be78203d5
SOTR: Fix handling of alias names (#5750) 2022-09-13 16:39:33 +02:00
Marc Bernard
16d69e8ab9
DOCV: Handle namespaces (#5756) 2022-09-13 10:03:37 +02:00
Marc Bernard
ee3f5f4cb1
DSYS: Simplify namespace split (#5757) 2022-09-13 07:38:25 +02:00
Marc Bernard
471b155bc4
SUSH,SUSC: Fix deletion (#5748) 2022-09-09 14:24:52 +02:00
Marc Bernard
f9b0cc16ea
W3XX: Sort parameters to avoid diffs (#5746) 2022-09-08 08:14:33 +02:00
Marc Bernard
24340fce32
SCVI: Sort tables to avoid diffs (#5745) 2022-09-08 08:04:19 +02:00
Marc Bernard
b250edc8f7
WDYN: Fix dump if no components exist (#5749) 2022-09-08 08:01:04 +02:00
Marc Bernard
be967a4e8a
G4xx, IWxx: Changed by (#5747)
* G4xx, IWxx: Changed by

* Empty block
2022-09-08 07:32:35 +02:00