Commit Graph

242 Commits

Author SHA1 Message Date
Alexander Tsybulsky
272925fff7 Floating save buttons (#2608)
* floating save buttons

* hover hand cursor
2019-04-09 11:44:52 -07:00
Alexander Tsybulsky
f39aab3244 fix display name in attache/change remote 2019-04-08 07:21:09 -07:00
Alexander Tsybulsky
3c80012b37 HDPI icon scaling (#2609)
* setting for icon scaling

* enforce icon scaling

* linter fixes
2019-04-05 03:47:09 -07:00
Lars Hvam
7bbaf069e2
File format update collection (#2605)
* File format update - changed object handler

I removed the following fields:

CLAS
VSEOCLASS-VERSION

INTF
VSEOINTERF-VERSION

PROG
PROGDIR-STATE

DCLS
AS4LOCAL
ABAP_LANGUAGE_VERSION (if exists)

DDLS
ABAP_LANGUAGE_VERSION (if exists)

DDLX
VERSION
RESPONSIBLE
MASTER_SYSTEM

MSAG
DOKIL-DOKSTATE

ENQU
DD25V-AS4LOCAL
DD25V-AS4VERS

* fix syntax error

* also clear PROG VARCL

* update XML files
2019-03-31 01:17:46 -07:00
sandra rossi
8f681e88dd 2 unit tests in ZCL_ABAPGIT_GUI_PAGE_DIFF failing
#2498 Two unit tests in ZCL_ABAPGIT_GUI_PAGE_DIFF failing

It concerns two test methods which test zcl_abapgit_gui_page_diff%3D>get_patch_data. The parameter IV_PATCH is passed with an incorrect value.

This issue is due to commit 389512f690 on Feb 26, 2019

Correction of method get_patch_data_add: 
- Before: |add_patch_zcl_test_git_add_p.clas.abap_19| 
- After: |patch_line_add_zcl_test_git_add_p.clas.abap_0_19| 

Correction of method get_patch_data_remove:
- Before: |remove_patch_ztest_patch.prog.abap_39| 
- After: |patch_line_remove_ztest_patch.prog.abap_0_39|
2019-03-30 03:20:31 -07:00
Jakub Filak
01b855467a clas: use exception instead of assert for not found file
For easier debugging.
2019-03-28 23:11:41 -07:00
Alexander Tsybulsky
f8347636a0 GUI remove zif_abapgit_gui_page (#2582)
* remove usage of zif_abapgit_gui_page

* reorderings

* delete zif_abapgit_gui_page
2019-03-28 23:08:04 -07:00
Alexander Tsybulsky
d22f5af1ab rewrite gui error handler 2019-03-28 22:57:39 -07:00
Kjetil Kilhavn
c7f21c2a5b Unknown action url -- fix for issue #2566 (#2567)
* Handle calls to repository URL on all pages

Call super class' for unhandled events in all classes displaying repository (identified from where-used list for zcl_abapgit_gui_chunk_lib%3D>render_repo_top).

I suppose it should be safe to add the 'super' call everywhere, but for now this will solve the bug.

* Revert "Merge branch 'unknown-action-url' into 'master'"

This reverts merge request !1

* Handle calls to repository URL on all pages

Call super class' for unhandled events in all classes displaying repository to handle URL click.
Relevant classes were identified by the where-used list for method render_repo_top in class zcl_abapgit_gui_chunk_lib.

I suppose it should be safe to add the 'super' call everywhere, but for now this will solve the bug.
2019-03-27 00:03:29 -07:00
Alexander Tsybulsky
ecc1c85ee7 GUI subclass zcx_abapgit_cancel from zcx_abapgit_exception (#2576)
* subclass zcx_abapgit_cancel from zcx_abapgit_excep

* upper case
2019-03-26 23:51:38 -07:00
Jakub Filak
77cea9c92a New repo with Folder Logic and Ignore Sub-packages params (#2561)
* repo: do not validate sub-packages when ignored

In our landscape, we often need to version a package which has
sub-packages and those sub-packages have own repositories - the super
package provides framework and the sub-packages provides production
functionality.

When adding a new repository for these "framework" super-packages,
we need want to configure "Ignore sub-packages" because they are
already versioned in standalone repositories.

We also need to turn of the sub-package repo package check which is done
by this patch.

Dependency of #2395

* repo: allow creating with folder logic and ignore package

I need to enable users to add a new online repo with ignored
sub-packages and PREFIX folder logic because we often deal with
framework + implementations packages hierarchies.

Dependency of #2395

* repo: add folder logic and ign. sub.pkg to the new repo popup

This patch adds the parameters Folder logic and Ignore subpackages to
the new online repo popup to help us deal with old package which do not
follow the prefix approach for subpackages and to allow us to version
superpackages (which are shared by many developers) in separate
repositories.

I am not sure how to add a check-box to the popup window. I think I need
to find the right table with the righ column of the type char(1).

Closes #2395
2019-03-22 05:50:46 -07:00
Alexander Tsybulsky
80f86bd005 free, go_page, ext error handler 2019-03-22 05:49:33 -07:00
Frederik Hudák
79905ccd82 Escape slashes in branch overview commit messages 2019-03-20 11:46:45 -07:00
Christian Guenter
a3c69433fb Fix: repo sett. display_name ony for online repos 2019-03-18 08:11:15 -07:00
Alexander Tsybulsky
1248319d82 UI move to core package (#2543)
* move to core package

* zcx_cancel to ui_core
2019-03-18 07:58:48 -07:00
Alexander Tsybulsky
1ad16a03fe SCI page deisgn (#2542)
* codeinsp design, phase 1

* fix alpha_output

* final design
2019-03-18 07:58:34 -07:00
Alexander Tsybulsky
85085b6434 improve list css 2019-03-17 01:42:55 -07:00
Alexander Tsybulsky
2ab4ae9f26 Refactor GUI interfaces (#2540)
* refactor gui interfaces

* delete zif_abapgit_gui_router

* move zif_abapgit_gui_page_hotkey to ui

* linter fixes
2019-03-17 01:42:41 -07:00
larshp
ff6725e759 replace uses of log with interface 2019-03-17 01:39:52 -07:00
Alexander Tsybulsky
17dc2501eb GUI, asset manager refactoring (#2536)
* refactor asset manager

* assets man tests

* linter fixes

* linter fix
2019-03-16 03:44:55 -07:00
Lars Hvam
f9318305e9
Minor fixes (#2532)
* minor fixes regarding unused variables

* minor code inspector fixes
2019-03-15 05:54:39 -07:00
Alexander Tsybulsky
9b38d79cce GUI CORE, move constants (#2526)
* zcl_abapgit_gui constants

* renames in all classes

* zif_abapgit_html

* zif_abapgit_html related renames

* remove gui->free for now
2019-03-15 02:22:08 -07:00
larshp
dcaf585d47 move file_download to ui package
move file_download to ui package, part of #2510

the zip class should ideally work without frontend interaction, and just provide/parse the raw xstrings, this way it can be reused across different frontend technologies
2019-03-15 01:52:42 -07:00
Sdfraga
7c8b2228fb Branch Overview Page gitGraph Horizontal Top scrollbar (#2492)
* Adding HTML new elements to BOverview Page

* Adding gitGraph CSS propertires

* Adding gitGraph scroller function

* Set gitGraph Scroller css width dynamically

* Initialize Top Horizontal Scroller on GitGraph

* Adding setGitGraphScroller() to BOverview HTML

* Fixed HTML wrong TAG

* Adding some comments

* Fixing abaplint messages

* Refactoring Indentation for Travis

* Refactoring for Travis

* Removing trailing spaces for Travis
2019-03-14 02:52:40 -07:00
Lars Hvam
48f6cb1bb1
move ZCL_ABAPGIT_FRONTEND_SERVICES to UI (#2516)
* move ZCL_ABAPGIT_FRONTEND_SERVICES to UI

move ZCL_ABAPGIT_FRONTEND_SERVICES to UI package

* move factory and interface

* fix errors found by linter
2019-03-14 01:34:19 -07:00
Lars Hvam
13213e2f2f
decode object name #2504 (#2507)
* decode object name #2504

* fix

* fix
2019-03-14 00:21:02 -07:00
larshp
d8da05b8bc tutorial, show correct abapgit package
tutorial, show correct abapgit package

#2461
2019-03-12 21:49:36 -07:00
Christian Guenter
c7093e753e Remove "disable octicons" user settings 2019-03-06 22:37:05 -08:00
Alexander Tsybulsky
c03bb681b3 Offline icons (#2454)
* font

* css fix and icon rendering

* assets and font link in html head

* more icons

* more css fixes

* replace icon names

* dev docs

* Fonts update

* icons rename

* doc update

* linter fixes

* fix for abapmerge
2019-03-06 00:49:04 -08:00
Lars Hvam
fc167ff3cd
update abaplint config to latest (#2480)
* update abaplint config to latest

* remove some descriptions

* remove more descriptions

* fixes

* fixes
2019-03-04 07:12:42 -08:00
Christian Guenter
963ff52dab Link hints: disable when no tooltips are visible
- Disable link hints mode when no tooltips are visible, e.g. when we pressed a non-existing combination.
- Smaller refactorings
2019-03-01 00:06:53 -08:00
larshp
14beb8cfac refactor nested IF to single IF 2019-03-01 00:06:29 -08:00
Christian Guenter
8cc6567d40 rename zcl_abapgit_tag to zcl_abapgit_git_tag 2019-02-26 21:29:41 -08:00
Christian Günter
389512f690 Patch / git add -p: Add and remove sections
After this commit is applied it is possible to add and remove
sections of code on the stage/patch page.
2019-02-25 21:29:24 -08:00
Christian Guenter
f73e18d587 Online repo "display name" to overrule default name 2019-02-25 07:20:01 -08:00
Christian Guenter
e19c54d3a1 New user setting: Disable parallel processing 2019-02-20 22:20:39 -08:00
larshp
5b44d8e89b REPO, remove method RUN_CODE_INSPECTOR
the successful flag is now saved in code inspector class instead
2019-02-20 22:00:36 -08:00
Lars Hvam
ffcd6c82ed
Refactor code inspector (#2412)
* delete method GET_INSPECTION

delete method GET_INSPECTION, not called from anywhere

* delete class ZCL_ABAPGIT_ABAP_UNIT_TESTS

* delete class ZCL_ABAPGIT_SYNTAX_CHECK

* delete class ZCL_ABAPGIT_ADHOC_CODE_INSP

* move VARIANT to importing in RUN

instead of in the constructor

* one variable containing the name

instaed of 2 with same contents

* linting
2019-02-19 21:37:40 -08:00
Christian Guenter
e91697e4e2 New global user settings 'Disable octicons'
With this commit a new user setting called 'disable octicons' is
introduced. Octicons should be disabled when the client doesn't have
internet access or the abapGit UI hangs sometimes.
By default this option isn't active.
2019-02-18 06:31:06 -08:00
Lars Hvam
d0a721b2cf
Move methods to private (#2416)
* ZCL_ABAPGIT_GUI_CHUNK_LIB move 2 methods private

* HTML_ACTION_UTILS move two methods private

* move calculate_skip_testclass to private

* move BUILD_ASX_NODE to private
2019-02-18 05:27:49 -08:00
Mattias Johansson
add9450d37 Ignore files not in local repo (#2404)
* Changed default text in branch popup

* Downgrade to Abap 7.02 syntax

* Reduce line length of commit (for abaplint)

* Ignore files that are not in local repo

Ignore files that are not in local repo when doing transport to branch

* Changed line indent

* More indentation fixes
2019-02-15 06:52:36 -08:00
larshp
426f815bee downport #2389 2019-02-14 21:10:07 -08:00
larshp
5018eae46c refactor public attributes #2369
refactor public attributes #2369
2019-02-09 23:28:22 -08:00
Lars Hvam
cb4479b95b
Cleanup (#2361)
* pretty print

* move identical code outside IF

* remove space before .

* remove unreferenced variables

* remove unreferenced variables

* remove unreferenced variables

* fix pseudo comment

* remove unreferenced field symbols
2019-02-04 23:08:29 -08:00
Mattias Johansson
0467707a5b Changed default text in branch popup (#2344)
* Changed default text in branch popup

* Downgrade to Abap 7.02 syntax

* Reduce line length of commit (for abaplint)
2019-02-02 03:52:14 -08:00
Christian Guenter
ad7809e4f2 Offline repo: Folder logic in create popup 2019-01-28 00:57:50 -08:00
Lars Hvam
e8b6b0020d
Add interface for ZCL_ABAPGIT_PROGRESS #2303 (#2316)
* interface for progress class

* adjust branch overview

* adjust git pack

* adjust diff page

* adjust objects class

* adjust activation class

* adjust repo online class

* adjust serialize class

few methods moved

* adjust tadir class
2019-01-23 06:28:54 +01:00
Lars Hvam
1a60384e84
move method get_unnecessary_local_objs #2127 (#2315)
* move method get_unnecessary_local_objs #2127

move method get_unnecessary_local_objs #2127

* interface for progress class

* oops, rollback previous commit
2019-01-23 06:27:29 +01:00
Lars Hvam
3f494f091f
Use built-in types (#2306)
* remove uses of DTEL BOOLEAN

* remove uses of DTEL BOOLE_D

* remove uses of DTEL FLAG

* remove uses of DTEL SAP_BOOL

* remove uses of DTEL XFELD

* Update zcl_abapgit_popups.clas.abap
2019-01-20 07:59:24 +01:00
Lars Hvam
ba9968123f
limit shown code inspector findings #2271 (#2307)
* codi_base will now render the full list

* limit list to show first 500
2019-01-20 07:51:41 +01:00