Commit Graph

306 Commits

Author SHA1 Message Date
Christian Guenter
d7e2833483 Warning at stage when not logged on in master lang 2019-10-06 01:12:33 -07:00
Christian Günter
a40e7f1bbc new function 'add all objects to transport request' (#2942)
* new function 'add all objects to transport req'

* enable cancel
2019-10-06 00:21:51 -07:00
Christian Günter
6decda9c07 Refactor zcl_abapgit_gui_view_repo (#2939)
* refactor build branch/tag dropdown

* refactor build advanced dropdown

* refactor build main toolbar

* cleanup

* cleanup

* post merge conflict fixes
2019-10-05 23:17:27 -07:00
Christian Günter
3905c67edd Order by on repo page (#2933)
* Order by on repo page

* move render_cols_pec to zcl_abapgit_gui_chunk_lib

* cleanup

* cleanup

* first new working version

* fix lint

* add OrderByHelper

* add new feature clear

* rename ICON to CLEAR

* cleanup

* refactor actions

* fix typo in method name

* remove duplication

* rename render_col_spec to render_order_by_table_he

* refactor type

* fix eslint warning

* isoltate repo_tab CSS

* fix non-code and metadata files at the top

* refactor

* cleanup

* new features "diffs first" + remove clear

* refactor

* take directories into account

* cleanup
2019-10-05 22:54:04 -07:00
Christian Günter
ee6d488a07 Branch Overview: fix support for branches with # (#2920) 2019-09-16 04:36:47 -07:00
CASAG-MariusRaht
9ad8973ab6 #2725 (#2907)
* #2725

> Bottom logo is now clickable and links to the repository page on GitHub
> New menu item 'Changelog' under 'Help' which links to the changelog.txt

Special Notes: 
> Link to documentation was already implemented
> Link for menu item 'Tutorials' isn't linked to anything. But that seems to be right, because there isn't a tutorial site separated from the documentation website

* abaplint: Normalization

* Update zcl_abapgit_services_abapgit.clas.abap

* Update zcl_abapgit_services_abapgit.clas.abap

* abaplint: fix max line length error

* abaplint

* Removed "|{}|"
2019-09-15 01:09:27 -07:00
CASAG-MariusRaht
0fd851c8d2 #2723 (#2909)
#2723
> Implemented re-run button for syntax check
2019-09-12 07:33:24 -07:00
Christian Günter
b6f82aa8cf Command palette: Jump to files on Diff/Stage page (#2913)
* Patch/Diff: Command palette for file jump

* change hotkey to F2

* cleanup

* Improve JS func call
2019-09-12 05:29:52 -07:00
CASAG-MariusRaht
0e27d90212 Fix for #2896 (#2906)
> Error message for missing development object
> Reopen "Object to File"-PopUp when object was not found
> Spelling correction for error message
2019-09-09 22:02:12 -07:00
Alexander Tsybulsky
739b14ab6a Command palette: Git actions (#2908)
* enumerateToolbarActions

* command prefix

* docs
2019-09-09 21:34:30 -07:00
Alexander Tsybulsky
587f792026 Command palette (Ctrl+P): Go to repo ... (#2897)
* command palette

* support for Ctrl; case insensitive search

* some wip

* refactor KeyNavigation

* eslint

* commandPalette key navigation improved

* last backspace hides the palette

* minor cleanups and ids
2019-09-07 23:12:49 -07:00
Christian Günter
cb00442062 Diff/Patch: Add Jump to file (#2895)
* Diff/Patch: Add Jump to file

* Patch/Diff: Add bottom margin for scrolling

* Remove filtered files from jump list
2019-08-30 04:17:17 -07:00
Alexander Tsybulsky
883c39bd25 column sorting in repo overview (#2887)
* column sorting draft

* linter fix

* remove old code

* fix toggleDetails - remember state

* eslint fix

* remove unused JS functions

* add column header for macro call
2019-08-26 22:06:27 -07:00
Christian Günter
2d143b081a fix CI result CSS (#2884) 2019-08-21 22:25:09 -07:00
Christian Günter
13c227359a Fix code inspector page navigation (#2883) 2019-08-21 22:22:11 -07:00
Jakub Filak
9a6e6e8b24 ui: add a workaround for JavaGUI dyn form bug (#2873)
JavaGUI does not pass values of options from forms generated via
JavaScript.

This commit adds enhances the base page class to render stub forms
(empty form elements), so the page's JavaScript does not need to create
the form element on its own.

It is an optional behavior and can be enabled by redefining the method
get_events which should return table of required events and the base
page object will add the empty form elements for them. Every table line
will be converted to a form with id = "form_" + the event's name.

On the action submit SAP event in the common JavaScript, the method
checks if there is the stub form and if so, the method uses it instead
of creating the dynamic one. Otherwise, it follows the old approach that
creates the form at run-time.

--- v2

Use 'null' instead of 'undefined' to check the form was not found in
the JavaScript code.

---

Issues: #1866, #2769
2019-08-21 22:18:45 -07:00
Alexander Tsybulsky
7133ae4b29 UT fix #2863 (#2871) 2019-08-15 22:23:56 -07:00
Christian Günter
cacf02d285 warning when SAPGUI for Java is used (#2841) 2019-08-05 02:02:42 -07:00
Christian Günter
c008788b9b Improve error information - follow up Part 3 (#2837)
*  Improve tooltip of "Goto source" link

* add another test
2019-08-05 01:57:30 -07:00
Christian Günter
77d3ff885f Fix hint position for checkboxes (#2834) 2019-08-04 09:47:58 -07:00
Christian Günter
4c4fae820f Patch: Disable unified view (#2836) 2019-08-03 04:34:49 -07:00
Christian Günter
99a6716f32 Log viewer: Add more exception information + actions (#2832) 2019-08-03 04:29:32 -07:00
Christian Günter
b994382f78 Improve error information - follow up Part 2 (#2814)
- Cleanup JS
- Delete superflous functions and methods
2019-08-03 04:24:03 -07:00
Alexander Tsybulsky
e379dd3cfe Completely dynamic JS hints (#2825)
* draft rewrite hint to be dynamic

* linter fixes

* remove color setting

* remove backspace and esc handling

* close dropdowns

* return some comments in JS

* linter fixes

* Fix hint for dropdown first time + alw close drdwn
2019-08-02 07:45:27 -07:00
Lars Hvam
8d87beea60
tutorial is just a view, no need to implement intf (#2823) 2019-08-01 03:17:59 -07:00
ThomasPloski
a5ebe60642 Refactoring of ZCL_ABAPGIT_ENVIRONMENT (#2826)
* Refactoring of ZCL_ABAPGIT_ENVIRONMENT #2810

* fixes saplint issues

* fixes saplint isues

* fixes saplint issues

* fixes issue based on review

* align zcl_abapgit_objects.clas.abap to master

* add the test class again
2019-08-01 02:49:59 -07:00
sandraros
3f05693262 UI Dark Theme #2610 (#2787)
* UI Dark Theme #2610

Proposal - Right now, only the first obvious screens were checked, and there are still a few issues with them.

* CSS cleanup of unused elements
2019-08-01 00:57:30 -07:00
Alexander Tsybulsky
d8b3034a30 close button css fixes (#2819) 2019-07-31 00:44:59 -07:00
Alexander Tsybulsky
29c45a7e7c more convenient html pp comment (#2817) 2019-07-31 00:36:51 -07:00
Christian Günter
50a6cf8ac9 Improve error information - follow up Part I (#2813)
* Improve error information - follow up Part I

- Bug: remove errorenous regex
- Add tooltip for message id and message class

* Replace text of message link
2019-07-30 05:04:00 -07:00
Christian Guenter
50cc8b810f Better error message 2019-07-30 03:05:39 -07:00
Christian Günter
5081ddf7d0 Improve error information - HTML error message (#2775)
* Improve error information

With this commit errors that are raised with zcx_abapgit_exception=>raise
and issued with message are enriched with two additional functions.

1) Go to source
Navigates to the source code position where zcx_abapgit_exception=>raise
is called

2) Callstack
Shows a popup with the full callstack and the possibility to navigate to
the source of each line with double click

This feature requires the full abapGit repository. Without nothing
changes.

* issue messages directly

* zcx_abapgit_exception: adapt callstack handling

- callstack as attribute
- export callstack to ABAP memory only when SAPGui is available

* rename memory id

* Add comment why we don't delete callstack from MEM

* cleanup

* first try html error display

* add some comments

* add longtext

* goto_source and callstack implemented

* part 2

* remove

* fix

* add close button

* fix long classname

* fix linter

* add jump to SE91

* fix lintmr

* fix and cleanup

* fix linter

* fix linter

* fix eslint

* fix linter

* remove message class

* remove superfluous constant

* add missing method implementation

* refactor

* add hotkey for message longtext toggling

* hotkey 2

* refactor + resize callstack popup

* Refactoring: simplify control flow

* fix goto callstack for merged abapGit

* refactor: simplify control flow

* Refactoring: introduce message helper

* fix linter

* remove TODO pragmas

* ren. render meth + move zcl_abapgit_gui_chunk_lib

* refactoring: simplify control flow

* simplify exception handling

* refactor

* refactor

* refactor

* remove duplication

* Rename method

* rename method

* remove superfluous constant

* call ZCL_ABAPGIT_MESSAGE_HELPER dynamically

* cleanup

* Improve UX

* fix linter

* remove hotkey
2019-07-28 03:46:53 -07:00
Christian Guenter
24e319cc68 Downport 2019-07-18 07:07:20 -07:00
Łukasz Pęgiel
63c8e4808c add log for Offline install (#2798)
* add log for Offline install

* white space
2019-07-17 08:17:09 -07:00
Christian Guenter
1a9d1b3d08 Patch: delete all lines removes the file 2019-07-17 00:58:31 -07:00
Lars Hvam
1dbd4d1912
Refactoring types (#2785)
* align use less different types

* refactor

* updates
2019-07-15 09:33:37 -07:00
Frederik Hudák
0299fb61c7 Consistent sort ordering of files (#2778) 2019-07-10 00:37:09 -07:00
Lars Hvam
f88237f411
remove double spaces (#2770)
* remove double spaces

* whitespace
2019-07-02 20:54:35 -07:00
Lars Hvam
c84b209944
Minor lint updates (#2766)
* remove some double space

* update abaplint to latest

* fixes
2019-07-01 22:08:54 -07:00
Alexander Tsybulsky
df0aca8272 Improve css preprocessing (#2765)
* improve assetman get_text_asset

* move css_processor to ui_core, reuse get_text_asse

* fix %26 refactor UTs

* zcl_abapgit_gui_html_processor

* if fix

* replace core logic

* comment finetuning

* linter fixes

* more linter fixes

* fix UTs, based on review
2019-07-01 20:53:43 -07:00
Christian Guenter
1f52d8b2c7 TR request jump: fallback to SAPGUI 2019-07-01 20:50:06 -07:00
Frederik Hudák
f5d421e399 ADT jump for package link and transports (#2758)
* ADT jump for package links

* Also handle transport requests/tasks

* fix abaplint
2019-06-28 23:02:37 -07:00
Lars Hvam
f6e8332754
Cleanup (#2753)
* refactor IF

* fix some indentation

* indentation fixes

* indentation fixes

* indentation

* indentation
2019-06-25 03:02:51 -07:00
Fabian Lupa
7f04d59bf9 Belize theme (#2733)
* Add Belize theme

* Implement polyfill for CSS variables

* Fix CSS variables with spaces in values

* Always load default theme and add others on top

* Adjust theme CSS for use with variables

* Support variables referencing variables in CSS

* Adjust themes

* Add font size to theme

* Skip asset registration for unused themes

* Unify theme greyscale

* Refactor CSS preprocessor

* Refactor CSS preprocessor, add basic tests

* Fix linter issues

* Always load theme asset

Otherwise switching does not work
2019-06-25 03:02:40 -07:00
Martin Fuchs
4aab0166ac Pass log to deserialization API and show log (#2729)
* Pass log interface for de-serialization

Interface ZIF_ABAPGIT_LOG is now passed for deseriaization API.
This includes:
- Log messages for FUGR: Imported function modules and includes
- Improved error messages for TABL compare
- Log objects w/o changes
- Log is shown in the UI if available ("Log" entry appears if a log exists, no persistence!)
This PR enhances #2534 and #2694

Another important change: In case an object fails (or a single function module in a group fails), the import continues with the next object!

* small pretty printer changes

small pretty printer changes

* fix abaplint issues

reduce line sizes and ensure 7.02 compatibility

* show errors and warnings from pull

Errors and warnings after a pull are now part of the "message list" above the object list in the main screen and will be shown immediately. The new"Log" button shows errors, warnings and success messages on demand.
The log title is now part of the ZIF_ABAPGIT_LOG interface.

* fix abaplint issue

fix abaplint issue
2019-06-21 23:05:10 -07:00
Frederik Hudák
c679d11d7b Change behavior of second back button to go home (#2679)
* Change behavior of second back button to go home

* Change logic as proposed

* Don't go to tutorial page on exit

* Final changes

* Fix abaplint
2019-06-13 22:59:18 -07:00
Thomas B
84042f1370 Enhance 'Transport to ZIP' to process multiple transport requests (#2683)
* New Program : Mass Transport to local zip file

Create new program ZMASSGIT in order to convert multiple tranport request to local zip files ( by giving output folder ).
Timestamped subfolder will be created in the input folder.

* Add files via upload

* Update zmassgit.prog.abap

* Add files via upload

* Add files via upload

* Delete zmassgit.prog.xml

* Delete zmassgit.prog.abap

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.abap

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.xml

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.abap

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.xml

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipscr.abap

* Rename zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipscr.xml to src/zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipscr.xml

* Rename zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2ziptop.abap to src/zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2ziptop.abap

* Rename zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2ziptop.xml to src/zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2ziptop.xml

* Rename zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.abap to src/zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.abap

* Rename zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.xml to src/zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.xml

* Rename zabapgit_masstransp2zip.fugr.xml to src/zabapgit_masstransp2zip.fugr.xml

* Rename zabapgit_masstransp2zip.fugr.z_abapgit_transports_2_zip.abap to src/zabapgit_masstransp2zip.fugr.z_abapgit_transports_2_zip.abap

* Rename zcl_abapgit_transport_mass.clas.abap to src/zcl_abapgit_transport_mass.clas.abap

* Rename zcl_abapgit_transport_mass.clas.xml to src/zcl_abapgit_transport_mass.clas.xml

* Delete zcl_abapgit_zip.clas.abap

* Delete zcl_abapgit_zip.clas.xml

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Update zcl_abapgit_zip.clas.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.abap

* Update zcl_abapgit_transport_mass.clas.xml

* Update zcl_abapgit_transport_mass.clas.abap

* Update zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.abap

* Update zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.xml

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.abap

* Update zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.abap

* New version without function group

* Cleanup

* Abaplint

* AbapLint Fixes

* Remove plugins objects from master

* Skip log flag in ZIP export

* Popup to ask the Export logic ( FULL / PREFIX ..)

* line length for abaplint

* Refactoring of code

Avoid redundancy of code and remove unused constant.

* Reduce line 50 length for abaplint ( < 120 )

* Change by the review of code

Refactoring of code

* AbapLint Fix
2019-06-11 08:57:08 -07:00
Alexander Tsybulsky
6845fe3ea4 Ui themes support (#2700)
* settings ui_theme

* theme css rendering

* theme split

* linetr fix
2019-06-07 03:36:44 -07:00
Martin Fuchs
2e781b316a ZIF_ABAPGIT_LOG: extend and move UI methods to new class (#2694)
* log: move show functions to new class

Enhance ZIF_ABAPGIT_LOG
- add IS_ITEM structure (object) to message adding functions
- add method "add_exception"
- add method "add_info"
- relocate methods "show", "to_html" and "write" to new class ZCL_ABAPGIT_LOG_VIEWER
Introduction of new log viewer class ZCL_ABAPGIT_LOG_VIEWER
Replacement of relocated methods where used
-> This is the next step providing a log for serialzation/de-serialization (see #2534)

* fix abaplint issues

fix abaplint issues

* fix abaplint issues (2)

fix abaplint issues
2019-05-26 03:16:03 -07:00
Domi Bigl
b6b3551238 downport assert_true()/false() #2698
702 don't know cl_abap_unit_assert%3D>assert_true() and assert_false()
2019-05-25 22:44:28 -07:00