SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 11:46:38 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
6,179 Commits 4 Branches 39 Tags 53 MiB
d9c4483cc2
Commit Graph

163 Commits

Author SHA1 Message Date
Fabian Lupa
799334dfe2
Add exposure to workflow class attributes (#5603) 
* Add exposure to workflow class attributes

* Add constant seoc_state_implemented to abaplint

* Also add seoc_state_implemented to ci/abaplint

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2022-05-31 20:33:17 +02:00
Lars Hvam
f0b3c96474
Align pragma style (#5535) 2022-05-07 09:08:34 +02:00
Lars Hvam
5a5630c198
update to latest npm packages (#5501) 
* update to latest npm packages

* update

* update abaplint config to latest
 2022-05-06 09:10:03 +02:00
Marc Bernard
1b4582bc03
Fix commit message encoding (#5508) 
* Fix commit message encoding

- Properly encode % and & symbols
- Add unit test for special characters

Closes https://github.com/abapGit/abapGit/issues/2448

* Exclude testclass

* Comment

* update to 2.0.17

* update to 2.0.18

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2022-05-05 15:29:38 +02:00
Lars Hvam
fd395e9288
update linter config (#5425) 
* wip

* update config

* update linter config

* update
 2022-04-01 10:13:26 +02:00
Lars Hvam
c3b9980486
replace XUBNAME with SYUNAME (#5248) 2022-01-06 08:18:45 +01:00
Lars Hvam
c0252083ff
abaplint config: no use of cl_aunit_assert (#5225) 2021-12-17 08:24:39 +01:00
Lars Hvam
4301d3e8c8
no chained assignment (#5140) 
* no chained assignment

* bugfix
 2021-11-19 16:19:27 +01:00
Lars Hvam
95effcdfbb
abaplint: additional forbidden void types (#5096) 2021-11-03 14:54:54 +01:00
Lars Hvam
cf642470d6
unit testing updates (#5027) 
update to eslint 8
run 4 more unit test methods
update abaplint stuff to latest
 2021-10-11 14:30:51 +02:00
Lars Hvam
3b67d90e76
5 additional unit tests running (#4935) 2021-09-10 07:46:05 +02:00
Lars Hvam
1b091a5241
update abaplint to latest (#4917) 2021-08-30 07:31:44 +02:00
Lars Hvam
9f025fa656
testing scaffolding (#4875) 
* additional classes are transpiled
* additional unit tests run under node.js
* `abap_transpile.json` moved to folder `/test/` from root
* new `npm run integration` target, doesnt really do anything yet
* new `/test/Readme.md` with [notes and stuff](https://github.com/abapGit/abapGit/pull/4875/files#diff-5de36acd90308dc62abf7855a686ee7052ffb6e762c756fd735fb0c9fbd9595d)
 2021-07-29 16:55:43 +02:00
Lars Hvam
a52ab7329b
update deps + additional unit testing via open-abap (#4871) 2021-07-18 13:17:24 +02:00
Lars Hvam
5365f536ae
update deps (#4854) 
* update deps

* upd
 2021-07-01 10:08:09 +02:00
Lars Hvam
096aded586
LANGU rollbacks (#4829) 
* LANGU rollbacks

#4828

* Update abaplint.json
 2021-06-08 16:42:20 +02:00
Lars Hvam
6098a4fbdb
update deps (#4818) 
* update deps

* upd
 2021-06-06 09:41:13 +02:00
Marc Bernard
e2a156a326
Replace deprecated LANGU type (#4815) 
* Replace deprecated LANGU type

Replace with `sy-langu` and update abaplint rule

* Replace langu

* Add langu to void types

* Replace table of langu
 2021-06-02 08:04:05 +02:00
Lars Hvam
c3aa834cc8
lint config: avoid use of BOOLE_D (#4798) 2021-05-28 06:22:52 +02:00
Lars Hvam
bebf39a704
update dependencies (#4785) 2021-05-27 16:40:21 +02:00
Lars Hvam
bd391fc04f
more unit tests running, update deps (#4773) 
* update deps

* upd

* upd

* update deps

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* split_path running

* upd

* upd

* add zcl_abapgit_gui_functions

* upd

* add zcl_abapgit_persistence_user

* upd

* upd

* upd

* upd

* upd

* upd

* upd

* decode_tag running

* upd

* upd

* upd

* ltcl_git_pack_decode_commit running

* decode_tag running

* ltcl_zlib->fixed running

* pack_short running

* pack_long running

* pack_multiple running

* upd

* upd

* upd

* start testing dynamic instance creation

* upd

* get_value running

* get_node_type running

* exists running

* 3 value_ methods running

* get_date running

* upd
 2021-05-22 06:23:40 +02:00
Marc Bernard
c2e9e58319
Enhance "Force Pull" to become "Selective Pull" (#4733) 
* Enhance "Force Pull" to become "Selective Pull"

With this PR you can now peform a selective pull. Yay!

- Changes "Force Pull" to show *all* changed objects in the usual "Overwrite Popup". This allows you to select individual objects to be pulled no matter if they were changed locally or remotely.
- Does *not* change the regular "Pull" logic

Closes #413, #4282

* Combine delete and overwrite popups

* Add icons to abaplint.json

* Change if to case

* Add icons to abaplint.json

* Enhance UTs

* show_icon

* Show icon

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2021-05-20 06:19:00 +02:00
Lars Hvam
b2d7dbd81e
update deps (#4730) 2021-04-29 07:14:41 +02:00
Lars Hvam
65c9b5c717
update abaplint to latest (#4662) 
* update abaplint to latest

* upd
 2021-03-24 12:53:50 +01:00
Lars Hvam
a5856a04c7
update npm deps, update abaplint configuration to latest (#4628) 
* update deps

* update abaplint config

* update to latest

* upd

* upd
 2021-03-12 07:17:05 +01:00
Lars Hvam
d0a7f97dda
additional forbidden void types (#4532) 2021-02-18 15:53:59 +01:00
Lars Hvam
ed89d2dd7c
update abaplint.json, dont define the same constant twice (#4531) 2021-02-18 14:55:11 +01:00
Lars Hvam
5efc7a63ab
update deps in package.json (#4514) 
* update deps in package.json

* enable rule max_one_method_parameter_per_line
 2021-02-15 14:16:16 +01:00
Lars Hvam
8e07d46f4b
jump_se11, remove unused parameters (#4498) 2021-02-09 15:50:27 +01:00
Lars Hvam
a704c355aa
unit testing test (#4391) 
* unit testing test

* upd

* upd

* upd

* upd

* update deps

* upd

* upd

* update deps

* upd

* update abaplint to latest

* enable rule use_class_based_exceptions
 2021-01-12 15:57:17 +01:00
Lars Hvam
0003d8b85e
update ajson with writer (#4255) 
* update ajson with writer

* update to latest

* fix exceptions

* convert exception
 2020-12-18 09:55:57 +01:00
Lars Hvam
260af61407
ecatt exceptions, test (#4312) 2020-12-12 08:51:49 +01:00
Lars Hvam
0a24986682
update linter configuration to latest (#4241) 
* update linter configuration to latest

* rerun

* rerun
 2020-11-24 17:07:14 +01:00
Lars Hvam
a53776ab5a
delete unused method in ZCL_ABAPGIT_OBJECT_CHDO (#4130) 
* delete unused method

delete unused method GET_GENERIC in class zcl_abapgit_object_chdo

* enable rule unused_methods
 2020-11-03 14:55:01 +01:00
Mike Pokraka
c1b2cf10a0
Update unit tests to use CI (#4106) 
* Update unit tests to use CI

* Make test repo configurable

* Remove local tests and use CI

* Lint fixes

* Replace local tests with CI

* Add Type Group constants to abaplint

* Update constants and replace assert_true

* Revert constants

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-11-03 08:49:22 +01:00
Lars Hvam
bda8280ba0
abaplint: enable parser_702_chaining rule (#4121) 2020-11-02 14:51:47 +01:00
Marc Bernard
bdc44f7476
Remove self-references (#4115) 
* Remove self-references

Remove unnecessary self-references (me->)

https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-method

* 702: Fix syntax error

No chaining with EXPORTING & CHANGING

* remove addiontal me, update abaplint config

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-11-02 09:25:27 +01:00
Lars Hvam
ff962f82e8
remove INTERFACE LOAD statement (#4035) 2020-10-17 11:07:28 +02:00
Lars Hvam
45bc9ed91d
update linter configuration (#4008) 2020-10-11 10:40:18 +02:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991) 
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
 2020-10-07 08:54:15 +02:00
Lars Hvam
1c1b04fbe9
update lint config, minor refactors (#3948) 2020-09-27 09:24:31 +02:00
Lars Hvam
03724484f1
use boolc (#3920) 2020-09-23 12:28:13 +02:00
Lars Hvam
015800b45b
Less DDIC references (#3905) 
* remove uses of CHAR30

* Update abaplint.json

* add basic unit test for ZCL_ABAPGIT_MESSAGE_HELPER

* replace uses of char50

* fix name

* Update abaplint.json

* use sy-uname instead of uname

in ZCL_ABAPGIT_USER_MASTER_RECORD
 2020-09-21 07:39:22 +02:00
Alexander Tsybulsky
d20cdd07c2
syst_title is missing in 731 (#3896) 
* syst_title is mising in 731

* adjust type

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-09-17 17:40:38 +02:00
Lars Hvam
b4169ff4b6
update lint config, plus remove identical condition (#3892) 2020-09-16 15:51:12 +02:00
Lars Hvam
42a532b9eb
reduce usage of ddic types (#3859) 
* add SAP_BOOL as forbidden void type

* reduce

* Update abaplint.json

* sychar10

* sylangu

* Update abaplint.json
 2020-09-10 15:30:25 +02:00
Lars Hvam
cbb35ade88
linter: add numc2 as forbidden void type (#3837) 2020-09-04 09:36:31 +02:00
Lars Hvam
428575fb58
1.99.1 (#3832) 
* v1.99.1

* 1.99.1

* linter, enable rule line_break_style
 2020-09-03 09:30:44 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827) 
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
 2020-09-03 09:13:47 +02:00
Lars Hvam
75b83825ed
update linter config (#3822) 2020-09-01 16:27:16 +02:00
Alexander Tsybulsky
a4e6c87985
Switching to PRs (#3695) 
* string map: public entries (read only)

* port http agent

* draft wip

* drafting

* fix SSL

* port ajson

* integrate ajson and http_agent

* agent global headers

* github enumerator

* update ajson

* draft wip

* enumerator factory

* http_agent via factory

* proxy

* repo->switch_origin draft

* refactor enum factory

* Revert "refactor enum factory"

This reverts commit bcfef40b38991adfe5f73677919db6bd0c652f7c.

* page wiring draft

* scripts draft

* "let it work!"

* repo setings page draft

* linter

* linter

* linter

* linter

* linter

* better settings page

* finetune page

* cleanups

* change hotkey

* fix ajson_error

* Update src/zcl_abapgit_repo_online.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* abaplint nesting 6

* remove description

* back to good old popups

* linter

* move commands to branches dropdown

* auth helpers

* move json to separate package

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-08-27 07:47:27 +02:00
Lars Hvam
e88f522e83
OTGR: syntax error, disable parents temporarily (#3787) 
* OTGR: syntax error, disable parents temporarily

* Update abaplint.json
 2020-08-24 11:36:58 +02:00
pokrakam
b20a020637
Allow naming of different test class types (#3771) 
* Allow naming of different test class types

Propose to use the more commonly used naming conventions for test classes rather than naming everything ltcl_. These are used by SAP and also referenced in the style guides e.g. the section on [Helper Methods](https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#put-help-methods-in-help-classes) and used in the ABAP unit testing book.

ltc_: test class
lth_: test helper
ltd_: test double
lts_: test suite

Oh, and also corrected bug in exception class name that I spotted when editing

* Update with generic naming suggestions

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-08-19 08:41:55 +02:00
pokrakam
138172ffda
Exclude test class with XML from line length check (#3755) 
* Exclude test class with XML from line length check

We could also exclude all zcl_abapgit_object*testclasses or even test classes in general.

* Correct syntax

* Update abaplint.json

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-08-17 20:37:18 +02:00
Lars Hvam
d1f277365b
create_sotr, remove unused parameters (#3739) 
* minor changes

* create_sotr, remove unused parameters
 2020-08-16 08:21:49 +02:00
Lars Hvam
7cf1202723
update linter configuration (#3734) 2020-08-14 12:22:32 +02:00
Lars Hvam
867c74701f
remove some unused variables (#3719) 
* remove some unused variables

* more unused
 2020-08-09 08:44:54 +02:00
Lars Hvam
37ec998898
update lint config (#3618) 2020-07-13 10:22:33 +02:00
Lars Hvam
74ea9f046a
linting: errors for anything that contains "ABAPGIT" (#3523) 2020-06-18 17:03:23 +02:00
Lars Hvam
024167ce97
replace SYREPID (#3501) 
* Update abaplint.json

* replace SYREPID
 2020-06-16 07:34:12 +02:00
Lars Hvam
9af61c99c6
fully type sydatum and syuzeit (#3457) 2020-06-07 09:01:08 +02:00
Lars Hvam
d36b43defe
line break parameters (#3444) 
* line break parameters

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* fix
 2020-06-04 15:10:35 +02:00
Lars Hvam
ea03cc5e4a
Fewer DDIC type references (#3434) 
* Fewer DDIC type references

* Update abaplint.json
 2020-05-29 06:30:24 +02:00
Lars Hvam
aec7468aad
Type Hunting (#3414) 
* Type Hunting

* update

* update

* flag
 2020-05-26 05:55:28 +02:00
Lars Hvam
f431d30140
setup linting of the compiled report (#3408) 
* lint the compiled report

* change

* Update ci.yml
 2020-05-24 10:36:14 +02:00
Lars Hvam
f17eddfd6b linting, update error namespace 2020-05-23 11:46:36 +02:00
larshp
323789836e add icons 2020-05-18 07:20:06 +02:00
larshp
0308182f81 update lint config 2020-05-16 10:39:15 +02:00
g-back
07c87edd03
PINF: Exporting to Returning Parameter (#3252) 
* change exporting to returning parameter

* enable prefer_returning_to_exporting
 2020-03-11 11:42:15 +01:00
Lars Hvam
136dfaf8d3 disable ambiguous_statement rule 
its not possible to make MODIFY explicit on 702 syntax
 2020-02-08 14:34:45 +01:00
Lars Hvam
7d0503218e no macros #3170 2020-02-03 09:20:58 +01:00
Lars Hvam
38837c3268
zlib, remove macros, #3170 (#3190) 
* zlib, remove macros, #3170

* sneaky update to abaplint.json

* sneaky sneaky

* Update abaplint.json
 2020-02-02 07:01:56 +01:00
Lars Hvam
3e0b0505b1
remove commented code (#3166) 
* update abaplint.json

* remove commented code

* remove 2 unused variables
 2020-01-24 14:31:04 +01:00
larshp
54f8f41c22 update abaplint.json 2020-01-11 09:41:52 +01:00
Lars Hvam
75812fb17b
less prefixes (#3144) 2020-01-11 09:24:36 +01:00
Lars Hvam
363baf7733
Update abaplint.json (#3143) 
* Update abaplint.json

* Update abaplint.json
 2020-01-08 07:24:26 +01:00
Lars Hvam
e201bf566f
remove class prefixes if its current class (#3137) 
* remove class prefixes if its current class

* Update abaplint.json
 2020-01-06 13:20:19 +01:00
Lars Hvam
b42f3bc485
Refactoring (#3134) 
* fully type constants

* moving to single line

* move to single line

* enable keep_single_parameter_on_one_line
 2019-12-28 12:11:32 +01:00
Lars Hvam
819a26527c update to latest lint version 2019-12-27 08:02:40 +01:00
Lars Hvam
29cb891d23
remove obsolete NO_HANDLER pragmas (#3085) 
* remove obsolete NO_HANDLER pragmas

* update lint to latest
 2019-11-25 07:35:41 +01:00
mariusraht2
064e006c88 Issue 3042: Error author regex (#3070) 
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Tags: Error author regex

> Regex couldn't match with string "pull[bot] <39814207+pull[bot]@users.noreply.github.com> 1573216988 +0000" because "[]" weren't allowed

* abapLint

* Added unit test for author_regex

#3042

* Any character in author name and Unit Tests

#3042
#3069

* Unit Tests and utils method for author regex

#3042
#3069

> Unit Tests for author_regex (zif_abapgit_definitions)
> New utils method for regex check as utils method in zcl_abapgit_utils
> Regex for author expects now at least one character for the author name ('^(.+)'...)
> Use zif_abapgit_definitions%3D>ty_commit_tt  instead of local type of the same type in class zcl_abapgit_branch_overview

* Changed utils method/tests and moved unit tests

#3042 - Error author regex
#3069 - Add unit tests

> Renamed is_author to extract_author_data and moved related source code from branch_overview to utils class
> Changed related unit tests to handle exception or not
> Moved unit tests to local class of zcl_abapgit_utils

* abapLint

* abapLint

* abapLint

* abapLint

* exclude 7bit test for testclass
 2019-11-21 06:40:25 +01:00
Lars Hvam
6b3fc6ebed update abaplint 2019-11-20 17:48:50 +01:00
Lars Hvam
04a6d7e484
Update abaplint.json to latest (#3045) 
* Update abaplint.json

* chain mainly declarations
 2019-11-06 09:35:18 +01:00
Lars Hvam
dbe484e124 disable no_public_attributes, temp workaround 2019-10-31 12:49:10 +01:00
larshp
d0e3956df8 update to latest 2019-10-27 12:05:47 +01:00
Lars Hvam
bed6050437
abaplint: add extra rules (#2953) 2019-10-07 23:00:12 -07:00
Frederik Hudák
3ae7e3ad66 Shorten abaplint.json by omitting optional properties (#2915) 
Due to recent changes in abaplint, the config can now be shortened by removing properties equal to their default values.
 2019-09-12 07:39:56 -07:00
Lars Hvam
14f01f64d5 enable additional rules 2019-08-30 05:36:36 -07:00
Lars Hvam
573cfb7e06
update to abaplint 2.0.0 (#2898) 
* Update abaplint.json

* Update package.json

* Update package.json
 2019-08-30 04:05:09 -07:00
Lars Hvam
4b84d0ae0a
Lint (#2870) 
* rewrite

* Update abaplint.json

* Update abaplint.json

* move to include where its used

* Update .gitignore

* Update package.json

* update to latest
 2019-08-15 05:52:02 -07:00
Lars Hvam
27f712a47b
linting (#2861) 
* rewrite

* Update abaplint.json

* Update abaplint.json

* move to include where its used

* Update .gitignore

* Update abaplint.json

* Update package.json

* Update package.json
 2019-08-11 23:16:10 -07:00
Lars Hvam
971efbfaac Update abaplint.json 2019-08-09 04:13:04 -07:00
Lars Hvam
c173458e39
avoid use of STATICS #2828 (#2858) 
* enable check for STATICS

* refactor to CLASS-DATA

* rename
 2019-08-08 01:30:13 -07:00
Lars Hvam
cadb70c7bb
linting, add global constants (#2849) 2019-08-06 23:13:08 -07:00
Lars Hvam
88a5b4cd50
update to latest abaplint (#2829) 
* update to latest abaplint

* Update package.json
 2019-08-02 01:32:14 -07:00
Lars Hvam
c84b209944
Minor lint updates (#2766) 
* remove some double space

* update abaplint to latest

* fixes
 2019-07-01 22:08:54 -07:00
Lars Hvam
58235f1e6a
do not skip descriptions check for exception classes (#2714) 
* do not skip descriptions check for exception classes

* remove description

* remove description

* remove description

* remove description

* remove description

* remove description

* remove description

* remove description
 2019-05-29 23:54:06 -07:00
Lars Hvam
0f7fb3658a
Align code, compare operators #2670 (#2702) 
* Update abaplint.json

* UDMO change compare operator
 2019-05-26 03:38:54 -07:00
Lars Hvam
9fade89856
change constructors to public (#2677) 
* enable abaplint constructor check

* change constructor to public

* change constructor to public

* change constructors to public
 2019-05-16 23:20:10 -07:00
larshp
76c91e0cc5 update to latest abaplint config 2019-05-14 15:43:47 +02:00