Commit Graph

24 Commits

Author SHA1 Message Date
Marc Bernard
dd37881589
702: Fix syntax error and missing check variant (#4117)
* 702: Downport 

No chaining with CHANGING

* 702: Downport

* Syntax check variant

* Too many fields warning

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:29:09 +01:00
mariusraht2
54ce6771bd
Issue #4027: Resolve possible crash of AG and add option to be able to suppress showing commit hash on Code Inspector result page (#4028)
* Replace LEAVE with CALL SCREEN

* Add new option iv_show_commit

Add new option iv_show_commit to GUI_CHUNK_LIB to be able to suppress showing commit hash on GUI_PAGE_CODE_INSP page

* abapLint: Replace 'EQ' by '='

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Hide commit hash on other pages too

Hide commit hash on ZCL_ABAPGIT_GUI_PAGE_REPO_SETT and ZCL_ABAPGIT_GUI_PAGE_SYNTAX pages

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-19 11:19:02 +02:00
Alexander Tsybulsky
555f2f3d0b
html event abstraction, phase 1 (#3900)
* event class, interface and gui

* router adaptation

* rest of the pages

* linter fixes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-19 07:57:39 +02:00
Lars Hvam
86657cc691
HTML refactoring (#3813)
* HTML refactoring

* removes the ADD_ICON alias

#3460

* remove IS_EMPTY alias

* more

* refactoring
2020-08-31 09:37:36 +02:00
Lars Hvam
dcc655eccf
syntax check page, show variant used (#3790)
* syntax check page, show variant used

closes #3660

* unify variant rendering
2020-08-25 07:05:32 +02:00
Frederik Hudák
a824368a4e
Add top repo menu to more pages (#3764)
* Add top repo menu to more pages

- diff, patch
- syntax check, code inspector
- repo settings

* Add to syntax check page, add margin

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-22 09:53:35 +02:00
Frederik Hudák
f5052cf0b6
Use title case in page titles, menus, forms (#3765)
* Use title case for page titles

Other minor changes:

- patch page is no longer called diff
- "code inspector" in main page action menu renamed to "check"

* Two more

* Update zcl_abapgit_gui_page_db_dis.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Repo advanced menu

* Commit form labels

* Repo setting lables

* Settings, repo

* Final ones?

* Database util

* Column name in stage page

* abaplint

* Update zcl_abapgit_gui_page_stage.clas.abap

* Hover texts for stage column, commit settings

* lint
2020-08-22 09:50:10 +02:00
Marc Bernard
324db52335
Enhance result view of Code Inspector/Syntax Check (#3717)
* Enhance result view of Code Inspector/Syntax Check

* Enhance result view of Code Inspector/Syntax Check

* Enhance result view of Code Inspector/Syntax Check

* Lint

* Move sort
2020-08-07 07:17:42 +02:00
Lars Hvam
420e6f5964
replace HTML with interface (#3490)
* replace HTML with interface

part of #3460

* pretty print
2020-06-13 09:39:46 +02:00
Alexander Tsybulsky
c056076170
Gui refactoring 2 (#3338)
* hotkeys refactoring: draft logic

- new interfaces
- gui services binding
- move render to zcl_hotkeys
- move global hotkeys to hotkeys class
- remove unnecessary stuff from gui_page

* implement zif_abapgit_gui_hotkeys in rel.pages

* settings page draft

* remove zif_abapgit_gui_page_hotkey

* linter fixes

* finalize rendering logic

* finalize settings

* linter fix

* sorting tweak

* fix abapgit_full work

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-05-08 10:26:54 +02:00
Alexander Tsybulsky
0eb22a0c87
Gui refactor, part 1 (#3289)
* gui component and event registering

* remove iv_prev_page from event_handler if

* constructors raising zcx_abapgit_exception

* get_gui_services - UT friendly

* linter fixes

* more linter fixes

* zif_gui_services stub all methods

* linter fix

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-07 10:30:43 +02:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
Christian Guenter
bae1e21c5b Refactoring: Delete unused variables 2020-01-13 18:41:52 +01:00
CASAG-MariusRaht
0fd851c8d2 #2723 (#2909)
#2723
> Implemented re-run button for syntax check
2019-09-12 07:33:24 -07:00
Srinivasu Reddy
94604a7db5 syntax page "no errors" more neat
Display no errors message in syntax check with green check and no syntax errors message
2019-04-22 22:45:59 -07:00
Lars Hvam
ffcd6c82ed
Refactor code inspector (#2412)
* delete method GET_INSPECTION

delete method GET_INSPECTION, not called from anywhere

* delete class ZCL_ABAPGIT_ABAP_UNIT_TESTS

* delete class ZCL_ABAPGIT_SYNTAX_CHECK

* delete class ZCL_ABAPGIT_ADHOC_CODE_INSP

* move VARIANT to importing in RUN

instead of in the constructor

* one variable containing the name

instaed of 2 with same contents

* linting
2019-02-19 21:37:40 -08:00
Lars Hvam
ba9968123f
limit shown code inspector findings #2271 (#2307)
* codi_base will now render the full list

* limit list to show first 500
2019-01-20 07:51:41 +01:00
larshp
788a7fedb9 naming conventions #2053 2018-11-07 09:00:12 +01:00
Frederik Hudák
1bb195b344 Removed the rest of endmethod/endclass comments 2018-10-18 07:27:27 +02:00
Lars Hvam
fa39fcd43f
Code inspector fixes (#1997)
* pretty print

* definitions to top of routine

* space before .

* omit parameter names where possible

* double space after if

* remove pseudo comments where possible
2018-10-12 07:56:27 +02:00
Marcello Urbani
eb34b7eeec Share output and event handler for code inspector 2018-09-25 16:23:07 +02:00
Christian Günter
fc1df4b9ee Introduce customizable hotkeys #1728 (#1820)
* Introduce customizable hotkeys

With this commit customizable hotkeys are introduced. They can
be defined in the user specific settings. Currently we support
only one letter keybindigs e.g. 's', 't' or 'x' and no modifiers.

Every page in the UI can decide which actions it offers for the
hotkeys. Therefore we introduce the interface ZIF_ABAPGIT_GUI_PAGE_HOTKEY
with the method GET_HOTKEY_ACTIONS. At this point in time only
the main page offers actions for hotkeys, but the mechanism works
already for all pages. New actions for hotkeys can be defined
easily.

Hotkeys are only available for installed abapGit repositories.
Because we need to detect the classes which implement the above
mentioned interface and it seems that there is no easy way to do
that for local classes. Maybe we can add it later when we know more.

We don't supply default key bindings. So it is totally up to the
user to define them.

* provide default hotkeys
2018-08-16 06:32:03 +02:00
christianguenter2
ea798193d0 Block commit/push if code inspection has errors
- new local setting to set check variant
- new local setting to block pull if code inspector check fails
- check is executed before staging
- new page to display code inspector results
2018-06-28 13:21:29 +02:00
Lars Hvam
68d0571516
More classes to global (#1209)
* lcl_background to global

* lcl_branch_overview to global

* lcl_services_git to global

* lcl_services_repo and lcl_services_db to global

* lcl_services_abapgit to global

* lcl_gui_chunk_lib to global

* lcl_gui_view_tutorial to global

* lif_auth to global

* lcl_auth and lcl_gui_view_repo to global

* lcl_view_repo

* lcl_gui_page_syntax to global

* 2 pages to global

* refactor router, less dynamic references

* background pages to global

* branch overview to global

* settings page to global

* repo settings page to global

* explore page to global

* diff page to global

* debug info to global

* main page to global

* refactor router, no dynamic references

* db pages to global

* router to global

* gui to global

* clean up includes

* move type definnition to interface

to avoid syntax error after abapmerge

* move types to interface

* move types to interface

* rename tyep

* move type

* move types

* move type
2018-02-17 12:40:54 +01:00