Commit Graph

37 Commits

Author SHA1 Message Date
Marc Bernard
dc95fb3efd
Fix syntax errors in 702 (#3548)
Caused by https://github.com/larshp/abapGit/pull/3525
2020-06-27 16:25:23 +02:00
Marc Bernard
09120cb80d
+On/offline: If package already in other repo, nav to repo (#3525)
* New method to get repo from package

If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo

* UI: If package exists in repo, nav to repo

+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo

Closes https://github.com/larshp/abapGit/issues/3452

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-06-20 14:32:00 +02:00
Frederik Hudák
657405433d
Add master language setting to new repo popups (#3409)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-26 06:29:31 +02:00
mariusraht2
b91043a270
Refactor Popup (#3310)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Delete pull.yml

* Refactored popup logic

Related to #3040

Refactoring of popup logic/calling to be able to reuse it as commit list.

* Removed reset flag

Removed reset flag cause it doesn't belong to this PR (will be readded later)

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-04 08:36:24 +02:00
Jaime Rodriguez Capote
fce71de4d1
Use constants for Y/N/P (#3291)
* Use constants

* Pretty Printer
2020-04-05 10:55:24 +02:00
Jaime Rodriguez Capote
27ac61e95d
Apack dependencies (#3285)
* Support APACK dependencies

Check installed apack package dependencies for current repository
Display a popup with dependencies

* abaplint checks

* abaplint checks

* abaplint checks

* Popup only when dependency not met

* abaplint checks

* abaplint checks

* Optimization

* abaplint checks

* abaplint checks

* Fix typo "dependeNcies"

* Remove address from dependency check

* Dependencies popup title

* Dependencies popup enhanced

* EXCEPTION column replacing MET
* Enable Git URL hiperlink

* APACK doc - Version dependency support

* Dependencies version check support

* abaplint checks

* abaplint checks

* Version utils

* fix syntax warning

* move set_dot_apack to protected

Co-authored-by: larshp <larshp@hotmail.com>
2020-04-05 08:57:59 +02:00
Lars Hvam
714fe7202d
whitespace fixes (#2964)
* whitespace fixes

* fix sql compare operators
2019-10-11 02:50:16 -07:00
Lars Hvam
1dbd4d1912
Refactoring types (#2785)
* align use less different types

* refactor

* updates
2019-07-15 09:33:37 -07:00
Lars Hvam
c84b209944
Minor lint updates (#2766)
* remove some double space

* update abaplint to latest

* fixes
2019-07-01 22:08:54 -07:00
Martin Fuchs
4aab0166ac Pass log to deserialization API and show log (#2729)
* Pass log interface for de-serialization

Interface ZIF_ABAPGIT_LOG is now passed for deseriaization API.
This includes:
- Log messages for FUGR: Imported function modules and includes
- Improved error messages for TABL compare
- Log objects w/o changes
- Log is shown in the UI if available ("Log" entry appears if a log exists, no persistence!)
This PR enhances #2534 and #2694

Another important change: In case an object fails (or a single function module in a group fails), the import continues with the next object!

* small pretty printer changes

small pretty printer changes

* fix abaplint issues

reduce line sizes and ensure 7.02 compatibility

* show errors and warnings from pull

Errors and warnings after a pull are now part of the "message list" above the object list in the main screen and will be shown immediately. The new"Log" button shows errors, warnings and success messages on demand.
The log title is now part of the ZIF_ABAPGIT_LOG interface.

* fix abaplint issue

fix abaplint issue
2019-06-21 23:05:10 -07:00
Hector Martinez
a41382352c Activation on ABAP 7.02 ( #2665) (#2666)
* fixed error when activating on ABAP 7.02

* implemented suggestion, direct assignment instead of casting

* implemented suggestion (now using the interface)

* changed lr_popups to li_popups
2019-05-13 23:49:11 -07:00
Alexander Tsybulsky
f39aab3244 fix display name in attache/change remote 2019-04-08 07:21:09 -07:00
Alexander Tsybulsky
ecc1c85ee7 GUI subclass zcx_abapgit_cancel from zcx_abapgit_exception (#2576)
* subclass zcx_abapgit_cancel from zcx_abapgit_excep

* upper case
2019-03-26 23:51:38 -07:00
Jakub Filak
77cea9c92a New repo with Folder Logic and Ignore Sub-packages params (#2561)
* repo: do not validate sub-packages when ignored

In our landscape, we often need to version a package which has
sub-packages and those sub-packages have own repositories - the super
package provides framework and the sub-packages provides production
functionality.

When adding a new repository for these "framework" super-packages,
we need want to configure "Ignore sub-packages" because they are
already versioned in standalone repositories.

We also need to turn of the sub-package repo package check which is done
by this patch.

Dependency of #2395

* repo: allow creating with folder logic and ignore package

I need to enable users to add a new online repo with ignored
sub-packages and PREFIX folder logic because we often deal with
framework + implementations packages hierarchies.

Dependency of #2395

* repo: add folder logic and ign. sub.pkg to the new repo popup

This patch adds the parameters Folder logic and Ignore subpackages to
the new online repo popup to help us deal with old package which do not
follow the prefix approach for subpackages and to allow us to version
superpackages (which are shared by many developers) in separate
repositories.

I am not sure how to add a check-box to the popup window. I think I need
to find the right table with the righ column of the type char(1).

Closes #2395
2019-03-22 05:50:46 -07:00
Christian Guenter
f73e18d587 Online repo "display name" to overrule default name 2019-02-25 07:20:01 -08:00
Christian Guenter
ad7809e4f2 Offline repo: Folder logic in create popup 2019-01-28 00:57:50 -08:00
Christian Guenter
67068136e1 UI: Replace 'Overwrite object' popup with sellist 2019-01-13 07:29:01 +01:00
sbcgua
e809df8384 repo->set refactoring, disconnect repo from persistence (#2164)
* 1st attempt (events)

* temp stash

* split persistence and repo, beta

* fix

* fix2

* fix3

* linter fixes

* review fixes
2018-12-02 09:10:55 +01:00
sbcgua
c465a6b2e8 Offline improvements (#2156)
* local reset in zip-based

* rebuild_local_checksums on new offline
2018-11-28 07:19:27 +01:00
Frederik Hudák
1bb195b344 Removed the rest of endmethod/endclass comments 2018-10-18 07:27:27 +02:00
Johannes Konings
c3691622ed fix some naming conventions
https://github.com/larshp/abapGit/issues/1132
2018-08-16 06:32:19 +02:00
larshp
f0fb0f0470 TADIR performance
TADIR performance #1756

All usages of TADIR aligned to use the same structure. 
DELFLAG added in the structure.
2 identical structure definitions deleted.

todo: test this PR works after abapmerge has run
2018-08-06 15:39:15 +02:00
Christian Günter
400846e036 Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER #1775 (#1776)
* Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER

* catch exception if interfaces doesn't exist

Catch exception if IF_OO_SOURCE_POS_INDEX_HELPER doesn't exist
2018-08-06 15:11:40 +02:00
larshp
02cccf6995 delete method set_new_remote in online repo
delete method set_new_remote in online repo

#1757
2018-08-05 13:12:36 +02:00
Christian Günter
4f9f47cd59 Set transport request if needed during uninstall or reset local (#1596)
* delete checks: set transport request if needed

this ensures that the transport request is set when deleting objects.
E.g. uninstalling the repositoy or reset local.

* separate type for delete checks
2018-07-11 16:18:08 +02:00
larshp
79b6ed0fa5 commit after updating checksums #1562
commit after updating checksums #1562

plus remove some comments
2018-07-07 07:43:19 +00:00
christianguenter2
4662883723 Introduce ZIF_ABAPGIT_POPUPS
- create popups with factory ZCL_ABAPGIT_UI_FACTORY
- inject test doubles with injector class ZCL_ABAPGIT_UI_INJECTOR
2018-06-15 11:21:48 +02:00
Lars Hvam
de23d5bf95
Merge pull request #1484 from larshp/issue_1390
first dependency injection, TADIR #1390
2018-06-14 06:27:04 +02:00
Jakub Filak
fb6efabfb9 tp: use the correct transport type in the tr popup
We are developing in an infinity system which is somehow cloned into a
new releases system. When we need to backport a bug fixes we do
cherry-pick the commits and pull them the release system. However, in
those systems we need to use the task type Repair.

Hence, we need to overwrite the default value of the parameter
wi_task_type of the function TRINT_ORDER_CHOICE which is 'S'
(Development/Correction) with the value 'R'.

I use the function TRINT_GET_REQUEST_TYPE and for the sake of simplicity
I assume that it is enough to know the transport type of the repository
package - in other words, it is no necessary to check every deserialized
object.

Related to #1446
2018-06-12 13:33:49 +02:00
larshp
4e67e884de first dependency injection #1390
* extract public methods of ZCL_ABAPGIT_TADIR to new interface
* create factory ZCL_ABAPGIT_FACTORY
* refactor existing calls
2018-06-10 12:11:48 +00:00
larshp
bd0a6ff34a fix cancel in select from list popup #1050 2018-05-13 08:43:06 +00:00
Lars Hvam
e2b430779d
clone without pull #832 (#1371)
* create online without pull #832

* update tutorial

* fix indentation
2018-05-11 10:14:51 +02:00
Christian Guenter
582a3ab02a refactor transport popup 2018-05-08 19:09:30 +02:00
Lars Hvam
13a559779f
move requirements popup to ui #1281 (#1292) 2018-04-03 16:21:51 +02:00
Lars Hvam
7a9bec815a
Seperate UI and logic (#1286)
* no activation popup in background

* purge: seperate ui and logic

* order by primary key
2018-03-30 12:28:00 +02:00
Lars Hvam
3f1b29c01f
fixes #1282 (#1283)
refactor overwrite object from other package popup to UI
2018-03-30 06:59:29 +02:00
Lars Hvam
7152b4281a
Refactoring (#1279)
* URL: rename and add validation method

plus validate url in NEW_ONLINE

* optimize select

* move write protection check

* start refactoring gui away from deserializati/pull

* mvoe ZCL_ABAPGIT_SERVICES_ABAPGIT to UI

* delete ZCL_ABAPGIT_SERVICES_BKG

moved to GUI page

* move ZCL_ABAPGIT_SERVICES_GIT to UI

* move ZCL_ABAPGIT_SERVICES_REPO to UI

* fix indentation

* overwrite popup refactored to UI
2018-03-29 14:29:03 +02:00