Commit Graph

3490 Commits

Author SHA1 Message Date
Christian Günter
e0742e5181
CUS1: fix jump (#5447) 2022-04-05 10:31:04 +02:00
Marc Bernard
3666dda767
Rename methods returning boolean (#5436)
Just a bit of Clean ABAP:
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-nouns-for-classes-and-verbs-for-methods

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-03 10:40:12 +02:00
Marc Bernard
3d158a3fbc
DDLS: Avoid dump and show error (#5437)
* DDLS: Avoid dump and show error

Ref https://github.com/abapGit/abapGit/issues/4624

* Typo
2022-04-03 10:10:58 +02:00
Marc Bernard
453c430723
Deserialize textpool for some objects (#5417)
* Deserialize textpool for some objects

Fixes inserting the textpool for objects that are not handled by `RPY_PROGRAM_INSERT`. This applies for example to function groups and exit includes (`zx...`).

* Fix deserialize_textpool

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-01 17:51:32 +02:00
Marc Bernard
014d40db1c
Fix "dynpro_send_in_background" (#5430)
* Fix "dynpro_send_in_background"

Suppresses dialog processes for ENHC, ENHS, ENSC, SPRX, and TRAN.

Closes #5420

* Update zcl_abapgit_object_enho.clas.abap

* Update zcl_abapgit_object_enhs.clas.abap

* Update zcl_abapgit_object_ensc.clas.abap

* Update zcl_abapgit_object_sprx.clas.abap

* Update zcl_abapgit_object_tran.clas.abap

* exit
2022-04-01 17:40:28 +02:00
Marc Bernard
485bb12cc1
Record objects in transports (#5419)
CI tests have shown that several object types are not properly recorded in transports. For some objects there was no transport entry when creating the objects, for others when deleting it. 

This PR add the necessary calls to `corr_insert()`. 

(some SE80 reorders)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-03-31 15:20:25 +02:00
Marc Bernard
30371b9a8f
Check if package name is allowed (#5416)
* Check if package name is allowed

When validating SAP packages, it now checks the naming conventions.

* Move method

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-03-31 14:57:48 +02:00
Marc Bernard
f712eb17a5
Folder logic "mixed" (#5413)
* Folder logic "mixed"

Introduces a new folder logic named `mixed` which combines `prefix` and `full`. The root package name will be used as prefix for all sub-packages but the package names are *not* concatenated recursively. This will allow for using significantly logic package names.

Also includes several new unit tests especially for nested packages which had not been tested before.

Closes #5410

Todo: Update docs

* Add constant

* Add options to UI

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-03-31 13:35:34 +02:00
Marc Bernard
6e927e63c5
UENO: Fix diff related to release (#5422) 2022-03-31 06:48:57 +02:00
Marc Bernard
ba09c6e92d
DDLX: Delete before DDLS (#5414)
Fix order of deletion
2022-03-29 23:28:41 +02:00
github-actions[bot]
45fbfd0feb
ajson, Automatic Update (#5412)
* [create-pull-request] automated change

* Update zcl_abapgit_ajson.clas.locals_imp.abap

* Update zcl_abapgit_ajson.clas.locals_imp.abap

* update deps

* skip

Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-03-28 09:14:13 +02:00
Marc Bernard
995e77e949
Visualize difference for EOF (#5404) 2022-03-25 06:58:33 +01:00
Marc Bernard
103790eb35
Remove popup for XML version mismatch (#5403)
Very unlikely that this error happens. Therefore, the popup was replaced with an exception which makes the case testable.
2022-03-24 07:12:24 +01:00
Marc Bernard
ab19fec80b
Fix deserialize order (#5399)
* Fix deserialize order

Fix order for 
- CLAS, INTF, XSLT
- IASP, IARP, IATU

* iaxu
2022-03-16 11:38:46 +01:00
Christian Günter
7992625644
Repo List: fix sort (#5397)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-03-15 18:56:55 +01:00
Marc Bernard
c88dc9f216
SRVB: Fix uncaught exception (#5398)
Fixes dumps due to uncaught exceptions and gives proper error message
2022-03-15 18:43:04 +01:00
ThomasPloski
38db43ce13
Update zcl_abapgit_object_srvd.clas.abap (#5395)
* Update zcl_abapgit_object_srvd.clas.abap

* Update src/objects/zcl_abapgit_object_srvd.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2022-03-10 08:44:30 +01:00
yellappam
bcdeebb3ad
Sort internal tables (#5390)
Function module WEBI_GET_OBJECT returns several internal tables. Sometimes, the sorting order of these internal tables is different in each system ex: S/4HANA and non-S/4HANA. This fixes #5389.
2022-03-02 14:37:23 +01:00
Lars Hvam
e5eb8d0d0a
icon, fix short dump (#5386)
#5385
2022-03-01 08:02:32 +01:00
Marc Bernard
524f6eebc5
CLAS/INTF: Fix serialize/deserialize of documentation (#5374)
* INTF: Fix serialize/deserialize of documentation

Documentation of interfaces (document class IF) was missing and has been added.

* Fix translations
2022-02-28 14:25:52 +01:00
sandraros
0f6267688e
Fix pull/activate table type ref to data type (#5384)
Fix #5383

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-27 17:45:29 +01:00
sandraros
5e53bb9626
Fix DDIC errors related to ref to class/interface (#5369) 2022-02-27 17:23:13 +01:00
Marc Bernard
a491dcf875
SOTS: Fix dump in case of lower case language code (#5381)
Closes #5380
2022-02-25 10:02:33 +01:00
Frederik Hudák
adb529152b
minor css adjustments (#5372)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-21 17:37:40 +01:00
sandraros
68e2cfa5c2
Fix data elem type ref to class in same repository (#5370)
* Fix data elem type ref to class in same repository

* simpler solution by testing refkind and reftype

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-21 17:20:39 +01:00
Marc Bernard
6a85f93312
Update CSS for password fields and buttons (#5364)
Minor addition to CSS

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-21 16:38:45 +01:00
Alexandr Razinkin
353f748bd6
Don't fail if a dictionary object is activated with warnings (#5362)
* Fix proposal for issue #5347: added support for 'TYPE REF TO DATA' DDIC data elements as components in DDIC structures

* Fix proposal for issue #5347. Added support for 'REF TO DATA' DTEL DDIC element residing in DDIC structure

* Fix proposal for issue #5347, added support for 'TYPE REF TO DATA' DDIC data element residing in DDIC data structurees

* REF TO DATA for DDIC element support (#5347)

* No error if ddic type has warning (abapGit#5361) during import

* Update zcl_abapgit_objects_activation.clas.abap

* Fix for (abapGit#5361). Warnings during DDIC objects activation shouldn't be considered as error but will be shown as 'yellow' messages after activation

* Fix for (#5361).
Warnings during DDIC objects activation shouldn't be considered as error but will be shown as 'yellow' messages after activation

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-20 11:39:09 +01:00
Alexander Tsybulsky
91cd4c3653
Separate zif_abapgit_repo (#5329)
* zif_repo basis

* all but zcl_abapgit_repo_srv

* fix zcl_abapgit_repo_srv

* remove create_new_log from interface

* "hack" -> "TODO"

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-19 09:22:46 +01:00
Lars Hvam
4ac0183df2
unit testing updates (#5354) 2022-02-19 09:02:13 +01:00
Christian Günter
2ba6151355
JUMP: Switch execution order - first specific then generic (#5357)
* Switch jump order

* fix DDLS

* fix SHI3
2022-02-18 05:48:36 +01:00
Alexandr Razinkin
256007685e
DTEL: REF TO DATA for DDIC element support (#5350) 2022-02-15 07:39:27 +01:00
yellappam
1246e2718f
Sort includes (#5352)
In some systems, function modules RS_GET_ALL_INCLUDES returns an include *T00. Where *T00 include is not returned, abapGit adds to the internal table. This results in different sorting order in different systems. Sort to keep the same order.
2022-02-15 06:37:58 +01:00
Marc Bernard
92b583bb18
Improve progress bar and log for pull (#5311)
- Eliminate flashing of progress bar during deserialize
- Updated description for deserialize steps
- Add steps to log (see below)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-14 08:25:27 +01:00
Shyam Balachandran
371b1d4137
Fix for Service Binding issue #5212 (#5344)
Fix for SRVB (Service Binding) is lost in version 1.113.0 #5212

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-11 16:58:28 +01:00
g-back
cce8be5f1b
persist "show folder view" option (#5343)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-10 12:01:54 +01:00
Lars Hvam
09936744e9
SICF, clear ICFALIASNO (#5338) 2022-02-10 11:58:12 +01:00
Frederik Hudák
baa09083e6
Repo view - show paths below object name (#5323)
* Repo view - show paths below object name

* rework table rows

* fix syntax

* remove old comment
2022-02-09 08:48:12 +01:00
Albert Mink
9ddad8b559
CHKO et al.: Raise if deleting TADIR fails (#5337)
This behavior will be defined centrally in #5263. But for now, just raise if something with the TADIR fails.
2022-02-08 09:34:11 +01:00
Christian Günter
a4a13e56f7
Repo page: remove orphaned hotkey 'x' aG settings (#5334)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-07 12:10:52 -05:00
Albert Mink
8c2840e517
fix type for the dynamic calls (#5333)
fixes #5332
2022-02-07 12:05:56 -05:00
Albert Mink
d79a38eec2
Enable AFF to delete TADIR entries (#5326)
* Enable AFF to delete TADIR entries

* AbapLint policy I

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* AbapLine policy II

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* AbapLint policy III

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* AbapLint policy IV

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* AbapLint policy V

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* AbapLint XY

* don't call AFF for trivial tasks

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2022-02-07 10:12:44 +01:00
Marc Bernard
b5b252744d
Detect JSON files during pull (#5313) 2022-02-02 14:24:38 -05:00
Albert Mink
a18d7542e7
CHKO et al.: Do write TADIR entry (#5320) 2022-02-02 14:12:16 -05:00
Albert Mink
fee5c18761
Deserialize active when calling ABAP file formats (#5319) 2022-02-02 14:08:54 -05:00
Christian Günter
f178b2539f
zcl_abapgit_git_commit, update shorttext (#5316)
* update shorttext

* remove shorttext sync
2022-02-02 09:28:25 +01:00
Marc Bernard
631132736d
UI: Center Popups - Part (#5315)
Adjusting more popups #5275
2022-02-02 07:35:02 +01:00
Marc Bernard
65dd5f7568
Update object descriptions - Part 1 (#5314) 2022-02-02 07:31:54 +01:00
Marc Bernard
5086b7226d
Add refresh after pull errors (#5312)
* Add refresh after pull errors

Follow-up #5303

* Indent
2022-02-01 16:41:58 +01:00
Marc Bernard
ec9ff1a29f
TABL: Properly show inactive objects (#5303)
* TABL: Properly show inactive objects

Current `is_active` check is insufficient for DDIC objects and can't detect "new" or "partically active" objects.

Introduces a new `is_active_ddic` method in `zcl_abapgit_objects_super` which should be used by all DDIC types (follow-up). 

Ref #5294

* Update zcl_abapgit_objects.clas.abap

* Update
2022-02-01 16:11:18 +01:00
Marc Bernard
ce31e33688
Refactor: Activation log (#5302)
* Refactor: Activation log

- Merges the activation log into the regular pull log
- Removes duplicate messages

* Update

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-01 15:24:35 +01:00