Commit Graph

3998 Commits

Author SHA1 Message Date
Marc Bernard
e4bafbe715
Validate if branch exists when displaying repo (#3749)
* Validate if branch exists when displaying repo

* Validate if branch exists when displaying repo

* Lint

* Lint and 702

* Lint

* Rename validate_branch to validate

* Fix msg and branch display name

* Move msg to UI layer

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-08-24 11:15:46 +02:00
Marc Bernard
7657d972e9
WDCC: Downport 702 (#3783)
* WDCC: Downport 702

Closes #3775

* try removing signatures

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-24 11:10:41 +02:00
dependabot-preview[bot]
6bf6c92f00
Update @abaplint/cli requirement from ^2.39.9 to ^2.39.16 (#3785) 2020-08-24 05:06:06 +00:00
Frederik Hudák
5c826e5993
Navigate to repo after new online (#3780)
* Navigate to repo after new online

* Update zcl_abapgit_gui_page_addonline.clas.abap
2020-08-22 14:39:39 +02:00
Marc Bernard
fe95dc7e5f
abapGit Emergency Mode (#3756)
* abapGit Emergency Mode

On rare occasions, it is necessary to edit the abapGit settings to overcome an issue (example: https://github.com/larshp/abapGit/issues/3701). 

This enhancement allows you to start abapGit in "emergency mode", which directly shows the "Database Utility" for you to view or edit any setting. 

How to start abapGit in "Emergency Mode":

1. Go to transaction SU3 to maintain your user profile
2. Maintain parameter DBT with value "ZABAPGIT" (all-caps).
3. Start abapGit
4. After exiting abapGit, go back to SU3 and remove parameter DBT

* Update ref-database-util.md

* Add files via upload

* Update ref-database-util.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-22 09:55:33 +02:00
Frederik Hudák
a824368a4e
Add top repo menu to more pages (#3764)
* Add top repo menu to more pages

- diff, patch
- syntax check, code inspector
- repo settings

* Add to syntax check page, add margin

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-22 09:53:35 +02:00
Frederik Hudák
f5052cf0b6
Use title case in page titles, menus, forms (#3765)
* Use title case for page titles

Other minor changes:

- patch page is no longer called diff
- "code inspector" in main page action menu renamed to "check"

* Two more

* Update zcl_abapgit_gui_page_db_dis.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Repo advanced menu

* Commit form labels

* Repo setting lables

* Settings, repo

* Final ones?

* Database util

* Column name in stage page

* abaplint

* Update zcl_abapgit_gui_page_stage.clas.abap

* Hover texts for stage column, commit settings

* lint
2020-08-22 09:50:10 +02:00
fdupret
511090d63d
Handle "invalid committer" error (#3774) 2020-08-20 17:56:40 +02:00
Lars Hvam
1433fe2fe9
DTEL and TABL EXISTS performance (#3748) 2020-08-19 09:00:28 +02:00
pokrakam
b20a020637
Allow naming of different test class types (#3771)
* Allow naming of different test class types

Propose to use the more commonly used naming conventions for test classes rather than naming everything ltcl_. These are used by SAP and also referenced in the style guides e.g. the section on [Helper Methods](https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#put-help-methods-in-help-classes) and used in the ABAP unit testing book.

ltc_: test class
lth_: test helper
ltd_: test double
lts_: test suite

Oh, and also corrected bug in exception class name that I spotted when editing

* Update with generic naming suggestions

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-19 08:41:55 +02:00
Frederik Hudák
a176682f44
Hide stage and patch action links for offline repo (#3767)
Stage dumps and patch shows an error that this is not possible.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-19 07:06:27 +02:00
Marc Bernard
3846dd96a4
Hide "Action" column when toggling "Details" (#3747)
Turning on "Details" in Repo Overview will now hide the "Action" column to improve display on smaller screens.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-19 07:02:01 +02:00
Marc Bernard
77a002f584
Fix error when using "Advanced > Force Stage" (#3759)
* Fix error when using "Advanced > Force Stage"

Closes https://github.com/larshp/abapGit/issues/3650

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-19 06:49:58 +02:00
Lars Hvam
a3faae9831
SICF serialization performance (#3762)
* SICF serialization performance

closes #3751

* bugfix
2020-08-19 06:46:32 +02:00
Lars Hvam
8e7eea457a
FUGR serialization, performance (#3761)
Instead of calling function module FUNCTION_IMPORT_DOKU, replace with a SELECT SINGLE in buffered table

closes #3753
2020-08-19 06:44:39 +02:00
Lars Hvam
4ec4760a87
RPY_PROGRAM_READ, set WITH_INCLUDELIST to false (#3760)
closes #3754
2020-08-19 06:41:27 +02:00
Lars Hvam
aa46658b65
DSYS, only split namespace if first char is slash (#3745) 2020-08-18 15:47:46 +02:00
Marc Bernard
37b938575e
Fix syntax errors in 702 (#3750)
* Fix syntax errors in 702

* Fix syntax errors in 702

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-18 07:05:52 +02:00
Lars Hvam
d5e5baa7d8
delete method ZCL_ABAPGIT_HTML=>CREATE (#3736) 2020-08-18 06:54:20 +02:00
pokrakam
138172ffda
Exclude test class with XML from line length check (#3755)
* Exclude test class with XML from line length check

We could also exclude all zcl_abapgit_object*testclasses or even test classes in general.

* Correct syntax

* Update abaplint.json

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-17 20:37:18 +02:00
Marc Bernard
5c53211219
Fix dump in Repo Overview for offline repos (#3746) 2020-08-17 17:22:04 +02:00
dependabot-preview[bot]
901ac09265
Update eslint requirement from ^7.6.0 to ^7.7.0 (#3744) 2020-08-17 05:53:05 +00:00
dependabot-preview[bot]
069e1937ea
Update @abaplint/cli requirement from ^2.38.20 to ^2.39.9 (#3743) 2020-08-17 05:50:12 +00:00
Lars Hvam
f878f3b4c3
remove some double spaces (#3740) 2020-08-16 08:24:12 +02:00
Lars Hvam
d1f277365b
create_sotr, remove unused parameters (#3739)
* minor changes

* create_sotr, remove unused parameters
2020-08-16 08:21:49 +02:00
Frederik Hudák
2a0a97bcd7
Add settings action link to main page, style for branch column (#3737)
* Add settings action link to main page

* Add branch styling to main page

* fix width

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-15 09:35:31 +02:00
Lars Hvam
1132dedf85
ZCL_ABAPGIT_APACK_WRITER syntax warnings (#3735)
fix ZCL_ABAPGIT_APACK_WRITER syntax warnings, #3720
2020-08-15 09:32:00 +02:00
Marc Bernard
9c883f2900
PROG,FUGR,ENHO: Remove workaround for leading spaces (#3728)
* ENHO: Remove workaround for leading spaces

* PROG: Remove workaround for leading spaces

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-14 12:24:38 +02:00
Lars Hvam
7cf1202723
update linter configuration (#3734) 2020-08-14 12:22:32 +02:00
Domi Bigl
20f93ff514
show last commit hash with link if possible (#3731)
* show last commit hash w/ link if possible

link to commit is supported for github.com and bitbucket.org

* remove inline data declaration

* add gitlab link support with UT

* add commit icon for non supported provider

* remove inline declaration

* remove new for CRETE OBJECT

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-13 15:41:45 +02:00
Marc Bernard
200db87f49
Add format for *.abap (#3679)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-13 09:05:19 +02:00
Marc Bernard
36248e8a83
DDLS: Improve error handling (#3727)
Closes https://github.com/larshp/abapGit/issues/2614

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-13 08:59:03 +02:00
Marc Bernard
5a56166d6d
Activate objects without popup (#3725)
* Activate objects without popup

* Activate objects without popup

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-13 08:55:10 +02:00
Marc Bernard
cfc900a2b1
DCLS/DDLS: Fix uninstall dependencies (#3726)
* DCLS/DDLS: Fix uninstall dependencies 

Closes https://github.com/larshp/abapGit/issues/2467

* Move DDLS before other DDIC

DDLS must be deleted before TABL (which is used in DDLS)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-13 08:52:50 +02:00
Christian Günter
dfc19fe718
Patch for staged files only (#3730)
* Allow Hotkeys on helper object

* Patch for staged files only

* cleanup

* fix linter

* Fix: refresh on page patch keeps sel. files

* Fix: Diff and Patch shd appear when only rem. Chg.

* fix linter

* clarify stage helper object in JS
2020-08-13 08:48:27 +02:00
Lars Hvam
17b6411cdb
remove unused variables (#3721)
* remove unused

* remove fstate

* remove

* false

* AVAS, delete method insert_links

* fstate

* sotr

* WAPA

* ssfo

* ddls mock
2020-08-11 18:11:39 +02:00
Harry Abrahams
32ec5430a7
Web DynPro Component Configuration Support (#3665)
* Web DynPro Component Configuration Support

Web DynPro Component Configuration Support Class

* WDCC Support - Syntax Corrections

Web DynPro Component Configuration Support 

Syntax Corrrections

* TADIR Object Name Concatenation Change/Removal

TADIR Object Name Concatenation Change/Removal

As ms_item-obj_name hold complete TADIR name, concatenation with ..00 is not necessary.

* WDCC Support - Syntax Corrections

Web DynPro Component Configuration Support

-Remove dynamic coding
-Remove explicit commit/roll back
-Use Tadir functionality of base class

* WDCC Support - Syntax Corrections

Web DynPro Component Configuration Support

-The EXPORTING keyword can be omitted (exporting))

* WDCC Support - Syntax Corrections

Web DynPro Component Configuration Support

-Removal of HJA comments
-Removal of me->

* Removal of Component Config XML in main object fil

Removal of Component Config XML in main object file

-Component Configuration raw XML added to additional comp_conf.xml file

* Additional xml file pretty printed as string

Additional file contents now pretty printed and added as string for easy diff.
Serialisation / Derialisation now working with pretty printing and un-pretty printing.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-11 05:31:49 +02:00
Christian Günter
e3c1623275
Fix dump in Code Insp. Display for exception class (#3724) 2020-08-10 17:14:09 +02:00
dependabot-preview[bot]
5c6198d621
Update @abaplint/cli requirement from ^2.38.14 to ^2.38.20 (#3722) 2020-08-10 07:43:32 +00:00
Lars Hvam
3321eed0eb
ci: update constants (#3723) 2020-08-10 09:40:20 +02:00
Lars Hvam
867c74701f
remove some unused variables (#3719)
* remove some unused variables

* more unused
2020-08-09 08:44:54 +02:00
Marc Bernard
0ea7b702ce
Refactor and enhance OTR support (#3681)
* WDYN: Fix missing texts

Texts were missing if more than one concept existed per WebDynpro component. Also fixes unit tests which were not working properly before and adds anew test.

* Pretty print

* Refactor and enhance SOTR support

Now supports all objects that use OTR: CLAS (LIMU/CPUB), ENHC, ENHO, ENHS, ENSC, WAPA (LIMU/WAPP) WDYA, WDYN (LIMU/WDYV), WEBI

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-09 08:41:47 +02:00
Marc Bernard
b7e0f15448
Fix status calculation (#3698)
Return checksum only if local item exists

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-09 08:38:50 +02:00
Lars Hvam
0052664c7c
optimize TADIR select (#3718) 2020-08-08 10:30:01 +02:00
Marc Bernard
324db52335
Enhance result view of Code Inspector/Syntax Check (#3717)
* Enhance result view of Code Inspector/Syntax Check

* Enhance result view of Code Inspector/Syntax Check

* Enhance result view of Code Inspector/Syntax Check

* Lint

* Move sort
2020-08-07 07:17:42 +02:00
Marc Bernard
c026ee89b0
Downport: Fix syntax errors in 702 (#3674)
* Downport: Fix syntax error in 702

Method "ASSERT_TRUE" does not exist in 702

* Downport: Fix syntax error in 702

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-06 13:50:53 +02:00
Marc Bernard
49f8ac48c0
DOMA: Fix translation of domain values (#3692)
* DOMA: Fix translations

* DOMA: Fix translations

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-06 13:46:07 +02:00
Christian Günter
4af7026e15
Fix: Open repo in master lang. opens repo (#3710)
After this fix is applied the menu "advanced > open in master language" opens the repo directly and doesn't open the repo list.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-06 13:37:48 +02:00
antonioyanez
a98ba1dfe1
fix bug of ignore subpackages flag (#3715)
Closes #3712
2020-08-06 11:53:58 +02:00
pokrakam
408f127b4a
Add exception instead of popup for background XML errors (#3708)
* Add exception/message logic, refactoring

* De-lint

* More de-linting

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-05 07:51:55 +02:00