Commit Graph

38 Commits

Author SHA1 Message Date
Lars Hvam
910bf46ae4
XML unit test, follow up (#4876) 2021-07-21 11:58:40 +02:00
Lars Hvam
e74c68e204
Decouple XML from UI factory (#4873) 2021-07-21 11:39:47 +02:00
Marc Bernard
d9f4ee7a54
Remove BCS usage (#4693)
Closes #4440

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-10 11:13:35 +02:00
Marc Bernard
31a550db0f
Refactor I18N settings (#4423)
* Refactor I18N settings

- Consolidate I18N parameters into a structure and pass it to xml and serializer classes (#4415)
- Continue change of terminology (#4043)

* Remove changes to serializer class

* Main lang

* DSYS

* OTGR

* Repo view

* Main langu

* Repo view %26 stage

* Serialize

* Settings

* Repo view

* Defs

* Stage

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-19 14:29:09 +01:00
Alexander Tsybulsky
44fceb677c
downport data_serializer (#4392) 2021-01-09 16:32:41 +01:00
Lars Hvam
f782190b3a
class ZCL_ABAPGIT_XML_PRETTY add unit tests (#4263)
* class ZCL_ABAPGIT_XML_PRETTY add unit tests

closes #4260

* Update zcl_abapgit_xml_pretty.clas.testclasses.abap

* fix for byte order mark
2020-12-01 05:09:02 +01:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
Lars Hvam
fff8f1b237
new URL, updates (#3936)
* Update build.yml

* docs, update urls

* code, update links
2020-09-24 09:42:52 +02:00
g-back
7871d23fef
XML Input/Output: Remove Aliases (#3898)
* change XML reference to interface

* remove aliases from XML in/out classes

* change XML references to interfaces
2020-09-18 14:01:44 +02:00
Lars Hvam
42a532b9eb
reduce usage of ddic types (#3859)
* add SAP_BOOL as forbidden void type

* reduce

* Update abaplint.json

* sychar10

* sylangu

* Update abaplint.json
2020-09-10 15:30:25 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Lars Hvam
f878f3b4c3
remove some double spaces (#3740) 2020-08-16 08:24:12 +02:00
pokrakam
408f127b4a
Add exception instead of popup for background XML errors (#3708)
* Add exception/message logic, refactoring

* De-lint

* More de-linting

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-05 07:51:55 +02:00
Andre Becker
507cb9c9db
Add interface for better testing to zcl_abapgit_xml_input/output (#3514)
* introduce interfaces for classes zcl_abapgit_xml_input/output

* refactor classes to use interfaces

* fix indentation of xml files

* fix exception class

* Removed default for commit comment (#3513)

* Removed default for commit comment

Closes https://github.com/larshp/abapGit/issues/3511

* Removed default for commit comment

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix incorrect status of ignored files in repo view (#3506)

* Fix incorrect status of ignored filed in repo view

After update of repo settings, some ignored files showed as "-/A". 
https://github.com/larshp/abapGit/pull/3415

* Whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Minor improvements of icons in repo view (#3493)

* Minor improvement for icons in repo view

* Add Icon Legend in "Debug Info"

A place to see available icons (will copy it to documentation).

* Pretty print

* Reverse icons in debug info

Icons are now in docs. No need for this here

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* z'ify

* zif'y

* remove to much zif'iation

* whitespace

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-21 09:57:42 +02:00
Lars Hvam
d36b43defe
line break parameters (#3444)
* line break parameters

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* fix
2020-06-04 15:10:35 +02:00
Lars Hvam
eb7e819b25 refactoring, delete unused variables and methods (#3203)
* zlib

* xml

* processor

* shi5

* remove unused filter parameter

* pinf cleanup

* ssfo delete empty method

* highlighter

* gui page res, remove unused

* remove unused in diff class

* adt link

* gui, remove 2 unused parameters

* branch overview
2020-02-09 09:38:17 +01:00
Jens Schwarz
9285dd29b3
Fix for issue #1044 (#3167)
* Fix for issue #1044

* Change of local variable names

* fix of bad indentation

* Update src/objects/zcl_abapgit_objects_files.clas.abap

Co-Authored-By: Lars Hvam <larshp@hotmail.com>

* Update zcl_abapgit_objects_files.clas.abap

* Also always add BOM in abapgit.xml file

* Update zcl_abapgit_dot_abapgit.clas.abap

* Update zcl_abapgit_objects_files.clas.abap

* Update zcl_abapgit_convert.clas.abap

* Update zcl_abapgit_convert.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-01 07:43:08 +01:00
Lars Hvam
714fe7202d
whitespace fixes (#2964)
* whitespace fixes

* fix sql compare operators
2019-10-11 02:50:16 -07:00
Alexander Tsybulsky
f2f82278e7 Serialize master lang only + settings UI improvements (#2954)
* repo settings ui improvements

* serialize_master_lang_only UI

* downport

* connect settings and serialization (MSAG)

* dtel doma tran prog fugr

* linter fixes
2019-10-07 23:03:57 -07:00
Christian Guenter
b7a80b0aa7 Downport string template in FM call 2019-04-22 01:45:19 -07:00
sandraros
5a6e6ee2f6 Leading spaces are lost when pulling bug #2571 (#2597)
* Leading spaces are lost when pulling bug #2571

Reason: during the pull (deserialization), the method `PARSE` of `ZCL_ABAPGIT_XML` does a `li_parser->set_normalizing( iv_normalize )` whose parameter has the default value "true", which strips leading and trailing spaces.

Solution: use `li_parser->add_strip_space_element( )` instead of using the normalization, which seems to work in elementary objects (clas, devc, doma, dtel, enho, enqu, fugr, intf, prog, scp1, tabl, tran, ttyp), but I fear of side effects throughout all abapGit features.

* #2571 zcl_abapgit_xml iv_normalize removed+AU

- Removal of useless parameter IV_NORMALIZE of method PARSE
- Abap Unit test added for testing the method PARSE for an XML valuecontaining leading and trailing spaces

* renaming attribute lo_xml to mo_xml
2019-04-19 02:49:15 -07:00
larshp
2dd157570d fix syntax error 2019-04-14 07:30:22 +00:00
Martin Fuchs
6560cbe539 report name of xml file in case of format error (#2626)
* report name of xml file in case of format error

In case of an error in the XML file, for support reason I want to know which file causes the error. The file name is mentioned if the XML itself is corrupt or if there is an XML version mismatch.
This PR fixes issue #2619.

* fix abaplint issues

fix abaplint issues
2019-04-14 00:14:22 -07:00
Lars Hvam
7bbaf069e2
File format update collection (#2605)
* File format update - changed object handler

I removed the following fields:

CLAS
VSEOCLASS-VERSION

INTF
VSEOINTERF-VERSION

PROG
PROGDIR-STATE

DCLS
AS4LOCAL
ABAP_LANGUAGE_VERSION (if exists)

DDLS
ABAP_LANGUAGE_VERSION (if exists)

DDLX
VERSION
RESPONSIBLE
MASTER_SYSTEM

MSAG
DOKIL-DOKSTATE

ENQU
DD25V-AS4LOCAL
DD25V-AS4VERS

* fix syntax error

* also clear PROG VARCL

* update XML files
2019-03-31 01:17:46 -07:00
Lars Hvam
f9318305e9
Minor fixes (#2532)
* minor fixes regarding unused variables

* minor code inspector fixes
2019-03-15 05:54:39 -07:00
Lars Hvam
d0a721b2cf
Move methods to private (#2416)
* ZCL_ABAPGIT_GUI_CHUNK_LIB move 2 methods private

* HTML_ACTION_UTILS move two methods private

* move calculate_skip_testclass to private

* move BUILD_ASX_NODE to private
2019-02-18 05:27:49 -08:00
Lars Hvam
3f494f091f
Use built-in types (#2306)
* remove uses of DTEL BOOLEAN

* remove uses of DTEL BOOLE_D

* remove uses of DTEL FLAG

* remove uses of DTEL SAP_BOOL

* remove uses of DTEL XFELD

* Update zcl_abapgit_popups.clas.abap
2019-01-20 07:59:24 +01:00
Eduardo Ferrari Copat
d47027ad6c Remove redundant class and interface metadata (#2195)
* Remove CLSFINAL from VSEOCLASS serialization

* Remove EXPOSURE from VSEOCLASS serialization

* Remove clsabstrct from VSEOCLASS serialization

* Remove EXPOSURE from VSEOINTERF serialization

* Revert "Remove EXPOSURE from VSEOINTERF serialization"

This reverts commit 4036b7d015.
2018-12-12 14:31:42 +01:00
larshp
7cdbbc92b6 remove some unreferenced variables 2018-11-08 16:35:08 +01:00
Frederik Hudák
26c6f4b4dc Removed endmethod and endclass comments - folders syntax, zlib, xml 2018-08-03 13:33:33 +02:00
Frederik Hudák
34a65ba8e4 Removed unnecessary default comments from testclasses 2018-08-03 13:32:57 +02:00
Lars Hvam
4fa485bf96
Remove superfluous spaces (#1712)
* remove spaces

* remove spaces

* remove spaces

* remove double space
2018-07-29 10:08:54 +02:00
larshp
d7e90aae60 move version definition to separate interface
moved version from DEFINITIONS interface to new VERSION interface, to avoid possible future merge conflicts, see #960
2018-07-25 06:37:38 +02:00
Lars Hvam
5baeaf070c
Minor changes (#1461)
* remove double space after IF

* remove accesses to table bodies

* remove parameter name where possible

* identical code in conditions
2018-06-06 16:24:15 +02:00
Lars Hvam
10dbd74f57
Minor changes (#1442)
* remove try without catch

* reduce nesting

* reduce nesting

* reduce line length
2018-06-04 15:12:03 +02:00
Tapio Reisinger
3293fe5461 Add unit test for render method (#1278)
* add render unt test

* Formatting source

* remove exporting key word

* Adept test include
2018-03-29 09:08:37 +02:00
larshp
df0f3152ef fix indentation 2018-01-08 15:31:37 +00:00
larshp
7ecbc07e19 lcl_xml to global class 2018-01-08 15:29:36 +00:00