Commit Graph

914 Commits

Author SHA1 Message Date
Marc Bernard
b331de6bc7
Naming of class constants (#4945)
* Naming of class constants

This is in preparation of enforcing a naming convention for constants in classes/interfaces. At the end, the following lint rule shall be set:

```json
    "class_attribute_names": {
      "constants": "^C_.+$",
...
    },
```

After this, the only remaining constants not following this rule are in `zcl_abapgit_version`.

* Update zif_abapgit_dot_abapgit.intf.abap

* Update zcl_abapgit_gui_chunk_lib.clas.abap

* Update zcl_abapgit_gui_router.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-14 16:47:48 +02:00
Lars Hvam
e7e8af832e
align package descripions (#4939)
prefix all package descriptions with "abapGit - "
2021-09-10 10:58:36 -04:00
Marc Bernard
08f90dd1f7
Fix "Cannot switch origin twice" in remote settings (#4921)
Closes #4919

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@gmail.com>
2021-08-31 07:31:12 +02:00
Jacek W
5f6b5a73c8
Add "Last changed by" to repo page (#4920)
* Add "Last changed by" to repo page

Proposition for #3267

* Add "Last changed by" to repo page

For #3267
- add "Changed by" also for local items

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-30 07:26:02 +02:00
Marc Bernard
de8b3e4fb2
JavaGUI: Workaround for trailing null values (#4903)
SAP GUI for Java 7.70 has trailing null values in postdata (if data >256 characters). This is a bug that SAP will have to fix.

As a workaround, abapGit will strip the trailing null values.  The workaround shall be removed 2022-12-31 latest.

Closes #4832

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-29 13:05:05 +02:00
Jacek W
549fc9a2ef
Add icon link for changing remote repo on the list (#4907)
* Add icon link for changing remote repo on the list

Proposition for #4737

* Add icon link for changing remote repo on the list

- corrections for PR #4907
- fixed syntax

* Update zcl_abapgit_gui_page_repo_over.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-08-29 12:54:03 +02:00
Lars Hvam
329fd9dc0e
interface and factory for ZCL_ABAPGIT_PERSIST_SETTINGS (#4882)
the old get_instance() method in ZCL_ABAPGIT_PERSIST_SETTINGS has been moved to a method in zcl_abapgit_persist_factory, plus interface added. Added to persist injector
2021-08-03 15:13:16 +02:00
Lars Hvam
9675ad6007
Replace use of type W3URL with string (#4874)
* replace W3URL with string

* fixes

* ASSERT strlen( iv_url ) <= 250.
2021-07-21 11:41:56 +02:00
Christian Günter
553d1f2319
LinkHints: trigger onclick event for checkboxes (#4870)
* LinkHints: trigger onclick event for checkboxes

* refactor

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-20 16:33:34 +02:00
Frederik Hudák
2cfb2790cf
Open repo - disable enter if command field is open (#4868) 2021-07-08 09:31:57 +02:00
Marc Bernard
1d98688be5
Dialogs: Set autofocus on first form element (#4853)
* Dialogs: Set autofocus on first form element

Improves usability. 

Closes #4816

* Autofocus for commit page

- Works in case JS is not an option

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-06 11:41:34 +02:00
Frederik Hudák
60a82331b5
Add more keyboard shortcuts for main page (#4846)
* Add more shortcuts for main page

* Update zabapgit_css_common.w3mi.data.css

* Update zcl_abapgit_gui_router.clas.abap

* Change keyboard shortcuts

* fix js

* fix js

* deindent

* indentation

* one more

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-07-06 11:32:27 +02:00
Mike Pokraka
b1cc6a2912
Refactor method in FM call for 702 (#4848) 2021-06-15 09:43:04 +02:00
Frederik Hudák
f892c9b4dc
fix unclosed tr tag (#4845)
* fix unclosed tr tag

fixes mistake from #4771
2021-06-14 18:23:59 +02:00
Frederik Hudák
d4cbf7059e
Repo overview - rework action buttons + cosmetic changes (#4771)
* Repo overview - cosmetic changes

* extract logic to method

* Update src/ui/zcl_abapgit_gui_page_repo_over.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* fix if in if

* unshorten remote, move package, improve wrapping

* Add max width for columns

* Mostly working now

* add prefixes

* Remove checkbox, move package where it was

* Keyboard navigation

< > to navigate in list (arrow keys don't seem to trigger), enter to open selected

* Ellipsis for repo url, use css variable

* Fix css, js persistence

* Fix invalid function name

* add back !important to override hover color

* abaplint

* Don't use const in js

* more eslint

* Remove unused field symbol

* eslint

* Bring back repo lock icon, styling improvements

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-06-14 14:44:38 +02:00
Christian Günter
6f8e3f45fa
Set focus: fix code inspector warning + improve error handling (#4843)
* Set Focus: fix code inspector warning 

+ improve error handling

* fix method signature
2021-06-14 10:58:01 +02:00
Marc Bernard
f857194037
Focus HTML control on abapGit startup (#4817)
* Focus HTML control on abapGit startup 

`cl_gui_control=>set_focus` must be called during PBO. Maybe there's a nicer way to pass the HTML control to the PBO.

* Move to output form

* Set focus

* Add autofocus
2021-06-09 17:24:59 +02:00
Marc Bernard
887e7dd332
Offline repo: "Compare via RFC" feature (#4789)
* Offline repo: "Import via RFC" feature

Adds option to **offline** repositories for importing a repo via an RFC connection from another SAP system. It's a shortcut for doing "Export ZIP" in one system, and "Import ZIP" in the other.

Closes #4784

Pre-requisite: abapGit develop version (with this change) is installed on remote SAP system. 

Note: The general recommendation is to use **online** repositories and a git server for comparing and synchronizing systems.

* Lint

* Create guide-import-rfc.md

* Langu

* Langu

* Write-protect only

* Compare

* Compare

* Compare

* Compare

* Git

* Update docs/guide-import-rfc.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-06-04 15:09:09 +02:00
Christian Günter
c332473ec0
Enable input fields (submit and text) for link hints (#4802)
* Enable input fields for link hints

* add Link Hints for all INPUTs and TEXTAREAs

* disable LinkHints when number input is active
2021-06-01 12:59:51 +02:00
Marc Bernard
ad244abacd
Terminology: Inclusive Language - Part 6 (#4791)
* Terminology: Inclusive Language - Part 6

Change remaining variables and switch setting to main_language. 

Finally closes #4043

* Add todo

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-28 13:15:00 +02:00
Marc Bernard
5f4eb56071
DEVC: Application component for local packages (#4790)
For local packages, the application component is now stored in AG persistence. This will avoid the diff, if transportable packages are pulled into local packages.

Closes #1880
2021-05-28 05:45:17 +02:00
Marc Bernard
e42e502d7d
Add support pack to debug info (#4779)
* Add support pack to debug info

* Add get_basis_release

* Lint

* Structure

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-20 11:30:05 +02:00
Marc Bernard
85cdff8de7
Fix menu hover background (#4768)
* Fix menu hover background

In default theme, the background color when hovering over menu items was bearly visible in HTML GUI and not visible at all in Win GUI.

The fix explicitly set the background color so both GUIs look the same.

* Keep subitem highlight

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-20 07:25:11 +02:00
Marc Bernard
c2e9e58319
Enhance "Force Pull" to become "Selective Pull" (#4733)
* Enhance "Force Pull" to become "Selective Pull"

With this PR you can now peform a selective pull. Yay!

- Changes "Force Pull" to show *all* changed objects in the usual "Overwrite Popup". This allows you to select individual objects to be pulled no matter if they were changed locally or remotely.
- Does *not* change the regular "Pull" logic

Closes #413, #4282

* Combine delete and overwrite popups

* Add icons to abaplint.json

* Change if to case

* Add icons to abaplint.json

* Enhance UTs

* show_icon

* Show icon

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-20 06:19:00 +02:00
Marc Bernard
7edc45a7fe
Enhance "Debug Info" (#4767)
- Differentiate between Developer and Standalone versions
- Add link to contribution guidelines
- Add listing of user exits with implementation status (based on include for standalone, class for developer version)
- Add feature to save debug info output as HTML page which can be used for attaching to Github issues

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-14 12:06:25 +02:00
Marc Bernard
0d993d4854
Add user exit for event handler (#4766)
* Add user exit for event handler

Closes #4722

* Remove debuginfo change

* Update docs

* Update docs

* fix typo

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-14 11:01:53 +02:00
Marc Bernard
7376c7bb6e
Adjust case of menu item (#4764)
Change to title case
2021-05-12 18:26:57 +02:00
Jacek W
8afae74228
Add "Only my changes" option (#4748)
New option "Only my changes" in "Filter" menu in "Diff" page for showing only changes for the current user.
2021-05-12 18:13:26 +02:00
Frederik Hudák
50bd3941e0
Change default width of abapgit (#4751)
* Change default width of abapgit

* Center settings forms
2021-05-12 18:10:33 +02:00
Marc Bernard
850d51408a
Fix saving proxy bypass (#4752)
Closes #4728
2021-05-06 06:36:58 +02:00
Lars Hvam
0344f7e360
add write protected icon in overview (#4745)
* add write protected icon in overview

closes #4528

* move to after name
2021-05-05 15:52:36 +02:00
Frederik Hudák
1b74a3f9a8
Enable switching branches from stage screen (#4744)
* Enable switching branches from stage screen

* Update zcl_abapgit_gui_page_stage.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-03 15:56:14 +02:00
Marc Bernard
c9bd8443ee
Add hover hightlight to repo toolbar (#4732)
Highlights links in repo toolbar on hover

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-03 14:47:38 +02:00
Lars Hvam
7b336a4a71
cleanup unused local variables (#4739) 2021-05-01 09:51:05 +02:00
fdupret
10b6c550e2
Fix wrong variable used (#4741) 2021-05-01 09:46:14 +02:00
Marc Bernard
1150390bdd
Settings: Adjust background (#4731)
Changes background to secondary color (same as repo top bar)
2021-04-29 17:20:04 +02:00
Marc Bernard
d47c72f429
Remote Settings: Toolbar icon & clean-up (#4724)
* Remote Settings: Clean-up

Continue #4718

- Branch > Switch to PR: removed
- Advanced > Checkout commit: removed
- Advanced > Make Offline / Online: removed menu items and popups
- Advanced > Change Remote: removed menu item and page

* Remove ty_popups

* Remove checkout_commit

* Remove repo_view switch_to_pr

* Remove get_switched

* Add "Edit" icon also for offline

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-27 19:03:06 +02:00
Marc Bernard
0feff94a32
Add icons and update icon docs (#4721)
* Update icon docs

Help, Utilities, Edit, Info, In Progress (Github annotation status), Failure (Github annotation status)

* Add icons

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-27 18:58:00 +02:00
Marc Bernard
a225e05950
New "Remote" tab in repo settings (#4705)
* New "Switch" tab in repo settings

This PR adds a new tab to the repo settings which combines all options for switching the repository to a different source:

- Switch between "Online" and "Offline"
- Switch to Branch, Tag, Commit, or Pull Request

Note 1: Value help for URL history has not been implemented yet.

Note 2: None of the existing related menu items have been removed yet.

* Clean-up

* Clean-up

* Clean-up

* Clean-up

* Clean-up

* Change to "Remote"

- rename class 
- add "autosave" for on/offline switch
- change "Switch" to "Remote"

* Update on/offline switch

* Update on/offline switch

* Update zcl_abapgit_gui_page_sett_remo.clas.abap

* Grammar

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-25 09:59:00 +02:00
Mike Pokraka
69ac4fd768
Change some masters to main %26 remove unused parameter (#4710)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-19 17:15:47 +02:00
Marc Bernard
f55cdcc253
Refactor filename logic (#4697)
Combines `zcl_abapgit_file_status=>identify_object` and `zcl_abapgit_object_files=>filename` into new class `zcl_abapgit_filename_logic`. This class provides `file_to_object` and `object_to_file` conversion logic similar to what `zcl_abapgit_folder_logic` does for packages and git folders. 

Also includes unit tests which were missing for the old methods.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-15 16:14:53 +02:00
Marc Bernard
f18a8ee82b
Terminology: Inclusive Language - Part 5 (#4702)
* Terminology: Inclusive Language - Part 5

Change of terminology (#4043)

- Replace `get_master_language` with `get_main_language` and remove it

* File Status

* Jump

* Language

* Main language

* Main language
2021-04-15 08:32:09 +02:00
g-back
4c6d407156
Export Package to Files: Fix for Namespaced Packages (#4701)
* escape package only for file name


make package parameter immutable

* fix form id
2021-04-14 12:43:24 +02:00
Marc Bernard
f290658941
Fix HTML for news panel (#4695)
* Fix HTML for news panel

Add missing `<ul>` tag

* Adjust UL

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-14 09:24:02 +02:00
Christian Günter
a3b6ad8d80
fix nbsp (#4677)
fix nbsp

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-14 09:21:26 +02:00
Marc Bernard
b6db4e2c23
Adjusting to "main" branch (#4691)
* Adjusting to "main" branch

* Adjust filename
2021-04-08 13:02:20 +02:00
Marc Bernard
cea83ffb86
Improve reuse of HTML viewer (#4688)
* Improve reuse of HTML viewer

Adding optional parameters to allow reuse of HTML viewer in subscreens and allow testing of query parameter table (potential replacement of `zcl_abapgit_html_action_util=>parse...`).

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-07 17:50:31 +02:00
Lars Hvam
1fb55fe3e8
TLOCK performance (#4636)
* add new method get_transports_for_list

* downport

* read tlock into local buffer

* fix

* refactor

* upd

* cleanup

* bugfix

* return data

* refactor staging page to use new logic

* lower case

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2021-04-03 09:06:45 +02:00
Marc Bernard
2a99c742eb
Add header for status column in repo view (#4680)
* Add header for status column in repo view

* Sort status

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-01 17:12:54 +02:00
Marc Bernard
b6e7efd75b
New online repo: Replace "clone" with "create" (#4682)
Closes #4681
2021-04-01 17:11:11 +02:00
Alexander Tsybulsky
e5e558a312
Log refactoring, part 1 (#4676)
* log: new features

* log in exception

* log via gui_services

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-27 10:57:57 +01:00
g-back
eee6b00378
Minor fixes/changes (#4665)
* remove assert, remove unused variable

* update documentation, follow-up to #4663
2021-03-24 13:34:02 +01:00
Kjetil Kilhavn
cfcee287a8
Fix for Java GUI so new repo can be defined (#4655)
* Fix for Java GUI so new repo can be defined

The HTML demo programs are able to pass values from a form, so why does abapGit not work with Java GUI?
I've been trying to figure this out. The key to a break-through was not any fancy code analysis, it was "brute force".
I added a method in ZCL_ABAPGIT_HTML_FORM to replace the generated HTML by a copy of the resulting HTML. Then I removed things until POST-data was filled, and added things back until it broke again.

The main issue was of course the complete lack of POST-data for the event.
This is solved by adding an action attribute to the form element and removing the form-action attribute from the 'default' submit button.

The biggest surprise was that radion buttons don't work as they should. Values are returned as if both radio buttons (in the new online repository form) are checked - which of course is not possible. I tried enabling the query table in the HTML viewer just in case this was specific to the POST-data, but no such luck, it is probably a problem with the HTML viewer itself. You won't find any samples from SAP with radio buttons either.
The bug is possibly fixed by the patch in Note 2832978.

The solution is far from perfect, but at least it is now possible to add new repositories in Java GUI.
The most annoying problem that remains is that if a dialog is opened to select a package or branch the existing input data are lost. One step at a time though...

* Update src/ui/zcl_abapgit_html_form.clas.abap

Linter fix

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Single-parameter calls on one line

One extended line, mind you...

* One argument per line - when possible

Don't break the string expression up over more lines thna neessary.

* Keep line length under 120 characters

* Playing catch-up

Fixing the conflict after another pull-request was merged

* Catch up with main branch

I didn't understand from the conflict resolution view on github the total difference between main and my fork. Looked at the source file and it became clear. 
So hopefully this is the last commit... (and hopefully that won't be "famous last words")

* Time to learn about rebase...

Removed duplicate statement to get number of rows

* Conflicting line reset

Reset to main
<<<<<<< kjetil-kilhavn/javagui-fix
          ii_html->add( |<td><input type="text" name="{ lv_cell_id }" id="{ lv_cell_id }"|
                     %26%26 | value="{ lv_value }"{ lv_readonly }></td>| ).
=======
          ii_html->add( |<td><input type="text" name="{ lv_cell_id }" id="{
                        lv_cell_id }" value="{ lv_value }"{ lv_readonly }></td>| ).
>>>>>>> main

Now, may I have all green lights please?

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-24 12:55:53 +01:00
Marc Bernard
a68cbbd5ce
Refactor "Background Mode" to HTML Form (#4663)
* Refactor "Background Mode" to HTML Form

ref #4171

- Moved "Background Mode" from "Advanced" menu to "Repo Settings"
- Changed Bckg Setting and Bckg Run to new HTML pages

* Add back_toolbar
2021-03-24 12:50:53 +01:00
Marc Bernard
18c9b404f1
Empty tables in HTML forms (#4658)
Previously if there were no data rows, it would render just the column headers of the table. 

After this change, it shows "Not available".

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-23 06:49:04 +01:00
g-back
1cbda2f2ae
Refactor "Export Package to ZIP" to HTML Form (#4652)
* refactor export package to zip to HTML form

* change literal to constant

* downport statement

* remove popup package_export

* reorder methods, unify whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-22 13:17:54 +01:00
Lars Hvam
cac2de1ced
user exit: wall messages (#4653)
* wall messages

closes #4530

* update docs
2021-03-22 13:15:03 +01:00
Daniel Wegner
193ad660fd
Respect wildcard characters in proxy bypass settin (#4649)
Co-authored-by: Daniel Wegner <d.wegner@fis-gmbh.de>
2021-03-18 19:08:02 +01:00
Marc Bernard
56bd2b1b13
Add measures to repo stats (#4646)
* Add measures to repo stats

- Lines in ABAP Files
- Lines of Code in ABAP Files (no empty or comment lines)

* Split read_stats

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-17 07:17:02 +01:00
Lars Hvam
11fd111572
move perf test option to new repo (#4645)
* move perf test option to new repo

Moving the performance test option to separate repository,
https://github.com/abapGit/performance-test

I guess this feature is not used very often, it will reduce the overall code size, and instead of refactoring these popups to HTML they can stay ALVs in the new repo

* fixes
2021-03-17 07:12:59 +01:00
Lars Hvam
e31e641f10
overview page, dont display ".git" (#4632)
* overview page, dont display ".git"

dont display ".git" in the urls in the overview page, to save a bit more horizontal space

also see #4539

* dont use regex
2021-03-16 16:51:04 +01:00
Lars Hvam
5a121a2174
perf test, dont look for current package (#4642)
the user can input the package anyhow

decouples the perf test option from gui #4639, plus will make it easier to implement #4641
2021-03-15 15:54:56 +01:00
Lars Hvam
16ca0fef77
ZCL_ABAPGIT_GUI delete unused GO_PAGE (#4640) 2021-03-15 15:30:21 +01:00
Lars Hvam
70fdc8771e
CTS API: remove unused iv_resolve_task_to_request (#4633) 2021-03-13 13:29:05 +01:00
g-back
72f34f5bdf
Refactor "Object to Files" to html form (#4623)
* start conversion from popup to html form

* replace magic with constants

* revert label

* restructure to gui component


modify export object logic

* adjust whitespace

* remove test_changed_by functionality

* remove popup_object

Co-authored-by: Goran Back <g.back@geringhoff.de>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-12 12:31:17 +01:00
g-back
71c4849ae5
Minor Fixes (#4627)
* remove exception from signature, remove comment

* change search help, try fieldname first

* enable lang switch when multiple tcodes are assgnd
2021-03-11 14:51:48 +01:00
Lars Hvam
26c81be9fd
Refactor "Change Remote" to html form (#4617)
* Refactor "Change Remote" to html form

* upd

* cleanup

* less whitespace

* update logic and descriptions
2021-03-10 07:29:13 +01:00
yellappam
0f2020b5c1
Unsupported object count in repo statistics (#4601)
* Add unsupported object count in repo statistics

* lint fix: Keep single parameter on one line

* Fix indentation

* Undo changes to TADIR and DEFINITIONS

Undo changes to ZCL_ABAPGIT_TADIR and ZIF_ABAPGIT_DEFINITIONS

* Refactor code

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-09 12:13:10 +01:00
Christian Günter
d7e43fc0b9
Diff calculation: improve performance (#4603)
* Diff calculation improve performance

* optimize table access

Co-authored-by: Christian Günter <Christian.Guenter@zuerich.ch>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-07 12:25:10 +01:00
Lars Hvam
72f08d64b1
refactor, remove use of CNHT_POST_DATA_LINE (#4607) 2021-03-07 12:18:20 +01:00
Lars Hvam
d7f74bd49c
zif_abapgit_poups cleanup (#4608)
* zif_abapgit_poups cleanup

delete method POPUP_TO_INFORM

* delete method POPUP_PROXY_BYPASS
2021-03-07 12:15:26 +01:00
Alexander Tsybulsky
17eac7b6c3
Strip XML details user exit (#4599)
* exit draft

* call exit

* linter fix

* PRE_CALCULATE_REPO_STATUS docs

* settings UI

* wire status calculation and repo settings

* uppercase

* diff rendering fix

* adjust docs

* adjust docs

* Remove settings

* more docs adjustments

* pass repo meta data into the exit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-06 09:35:35 +01:00
Lars Hvam
a77160e58c
refactor, remove bcs and solix usage (#4605)
* refactor, remove bcs and solix usage

* DEFAULT KEY
2021-03-06 08:56:02 +01:00
Lars Hvam
393771e6ef
allow switching branches in write protected repos (#4595)
* allow switching branches in write protected repos

* fix
2021-03-06 08:43:18 +01:00
Christian Günter
011dfc6590
Distinguish repo and file diffs to fix d-hotkey (#4591) 2021-03-03 05:30:21 +01:00
Alexander Tsybulsky
3df4863feb
LXE langs refactoring (#4494)
* main refactoring part

* linter fix

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-01 07:02:04 +01:00
Marc Bernard
7da94f396d
Fix jump to objects with special characters (#4558)
Fixes jump to an object in case the object name contains escaped characters

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-24 05:55:23 +01:00
Lars Hvam
4a30f00a7e
HTML, minor performance? (#4553)
* HTML, minor performance?

@FreHu can you try this, to see if the performance is a few ms better?

* upd
2021-02-22 06:51:24 +01:00
Frederik Hudák
add83f5b94
Repo overview performance improvements (#4541)
* Repo overview performance improvements

* Rework map_repo_list_to_overview

* Reduce usages of get_key

* Fix inline data

* Don't load package descriptions in repo overview

the select is expensive

* suppress titles for non-favorite repositories

* lint

* Update src/ui/zcl_abapgit_gui_page_repo_over.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* optimize render_repo_palette

* Optimize gui_router

* Update zcl_abapgit_gui_page_repo_over.clas.abap

* Update zcl_abapgit_migrations.clas.abap

* remove unused variable

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-21 11:29:01 +01:00
Frederik Hudák
e68feff2e1
Main page - disable hover info for package/user links (#4545)
* Main page - Only show hover info for favorites

in package, user links

suppress titles for non-favorite repositories

* always suppress loading titles in repo overview

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-20 17:22:25 +01:00
Frederik Hudák
c3012513b3
Optimize performance of switching branches (#4548) 2021-02-20 17:16:50 +01:00
Lars Hvam
40cd29297d
overview page, dont display "https://" (#4539)
* overview page, dont display "https://"

dont display "https://" or "http://" in overview page

delete unused method HAS_FAVORITES

* add title
2021-02-20 10:28:02 +01:00
Lars Hvam
da53a04abb
zif_abapgit_html_viewer: refactor CNHT_POST_DATA_TAB & CNHT_QUERY_TABLE (#4499)
* zif_abapgit_html_viewer

* fix syntax
2021-02-12 11:05:46 +01:00
Lars Hvam
fc3fbbaba8
remove install abapgit option from debug page (#4501)
* remove install abapgit from debug page

* fix
2021-02-11 06:51:21 +01:00
Lars Hvam
8e07d46f4b
jump_se11, remove unused parameters (#4498) 2021-02-09 15:50:27 +01:00
Marc Bernard
3766260312
Correct statistics for offline repos (#4489)
* Correct statistics for offline repos

- Adjust labels: "Remote" to "ZIP"
- Fix some file counts

* ZIP

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-09 07:33:17 +01:00
Marc Bernard
3db8c950b8
Adjust "ZIP" spelling (#4495)
* ZIP

* ZIP

* ZIP

* ZIP

* ZIP
2021-02-08 14:46:05 +01:00
Marc Bernard
c26d2158a1
Fix minor CSS issues (#4492)
Fix the following issues to make it CSS3 compliant:
- Font-style bold is not a font-style value
- Family names containing whitespace should be quoted
- Same color for background-color and border-color

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-06 09:39:03 +01:00
Marc Bernard
a15ca2a801
Remove packages from duplicate file check (#4488)
* Remove packages from duplicate file check 

Closes #4485

* Lint
2021-02-05 07:18:38 +01:00
Christian Günter
3674fa55fc
fix sapevents for chromium based browser control (#4478)
* fix sapevents for chromium based browser control

* Fix tooltip hotkey + remove duplication

* fix eslint errors

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-04 15:18:10 +01:00
Marc Bernard
73576ee60e
Improve error messages (#4472)
* Improve error messages

Pass T100 messages to UI/log

* T100 errors

* APACK

* OO

* DEVC

* DRUL

* DTDC

* SRVB

* OBJS

* Program

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-03 16:31:55 +01:00
Marc Bernard
13d3d0aac1
Replace void types (#4484) 2021-02-03 05:53:50 +01:00
Marc Bernard
eb4986389e
Adjustments to Debug Info (#4459)
* Adjustments to Debug Info

- Fix display of abapGit installation package (side-effect of changed package assignment)
- Clarify that list of supported objects is relevant for the local system only (since it's release dependent)
- Add link to complete list of supported objects

* Remove pragmas
2021-01-27 09:23:44 +01:00
Marc Bernard
212f9f8da2
Remove obsolete code related to hotkeys (#4456)
Remove code related to user-specific hotkey settings.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-26 19:36:24 +01:00
Marc Bernard
4b34d5743e
Minor adjustment to front-end dialogs (#4458)
- Change extension of ZIP-files to lower case ".zip"
- Adjust error messages

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-26 19:31:33 +01:00
Marc Bernard
6d356400f6
Terminology: Inclusive Language - Part 4b (#4436)
Change of terminology (#4043). This time with the missing changes in service_repo.

repo_srv and serializer will be next after #4431.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-23 10:13:42 +01:00
Marc Bernard
40efc567f6
Automatic creation of top repository package (#4431)
* Automatic creation of top repository package

When adding a repository, it is not necessary anymore that the top SAP package assigned to the repository exists. Just enter a package name and clone (works for offline, too). 

The initial diff will now show that the top package exists remotely only. Therefore, when pulling, you will not get the "confirm overwrite package" popup anymore. Yippie!

* Typo

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-23 10:11:54 +01:00
Frederik Hudák
45badeb527
Add refresh button to stage page (#4437) 2021-01-23 09:56:15 +01:00
Lars Hvam
431f7095f4
bugfix, Component MAIN_LANG_ONLY not found in targ (#4435)
#4434

rolls back changes from #4432
2021-01-22 10:17:24 +01:00
Marc Bernard
978b7a4a57
Terminology: Inclusive Language - Part 4 (#4432)
* Terminology: Inclusive Language - Part 4

Continue change of terminology (#4043)

* Service

* Language

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-21 17:18:03 +01:00
Marc Bernard
5c7baae1ab
Refactor CTS API and support additional objects (#4424)
* Refactor CTS API and support additional objects

- Change methods from public to private
- Reduce interface to public methods
- Support objects that can not be locked but can be included in a transport (prep for namespaces)

* Remove lenght check

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-20 18:23:10 +01:00
Marc Bernard
31a550db0f
Refactor I18N settings (#4423)
* Refactor I18N settings

- Consolidate I18N parameters into a structure and pass it to xml and serializer classes (#4415)
- Continue change of terminology (#4043)

* Remove changes to serializer class

* Main lang

* DSYS

* OTGR

* Repo view

* Main langu

* Repo view %26 stage

* Serialize

* Settings

* Repo view

* Defs

* Stage

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-19 14:29:09 +01:00
Marc Bernard
fd86eaa0bc
Repo view: Adjust link to settings & render transport (#4422)
* Repo view: Adjust link to settings & render transport 

- Update link text
- Re-init flag to render transport (in case the package has changed)

* Main langu
2021-01-19 08:11:22 +01:00
Alexander Tsybulsky
47dae10ab0
I18n settings (#4416)
* dot abapGit i18n_langs

* rewrite dot abapgit (better design)

* settings

* linter fix

* review fixes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-18 09:32:55 +01:00
Marc Bernard
a824eef662
Prevent staging of duplicate files (#4403)
* Prevent staging of duplicate files

Since objects cannot exist in multiple packages, the staging page is now checking the selected files to prevent the resulting repo from containing an object multiple times.

If an object is moved to another SAP package and the corresponding files are seleted to be added to the repo (for the new package), then the files must also be removed from the repo (from the old package). If not, an error is raised.

* Remove other changes

* Update file status

* Extend unit test

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-17 09:28:54 +01:00
Lars Hvam
db6db7cf79
remove more unused variables (#4413) 2021-01-15 17:22:51 +01:00
Lars Hvam
690da4e51f
delete some unused variables (#4411)
* delete some unused variables

* bdef, remove unused vars

* remove some more
2021-01-15 08:31:01 +01:00
Marc Bernard
748ff1b09b
Dialogs: Remove old repo settings (#4406)
- Remove repo settings page
- Redirect repo overview to new repo settings
- Fix "requirements" table on new repo settings page

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-14 14:13:35 +01:00
Marc Bernard
fcd1159416
UI: Adjust "back" for settings (#4409)
Changes "back" to go to bookmarked page. Closes #4408
2021-01-14 07:44:28 +01:00
Marc Bernard
40331ee80f
Follow-up HTML viewer exceptions (#4404)
* Follow-up HTML viewer exceptions

Properly catch HTML viewer exceptions (follow-up #4396) to avoid dumps

* Add exception

* Add exception

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-12 08:54:03 +01:00
Lars Hvam
f1dbe88729
suppress syntax warnings (#4398) 2021-01-11 10:28:27 +01:00
Lars Hvam
89c77d9e6b
zif_abapgit_html_viewer, change to class based exc (#4396)
* zif_abapgit_html_viewer, change to class based exc

#4381, part A

* catch
2021-01-11 09:59:26 +01:00
Lars Hvam
889d062e1c
data, basic serialization (#4369)
* data

* refactor ZCL_ABAPGIT_SERIALIZE

* upd

* serializing

* cleanup

* fix

* fix

* rename
2021-01-09 10:50:58 +01:00
Marc Bernard
2e476eb7b2
Dialogs: HTML forms for repo settings (#4384)
* Dialogs: HTML forms for repo settings

This moves the repo settings to HTML forms. The settings are split into three pages:
- Repository settings (ie abapgit.xml)
- Local settings
- Infos

* Lint

* Infos > Stats

* Infos > Stats

* Infos > Stats

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-08 13:09:37 +01:00
Marc Bernard
e5540ae054
UI: Refactor form class and fix textarea (#4379)
* UI: Refactor form css class

- Move styles to CSS
- Provide default for form class
- Remove form class from render calls

* Update css

* Condense textarea

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-05 09:25:58 +01:00
Lars Hvam
9f583c1bcc
use non interfaced fields_to_string() (#4378) 2021-01-05 07:57:30 +01:00
Lars Hvam
8b506aa077
omit some default parameter names (#4370)
* apack, omit parameter names

* mass and objects

* omit

* omit
2021-01-04 10:41:20 +01:00
Lars Hvam
1d1d046d39
data: use ajson for serialization (#4363)
* data: use ajson for serialization

* config to_json

* implement from_json

* fix

* move method build_table_itab to new class

* start deserialize

* update

* scaffolding

* add page

* upd

* fix warning

* update

* rename variable

* upd

* update

* reorder
2021-01-03 04:55:24 +01:00
Lars Hvam
d35848b2f8
string map: change set() input value to csequence (#4368) 2021-01-03 04:51:10 +01:00
Marc Bernard
6623679e67
Dialogs: HTML forms - follow-up (#4329)
* Dialogs: HTML forms - follow-up

Follow-up to #4264:

- Split `zcl_abapgit_html_form` class
Processing form data has been moved to `zcl_abapgit_html_form_utils`

- `iv_is_main` refactored to `iv_cmd_type`

- In case of unsaved data, form exit will now prompt for confirmation (`zcl_abapgit_html_form_utils`)

* dot space

* lint

* Remove const

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-02 15:12:09 +01:00
Eduardo Ferrari Copat
16258c59b6
Checkout commit: additional user interface (#4120) (#4349)
* Set branch name with commit

* Can't stage when commit is checked out

* Add missing variable

* Remove passing a parameter, since set relies on IS SUPPLIED

* Undo last commit

* Intelligent create branch when commit is checked o

ut

* lint

* Fix cancel buttons (missing commit)

* Code review

* Remove unused variables

* Add extra line

* Remove unused variable

* Add back new branch pop-up. Considers tag.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-28 12:39:26 +01:00
Lars Hvam
704198f521
unit testing test (#4345)
* update deps

* update deps

* remove CHAR01 usages

* update deps

* update deps

* update deps

* all unit tests in syntax now running!

* update deps

* update deps

* update deps

* enable additional exception unit tests

* zcl_abapgit_string_map running

* upd

* login manager running

* update deps, add progress clas

* upd

* update deps

* fix whitespace

* update deps

* upd

* update deps

* update deps

* update deps

* use cl_abap newline

* upd

* run more

* sort

* update deps

* add intf

* update deps

* upd

* add zcl_abapgit_exit

* some xml interfaces

* zcl_abapgit_version running
2020-12-27 18:00:59 +01:00
Lars Hvam
4b2309f952
zif_abapgit_html, remove uses of char1 (#4351) 2020-12-24 08:36:58 +01:00
Marc Bernard
73cba7ff1b
Fix sorting of objects in repo view (#4346)
Regression of #4087. Closes #4339

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-22 06:47:45 +01:00
Marc Bernard
f1bf013adf
Refactor: GUI router state transfer (#4336)
Moving page-dependent state changes to separate methods for clarity
2020-12-16 08:23:00 +01:00
Christian Günter
0e4f29efa1
New Repo: Check package existence before showing popup (#4323)
* New Repo: Check package existence before showing p

* fix lint errors

* fix linter

* add more unit tests

* refactor unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-14 14:54:28 +01:00
Jaime Rodriguez Capote
6c87fa3f05
Several repos for same URL (#4313)
* Check URL repo before add

* Unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-12 08:49:38 +01:00
Marc Bernard
d0983cf386
Dialogs: HTML form enhancements (#4264)
* Dialogs: HTML form tweaks

- Minor increase of contrast for background, input- and readonly fields
- Add read-only option for columns of table control

* Add is_empty

* Add init and hidden

* Render

* Remove init

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-12 08:45:47 +01:00
Lars Hvam
efaa0e65c0
more generic exception catching (#4307) 2020-12-11 07:46:07 +01:00
Marc Bernard
07cdc0e0e8
Resolve circular reference in /syntax/ (#4292)
Closes #4258

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-07 09:13:58 +01:00
Fabian Lupa
ca51d8b0c7
Ensure open in main language opens same abapGit version (#4291)
Fixes #4276

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-06 06:36:45 +01:00
Lars Hvam
bf89ac55f6
uninstall: "including subpackages" (#4287) 2020-12-04 08:44:03 +01:00
Lars Hvam
efa6aa9347
Remove two places wih repo class insantiation (#4250)
* zip, method encode_files as public

* refactor instantiation

* remove filter input parameter
2020-11-30 11:23:36 +01:00
Marc Bernard
7f61ebd645
UI: Clear progress bar (#4249)
* UI: Clear progress bar

Clears status/progress bar at end of process and removes leftover messages. 

Closes #3505

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-27 10:18:52 +01:00
Marc Bernard
552024ac3f
UI: Improvements for setting pages (#4229)
* UI: Improvements for setting pages

- Better navigation between settings pages
After jumping between setting pages, the back button will go to last page before navigating to the settings (ie "back with bookmark")
- Add commit work

* Lint + router

* Jump repo view to settings

* Lint

* Conflict

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-26 11:54:49 +01:00
Constantinos Sourelis
5d8f4d2033
User interface: "Advanced" menu tooltips (#4214)
* User interface, "Advanced" menu

Added tooltips to the "Remove" and "Uninstall" options in the advanced menu. As a new user, I would revisit the [documentation](https://docs.abapgit.org/guide-online-uninstall.html) to distinguish between the two.

The tooltips are passed as "iv_title" parameters to ZCL_ABAPGIT_HTML_TOOLBAR->add

* Update src/ui/zcl_abapgit_gui_page_repo_view.clas.abap

Adjustments from review

* Update src/ui/zcl_abapgit_gui_page_repo_view.clas.abap

Adjustments from review

* Update zcl_abapgit_gui_page_repo_view.clas.abap

Comply with abaplint line length of 120

* Update zcl_abapgit_gui_page_repo_view.clas.abap

Comply with abaplint's no whitespaces at EOL

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-24 15:43:40 +01:00
Lars Hvam
01d968c1f8
show log, remove title parameter (#4234)
* show log, remove title parameter

the log objec already have the title as part of the object, another input is not required

this aligns the code to always use the title from the object

closes #4223

* zif_abapgit_log, change title to csequence input
2020-11-24 15:41:26 +01:00
Marc Bernard
9efdae315d
Dialogs: Enhance HTML form with table control (#4230)
* Dialogs: Enhance HTML form with table control

- Adds option to maintain data using a table control
- Extends UTs with several cases that were include in #4172
- Table control to be used by "repo settings" #4171

* Border

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-24 08:11:53 +01:00
Marc Bernard
aa2f4bb8e7
Resolve hotkey conflict (#4228)
"f" is default for vimium-links. Changed "New Offline" to "o".

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-24 08:04:27 +01:00
Lars Hvam
53790c3770
log, purge() now returns the log (#4222)
* log, purge() now returns the log

For each action, the log should be returned, then it is up to the UI how or if to show or persist it in the session.

First step of #2821

* li_log not needed anymore
2020-11-24 07:58:22 +01:00
Lars Hvam
381d40e35a
ZCL_ABAPGIT_HASH add shorthand methods (#4220)
This adds shorthand methods for the SHA1 calculation of the different git artifacts.
More logic in ZCL_ABAPGIT_HASH, but easier to read and less application logic.
2020-11-23 14:30:31 +01:00
Constantinos Sourelis
e51ca12eb5
Fix uncaught exception of zcl_abapgit_repo_srv (#4215)
When repeatedly navigating "back" to the main screen via the "Repository List" [o] button:
If somewhere in this navigation sequence you Remove a repository,
then continue on via "Repository List",
but later you use the GUI's actual "BACK" button, until you have returned to the main screen where that repository still existed,
a short dump occurs as the exception raised by zcl_abapgit_repo_srv=>get in zcl_abapgit_gui_page_repo_view->render_content propagates unhandled

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-23 08:31:26 +01:00
Marc Bernard
82668de47b
UI: New pages for global and personal settings (#4192)
* Dialogs: New pages for global and personal setting

Redesign of abapGit settings using HTML forms. Two functional changes to old settings page:
- "Development Internal Settings" are only visible when using the developer version (not in standalone program)
- "User-specific hotkey settings" are not available anymore. The default hotkeys continue to work as before.

Global/Personal settings can be reached using hotkeys "x" and "y".

* Lint

* Hide button

* Change to top menu

* Remove old page

* Remove old page

* fix links

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-23 08:24:17 +01:00
Lars Hvam
725d92f98e
bugfix, PR popup sorting (#4206) 2020-11-20 08:51:01 +01:00
Fabian Lupa
123de8fd68
Allow html viewer to be hidden (#4203)
* Allow html viewer to be hidden

for CALL SCREEN in the same session to work

* Move html viewer hiding to router
2020-11-20 08:38:37 +01:00
Marc Bernard
46470da59d
Improvements for uninstall (#4198)
* Improvements for uninstall

- Improve error handling on deletion collecting errors in log
Closes #4197

- Remove limit of 3 loops which allows deleting objects with deeper dependencies
(Follow-up https://github.com/abapGit/abapGit/issues/3228#issuecomment-728800249)

* Exception

* Error msg

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-19 09:31:31 +01:00
Marc Bernard
9e385c264e
UI: Add help buttons to "New Online/Offline" (#4189)
* UI: Add help buttons to "New Online/Offline"

- Add help button to both dialogs linking to docs.abapgit.org
- Clicking the button brings up the documentation inside the GUI HTML viewer
- Enhancement to `zcl_abapgit_gui` and `zcl_abapgit_html_viewer_gui` to properly handle 'Back' when navigating through Internet pages

* Open help in external browser

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-18 07:33:00 +01:00
Fabian Lupa
267f7a0a6e
Fix reset for deletions (#4194)
* Fix reset local not deleting objects

Fixes #4186

* Fix typo

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-17 17:59:01 +01:00
Fabian Lupa
a042442e64
Fix missing td for offline repos (#4193)
Fixes #4190
2020-11-17 10:48:27 +01:00
Marc Bernard
e93cbc5a1f
Move ty_deserialization, ty_step_data, ty_repo_ref_tt (#4181)
* Move ty_deserialization, ty_step_data

Remove dependencies from `zif_abapgit_definitions` (see https://github.com/abapGit/abapGit/issues/4179)

* Move to interface

* Move ty_repo_ref_tt
2020-11-16 08:34:29 +01:00
Marc Bernard
2f31cc6173
UI: Fix HTML validation warnings and error (#4173)
* UI: Fix HTML validation warnings and error

* Back to previous ie=

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-14 16:19:29 +01:00
Lars Hvam
a119c617d3
ALPHA downport, refactor XSTRING_TO_INT (#4177)
* Refactor XSTRING_TO_INT

this will use the built-in type conversion, its less code and most likely also runs faster

* delete METHOD alpha_output

it is only used in one place, and its a simple NUMC that is converted
2020-11-14 16:03:33 +01:00
Marc Bernard
16e8f3d02d
Dialogs: HTML form enhancements (#4172)
* Dialogs: HTML form enhancements

In preparation for https://github.com/abapGit/abapGit/issues/4171, HTML forms were enhanced as follows:

- New integer fields (type "number") with min/max, https://github.com/abapGit/abapGit/issues/3559
- Added support for minlength/maxlength for text fields
- Added support for read-only fields
- Added support for password fields
- New option for adding a help button to the form (with URL link)
- Moved HTML snippets to render method
- Changed parameters to csequence to also accept char variables (like abap_true)
- Minor adjustments to styles

* Lint and fix ul/fieldgroup

* Min/max validation, textarea

* Close textarea tag

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-14 11:28:19 +01:00
Marc Bernard
61599d8225
Dialogs: Change UI texts to title case (#4176)
* Dialogs: Change ui texts to title case

Adjust texts of "New Online" and "New Offline" pages to title case

* Clone
2020-11-14 08:40:50 +01:00
Lars Hvam
c4f75fc5a8
ZCL_ABAPGIT_CONVERT refactor (#4161)
* ZCL_ABAPGIT_CONVERT  refactor

this removes calls to function modules, replacing with class based equivalents, or all custom ABAP implementations

* rename local variables
2020-11-12 09:00:32 +01:00
Lars Hvam
8226aefcfe
add interface ZIF_ABAPGIT_MERGE (#4160)
* move merge types to merge class

this will make the God interface defintions smaller

also reducing INTF -> CLAS references

and making it easier to add an interface for the merge class in the future

* add interface ZIF_ABAPGIT_MERGE
2020-11-12 08:57:34 +01:00
Marc Bernard
b25a67acea
Terminology: Inclusive Language - Part 2 (#4159)
* Terminology: Inclusive Language - Part 2

Change "Master Language" to "Main Language" in UI and comments (documentation and variables next)

* Docs

* Docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-11 10:36:38 +01:00
Marc Bernard
b5ba5092bf
Terminology: Inclusive Language - Part 1 (#4158)
Changing "User Master Record" to "User Record"
2020-11-10 15:16:41 +01:00
Lars Hvam
e35df57646
Change TY_SVAL_TT location (#4155) 2020-11-10 14:21:42 +01:00
Lars Hvam
3162b23c39
Move git url repo methods (#4147)
* Move git url repo methods

This moves methods GET_COMMIT_DISPLAY_URL and GET_DEFAULT_COMMIT_DISPLAY_URL from the repo class to new class in new package GIT_PLATFORM.

we want to keep the repo class small, as its quite complex and central

#4085

* fix line length
2020-11-10 06:34:16 +01:00
Marc Bernard
5df956a37a
Toggle display of hidden characters on diff page (#4136)
* Toggle display of hidden characters on diff page

Time for something new...

I added a toggle switch to the diff page that allows you to show otherwise hidden characters.
- CR end-of-line 
- Spaces
- Tabs
- Byte-order-mark

Closes https://github.com/abapGit/abapGit/issues/2124
Closes https://github.com/abapGit/abapGit/issues/3676
Improves https://github.com/abapGit/abapGit/issues/2804

* Add ini

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-07 09:54:38 +01:00
Lars Hvam
85404ce72f
Refactor ZCL_ABAPGIT_PERSIST_BACKGROUND (#4123)
+ remove MT_JOBS
+ add GET_BY_KEY that can be used instead of LIST

closes #1455
2020-11-07 09:52:00 +01:00
Marc Bernard
5c1298697d
Trigger main command when pressing enter in form (#4102)
* Triggers main command when pressing enter in form

Adds hidden button that triggers main command when pressing the enter key

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-05 09:46:21 +01:00
Marc Bernard
b408cad115
Backup and restore for abapGit persistency (#4137)
* Backup and restore for abapGit persistency

Backup complete content of abapGit persistency to a ZIP file and restore when necessary.

* Messages

* 702

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-05 09:28:48 +01:00
Marc Bernard
87a3806ce1
UI: Unify rendering of transport, user names - part 2 (#4133)
- Added icon for user
- Changed icon for transport to truck
- Adapted "staging" page 
- Renamed CSS-classes because of conflict with classes used on staging page

Screenshots #4097
Closes #4098

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-04 14:51:34 +01:00
Frederik Hudák
990441dbe0
Retrieve transport and changed by for deletions (#4056)
* Retrieve transport and changed by for deletions

* Refactor

* Remove breakpoint

* Update src/ui/zcl_abapgit_gui_page_stage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/ui/zcl_abapgit_gui_page_stage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/ui/zcl_abapgit_gui_page_stage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Abaplint

* ABAPLINT

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-03 08:52:49 +01:00
Lars Hvam
c2492dd47e
delete unused methods (#4125)
* ZCL_ABAPGIT_REPO_FILTER

delete ZCL_ABAPGIT_REPO_FILTER->GET_PACKAGE
ZCL_ABAPGIT_REPO_FILTER delete MV_PACKAGE

* testclass, delete method given_fstate

* delete ZCL_ABAPGIT_GUI_PAGE_PATCH->IS_EVERY_CHANGE

delete method delete ZCL_ABAPGIT_GUI_PAGE_PATCH->IS_EVERY_CHANGED_LINE_PATCHED

* delete ZCL_ABAPGIT_OBJECTS_SUPER->CHECK_TIMESTAMP
2020-11-03 08:45:21 +01:00
Lars Hvam
df652f0436
delete various unused local variables (#4126) 2020-11-03 08:43:04 +01:00
Marc Bernard
6779e90448
UI: Sort "Switch origin" by PR number (#4127)
- Sort descending by PR number
- Rename menu items

Closes https://github.com/abapGit/abapGit/issues/4031

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-03 08:41:06 +01:00
Marc Bernard
e6acd28bda
Fix invalid HTML (#4128)
* Fix invalid HTML

- Fix HTML in case changelog contains `<, >, &` characters

* Invalid unquoted attribute value

* No tags after </body>
2020-11-03 08:38:02 +01:00
Marc Bernard
29aea372a5
UI: Adjustments to Repo Palette (#4079)
* UI: Adjustments to Repo Palette

- Sort alphabetically
- Pad offline icon (using CSS)

* CSS

* CSS

* Remove css changes

Css is fixed in #4112

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
2020-11-02 09:38:33 +01:00
Marc Bernard
dd37881589
702: Fix syntax error and missing check variant (#4117)
* 702: Downport 

No chaining with CHANGING

* 702: Downport

* Syntax check variant

* Too many fields warning

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:29:09 +01:00
Marc Bernard
bdc44f7476
Remove self-references (#4115)
* Remove self-references

Remove unnecessary self-references (me->)

https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-method

* 702: Fix syntax error

No chaining with EXPORTING & CHANGING

* remove addiontal me, update abaplint config

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:25:27 +01:00
Alexander Tsybulsky
614a8d60a3
new icons and css adjustments (#4112)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:16:59 +01:00
mariusraht2
ec99d16ec0
Checkout commit: Add menu entry and finish implementation (#4101)
* Implementation

* Add menu entry for checkout commit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-30 10:24:27 +01:00
Marc Bernard
666dfbda66
UI: Unify rendering of branch, package, transport, user names (#4097)
* UI: Unify rendering of branch, package, user names

Branch name was already rendered "boxed with a leading icon". The same is now done for package and user names.

See `zcl_abapgit_gui_chunk_lib->render_branch_name, render_package_name, render_user_name`.

Closes #4059

* Lint %26 transport

* Unknown user

* Transport css

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-30 10:13:09 +01:00
Marc Bernard
5d480d8e8d
Fix jump links on diff page (#4096)
Some files that existed locally didn't have a link. After #4084, the state can be evaluated properly to determine if local object exists.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-30 10:01:42 +01:00
Frederik Hudák
888bbcb27e
Disable sorting for action column (#4087)
* Disable sorting for action column

* abaplint

* Revert renamed methods
2020-10-28 12:23:00 +01:00
mariusraht2
6b336c58f0
ZCL_ABAPGIT_REPO_ONLINE: Change methods fetch_remote and push to be able to retrieve and push objects also by commit hash (#4077)
* Implementation

* Add changes to push method

* Reset commit hash if branch is being switched

* abapLint: Remove whitespace

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2020-10-28 11:56:56 +01:00
mariusraht2
a4172c6acc
ZCL_ABAPGIT_SERVICES_GIT: Add new method checkout_commit to let the user check out commits (#4076)
* Implementation

* abapLint: Omit exporting

* Omit obsolete variables

* Add caller for checkout_commit

* Extend hash column for 1 character

* Add reset_remote to set_sha1

* Merge branch 'master' into add_checkout_commit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-28 11:08:39 +01:00
mariusraht2
69b6c3c38a
Implementation (#4086) 2020-10-28 10:41:22 +01:00
Marc Bernard
f699812b02
UI: Adjustments to Command Palette (#4080)
- Add prefix for utilities and help commands
- Remove leading spaces

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-28 06:46:53 +01:00
Marc Bernard
46f504a0e8
UI: Adjustments to Hotkeys (#4083)
- Add hotkey "f" for "new offline"
- Add hotkey "c" for "syntax check"
- Fix #3927
2020-10-28 06:42:40 +01:00
mariusraht2
3ec07c6493
ZCL_ABAPGIT_SERVICES_GIT: Change signature of method checkout_commit_build_popup (#4072)
* Implementation

* Remove unrelated pretty printer changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-27 16:14:16 +01:00
mariusraht2
5aebc0c88e
ZCL_ABAPGIT_SERVICES_GIT: Add method checkout_commit_build_list to build the popup selection table for commits (#4070)
* Implementation

* abapLint: Omit exporting and avoid void types

* Clear all exporting parameters first

* Remove unrelated pretty printer changes
2020-10-27 16:05:04 +01:00
Jaime Rodriguez Capote
d6fbcc1fb6
Fix repo view class name importing ZIP (#4065) 2020-10-26 10:39:16 +01:00
Fabian Lupa
ceeb95eec1
Fix arrow direction for sort order (#4062) 2020-10-26 08:06:28 +01:00
mariusraht2
54ce6771bd
Issue #4027: Resolve possible crash of AG and add option to be able to suppress showing commit hash on Code Inspector result page (#4028)
* Replace LEAVE with CALL SCREEN

* Add new option iv_show_commit

Add new option iv_show_commit to GUI_CHUNK_LIB to be able to suppress showing commit hash on GUI_PAGE_CODE_INSP page

* abapLint: Replace 'EQ' by '='

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Hide commit hash on other pages too

Hide commit hash on ZCL_ABAPGIT_GUI_PAGE_REPO_SETT and ZCL_ABAPGIT_GUI_PAGE_SYNTAX pages

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-19 11:19:02 +02:00
mariusraht2
9ac7630711
ZABAPGIT_FORMS: Remove obsolete form package_popup and related callback handler (#4029)
* ZABAPGIT_FORMS: Remove obsolete methods

- Remove branch_popup
- Remove package_popup

* Readd branch_popup

* Readd branch_popup

* Remove related callback handler

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-16 09:11:18 +02:00
Alexander Tsybulsky
19c49fd960
Bugfixes in html_form and Finetune add pages to new event (#4011)
* refactor validation in html_form + UT

* minor UT tweak

* subtle form bugfix (boolc return space string)

* cleanup add forms

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-12 16:40:24 +02:00
Alexander Tsybulsky
4b6c424465
html event abstraction, phase 5 - case insensitive query and form_data (#4007)
* case-insensitive string map

* refactor gui_event and its UTs

* remove query uppercased in pages

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-11 10:47:37 +02:00
Marc Bernard
0adb9dec58
Add Offline: Uppercase package name (#4002) 2020-10-09 12:30:07 +02:00
Lars Hvam
f9d064829a
remove more ALIASes (#3986)
most of these are not in use, but was also public
2020-10-07 09:05:28 +02:00
Lars Hvam
4e96acd4be
use HEAD symref as default branch (#3983)
* use HEAD symref as default branch

closes #3974

* autodetect
2020-10-07 08:59:30 +02:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
Alexander Tsybulsky
7c0ec067a1
rename repo related pages (#3982) 2020-10-06 08:22:22 +02:00
Marc Bernard
42c909e688
Refactor: Remove dynamic instantiation of ZCL_ABAPGIT_MESSAGE_HELPER (#3966)
* Refactor: Remove dynamic instantiation of ZCL_ABAPGIT_MESSAGE_HELPER

Consolidate `ZCL_ABAPGIT_MESSAGE_HELPER` features into `ZCX_ABAPGIT_EXCEPTION` and removes helper.

* Remove helper

* Pretty

* Update chunk_lib

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-05 16:50:36 +02:00
Alexander Tsybulsky
6941d9824a
html event abstraction, phase 4 - form_data (#3975)
* event->post_data logic

* part of pages, commit test

this is also long text
to test

* string_map: port strict() feature

* pages refactoring part 2

* linter

* docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-05 09:33:01 +02:00
Marc Bernard
25774396e6
Dialogs: add offline repo HTML form (#3960)
* Dialogs: add offline repo HTML form

* Dialogs: add offline repo HTML form

* Dialogs: add offline repo HTML form

* Lint

* Lint

* Chaining

* Set required attribute

* Check for empty display name

* Change validation

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-03 10:18:45 +02:00
Marc Bernard
c9da76b3ee
Fix error from CL_PACKAGE_FACTORY=>LOAD_PACKAGE (#3958)
* Fix error from CL_PACKAGE_FACTORY=>LOAD_PACKAGE

* Variable

* Change to T100 messages

* super->constructor( )

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-29 17:29:02 +02:00
Marc Bernard
5bde9bd549
Fix syntax errors in 702 (#3955)
* Fix syntax errors in 702

* Fix syntax errors in 702
2020-09-28 19:58:31 +02:00
Alexander Tsybulsky
e95b6f7806
html event abstraction, phase 3 - query (#3903)
* event->query

* page db refactoring

* linter fix

* linter fix

* address repo via key= param

* linter

* mv_getdata WIP

* mv_getdata - finish

* cleanup action utils

* linter fix

* another linter fix

* docs for event->query
2020-09-28 16:41:59 +02:00
Marc Bernard
dc9773bee9
Fix handling of T100 exceptions (#3943)
* Fix errors raised during deletion

* Fix error handler

* Harmonize top and bottom message banners

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-27 10:56:08 +02:00
Lars Hvam
1c1b04fbe9
update lint config, minor refactors (#3948) 2020-09-27 09:24:31 +02:00
Lars Hvam
fff8f1b237
new URL, updates (#3936)
* Update build.yml

* docs, update urls

* code, update links
2020-09-24 09:42:52 +02:00
Fabian Lupa
f2defab59e
Add option to synchronize theme with frontend (#3929)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-23 12:34:15 +02:00
Fabian Lupa
b7d318d2e9
Add button to launch IEChooser.exe on Windows (#3922)
* Add button to launch IEChooser.exe on Windows

* Fix CASE statement

* Determine iechooser.exe path using system directory

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-23 12:31:01 +02:00
Lars Hvam
03724484f1
use boolc (#3920) 2020-09-23 12:28:13 +02:00
Fabian Lupa
8ad4d130d4
Fix sort by created at in repo overview (#3919)
Fixes #3918

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-22 08:56:58 +02:00
Fabian Lupa
a2f57aeb9a
Split up global settings button and utility menu (#3913)
* Split settings and dev utils menu

* Fix missing settings hotkey on repo view

* Revert "Fix missing settings hotkey on repo view"

This reverts commit 1444744a5f.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-22 08:54:40 +02:00
Lars Hvam
015800b45b
Less DDIC references (#3905)
* remove uses of CHAR30

* Update abaplint.json

* add basic unit test for ZCL_ABAPGIT_MESSAGE_HELPER

* replace uses of char50

* fix name

* Update abaplint.json

* use sy-uname instead of uname

in ZCL_ABAPGIT_USER_MASTER_RECORD
2020-09-21 07:39:22 +02:00
Fabian Lupa
a16a903f57
Show repo list button in tutorial (#3910)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-20 09:43:54 +02:00
Fabian Lupa
bab9b7ba22
Show tutorial if there are no repos (#3907)
Fixes #3553

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-20 09:40:57 +02:00
Alexander Tsybulsky
aae82485e0
html_form chaining (#3908) 2020-09-20 09:29:12 +02:00
Alexander Tsybulsky
6e515e1063
Unified validate and normalize form params in html_form class (#3904)
* html_from - validate and normalize form params

* docs
2020-09-20 07:41:46 +02:00
Alexander Tsybulsky
9574dca828
html event abstraction, phase 2 (action utils usage unification) (#3902)
* action utils improvements

* page unifications

* linter
2020-09-19 11:02:01 +02:00
Alexander Tsybulsky
555f2f3d0b
html event abstraction, phase 1 (#3900)
* event class, interface and gui

* router adaptation

* rest of the pages

* linter fixes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-19 07:57:39 +02:00
Fabian Lupa
143a7ccc1c
Downport, fixes #3897 (#3899) 2020-09-19 07:54:36 +02:00
Alexander Tsybulsky
d20cdd07c2
syst_title is missing in 731 (#3896)
* syst_title is mising in 731

* adjust type

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-17 17:40:38 +02:00
Marc Bernard
475f67d1d8
Remove trailing spaces in HTML output (#3893)
* Remove trailing spaces from html

* Return string size
2020-09-17 17:07:46 +02:00
Lars Hvam
9f396366cd
gui refactoring, for web edition (#3890)
* put cl_gui_html_viewer behind an interface

* cleanup

* injectable html viewer

* method_parameter_names, exclude zif_abapgit_html_viewer

* fix whitespace

* public get_asset_manager

* Update abaplint.json

* add prefixes
2020-09-16 12:39:23 +02:00
Lars Hvam
5b93872199
reduce existing string templates (#3886) 2020-09-15 08:14:42 +02:00
Lars Hvam
2ff25e27dd
pretty print ZCL_ABAPGIT_HTML_FORM and static (#3880)
pretty print class ZCL_ABAPGIT_HTML_FORM, and change two static methods to instance, this will make future possible changes to the class easier to see in the history
2020-09-12 06:50:31 +02:00
Lars Hvam
f0208ae883
html, use interfaces (#3871)
* html, use interfaces

#3460

* fix syntax, remove alias

* last one 🎉
2020-09-12 05:16:21 +02:00
Marc Bernard
7e4ae44fea
Enhance result view of Code Inspector/Syntax Check (#3861)
Follow-up to #3717: 
- Proper display of public, protected, and private sections
- Add CLAS prefix to be inline with other object types

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-11 11:23:33 +02:00
mariusraht2
4dce10e83c
popup_to_select_from_list can handle element-based tables (#3858)
* popup_to_select_from_list can handle element tabs

popup_to_select_from_list can now handle element-based non-structured tables like a table of url strings

Therefore related to #3639

* Update zcl_abapgit_popups.clas.abap

* Fixed wrong value assigning and added assert
2020-09-11 09:25:21 +02:00
Lars Hvam
42a532b9eb
reduce usage of ddic types (#3859)
* add SAP_BOOL as forbidden void type

* reduce

* Update abaplint.json

* sychar10

* sylangu

* Update abaplint.json
2020-09-10 15:30:25 +02:00
Fabian Lupa
dc5725b49c
Add performance test (#3847)
* Add performance test

* Fix some linter errors

* Refactor free selections to reduce method length

* Performance test add title to result ALV

* Attempt downport

* Downport

* Pretty Printer VS abaplint

* Undo more changes done by pretty printer

* Adjust performance popup title and ALV layout

* Move free sel dialog to global for abapmerge

* Move some type definitions for abapmerge

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-08 10:39:20 +02:00
g-back
3e4ce7bf73
Offline Repos: add ZIP Import/Export to actions (#3823)
* navigate to repo after ZIP import

* add zip import/export action for offline repos

* rename action labels

* change new state to be dependent on current page


change replacing -> new page if action called from repo list
rerender if in repo view

* add some TODOs, see PR discussion

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-08 10:32:17 +02:00
Lars Hvam
6739b768e9
html refactoring (#3843)
* html refactoring

change A() to instance method
remove ADD_CHECKBOX alias

* removes ICON alias

* more
2020-09-06 09:45:51 +02:00
Marc Bernard
c09cc67c83
Fix startup of repo view (#3831)
* Update error msg

* Fix login popup errors and cancelation

* Remove validate/reset methods

* Lint

* Rename iv_repo_online to io_repo_online

* Change to error in status bar

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-04 09:32:38 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Lars Hvam
98a261df1b
remove some unused variables (#3825) 2020-09-01 16:32:44 +02:00
Lars Hvam
86657cc691
HTML refactoring (#3813)
* HTML refactoring

* removes the ADD_ICON alias

#3460

* remove IS_EMPTY alias

* more

* refactoring
2020-08-31 09:37:36 +02:00
Lars Hvam
271e365f06
html, use interfaces (#3811)
* html, use interfaces

* more

* more

* more

* this removes the ADD_A alias
2020-08-29 08:00:56 +02:00
Lars Hvam
84c80a761c
refactoring, use interface for html (#3793)
* refactoring, use interface for html

replace uses of zcl_abapgit_html with zif_abapgit_html

#3460

* replace additional uses of the A alias

* This removes the A alias from the HTML class

This removes the following alias,
"a FOR zif_abapgit_html~a ."

* fix syntax error
2020-08-27 07:51:51 +02:00
Alexander Tsybulsky
a4e6c87985
Switching to PRs (#3695)
* string map: public entries (read only)

* port http agent

* draft wip

* drafting

* fix SSL

* port ajson

* integrate ajson and http_agent

* agent global headers

* github enumerator

* update ajson

* draft wip

* enumerator factory

* http_agent via factory

* proxy

* repo->switch_origin draft

* refactor enum factory

* Revert "refactor enum factory"

This reverts commit bcfef40b38991adfe5f73677919db6bd0c652f7c.

* page wiring draft

* scripts draft

* "let it work!"

* repo setings page draft

* linter

* linter

* linter

* linter

* linter

* better settings page

* finetune page

* cleanups

* change hotkey

* fix ajson_error

* Update src/zcl_abapgit_repo_online.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* abaplint nesting 6

* remove description

* back to good old popups

* linter

* move commands to branches dropdown

* auth helpers

* move json to separate package

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-27 07:47:27 +02:00
Lars Hvam
681f60a265
background pull: always overwrite all objects (#3802)
* background pull: always overwrite all objects

always choose to overwrite all objects when using the pull in background feature. If the decision is not set the job will fail with a "undecided" error

#3800

* fix page title typo
2020-08-27 07:38:18 +02:00
g-back
8fc08b9c22
Add success messages for repo removal/uninstall (#3797)
* add success messages for repo removal/uninstall

* remove single quotes, add packg name to remove msg

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-27 07:33:55 +02:00
Lars Hvam
bb6785812e
styling, fix background color on background settin (#3801) 2020-08-27 07:30:41 +02:00
Marc Bernard
f1f3673b09
Improve display when there are no changes in repo view (#3803)
* Improve display when there are no changes in repo view

* Update view and remove empty_package method

* Empty package msg

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-27 07:27:24 +02:00
Lars Hvam
a9d22356a1
test (#3791) 2020-08-25 07:29:12 +02:00
Frederik Hudák
380857a896
Reposition repo filters (#3779)
* Reposition repo filters

* Remove show order by logic

* Fix diffs first being backwards

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-25 07:14:50 +02:00
Lars Hvam
dcc655eccf
syntax check page, show variant used (#3790)
* syntax check page, show variant used

closes #3660

* unify variant rendering
2020-08-25 07:05:32 +02:00
Marc Bernard
af5b898a37
Refactor branch constants (#3784)
* Branch constants

* Refactor branch constants

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-24 11:25:46 +02:00
Marc Bernard
e4bafbe715
Validate if branch exists when displaying repo (#3749)
* Validate if branch exists when displaying repo

* Validate if branch exists when displaying repo

* Lint

* Lint and 702

* Lint

* Rename validate_branch to validate

* Fix msg and branch display name

* Move msg to UI layer

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-08-24 11:15:46 +02:00
Frederik Hudák
5c826e5993
Navigate to repo after new online (#3780)
* Navigate to repo after new online

* Update zcl_abapgit_gui_page_addonline.clas.abap
2020-08-22 14:39:39 +02:00
Marc Bernard
fe95dc7e5f
abapGit Emergency Mode (#3756)
* abapGit Emergency Mode

On rare occasions, it is necessary to edit the abapGit settings to overcome an issue (example: https://github.com/larshp/abapGit/issues/3701). 

This enhancement allows you to start abapGit in "emergency mode", which directly shows the "Database Utility" for you to view or edit any setting. 

How to start abapGit in "Emergency Mode":

1. Go to transaction SU3 to maintain your user profile
2. Maintain parameter DBT with value "ZABAPGIT" (all-caps).
3. Start abapGit
4. After exiting abapGit, go back to SU3 and remove parameter DBT

* Update ref-database-util.md

* Add files via upload

* Update ref-database-util.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-22 09:55:33 +02:00
Frederik Hudák
a824368a4e
Add top repo menu to more pages (#3764)
* Add top repo menu to more pages

- diff, patch
- syntax check, code inspector
- repo settings

* Add to syntax check page, add margin

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-22 09:53:35 +02:00
Frederik Hudák
f5052cf0b6
Use title case in page titles, menus, forms (#3765)
* Use title case for page titles

Other minor changes:

- patch page is no longer called diff
- "code inspector" in main page action menu renamed to "check"

* Two more

* Update zcl_abapgit_gui_page_db_dis.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Repo advanced menu

* Commit form labels

* Repo setting lables

* Settings, repo

* Final ones?

* Database util

* Column name in stage page

* abaplint

* Update zcl_abapgit_gui_page_stage.clas.abap

* Hover texts for stage column, commit settings

* lint
2020-08-22 09:50:10 +02:00