Commit Graph

3765 Commits

Author SHA1 Message Date
Marc Bernard
8e7c79261d
CLAS,INTF: Catch runtime error during update (#5841)
Prevent dump when deserializing classes and interfaces in case a sub component was changed in a way that standard SAP code does not handle.

References: 
- message `OO_SOURCE_BASED 019`
- SAP Note [2166231](https://launchpad.support.sap.com/#/notes/2166231)
- https://github.com/abapGit/abapGit/issues/5836

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-10-31 08:49:46 -04:00
github-actions[bot]
8add5d6391
ajson, Automatic Update (#5837) 2022-10-24 08:16:51 +02:00
Katharina Wurz
e4aeff4f04
Small refactoring of zcl_abapgit_aff_registry (#5835) 2022-10-23 14:59:05 +02:00
Jaime Rodriguez Capote
976dd0f768
Skip Project piece list request (#5834) 2022-10-20 16:56:41 +02:00
Marc Bernard
34c07b6f98
Avoid overwriting built-in functions (#5832) 2022-10-20 16:45:31 +02:00
Marc Bernard
24b1bcffa7
Remove cases of modifying syst fields (#5831)
Remove cases of modifying `syst` structure
2022-10-20 16:43:03 +02:00
Alexander Tsybulsky
d2ba4af805
UI repo over tweaks (#5790)
* bugfix remove command

* bugfix diff shortcut

* wip

* working

* css clean ups

* linter fix

* css improvements

* font 90%

* css cleanups
2022-10-17 15:17:22 -04:00
Marc Bernard
9bcbebb46b
Disable "experimental" feature for stand-alone version (#5828)
Closes #5827
2022-10-17 10:13:54 -04:00
Lars Hvam
e539fc30e2
update AFF types to latest (#5824) 2022-10-17 16:05:40 +02:00
Lars Hvam
9af402ff9f
INTF cleanup: delete unused methods (#5823) 2022-10-17 15:48:01 +02:00
Lars Hvam
cb66e18738
housekeeping, delete some unused variables (#5825) 2022-10-17 15:25:00 +02:00
Lars Hvam
188c9ed903
dont use I18_A_LANGISO2, its not released (#5822)
* dont use I18_A_LANGISO2, its not released

* use LAISO

* use LAISO
2022-10-14 15:17:44 -04:00
Albert Mink
22214428d7
AFF: More UT for testing deserializing (#5821)
more details in UT
2022-10-13 19:41:26 +02:00
Marc Bernard
302ac77c44
UI: Add hint for "icon scaling" setting (#5819) 2022-10-12 12:50:57 -04:00
Uenal Akkaya
763fbad76c
DRUL: Use CL_BLUE_SOURCE_OBJECT_DATA instead of CL_DRUL_WB_OBJECT_DATA (#5818)
* Update zcl_abapgit_object_drul.clas.abap

Use in class ZCL_ABAPGIT_OBJECT_DRUL the more generic type CL_BLUE_SOURCE_OBJECT_DATA instead of CL_DRUL_WB_OBJECT_DATA

* Update zcl_abapgit_object_drul.clas.abap

Use in class ZCL_ABAPGIT_OBJECT_DRUL the more generic, similar type CL_BLUE_SOURCE_OBJECT_DATA instead of CL_DRUL_WB_OBJECT_DATA
2022-10-12 09:56:30 -04:00
Albert Mink
27bec52c8a
AFF with namespaces (#5779) 2022-10-10 11:38:47 -04:00
Marc Bernard
67093085f6
CLAS,ENHO: Fix inactive enhancements (#5810)
* CLAS,ENHO: Fix inactive enhancements

When pulling a change to an existing class, existing enhancement where inactivated and the enhancement code deleted. 

This was caused by unnecessarily calling `CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE'` in `zcl_abapgit_oo_class->create`, twice.

The change avoids the second call if the class properties and attributes have *not* been changed. Interfaces are handled the same way. 

Tested with CI tests for classes and interfaces:


Closes #5809

* Clear

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-10-07 15:00:31 -04:00
Alexander Tsybulsky
3ecf82777c
UI repo over view page refactoring (#5789)
* improvements in abapgit_html

* linter fix

* repo over code styling

* repo overview refactoring part 1

* move universal cod to chunks

* cleanup new code temporarily

* more clean ups

* ui_component register_hotkeys helper

* move relevant hotkeys to repo overview

* forgotten part

* move event handling to repo over

* reuse td

* move render_repo_url to chunks

* minor

* linter fix

* new > create

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-10-07 14:46:43 -04:00
Alexander Tsybulsky
3e4e631cdb
Improvements in html engine (#5788)
* improvements in abapgit_html

* linter fix

* Try to workaround transpiler bug

* exclude uts from transpiler

* new -> create

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-10-06 16:34:01 -04:00
Patrick Winkler
cda541692f
SMBC: Business Configuration Maintenance Objects (#5812)
* enable SMBC for abapGit

* fix abapLint issues
2022-10-06 09:11:37 -04:00
Marc Bernard
fbeabd6220
ENHO: Unlock objects in cases of errors (#5811) 2022-10-06 10:17:22 +02:00
Christian Günter
86751b6961
VIEW: Add translation support (#5806)
fix linter
2022-10-05 20:11:46 -04:00
Christian Günter
f8564cb679
AFF: Fix existence check (#5803)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-10-04 17:48:11 -04:00
Marc Bernard
0437fc4e95
1.118.0 (#5802)
* v1.118.0

* 1.118.0

* Update changelog.txt

* Update changelog.txt
2022-10-04 10:33:39 -04:00
Christian Günter
1be856d23a
Fix failing unit test for SAP_BASIS SP00 (#5801)
* Fix failing unit test for SAP_BASIS SP00

before this fix ls_requirement-min_patch gets negative for SP00 and therefore failing

* fix linter

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-10-04 09:53:42 -04:00
Marc Bernard
35718fbf77
W3xx: Remove unnecessary metadata (#5780)
* W3xx: Remove unnecessary metadata

* Clear metadata

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-10-04 09:47:05 -04:00
Marc Bernard
004885fcc0
FUGR: Add documentation (longtexts) (#5795)
After #5786, Ref #5774

Serialize and deserialize documentation of function group, function modules, and parameters. 

Test case: 
https://github.com/abapGit-tests/FUGR_docu

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-10-04 09:44:03 -04:00
Jon Friesen
954d913191
CLAS,INTF: Support for component documentation (#5575)
* serialization

* full sotr class serialization

* nw 7.02 compatibility

* ensure consistent order

* Second attempt to stage support for CLAS and INTF 

Second attempt to stage support for CLAS and INTF, first attempt did not have changes

* Pretty printed

* Lint compliance part 1

* Lint compliance part 2

* code review remediation plus one bugfix

includes one bugfix - do not write entries in <DOCU_CAT> if there are no lines of text

* Update src/objects/zcl_abapgit_objects_program.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Switch to new method

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Marc Bernard <marc@marcbernardtools.com>
2022-10-04 09:33:38 -04:00
Marc Bernard
e0e3b442a0
Various objects: Add documentation (longtexts) (#5796)
Add documentation (longtexts)

After #5786, Ref #5774

Serialize and deserialize documentation of CHAR, DTEL supplements, SFBF, SFBS, SFSW, TTYP, VIEW, WDYA, XINX

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-10-04 09:18:28 -04:00
Christian Günter
ee4320db6b
fix language dependent unit test (#5799)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-10-04 09:06:41 -04:00
marcushoepfner
3060254d10
Fix subcomponent text deserialization (json) (#5783)
* fix

* Take linters recommendations

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* adapted missing call; fix syntax issue

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-10-04 11:17:04 +02:00
Christian Günter
cbec754b65
Downport, version unit tests (#5797) 2022-10-04 08:58:18 +02:00
Marc Bernard
d936b8dc0b
Prepare processing longtexts for sub components (#5786) 2022-10-04 08:09:56 +02:00
Fabian Lupa
125b529583
Allow use of changelog feature without APACK (#5739) 2022-10-04 07:50:37 +02:00
Marc Bernard
fcdb07a7a6
TABL: Fix deserialize if foreign key exists (#5773) 2022-10-02 09:19:33 +02:00
Marc Bernard
16656d8141
CLAS: Fix pull for deleted interface methods (#5768)
* CLAS: Fix pull for deleted interface methods

In case an interface method was deleted, pulling a class that had implemented such method would not delete the implementation. This resulted in a diff and manual effort to remove the method (or repair the class).

The fix will compare the implemented methods and trigger the repair if necessary.

Closes #5578

* Update zcl_abapgit_oo_class.clas.abap

* return all includes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-09-26 11:20:17 -04:00
Fabian Lupa
77fea02b45
Force usage of local object handler classes (#5778) 2022-09-26 06:50:16 -04:00
github-actions[bot]
86e88991e5
ajson, Automatic Update (#5776) 2022-09-24 13:38:15 +02:00
Marc Bernard
f1c1aad740
Delete obsolete longtexts on pull (#5751)
* Delete obsolete longtexts on pull

Longtexts that exist in the system but not in the remote repository are deleted when pulling.

Closes #5202

* Refactor

* Constant

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-09-23 09:57:44 -04:00
github-actions[bot]
c1a631fba3
ajson, Automatic Update (#5771) 2022-09-22 07:11:17 +02:00
Lars Hvam
ec83d1de35
Data: downport (#5770)
#5769
2022-09-22 06:59:19 +02:00
Marc Bernard
7db0c6082e
1.117.0 (#5765)
* 1.117.0

* Update version

* Update changelog.txt
2022-09-19 13:48:55 -04:00
Marc Bernard
aa1748ab28
Fix unit test for user persistence (#5763)
* Fix unit test for user persistence

Test fails if no repo exists with key `REPO/000000000001`

* Use existing constants

* Update src/persist/zcl_abapgit_persistence_user.clas.testclasses.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2022-09-19 11:49:56 -04:00
github-actions[bot]
b60007c752
ajson, Automatic Update (#5764) 2022-09-19 07:20:50 +02:00
Lars Hvam
29622bdf7b
TABU data: refactor some unit tests (#5758) 2022-09-19 06:44:04 +02:00
Marc Bernard
b18586ba32
CLAS,INTF: Add missing shorttexts (#5755)
* CLAS,INTF: Add missing shorttexts

Serializes shorttexts for sub components (like method and event parameters).

Preparation for https://github.com/abapGit/abapGit/pull/5718

New test cases:

https://github.com/abapGit-tests/INTF_docu
https://github.com/abapGit-tests/CLAS_docu

* Clear/set class/interface name for shorttexts

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-09-15 11:34:32 -04:00
Marc Bernard
b9bb9a8094
Add uninstall option to repository overview (#5753)
* Add uninstall option to repository overview

* Hover + Remove

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-09-15 09:08:23 -04:00
Marc Bernard
0be78203d5
SOTR: Fix handling of alias names (#5750) 2022-09-13 16:39:33 +02:00
Marc Bernard
16d69e8ab9
DOCV: Handle namespaces (#5756) 2022-09-13 10:03:37 +02:00
Marc Bernard
ee3f5f4cb1
DSYS: Simplify namespace split (#5757) 2022-09-13 07:38:25 +02:00
Marc Bernard
471b155bc4
SUSH,SUSC: Fix deletion (#5748) 2022-09-09 14:24:52 +02:00
Marc Bernard
f9b0cc16ea
W3XX: Sort parameters to avoid diffs (#5746) 2022-09-08 08:14:33 +02:00
Marc Bernard
24340fce32
SCVI: Sort tables to avoid diffs (#5745) 2022-09-08 08:04:19 +02:00
Marc Bernard
b250edc8f7
WDYN: Fix dump if no components exist (#5749) 2022-09-08 08:01:04 +02:00
Marc Bernard
be967a4e8a
G4xx, IWxx: Changed by (#5747)
* G4xx, IWxx: Changed by

* Empty block
2022-09-08 07:32:35 +02:00
Marc Bernard
e1f78f733b
Remove unused branch popup (#5742)
`branch_popup_callback` and `POPUP_GET_VALUES_USER_BUTTONS` are not used anymore and leftovers from previous refactoring.
2022-09-07 09:47:44 -04:00
Marc Bernard
dd58dac4c3
Fix dump when deleting repo with DB utility (#5740)
* Fix dump when deleting repo with DB utility

Ref #5612

- Avoid dump when manually deleting entries with DB Utility
- Avoid inconsistency when deleting repo entry but not repo checksums
- Improve warning popup and error message

* Fix warning

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-09-07 08:41:41 -04:00
Marc Bernard
df62cb6ff4
DEVC: Fix dump if package has been delete (#5741)
If a package is deleted in a different session while viewing a repository, refreshing the repo view will dump.
2022-09-06 14:36:56 -04:00
Jorge Sancho
efb42650e0
new SOBJ serializer (#5724)
* 1st version of abapGit - SOBJ serializer

- added class 1st version of zcl_abapgit_object_sobj
- pending more testing

* refactoring to comply with abapGit conventions

* downporting to 7.02

* refactoring as abaplint suggests

'data' keyword in cappital letters

* more abaplint fixing

* changes for PR merging

- changed ABAP class title
- deleted commented code

* changes for PR merging (2)

- fixing abaplint

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-09-05 12:58:48 -04:00
thorsten-wolf-neptune
e58138e4f9
Fixed "Add via Transport" short keys (#5736)
* fixed "Add via Transport" short keys

* replace trobj_name with TYPE C LENTH 120

* Pretty Printer (VALUE uppercase)

* add skip

* add skip

* removed pretty printer comments

* running

* Replace with dtel

Works should SAP change the max key length

* Replace dtel 

For abaplint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-09-05 12:24:56 -04:00
github-actions[bot]
fbd0b7cc9d
ajson, Automatic Update (#5738) 2022-09-05 09:20:46 +02:00
Lars Hvam
366a30a0e0
export object page: add setting for only main language (#5735) 2022-09-02 08:54:00 +02:00
Lars Hvam
6743ac5fda
add page for running unit tests (#5719) 2022-09-02 08:43:28 +02:00
Marc Bernard
ae8d471d4a
Check logon language during uninstall (#5731) 2022-08-29 21:59:51 -04:00
Lars Hvam
ac982560aa
Data serialization, add WHERE condition based on transport (#5720) 2022-08-26 08:33:22 +02:00
Marc Bernard
1737957b34
Fix regression in non-Unicode systems (#5732) 2022-08-26 08:19:24 +02:00
Lars Hvam
c90ec52c42
fix some background colors (#5716) 2022-08-23 07:40:43 +02:00
Albert Mink
26f93a18bf
Fix language conversion, now 7.02 compatible (#5727)
solves #5726
2022-08-22 17:24:24 +02:00
Lars Hvam
ded64f98da
advanced dropdown: add separators (#5717) 2022-08-20 12:02:51 +02:00
Lars Hvam
7ac80cebf3
zlib/deflate decompression, bugfix (#5723)
zlib, bugfix
2022-08-18 06:00:46 +02:00
Vanessa
1c8bb3bfd6
New Object EVTB based on AFF (#5707) 2022-08-16 07:44:51 +02:00
Albert Mink
96dd561a3c
[AFF] deserialize INTF metadata as JSON (#5704) 2022-08-11 06:55:39 +02:00
Katharina Wurz
111656b7b1
Deal with empty active version (object was never activated) (#5714)
* Deal with empty active version

* Put if condition into method
2022-08-09 17:21:46 +02:00
github-actions[bot]
a09f9871b7
ajson, Automatic Update (#5713) 2022-08-08 07:04:15 +02:00
Katharina Wurz
fba53633b4
Improvements for CHK* classes (#5712) 2022-08-07 08:38:34 +02:00
Bo Larsson
284f056f60
downport assert_true() (#5711)
closes #5710
2022-08-05 13:18:55 +02:00
Albert Mink
bef09c48cb
[AFF] More detailed error msg (#5709) 2022-08-04 13:28:33 +02:00
Lars Hvam
2e879323c3
downport, temporary workaround, if_adt_lock_handle (#5706) 2022-08-04 10:03:54 +02:00
marcushoepfner
61e7d13cd0
INTF Refactor deserialize (#5698) 2022-08-03 17:16:02 +02:00
Lars Hvam
ffd3c95d4a
disable dependabot, unit testing (#5699) 2022-08-01 10:07:42 +02:00
marcushoepfner
fd7d4771d8
started unit tests for intf deserialize (#5697) 2022-07-26 14:54:42 +02:00
Albert Mink
d266f13415
[AFF] Custom AJSON filter for INTF serialization (#5675) 2022-07-26 07:53:55 +02:00
github-actions[bot]
229548a208
ajson, Automatic Update (#5695) 2022-07-25 10:34:08 +02:00
Lars Hvam
9ce3b76d54
refactor call to 'TR_READ_NAMESPACE (#5693) 2022-07-25 10:29:43 +02:00
Katharina Wurz
863f7d7088
Exception handling small improvement (#5691) 2022-07-21 07:38:01 +02:00
github-actions[bot]
15df1fd539
ajson, Automatic Update (#5689) 2022-07-20 08:10:52 +02:00
Albert Mink
0bf8388a6e
Use sy-uname instead cl_abap_syst->get_user_name (#5685) 2022-07-13 09:13:41 +02:00
Marc Bernard
bdfe982ee8
Improve package / sub-package check (#5628)
If a sub-package is removed from the package hierarchy, instead of an exception, abapGit now shows a detailed warning message in the log.

This allows to remedy the situation either by adding the sub-package to the package hierarchy or by removing the sub-package from the repository (via push).
2022-07-12 11:14:02 +02:00
github-actions[bot]
b6de2d0dc8
ajson, Automatic Update (#5682) 2022-07-11 12:17:51 +02:00
Lars Hvam
2f5d44de3e
IWSG: implement CHANGED_BY (#5680) 2022-07-08 11:11:46 +02:00
Christian Günter
5af8cf8862
AFF: Downport (#5679)
* AFF: Downport

* fix lint
2022-07-06 17:15:42 +02:00
Marc Bernard
89103ce49c
Repo view: Fix "View > Changes only" for offline (#5641)
Closes #4266
2022-07-06 10:23:28 +02:00
Albert Mink
96cd546c7e
[AFF] Get data for serialization from the DB (#5670)
* [AFF] Get data for serialization from the DB

This is definitely not 7.02 syntax.

Contributes to #5658

* is this 7.02 syntax?

* WIP: inlide data declaration

* declare locale variable FIELD-SYMBOL

* multiple statements -> line break; local variable

* one more FIELD0-SYMBOL

* fix redundant `this`

* WIP: streamline data types

* WIP: streamline data types and typos

* add const to abaplint config

* rm commended code line

* add const to abaplint config

* WIP: SELECT follows 7.02 syntax

* space before dot

* WIP: SELECT 7.02

* linter constants

* WIP: finish SELECT 7.02

* Update src/objects/zcl_abapgit_object_intf.clas.locals_imp.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* add ci/abaplint CONST

* more CONST to ci/abaplint

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2022-07-05 08:54:47 +02:00
Marc Bernard
d427c6cfe7
Skipping serialization for ignored objects (#5648)
* Skipping serialization for ignored objects 

Serialization now evaluates the ignore list and skips matching objects. Note: The match is using the ABAP `cp` operator.

Example:
```
*ztest.prog.*         Ignore individual program
*.ectd.*                 Ignore all objects of a given type
*/subpack/*           Ignore all objects in a sub-package
```
2022-07-01 08:16:44 +02:00
Albert Mink
89090b5c00
[AFF] Allow object handler to serialize JSON via experimental feature (#5660)
* [AFF] Object handler for INTF

* Add JSON handler

* hard coded language

* adopt to abapLint rules

* wip: abaplint

* wip: abapLint

* adjust to naming conventions

* AJSON filtering abapLanguageVersion for serializat

* SELECT 7.02; UPPER

* abapLint params

* filter/remove the empty arrays

* reset obj handler to origin/main

* add experimental feature to enable AFF serializati

* typos, indentation and more

* move code to local clas

* Update src/objects/zcl_abapgit_object_intf.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-06-30 16:06:55 +02:00
Albert Mink
eb2ae98c6d
[Refac] Object handler for INTF (serialize) (#5668) 2022-06-30 11:51:41 +02:00
Marc Bernard
01297df9a5
Avoid duplicate key error (#5663)
Follow-up #5652

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-06-29 14:39:10 +02:00
Marc Bernard
394212630d
1.116.0 (#5653)
See [changelog](https://github.com/abapGit/abapGit/blob/main/changelog.txt)
2022-06-29 12:29:06 +02:00
Marc Bernard
3e4c684815
Rename repo interface method implementations (#5667)
Renames methods after changing to interface. Interface methods are now properly named `<interface>~<method>` (instead of `<alias>`). This also fixes warnings and navigation issues in `SE24/SE80`.
2022-06-28 09:24:47 +02:00
Christian Günter
2d178b650a
Improve folder logic popup (#5662) 2022-06-27 13:20:35 +02:00