Commit Graph

78 Commits

Author SHA1 Message Date
Italo N
f4c8d13a2c Bug - PROG name contain '%3D' (#2980)
Issue #2923
2019-10-27 11:19:32 +01:00
Fabian Lupa
d72028a1e8 Progress indicator minimum percentage (#2855)
Fixes #2762
2019-08-07 21:25:57 -07:00
Christian Günter
99a6716f32 Log viewer: Add more exception information + actions (#2832) 2019-08-03 04:29:32 -07:00
Lars Hvam
d42bb98662
fixes #2808 (#2818)
fixes #2808
2019-07-31 00:41:01 -07:00
Lars Hvam
f6e8332754
Cleanup (#2753)
* refactor IF

* fix some indentation

* indentation fixes

* indentation fixes

* indentation

* indentation
2019-06-25 03:02:51 -07:00
Martin Fuchs
4aab0166ac Pass log to deserialization API and show log (#2729)
* Pass log interface for de-serialization

Interface ZIF_ABAPGIT_LOG is now passed for deseriaization API.
This includes:
- Log messages for FUGR: Imported function modules and includes
- Improved error messages for TABL compare
- Log objects w/o changes
- Log is shown in the UI if available ("Log" entry appears if a log exists, no persistence!)
This PR enhances #2534 and #2694

Another important change: In case an object fails (or a single function module in a group fails), the import continues with the next object!

* small pretty printer changes

small pretty printer changes

* fix abaplint issues

reduce line sizes and ensure 7.02 compatibility

* show errors and warnings from pull

Errors and warnings after a pull are now part of the "message list" above the object list in the main screen and will be shown immediately. The new"Log" button shows errors, warnings and success messages on demand.
The log title is now part of the ZIF_ABAPGIT_LOG interface.

* fix abaplint issue

fix abaplint issue
2019-06-21 23:05:10 -07:00
Fabian Lupa
3f01361d13 Check other dev clients in user master record (#2710)
* Fallback check other clients in user master record

* Replace SELECT...ENDSELECT with SELECT SINGLE
2019-06-11 08:57:28 -07:00
Martin Fuchs
42a3e7dfbb
fix_log_get_status (#2715)
Fix error in status calculation for ZCL_ABAPGIT_LOG for whole log and message table.
This PR belongs to #2694.
2019-05-29 09:10:06 +02:00
Martin Fuchs
2e781b316a ZIF_ABAPGIT_LOG: extend and move UI methods to new class (#2694)
* log: move show functions to new class

Enhance ZIF_ABAPGIT_LOG
- add IS_ITEM structure (object) to message adding functions
- add method "add_exception"
- add method "add_info"
- relocate methods "show", "to_html" and "write" to new class ZCL_ABAPGIT_LOG_VIEWER
Introduction of new log viewer class ZCL_ABAPGIT_LOG_VIEWER
Replacement of relocated methods where used
-> This is the next step providing a log for serialzation/de-serialization (see #2534)

* fix abaplint issues

fix abaplint issues

* fix abaplint issues (2)

fix abaplint issues
2019-05-26 03:16:03 -07:00
Alexander Tsybulsky
2fdff035be unify convert utils, part1 2019-04-24 07:59:06 -07:00
Lars Hvam
7bbaf069e2
File format update collection (#2605)
* File format update - changed object handler

I removed the following fields:

CLAS
VSEOCLASS-VERSION

INTF
VSEOINTERF-VERSION

PROG
PROGDIR-STATE

DCLS
AS4LOCAL
ABAP_LANGUAGE_VERSION (if exists)

DDLS
ABAP_LANGUAGE_VERSION (if exists)

DDLX
VERSION
RESPONSIBLE
MASTER_SYSTEM

MSAG
DOKIL-DOKSTATE

ENQU
DD25V-AS4LOCAL
DD25V-AS4VERS

* fix syntax error

* also clear PROG VARCL

* update XML files
2019-03-31 01:17:46 -07:00
Alexander Tsybulsky
1ad16a03fe SCI page deisgn (#2542)
* codeinsp design, phase 1

* fix alpha_output

* final design
2019-03-18 07:58:34 -07:00
larshp
ff6725e759 replace uses of log with interface 2019-03-17 01:39:52 -07:00
Martin Fuchs
a1c626ddce Introduce ZIF_ABAPGIT_LOG (#2534)
* ZIF_ABAPGIT_LOG

Introducing the log interface ZIF_ABAPGIT_LOG

* Add ZIF_ABAPGIT_LOG to ZCL_ABAPGIT_LOG

Add ZIF_ABAPGIT_LOG to ZCL_ABAPGIT_LOG
2019-03-16 03:33:58 -07:00
larshp
6dc56433ab allow injection of progress indicator 2019-03-15 01:14:45 -07:00
Lars Hvam
48f6cb1bb1
move ZCL_ABAPGIT_FRONTEND_SERVICES to UI (#2516)
* move ZCL_ABAPGIT_FRONTEND_SERVICES to UI

move ZCL_ABAPGIT_FRONTEND_SERVICES to UI package

* move factory and interface

* fix errors found by linter
2019-03-14 01:34:19 -07:00
Alexander Tsybulsky
c03bb681b3 Offline icons (#2454)
* font

* css fix and icon rendering

* assets and font link in html head

* more icons

* more css fixes

* replace icon names

* dev docs

* Fonts update

* icons rename

* doc update

* linter fixes

* fix for abapmerge
2019-03-06 00:49:04 -08:00
Lars Hvam
fc167ff3cd
update abaplint config to latest (#2480)
* update abaplint config to latest

* remove some descriptions

* remove more descriptions

* fixes

* fixes
2019-03-04 07:12:42 -08:00
larshp
5018eae46c refactor public attributes #2369
refactor public attributes #2369
2019-02-09 23:28:22 -08:00
Lars Hvam
30547792dd
use built in types (#2363)
* replace use of x255

* use same type as field source

* remove use of text25

* remove use of numc4

* remove use of DATUM
2019-02-05 23:08:04 -08:00
Lars Hvam
e8b6b0020d
Add interface for ZCL_ABAPGIT_PROGRESS #2303 (#2316)
* interface for progress class

* adjust branch overview

* adjust git pack

* adjust diff page

* adjust objects class

* adjust activation class

* adjust repo online class

* adjust serialize class

few methods moved

* adjust tadir class
2019-01-23 06:28:54 +01:00
larshp
ee76ec1f45 update to latest abaplint 2019-01-18 07:06:55 +01:00
larshp
3509df80ae add class descriptions 2019-01-14 20:06:33 +01:00
Alexander Tsybulsky
dd52f33497 move isola to zcl_abapgit_convert 2018-12-30 08:07:19 +01:00
larshp
c37ce5ff06 Cleanup classes package assignment #2217 2018-12-30 08:03:38 +01:00
larshp
e0841e3bec indentation and se80 reorderings
no logic changes
2018-12-26 06:35:55 +01:00
Christian Guenter
66fa31e0aa Fix zcl_abapgit_frontend_services xml - newformat 2018-12-22 11:42:40 +01:00
sbcgua
2b887bb7c3 Frontend services util (#2219)
* extract file system calls from zip

* fs to utils package

* rename fs to frontend services

* linter fix

* fix zip class

* review fixes
2018-12-22 11:35:49 +01:00
Eduardo Ferrari Copat
d47027ad6c Remove redundant class and interface metadata (#2195)
* Remove CLSFINAL from VSEOCLASS serialization

* Remove EXPOSURE from VSEOCLASS serialization

* Remove clsabstrct from VSEOCLASS serialization

* Remove EXPOSURE from VSEOINTERF serialization

* Revert "Remove EXPOSURE from VSEOINTERF serialization"

This reverts commit 4036b7d015.
2018-12-12 14:31:42 +01:00
larshp
aae099b93d naming conventions 2018-11-11 17:45:12 +01:00
Lars Hvam
06616580eb
Naming conventions (#2059)
* fix naming conventions

* naming conventions
2018-11-07 12:50:20 +01:00
Christian Günter
0fa50309a1 Staging smaller chunks of code like git add -p (#1842)
* Staging smaller chunks of code like git add -p

With this commit a new feature which works similar to git add -p
is added. We are now able to patch, which means that we can
commit on line basis. And are not restricted anymore to commit
only on file basis.

* move get_page_patch to stage page

* Refactor JS

* Refactor JS
2018-09-08 08:58:25 +02:00
Johannes Konings
d25bfaf725 fix some naming conventions
https://github.com/larshp/abapGit/issues/1132
2018-08-17 09:24:22 +02:00
larshp
e49b404b58 delete some unreferenced variables 2018-08-07 16:01:29 +02:00
Christian Guenter
d82a02cd0e downport 2018-08-06 18:11:09 +02:00
Lars Hvam
c72d04ea80
Refactor background to use log object instead of WRITE (#1753)
* LOG: extra ADD_* methods

Methods ADD_ERROR, ADD_INFO, and ADD_WARNING added to log class

* refactor background to use log object

refactor background to use log object instead of WRITE
2018-08-05 08:08:41 +02:00
Frederik Hudák
9d79bc3cc5 Removed endmethod and endclass comments - folder utils 2018-08-01 18:55:31 +02:00
Michael Käsemann
d2fbceb949 Added unit tests for conversion methods
- Added unit tests for metods BITBYTE_TO_INT and X_TO_BITBYTE of class ZCL_ABAPGIT_CONVERT.
2018-07-09 12:38:26 +02:00
mkaesemann
3ec6188536
Fixed build issues
Removed whitespace at end of empty line caused by the Github editor.
2018-07-09 11:35:57 +02:00
mkaesemann
7dc2dc1af2
Fixed formatting errors
Fixed indentation and linter issues
2018-07-09 11:32:32 +02:00
Michael Käsemann
3294474243 Performance Improvement in BITBYTE_TO_INT Conversion
- Changed: Reduced calculations and processing required to convert a bit string into an integer value to a minimum.
2018-07-09 11:09:53 +02:00
Lars Hvam
20d4605491
Merge pull request #1568 from mkaesemann/feature/X_TO_BITBYTE_optimization
Performance Improvement in X_TO_BITBYTE Conversion
2018-07-06 16:28:07 +02:00
Michael Käsemann
f7f78dfc26 Performance Improvement in X_TO_BITBYTE Conversion
- Changed: Since X_TO_BITBYTE only converts a single byte to a bitstring, it is faster to use direct addressing instead of a loop/concatenate pair, since concatenate on characters has to process the whole char array in each run.
2018-07-06 15:39:52 +02:00
mkaesemann
b80a10024b
Moved progress percentage calculation into execution block
Moved the progress percentage calculation into the execution block, because we don't need to calculate the percentage if we are not going to display it.
2018-07-06 15:16:28 +02:00
mkaesemann
7ec692389e
Fixed Date Calculation for Refresh Interval Detection
Forgot to recalculate the date, so we don't run into problems if someone works late at night
2018-07-06 14:54:47 +02:00
larshp
6db1b2fbfa pretty print 2018-07-06 12:20:01 +00:00
Michael Käsemann
28a1554526 Limit Progress Indicator Updates
Fixed an issue with the progress indicator updates, where updates of the progress indicator would flush the message queue of SAP GUI and cause a GUI crash or hang.
The problem is described in SAP note #2084109 and seems to occur for large repositories (especially after installing SAP GUI 7.50 PL6)
2018-07-05 13:55:59 +02:00
christianguenter2
ea798193d0 Block commit/push if code inspection has errors
- new local setting to set check variant
- new local setting to block pull if code inspector check fails
- check is executed before staging
- new page to display code inspector results
2018-06-28 13:21:29 +02:00
larshp
4219c6d162 cl_aunit_assert is obsolete 2018-06-10 11:45:39 +00:00
Christian Guenter
542e290450 Log: show ALV popup 2018-05-14 13:22:33 +02:00