Commit Graph

18 Commits

Author SHA1 Message Date
Marc Bernard
f6cd2e12bd
Fix DDIC activation issues (#4111)
* Fix DDIC activation issues

- Avoid double activation of DDIC objects in case of "LATE" processing
- Derive DDIC id for XINX and MCID (same as for INDX)

Closes #4103

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:40:33 +01:00
Marc Bernard
c0192df9ec
Close some minor ToDos (#3995)
* Close some todos 

FUGR does not have any class includes

* Remove huh?

* Move WDYN activation to serializer

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-09 13:11:24 +02:00
Marc Bernard
5a56166d6d
Activate objects without popup (#3725)
* Activate objects without popup

* Activate objects without popup

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-13 08:55:10 +02:00
Lars Hvam
3e0b0505b1
remove commented code (#3166)
* update abaplint.json

* remove commented code

* remove 2 unused variables
2020-01-24 14:31:04 +01:00
Martin Fuchs
2e781b316a ZIF_ABAPGIT_LOG: extend and move UI methods to new class (#2694)
* log: move show functions to new class

Enhance ZIF_ABAPGIT_LOG
- add IS_ITEM structure (object) to message adding functions
- add method "add_exception"
- add method "add_info"
- relocate methods "show", "to_html" and "write" to new class ZCL_ABAPGIT_LOG_VIEWER
Introduction of new log viewer class ZCL_ABAPGIT_LOG_VIEWER
Replacement of relocated methods where used
-> This is the next step providing a log for serialzation/de-serialization (see #2534)

* fix abaplint issues

fix abaplint issues

* fix abaplint issues (2)

fix abaplint issues
2019-05-26 03:16:03 -07:00
larshp
ff6725e759 replace uses of log with interface 2019-03-17 01:39:52 -07:00
larshp
75ee96bce0 Activate parallel DDIC activation #1055
Activate parallel DDIC activation #1055

With this more activation errors will be shown, plus better performance
2019-02-20 22:01:03 -08:00
Lars Hvam
e8b6b0020d
Add interface for ZCL_ABAPGIT_PROGRESS #2303 (#2316)
* interface for progress class

* adjust branch overview

* adjust git pack

* adjust diff page

* adjust objects class

* adjust activation class

* adjust repo online class

* adjust serialize class

few methods moved

* adjust tadir class
2019-01-23 06:28:54 +01:00
Lars Hvam
610c48d51f
Remove commented code (#2285)
* delete commented code

* delete commented code

* commented code
2019-01-13 10:28:18 +01:00
Lars Hvam
35f1462d3a
updates to experimental DDIC activation logic (#2206)
* updates to experimental ddic activation logic

* deleted too much

* special handling for INDX

* fixored, this seems to work
2018-12-17 08:17:53 +01:00
larshp
7cdbbc92b6 remove some unreferenced variables 2018-11-08 16:35:08 +01:00
Christian Guenter
45a2ba1cd1 add factory for GUI_IS_AVAILABLE
This commit adds an indirection for function module GUI_IS_AVAILABLE
via interface ZIF_ABAPGIT_GUI_FUNCTIONS and factory ZCL_ABAPGIT_UI_FACTORY.

For tests the implementation can be replaced with
ZCL_ABAPGIT_UI_INJECTOR=>SET_GUI_FUNCTIONS
2018-11-03 08:42:32 +01:00
Frederik Hudák
c4639f65ce Removed endmethod and endclass comments - objects folder 2018-07-28 10:10:16 +02:00
Jakub Filak
17b808c8a5 Mass activation: re-check DDIC objs in transport
DDLS objects are not cheked in a transport in their deserialize method.
The parallel activation does not call RS_WORKING_OBJECTS_ACTIVATE which
checks in the activated object in a transport.
Therefor, DDLS objecst are never checked in a transport when
the parallel activation is in place (the option experimental features
is enabled - which is enabled by default on all our systems).

I wanted to use TRINT_OBJECTS_CHECK_AND_INSERT because this function
is used by ADT:

CL_WB_ADT_REST_RESOURCE~post
    CL_WB_ADT_REST_RESOURCE_DATA
    ~if_wb_adt_rest_resource_data~get_transport_key
        CL_WB_OBJECT~get_transport_key -> PGMID%3DR3TR, OBJTYPE%3DDDLS
    CL_WB_ADT_REST_RESOURCE~lock
        CL_WB_ADT_REST_RESOURCE~check_obj_in_transport_request
            CL_ADT_CTS_MANAGEMENT~check_objects_in_request
                CL_ADT_CTS_MANAGEMENT~LCL_DB_PERSISTENCE~check_objects
                    CALL FUNCTION CTS_WBO_API_CHECK_OBJECTS
                        CALL FUNCTION TRINT_WBO_IMPL_CHECK_OBJECTS
                            SAPLCTS_WBO_API_IMPL /
                            LCTS_WBO_API_IMPLF06 /
      FORM CALL_OBJECTS_CHECK_AND_INSERT
                                CALL FUNCTION
                                TRINT_OBJECTS_CHECK_AND_INSERT


But it is not enough to call this function, hence, I use RS_CORR_INSERT
which was mentioned by @larshp in our slack conversation. The function
internally use calls TRINT_OBJECTS_CHECK_AND_INSERT.

I tested this patch with modification of a CDS view and also with 
adding a new CDS view.

Closes #1466
2018-06-07 16:10:23 +02:00
Lars Hvam
7a9bec815a
Seperate UI and logic (#1286)
* no activation popup in background

* purge: seperate ui and logic

* order by primary key
2018-03-30 12:28:00 +02:00
larshp
cf216438e9 add progress bar, #1190 2018-02-11 08:34:35 +00:00
larshp
cec950e7ca CLAS: fix where-used in deserialization #1179 2018-02-03 12:05:20 +00:00
larshp
c1d01d37e3 lcl_objects_activation to global
lcl_objects_activation to global class
2018-01-22 16:55:03 +00:00