Commit Graph

164 Commits

Author SHA1 Message Date
Christian Günter
f7ce109f86 SUSO Delete: remove popup #1948 (#1949)
* SUSO: Delete remove popup

* Refactor delete document method
2018-09-25 16:02:02 +02:00
larshp
d21bbb6caa XSLT: show sy-subrc error 2018-09-25 16:01:25 +02:00
Marcello Urbani
3c86342bef Issue#1878 popup deleting msag (#1918)
* removed popup saving msag

* fixed capitalization

* refactored with variable prefixes

* refactored exceptions and split methods

also removed S messages.
Previous code was mostly copy %26 paste of the original

* Cleaned up

* more cleanup
2018-09-21 09:19:44 +02:00
Christian Guenter
46da683d7b AUTH: remove delete popups 2018-09-21 09:13:37 +02:00
Christian Guenter
829a68fcc6 AUTH serialization: fix package popup 2018-09-21 09:12:56 +02:00
Christian Günter
aa7a5fd01f FORM: record transport request 2018-09-21 09:12:03 +02:00
Domi Bigl
f61eb50dbf Code inspector results do not respect 'Jump to ADT first' setting #1892 (#1903)
* enable ADT jump from CI result

* enable ADT jump from CI result for all objects

* cleanup + PP

* cleanup + PP + save/activate in ADT

* remove commented code
2018-09-16 10:05:38 +02:00
larshp
b2f43a04b6 handle error from RS_CUA_INTERNAL_FETCH #1899 2018-09-08 08:04:24 +02:00
Christian Guenter
f4859d179d fix no master language 2018-09-03 18:40:54 +02:00
Christian Guenter
cf8592a2ef Docu Longtexts: Serialize all languages 2018-09-03 18:40:54 +02:00
Domi Bigl
0b3c9970d6
ENQU: clear some more fields #1110 (#1888)
* ENQU: clear fields #1110

* ENQU: clear some more fields #1110
2018-08-31 18:04:47 +02:00
Domi Bigl
1a6f3623b3 ENQU: clear fields #1110 2018-08-31 07:21:39 +02:00
Christian Guenter
491cb6d1e7 FIX SHMA package popup 2018-08-31 07:21:01 +02:00
larshp
a4528290f3 MSAG: skip longtexts if none exist 2018-08-31 07:20:38 +02:00
Jakub Filak
6a01862cd6 Avoid use of the RS package in BASIS systems (#1874)
* objects: use a different constant for 'R3TR'

The constant rs_c_pgmid_r3tr comes from the package RS which is not
available in pure BASIS systems.

The constant seok_pgmid_r3tr comes from the package SEOK and abapGit is
already using another constants from this package - seok_access_*.

Related to #1826

* objects: replace rs_c_true with abap_true

The constant rs_c_true comes from the package RS which is no available
in pure BASIS systems.

I believe that the constant rs_c_true was used by mistake.
The constant was assigned to a variable which is of the type abap_bool
and the variable is initialized with abap_false.

Related to #1826
2018-08-29 12:36:16 +02:00
Christian Guenter
46f32e6422 Longtext serialization for DTEL, DOMA and TABL
This commit adds three new methods to ZCL_ABAPGIT_OBJECTS_SUPER:
- SERIALIZE_LONGTEXTS
- DESERIALIZE_LONGTEXTS
- DELETE_LONGTEXTS
They can be called on demand in concrete object type serializers.

In this commit they were called from DTEL, DOMA and TABL
2018-08-28 08:30:13 +02:00
Christian Guenter
d3f4584d3a MSAG: implement is_locked 2018-08-27 09:53:31 +02:00
Christian Guenter
d28b0fdc97 MSAG: Serialize longtexts in message classes 2018-08-22 06:45:38 +02:00
Christian Guenter
e394966795 FIX: CLAS is_locked read enque
Read enqueue entries instead of enqueueing
2018-08-22 06:34:32 +02:00
Marcello Urbani
40fd90b14d Release locks/abapGit on pure BASIS system Issue #1826 (#1850)
* abapGit on pure BASIS system #1826

* fixed spacing

* Added fallback to old FM

* fixed spacing
2018-08-21 10:36:26 +02:00
Marcello Urbani
f35c285605 clean up ZCL_ABAPGIT_OBJECT_CLAS_OLD, #1801 (#1846)
* refactor zcl_abapgit_object_clas

removed dependencies from zcl_abapgit_object_clas_old, moved methods

* deleted zcl_abapgit_object_clas_old
2018-08-21 10:34:55 +02:00
Johannes Konings
d25bfaf725 fix some naming conventions
https://github.com/larshp/abapGit/issues/1132
2018-08-17 09:24:22 +02:00
Johannes Konings
c3691622ed fix some naming conventions
https://github.com/larshp/abapGit/issues/1132
2018-08-16 06:32:19 +02:00
larshp
e3df6fe4c2 PROG: add guard for bad TADIR EIMP entries 2018-08-13 18:33:23 +02:00
sandraros
57d28d124b Always correct rs cua internal write errors (#1810)
* correct xml errors of CUA interfaces

Issue error RS_CUA_INTERNAL_WRITE while pulling an old abapgit repository #1807. Same issue as #562 (error RS_CUA_INTERNAL_WRITE) which is solved by correcting manually the XML of the CUA interfaces (fastidious), or by regenerating the XML (but unfortunately sometimes the abapGit repository is from someone else).
Automatically fix this before RS_CUA_INTERNAL_WRITE is called. It's useless having this as a configuration option.

* refactor: extract code to a new method

* Better refactoring of auto correction CUA
2018-08-12 09:42:08 +02:00
Johannes Konings
efda46d4da TABL ROWORCOLST serialize: Delete value C #1722 (#1791)
* TABL ROWORCOLSTserialize: Delete value C

https://github.com/larshp/abapGit/issues/1722

* Changed IF

https://github.com/larshp/abapGit/issues/1722
2018-08-08 15:06:42 +02:00
larshp
00f94d3f2e 702 downport 2018-08-08 14:58:53 +02:00
larshp
e49b404b58 delete some unreferenced variables 2018-08-07 16:01:29 +02:00
Christian Guenter
a1e010c0fc downport 702 2018-08-07 14:54:29 +02:00
Christian Guenter
173351c13f downport 702 2018-08-07 13:46:58 +02:00
Johannes Konings
f214fab73d fix some naming convention
https://github.com/larshp/abapGit/issues/1132
2018-08-07 12:03:21 +02:00
Christian Guenter
0fa4ed299e downport 702 2018-08-07 10:26:57 +02:00
Johannes Konings
0a357149a4 PARA Delete without RS_PARAMETER_DELETE
https://github.com/larshp/abapGit/issues/1575
Deletion of PARA caused a popup in FM RS_PARAMETER_DELETE. 
To avoid that, the logic of the FM had to be implemented directly in the delete method.
2018-08-07 07:24:45 +02:00
Johannes Konings
1bbe4b6c1f deserialize SSST: insert_tadir
https://github.com/larshp/abapGit/issues/1755
method insert_tadir avoids "Object Directory Entry" popup
2018-08-07 07:23:05 +02:00
Christian Guenter
840fe06262 downport 702 2018-08-06 19:59:49 +02:00
Christian Guenter
d82a02cd0e downport 2018-08-06 18:11:09 +02:00
larshp
f0fb0f0470 TADIR performance
TADIR performance #1756

All usages of TADIR aligned to use the same structure. 
DELFLAG added in the structure.
2 identical structure definitions deleted.

todo: test this PR works after abapmerge has run
2018-08-06 15:39:15 +02:00
Christian Günter
400846e036 Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER #1775 (#1776)
* Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER

* catch exception if interfaces doesn't exist

Catch exception if IF_OO_SOURCE_POS_INDEX_HELPER doesn't exist
2018-08-06 15:11:40 +02:00
Christian Guenter
6ef0357795 ecatt downport 2018-08-06 13:31:43 +02:00
Christian Günter
a4e670d254 ecatt: downport and fix naming #1737 (#1740)
* ecatt: downport and fix naming

* ecatt downport /2
2018-08-03 14:47:17 +02:00
Frederik Hudák
34a65ba8e4 Removed unnecessary default comments from testclasses 2018-08-03 13:32:57 +02:00
Christian Guenter
fa61f45886 SSFO: fix jump to text module
After this commit is applied jump to smartforms
text modules works as expected.
2018-07-31 13:46:30 +02:00
Lars Hvam
4fa485bf96
Remove superfluous spaces (#1712)
* remove spaces

* remove spaces

* remove spaces

* remove double space
2018-07-29 10:08:54 +02:00
Frederik Hudák
c4639f65ce Removed endmethod and endclass comments - objects folder 2018-07-28 10:10:16 +02:00
Lars Hvam
62580af494
Omit parameter name where possible (#1704)
* zcl_abapgit_2fa_github_auth omit parameter name

* ecatt omit parameter names

* zcl_abapgit_ecatt_script_downl pretty print

* zcl_abapgit_ecatt_script_downl omit parameter name

* zcl_abapgit_ecatt_val_obj_upl omit parameter name

* zcl_abapgit_file_status omit parameter name

* zcl_abapgit_gui omit parameter name

* zcl_abapgit_gui_page_boverview omit parameter name

* zcl_abapgit_syntax_highlighter omit parameter name
2018-07-28 07:25:28 +02:00
Christian Guenter
8c38e17df6 CHAR: fix copy and paste error
Before this commit is applied we get DBSQL_DUPLICATE_KEY_ERROR
dumps while 'reset local'.
2018-07-27 06:17:32 +02:00
Christian Guenter
494cc5a8f8 CHAR: catch exceptions and implement is_locked
Before this commit is applied we get shortdumps when the object
is locked during deserialization or deletions.
2018-07-26 13:37:10 +02:00
Christian Guenter
9966bf4c86 Refactor: SET PARAMETER EUK
After this commit is applied all calls of "SET PARAMETER 'EUK'"
are replaced with the call of objects_super->set_default_package.
The method uses the ABAP memory which is in this case more reliable.
2018-07-25 16:16:28 +02:00
Christian Günter
8572013c7e CHAR: fix package popup during pull #1661 (#1689)
* CHAR: fix package popup during pull

* Remove superfluous ABAP memory clearance

memory is already cleared in RS_CORR_INSERT

* Introduce objects_super set_default_package

Refactor set default package logic to super class
zcl_abapgit_objects_super method set_default_package.
2018-07-25 15:00:52 +02:00
larshp
45bb5c7405 AVAS: propagate exception to caller
AVAS, propagate exception to caller, this will fix the syntax warning
2018-07-22 09:46:13 +02:00