Lars Hvam
95a8a42c25
Parse commit message in branch overview, fix for PGP signature #1387 ( #1698 )
...
* pretty print, trigger reordering of methods
* skip PGP signature
* change PARSE_COMMITS to static
change PARSE_COMMITS to static and add unit tests class
* add simple unit test and fix CI findings
2018-07-27 13:16:34 +02:00
Christian Guenter
8c38e17df6
CHAR: fix copy and paste error
...
Before this commit is applied we get DBSQL_DUPLICATE_KEY_ERROR
dumps while 'reset local'.
2018-07-27 06:17:32 +02:00
Michael Käsemann
4a51d2845c
Small performance improvement in ZCL_ABAPGIT_FILE_STATUS=>CALCULATE_STATUS, where the subpackage information is read only once and then sorted and the sorted information can then be accessed through a binary search read.
2018-07-26 13:38:24 +02:00
Christian Guenter
494cc5a8f8
CHAR: catch exceptions and implement is_locked
...
Before this commit is applied we get shortdumps when the object
is locked during deserialization or deletions.
2018-07-26 13:37:10 +02:00
Christian Guenter
9966bf4c86
Refactor: SET PARAMETER EUK
...
After this commit is applied all calls of "SET PARAMETER 'EUK'"
are replaced with the call of objects_super->set_default_package.
The method uses the ABAP memory which is in this case more reliable.
2018-07-25 16:16:28 +02:00
Christian Günter
8572013c7e
CHAR: fix package popup during pull #1661 ( #1689 )
...
* CHAR: fix package popup during pull
* Remove superfluous ABAP memory clearance
memory is already cleared in RS_CORR_INSERT
* Introduce objects_super set_default_package
Refactor set default package logic to super class
zcl_abapgit_objects_super method set_default_package.
2018-07-25 15:00:52 +02:00
Christian Guenter
335759f741
Store user and time for last deserialize
...
With this commit after every deserialize operation the user, date and time
are stored in repo xml. The information is shown in repo overview.
2018-07-25 06:50:18 +02:00
Christian Guenter
5d439e3699
Code inspector for offline repositories
...
Before this commit it wasn't possible to run code inspection
for offline repos. A dump occured.
With this commit it is possible to run code inspections
for offline repos, too.
2018-07-25 06:47:59 +02:00
mkaesemann
e132c17205
Fixed spelling error
2018-07-25 06:44:07 +02:00
Michael Käsemann
a80ae3c4f5
Fixed naming and missing data element definition
2018-07-25 06:44:07 +02:00
Michael Käsemann
9f50c2d59e
ZIF_ABAPGIT_SAP_PACKAGE~LIST_SUBPACKAGES in ZCL_ABAPGIT_SAP_PACKAGE returned duplicate entries for subpackages with more than 1 hierarchy level, because the recursion selected all subpackages of a given package and added them to the list and then parsed the added subpackages again, which would in turn again select the subpackages of the subpackage.
2018-07-25 06:44:07 +02:00
Christian Guenter
bb82f2c8bd
Refresh online repo: call BRANCH_LIST just once
...
Before this commit is applied BRANCH_LIST is called twice while
refreshing an online repo. This leads to two identical HTTP calls.
After this commit is applied BRANCH_LIST is only called once and
therefore only one HTTP request is sent.
2018-07-25 06:43:21 +02:00
larshp
d7e90aae60
move version definition to separate interface
...
moved version from DEFINITIONS interface to new VERSION interface, to avoid possible future merge conflicts, see #960
2018-07-25 06:37:38 +02:00
larshp
640839ad0e
Do not delete repo at pull error #1675
...
Some time ago, the repo was pulled immediately after creation, this has been changed, so we do not need this workaround anymore. Also see #843
2018-07-22 11:55:13 +02:00
Christian Guenter
01c2cfb610
NEWS: Only update last_change_seen if changed
2018-07-22 11:06:38 +02:00
Christian Günter
7ac8dc15b6
Remove local SHA1 from online repository #1485 , #1509 ( #1666 )
...
* Remove local SHA1 from online repository
In this commit we remove the local SHA1 and all its references from
ZCL_ABAPGIT_REPO_ONLINE. SHA1 is also removed from repo persistency.
SHA1 insn't needed anymore. All where-used places were either migrated to
remote_SHA1 or removed.
* reintroduce logic after push
2018-07-22 10:11:09 +02:00
larshp
45bb5c7405
AVAS: propagate exception to caller
...
AVAS, propagate exception to caller, this will fix the syntax warning
2018-07-22 09:46:13 +02:00
Christian Guenter
1c368ed80c
FUGR: Update short text if already exists
...
If the short text of the function group has changed in the remote repo,
it's currently not possible to pull that change.
With this commit the short text is pulled properly.
2018-07-22 07:21:06 +02:00
larshp
52758028a7
delete commented unit test code #1189
2018-07-22 07:20:12 +02:00
larshp
60a4f5ed56
FUGR: show error code from RS_FUNCTION_POOL_INSERT
...
FUGR: show error code from RS_FUNCTION_POOL_INSERT
2018-07-21 11:36:30 +02:00
Lars Hvam
16dcb2ea99
Optimize STATUS performance ( #1664 )
...
* Optimize STATUS performance
move list_subpackages() outside of loop
* logic updated
2018-07-21 11:36:15 +02:00
Johannes Konings
b98db9bd7c
branch overview: no singleton ( #1665 )
...
https://github.com/larshp/abapGit/issues/1647
2018-07-20 11:21:26 +02:00
Johannes Konings
cdf2f5f448
ABAP Unit for ZCL_ABAPGIT_BRANCH_OVERVIEW #1647 ( #1654 )
...
branch overview:
* preparation ABAP Unit
* change to key
#1647
2018-07-20 09:29:41 +02:00
Lars Hvam
7079e5ac50
Version 1.72.1 ( #1663 )
...
* 1.72.1
* v1.72.1 changelog
2018-07-20 08:10:50 +02:00
larshp
7d622fc495
CHAR: fix dump during pull #1660
...
Set the activation state to inactive for the values
2018-07-20 07:26:19 +02:00
Christian Guenter
1c2a1f709e
CUS1: deserialization add RS_CORR_INSERT
...
before this commit CUS1 wasn't deserialized properly because no TADIR entry was inserted.
2018-07-20 07:20:33 +02:00
Christian Guenter
25980d80fe
SICF: Delete data from ICFAPPLCUST
...
The data in table ICFAPPLCUST (Application Customizing Data) isn't
deleted by cl_icf_tree=>if_icf_tree~delete_node( ). Before this commit
is applied it's not possible to delete ICF nodes with data in that table.
With this commit we delete the data in the table. It's the same as
transaction SICF does.
2018-07-20 06:45:40 +02:00
Christian Guenter
3ba843ad54
VCLS jump: open view cluster in new window
...
Before this commit VCLS jump calls VIEWCLUSTER_MAINTENANCE_CALL
which opens inplace. But that's not compatible with abapGit UI
and nothing is visible.
And the semantics changed. The above mentioned FM call the view
cluster for data maintenance and not the development object.
To be aligned with abapGit logic now the transaction SE54 is called.
2018-07-18 18:24:15 +02:00
Christian Guenter
9822822403
VCLS: Fix - replace meth corr_insert( )
...
Replaces the call of corr_insert( ) with its own call of FM
RS_CORR_INSERT because the parameters used in corr_insert
aren't valid for VCLS
2018-07-18 16:36:31 +02:00
Jakub Filak
b3186e9202
AVAS: report detailed errors ( #1652 )
...
Unfortunately, we are versioning AVAS objects that can be instantiated
only in SAP systems but we use the repo also in sandbox Customer
systems.
Whenever I open the repository I get an exception of the type
cx_pak_invalid_data.
Without this commit I see the error message:
"AVAS error".
With this commit I see the error message:
"AVAS $GUID: invalid data: The functionality is not supported in
customer systems"
2018-07-18 15:37:22 +02:00
Christian Günter
495e832882
downport CMPT ( #1648 )
2018-07-17 13:06:32 +02:00
Christian Günter
394ea52d61
More is_locked: ENHO, FORM, SFPF, SFPI ( #1646 )
2018-07-17 07:40:01 +02:00
Christian Günter
67b7f74911
Fix: warning package shown twice ( #1644 )
2018-07-17 07:28:57 +02:00
ThomasPloski
6ea0c465f4
fixes issue #1621 ( #1640 )
2018-07-14 06:51:20 +02:00
Lars Hvam
4f96d8dbee
show path in diff page #1624 ( #1638 )
...
show path in diff page #1624
plus remove some comments after ENDMETHOD
2018-07-14 06:51:07 +02:00
Lars Hvam
f4e9676855
CUS0 handle TADIR ( #1636 )
...
* SE80 pretty print
* CUS0 handle TADIR #1565
2018-07-14 06:50:56 +02:00
Lars Hvam
3a5b2b73fb
VCLS handle TADIR #1565 ( #1633 )
...
VCLS handle TADIR #1565
Source code reorganized by SE80.
Changes: call to corr_insert() added, plus set rs_metadata-delete_tadir %3D abap_true.
2018-07-14 06:50:44 +02:00
Lars Hvam
1b154ccf7f
list superpackages, fix double entries #1612 ( #1632 )
...
list superpackages, fix double entries #1612
2018-07-14 06:50:33 +02:00
ThomasPloski
153606eb7a
fixes issue #1630 ( #1637 )
2018-07-13 13:26:46 +02:00
larshp
48e2549003
1.72.0
2018-07-13 08:17:58 +00:00
Lars Hvam
b7ad2b553f
issue #1630 , temporary workaround ( #1631 )
2018-07-13 10:06:25 +02:00
Johannes Konings
e34d80214e
zcl_abapgit_object_form naming convention #1132 ( #1628 )
...
* typo corrected "Guide for installing bundle"
* zcl_abapgit_factory naming convention
https://github.com/larshp/abapGit/issues/1132
* zcl_abapgit_object_form naming convention
https://github.com/larshp/abapGit/issues/1132
2018-07-13 04:30:30 +02:00
Johannes Konings
e74e03f5a5
zcl_abapgit_factory naming convention #1132 ( #1619 )
...
* typo corrected "Guide for installing bundle"
* zcl_abapgit_factory naming convention
https://github.com/larshp/abapGit/issues/1132
2018-07-12 16:57:12 +02:00
Lars Hvam
6bdb655435
AVAS support ( #1609 )
...
* AVAS #1360
* AVAS support
* fix linter errors
2018-07-12 16:55:46 +02:00
Lars Hvam
bf3e5df77e
start moving unit tests to the right classes ( #1610 )
2018-07-12 16:40:22 +02:00
Christian Günter
4f9f47cd59
Set transport request if needed during uninstall or reset local ( #1596 )
...
* delete checks: set transport request if needed
this ensures that the transport request is set when deleting objects.
E.g. uninstalling the repositoy or reset local.
* separate type for delete checks
2018-07-11 16:18:08 +02:00
ThomasPloski
6ced7c04bb
using "#EC CI_GENBUFF ( #1618 )
2018-07-11 16:16:48 +02:00
Christian Günter
c161b0d5d4
Overview page: initial focus to filter ( #1616 )
2018-07-11 15:45:56 +02:00
Lars Hvam
23ded859ea
update source index, #1597 ( #1598 )
...
* update source index #1597
* remove comment
* fix indentation
2018-07-10 16:41:00 +02:00
Lars Hvam
7d7def95a5
Generic object handler + ASFC support #1578 ( #1590 )
...
* scaffolding #1578
* generic object handler #1578
* fix linter errors
2018-07-10 16:39:49 +02:00
ThomasPloski
513fe052bb
Consideration of ABAP Language Version ( #1567 )
...
* Consideration of ABAP Language Version
* update
* Update zcl_abapgit_object_fugr.clas.abap
2018-07-09 18:51:53 +02:00
Thoralf Hänsel
5e824d7b62
Naming conventions for zcl_abapgit_ecatt_script_downl #1132 ( #1604 )
...
* Naming conventions zcl_abapgit_ecatt_script_downl
https://github.com/larshp/abapGit/issues/1132
* Fix indentation.
https://github.com/larshp/abapGit/issues/1132
* Naming conventions zcl_abapgit_ecatt_val_obj_upl
https://github.com/larshp/abapGit/issues/1132
2018-07-09 16:30:46 +02:00
Lars Hvam
9c5c704fad
Merge pull request #1594 from christianguenter2/issue_1558
...
Do not automatically deserialize last seen repo
2018-07-09 16:28:01 +02:00
Lars Hvam
f54009e65a
Merge pull request #1603 from mkaesemann/feature/BITBYTE_TO_INT_optimization
...
Performance Improvement in BITBYTE_TO_INT Conversion
2018-07-09 16:23:41 +02:00
Christian Guenter
3f2e9be939
Do not automatically deserialize last seen repo
...
- new default behaviour is that the last seen repo isn't deserialized automatically. Instead the user has to choose a repo to work with
- old behaviour can be reactivated via user setting
2018-07-09 16:15:36 +02:00
Lars Hvam
58952c15fc
Merge pull request #1599 from christianguenter2/SCP1_jump
...
SCP1 jump
2018-07-09 14:06:28 +02:00
Michael Käsemann
d2fbceb949
Added unit tests for conversion methods
...
- Added unit tests for metods BITBYTE_TO_INT and X_TO_BITBYTE of class ZCL_ABAPGIT_CONVERT.
2018-07-09 12:38:26 +02:00
mkaesemann
3ec6188536
Fixed build issues
...
Removed whitespace at end of empty line caused by the Github editor.
2018-07-09 11:35:57 +02:00
mkaesemann
7dc2dc1af2
Fixed formatting errors
...
Fixed indentation and linter issues
2018-07-09 11:32:32 +02:00
Michael Käsemann
3294474243
Performance Improvement in BITBYTE_TO_INT Conversion
...
- Changed: Reduced calculations and processing required to convert a bit string into an integer value to a minimum.
2018-07-09 11:09:53 +02:00
Christian Guenter
f88a95d0d4
New default setting: jump to ABAP in Eclipse
2018-07-08 21:20:36 +02:00
Christian Guenter
6dc1f30cea
SCP1 jump
2018-07-08 21:09:04 +02:00
Christian Günter
e98dbffe92
Merge pull request #1595 from larshp/SCP1
...
Basic SCP1 support #1004
2018-07-08 20:54:53 +02:00
larshp
fdb2483b70
remove breakpoints
2018-07-08 11:12:13 +00:00
larshp
eb86f02a29
basic SCP1 support, #1004
2018-07-08 11:08:46 +00:00
larshp
bb3e092d61
basic SCP1 serialization
2018-07-08 10:02:44 +00:00
Christian Guenter
3ce838269d
add timezone to overview page
2018-07-08 09:54:34 +00:00
Christian Guenter
7684e7b2ad
merge page: remove duplication
2018-07-08 09:40:00 +00:00
Lars Hvam
290c1109a7
Merge pull request #1588 from JohannesKonings/issue_1585
...
syntax error in NW 7.31 caused by PARTIALLY IMPLEMENTED #1585
2018-07-08 07:21:01 +02:00
Lars Hvam
c6713e608d
Merge pull request #1587 from JohannesKonings/issue_1586
...
Embedded Expressions ALPHA cause syntax error on NW 7.31 #1586
2018-07-08 07:19:20 +02:00
Lars Hvam
528f8d7c3c
Merge pull request #1583 from larshp/issue_1449
...
remove link to plugins #1449
2018-07-08 07:18:51 +02:00
Lars Hvam
997256c0b4
Merge pull request #1577 from larshp/issue_1552
...
avoid duplicate objects in reset local #1552
2018-07-08 07:18:38 +02:00
Johannes Konings
d605b89090
PARTIALLY IMPLEMENTED removed
...
https://github.com/larshp/abapGit/issues/1585
2018-07-07 18:31:42 +02:00
Johannes Konings
1f81fd9eff
Expressions ALPHA to CONVERSION_EXIT_ALPHA_OUTPUT
...
https://github.com/larshp/abapGit/issues/1586
2018-07-07 18:03:50 +02:00
larshp
21bd0ec64c
remove link to plugins #1449
...
remove link to plugins #1449
2018-07-07 08:33:52 +00:00
larshp
583397ff31
avoid duplicate objects in reset local #1552
...
avoid duplicate objects in reset local #1552
2018-07-07 07:56:07 +00:00
larshp
79b6ed0fa5
commit after updating checksums #1562
...
commit after updating checksums #1562
plus remove some comments
2018-07-07 07:43:19 +00:00
Lars Hvam
0403e29109
Merge pull request #1573 from christianguenter2/issue_1559
...
run code inspector after conflict resolution
2018-07-07 09:01:14 +02:00
Lars Hvam
3a3c06825b
Merge pull request #1571 from christianguenter2/issue_1544
...
Add creator and created at to overview page
2018-07-07 08:59:20 +02:00
Lars Hvam
15c2fae36a
Merge pull request #1572 from larshp/issue_1539
...
PARA as DDIC, #1539
2018-07-07 08:55:55 +02:00
Christian Guenter
c6ebf2be1f
run code inspector after conflict resolution
2018-07-06 16:34:16 +02:00
Lars Hvam
20d4605491
Merge pull request #1568 from mkaesemann/feature/X_TO_BITBYTE_optimization
...
Performance Improvement in X_TO_BITBYTE Conversion
2018-07-06 16:28:07 +02:00
larshp
14683c1aef
PARA as DDIC, #1539
...
this will create the PARA object before the DTEL, tested ok via repo https://github.com/abapGit-tests/DTEL_with_PARA
2018-07-06 13:51:01 +00:00
Christian Guenter
73f2bdd13b
Add creator and created at to overview page
2018-07-06 13:46:49 +00:00
Michael Käsemann
f7f78dfc26
Performance Improvement in X_TO_BITBYTE Conversion
...
- Changed: Since X_TO_BITBYTE only converts a single byte to a bitstring, it is faster to use direct addressing instead of a loop/concatenate pair, since concatenate on characters has to process the whole char array in each run.
2018-07-06 15:39:52 +02:00
Lars Hvam
17d59cc28f
Merge pull request #1563 from mkaesemann/feature/limit_progress_indicator_update
...
Limit Progress Indicator Updates
2018-07-06 15:23:10 +02:00
mkaesemann
b80a10024b
Moved progress percentage calculation into execution block
...
Moved the progress percentage calculation into the execution block, because we don't need to calculate the percentage if we are not going to display it.
2018-07-06 15:16:28 +02:00
mkaesemann
7ec692389e
Fixed Date Calculation for Refresh Interval Detection
...
Forgot to recalculate the date, so we don't run into problems if someone works late at night
2018-07-06 14:54:47 +02:00
larshp
28f1736a41
1.71.0
2018-07-06 12:35:16 +00:00
Lars Hvam
1abce8e84c
Merge pull request #1564 from EduardoCopat/1280
...
validate sub and super packages from installed repos
2018-07-06 14:29:36 +02:00
larshp
6db1b2fbfa
pretty print
2018-07-06 12:20:01 +00:00
Lars Hvam
0fa0c3bfe9
Merge pull request #1534 from christianguenter2/issue_1533
...
delete empty packages
2018-07-06 14:13:47 +02:00
COPAT
e3676de797
validate sub and super packages from repos
...
validate sub and super packages from repos
2018-07-05 23:35:29 +02:00
Christian Guenter
ad5ae2a185
delete empty packages
2018-07-05 23:19:32 +02:00
Michael Käsemann
28a1554526
Limit Progress Indicator Updates
...
Fixed an issue with the progress indicator updates, where updates of the progress indicator would flush the message queue of SAP GUI and cause a GUI crash or hang.
The problem is described in SAP note #2084109 and seems to occur for large repositories (especially after installing SAP GUI 7.50 PL6)
2018-07-05 13:55:59 +02:00
Lars Hvam
6f54a1e9ff
Merge pull request #1553 from flaiker/requirements-ui
...
Add UI for requirements in repo settings
2018-07-03 07:45:29 +02:00
Lars Hvam
55c77d55f3
Merge pull request #1551 from christianguenter2/issue_1544
...
add created_by and created_at to repo xml
2018-07-02 19:55:52 +02:00
Lars Hvam
18709bdf74
Merge pull request #1550 from christianguenter2/issue_1543
...
New repository overview page
2018-07-02 19:50:17 +02:00
Lars Hvam
f1786cb405
Merge pull request #1541 from larshp/issue_1539
...
Delete PARA after DTEL, #1539
2018-07-02 17:29:53 +02:00
Lars Hvam
b39bab5363
Merge pull request #1538 from larshp/issue_1537
...
TABL: check existence before SELECTing
2018-07-02 17:29:38 +02:00
Christian Guenter
59128df664
downport code inspector page
2018-07-02 10:38:23 +00:00
Fabian Lupa
127f5a3c9c
Remove unused action decode methode
2018-07-02 00:51:38 +02:00
Fabian Lupa
43e91a6296
Add UI for requirements in repo settings
...
Fixes #1547
2018-07-01 18:27:07 +02:00
Christian Guenter
1c59b131b7
add created_by and created_at to repo xml
2018-07-01 15:53:56 +00:00
Christian Guenter
6dfb6316c6
Repository overview page
2018-07-01 16:47:28 +02:00
Christian Guenter
31fb79f915
Fix naming in file_status
2018-06-30 09:27:46 +00:00
larshp
bd7313b472
Delete PARA after DTEL, #1539
2018-06-28 13:49:32 +00:00
Christian Guenter
10b29556f7
fix bug in run_code_inspection
2018-06-28 13:47:07 +00:00
larshp
dcc765d013
TABL: check existence before SELECTing
2018-06-28 13:11:42 +00:00
larshp
f1ffa6eb26
fix FUGR locking problem
...
plus show sy-subrc in case of errors from RPY_DYNPRO_INSERT
2018-06-28 12:29:29 +00:00
larshp
eeb07b0e3f
1.70.0
2018-06-28 12:03:30 +00:00
Lars Hvam
52fb9858ff
Merge pull request #1532 from christianguenter2/1460
...
move db util pages to separate package
2018-06-28 13:41:58 +02:00
Lars Hvam
4e4dac57dc
Merge pull request #1529 from christianguenter2/exp_WAPA_better_diff
...
WAPA: better delta handling
2018-06-28 13:41:15 +02:00
Lars Hvam
cda961dbe1
Merge pull request #1527 from christianguenter2/tag_popups
...
tag popups: dependency injection
2018-06-28 13:33:55 +02:00
christianguenter2
ea798193d0
Block commit/push if code inspection has errors
...
- new local setting to set check variant
- new local setting to block pull if code inspector check fails
- check is executed before staging
- new page to display code inspector results
2018-06-28 13:21:29 +02:00
christianguenter2
557ae3279f
move db util pages to separate package
2018-06-28 12:04:25 +02:00
Christian Guenter
a3d26b9901
WAPA: better delta handling
2018-06-26 11:01:42 +02:00
Christian Guenter
fb91909947
tag popups dependency injection
2018-06-25 11:15:46 +02:00
Lars Hvam
307c1395d2
Merge pull request #1523 from christianguenter2/issue_437
...
Implement IS_LOCKED for W3*, TTYP, TRAN, SSFO, SSST
2018-06-21 14:28:35 +02:00
Lars Hvam
016e66244d
Merge pull request #1522 from christianguenter2/issue_1521
...
Delete: check if any object is locked
2018-06-21 14:28:01 +02:00
Lars Hvam
f79e4b7f7b
Merge pull request #1520 from christianguenter2/issue_1512
...
add commit to toggle_favorites
2018-06-21 14:27:44 +02:00
christianguenter2
002f5ba73d
Implement IS_LOCKED for W3*, TTYP, TRAN, SSFO, SSST
2018-06-19 18:05:09 +02:00
Christian Guenter
79a0a8fa85
Delete: checks if any object is locked
2018-06-19 13:32:25 +00:00
Christian Guenter
e167464f1d
add commit to toggle_favorites
2018-06-19 11:24:00 +00:00
larshp
fa94fa8ea1
unexpected folder structure #1425
...
treat objects as non existing when outside the starting folder
2018-06-19 08:16:55 +02:00
Lars Hvam
145a82e9ef
Merge pull request #1518 from christianguenter2/issue_1514
...
Dependency injection for ZCL_ABAPGIT_SAP_PACKAGE
2018-06-18 15:46:34 +02:00
larshp
cac21f2b37
CHAR: implement is_locked
2018-06-18 15:41:13 +02:00
Christian Guenter
36f257f0bb
Dependency injection for ZCL_ABAPGIT_SAP_PACKAGE
2018-06-18 15:37:16 +02:00
Lars Hvam
b6894a5e67
Merge pull request #1517 from christianguenter2/issue_437
...
Block pull if any of deserialized object is locked
2018-06-18 15:32:07 +02:00
Lars Hvam
838769d0bc
Merge pull request #1516 from FreHu/master
...
Fixed error message when committing without author name
2018-06-18 15:23:47 +02:00
Lars Hvam
b071d6e837
Merge pull request #1513 from larshp/char
...
CHAR support, #1511
2018-06-18 15:22:49 +02:00
christianguenter2
6521d09470
Block pull if any of deserialized object is locked
2018-06-18 14:18:58 +02:00
Frederik Hudák
7e4285c1a8
Fixed error message when committing
2018-06-18 09:21:51 +02:00
larshp
1290dcec93
CHAR support, #1511
2018-06-17 12:29:29 +00:00
larshp
9f75d6bd2b
refresh repo cache after deletion #1482
2018-06-17 08:23:56 +00:00
larshp
a1e23739b2
1.69.1
2018-06-17 07:58:52 +00:00
Lars Hvam
07955081eb
Merge pull request #1508 from larshp/status
...
file_status, more testing
2018-06-17 09:50:43 +02:00
Lars Hvam
ad0d06e4d0
Merge pull request #1507 from larshp/issue_1502
...
TABL: consider DD12L in changed_by #1502
2018-06-17 09:50:14 +02:00
Lars Hvam
4ae6a8cabb
Merge pull request #1506 from christianguenter2/popup_interface2
...
Introduce ZIF_ABAPGIT_POPUPS
2018-06-17 09:50:01 +02:00
christianguenter2
4662883723
Introduce ZIF_ABAPGIT_POPUPS
...
- create popups with factory ZCL_ABAPGIT_UI_FACTORY
- inject test doubles with injector class ZCL_ABAPGIT_UI_INJECTOR
2018-06-15 11:21:48 +02:00
larshp
a366fed833
file_status, more testing
...
old broken test removed
2018-06-15 09:20:42 +00:00
larshp
d8a5f395ea
TABL: consider DD12L in changed_by #1502
2018-06-15 08:12:42 +00:00
larshp
9352ddbf3f
SEO_CS_CACHE downport #1414
2018-06-15 07:29:13 +00:00
Lars Hvam
4f59c42fb4
Merge pull request #1501 from christianguenter2/issue_1390
...
Introduce injector class
2018-06-15 09:10:03 +02:00
Christian Guenter
6a9acb8a1b
add injector class
2018-06-14 20:33:34 +02:00
Christian Guenter
7b9578a11b
implement missing interface methods
2018-06-14 18:25:00 +00:00
Lars Hvam
eec7a7d096
refactor file status unit tests ( #1499 )
...
* refactor file status unit tests
one method per check
tests in ltcl_file_status2 now successful
* more tests
add helper class
2018-06-14 08:13:37 +02:00
Lars Hvam
602bdf6d96
Merge pull request #1498 from christianguenter2/issue_1494
...
SSFO deserialization: catch cx_ssf_fb
2018-06-14 06:29:05 +02:00
Lars Hvam
b7fc27cfcf
Merge pull request #1497 from christianguenter2/issue_1493
...
Pass log object to user exit method change_tadir
2018-06-14 06:28:46 +02:00
Lars Hvam
b71b96fc9f
Merge pull request #1496 from larshp/repo_srv
...
interface for ZCL_ABAPGIT_REPO_SRV
2018-06-14 06:27:51 +02:00
Lars Hvam
de23d5bf95
Merge pull request #1484 from larshp/issue_1390
...
first dependency injection, TADIR #1390
2018-06-14 06:27:04 +02:00
Christian Guenter
ce89e75eb9
SSFO deserialization: catch cx_ssf_fb
2018-06-13 19:39:35 +00:00
Christian Guenter
a38d9feaff
Pass log object to user exit method change_tadir
2018-06-13 19:15:53 +00:00
larshp
45aa71f2da
interface for ZCL_ABAPGIT_REPO_SRV
2018-06-13 17:28:56 +02:00
Lars Hvam
b7c045210b
Merge pull request #1490 from filak-sap/issue_1446
...
Use the required transport type
2018-06-13 06:53:54 +02:00
Jakub Filak
fb6efabfb9
tp: use the correct transport type in the tr popup
...
We are developing in an infinity system which is somehow cloned into a
new releases system. When we need to backport a bug fixes we do
cherry-pick the commits and pull them the release system. However, in
those systems we need to use the task type Repair.
Hence, we need to overwrite the default value of the parameter
wi_task_type of the function TRINT_ORDER_CHOICE which is 'S'
(Development/Correction) with the value 'R'.
I use the function TRINT_GET_REQUEST_TYPE and for the sake of simplicity
I assume that it is enough to know the transport type of the repository
package - in other words, it is no necessary to check every deserialized
object.
Related to #1446
2018-06-12 13:33:49 +02:00
Jakub Filak
56c58b7a29
SAP Package: add the method get_transport_type
...
For the parameters WI_ORDER_TYPE and WI_TASK_TYPE of the function
TRINT_ORDER_CHOICE called from the method popup_transport_request
of the class zcl_abapgit_popups.
Sometimes we need a repair task but the function TRINT_ORDER_CHOICE
searches for Development/Correction tasks.
I hope that we can decide what task type is needed by a package (DEVC).
Related to #1446
2018-06-12 13:33:49 +02:00
Lars Hvam
f846f250a6
Merge pull request #1492 from christianguenter2/1355
...
disable "no changes" for offline projects
2018-06-12 08:42:20 +02:00
Christian Guenter
a62eae188a
disable "no changes" for offline projects
2018-06-11 14:49:20 +00:00
larshp
334ce44c0d
DDLS: fix dump #1488
2018-06-11 12:03:59 +02:00
Christian Guenter
3e3cd365a8
Quick fix: duplicate type definition
2018-06-10 17:51:21 +00:00
larshp
4e67e884de
first dependency injection #1390
...
* extract public methods of ZCL_ABAPGIT_TADIR to new interface
* create factory ZCL_ABAPGIT_FACTORY
* refactor existing calls
2018-06-10 12:11:48 +00:00
Lars Hvam
fbadb3537b
Merge pull request #1481 from christianguenter2/tadir_userexit
...
New exit: change_tadir
2018-06-10 13:57:28 +02:00
larshp
4219c6d162
cl_aunit_assert is obsolete
2018-06-10 11:45:39 +00:00
Christian Guenter
c7179ed509
new exit: change_tadir
2018-06-10 10:59:00 +02:00
larshp
dcf423bc09
main package is also part of repo #1477
2018-06-10 06:24:13 +00:00
larshp
806fbe1a69
1.69.0
2018-06-09 09:54:20 +00:00
Lars Hvam
6af7b9730e
Merge pull request #1476 from christianguenter2/1355
...
fix gui: show changes only
2018-06-09 11:51:00 +02:00
Lars Hvam
745a10af71
Merge pull request #1474 from christianguenter2/1471
...
fix checkout annotated tags
2018-06-09 11:50:39 +02:00
Lars Hvam
bd1fefd41d
Merge pull request #1468 from filak-sap/issue_1446_check_ddls
...
Mass activation: re-check DDIC objs in transport
2018-06-09 11:50:25 +02:00
Lars Hvam
63318afa88
Merge pull request #1465 from christianguenter2/1464
...
set new remote: supply remote SHA1
2018-06-09 11:49:45 +02:00
Lars Hvam
3e61a0fdfa
Merge pull request #1430 from juancarlosrodriguezf/master
...
FORM: Error of duplicity because SPRAS is case sensitive
2018-06-09 11:49:19 +02:00
Christian Guenter
8ddeacade5
fix gui show changes only
2018-06-08 08:35:20 +02:00
Christian Guenter
6afa45c5ed
fix checkout annotated tags
2018-06-07 21:05:11 +02:00
Lars Hvam
9f5eebf404
Merge pull request #1472 from christianguenter2/1440
...
Deactivate pull after switching branches and tags
2018-06-07 20:38:45 +02:00
Christian Guenter
8074aa3272
COMMIT WORK AND WAIT after switching tags
2018-06-07 17:30:43 +00:00
Christian Guenter
c32306f54c
deactivate pull after switching branches
2018-06-07 17:01:14 +00:00
Jakub Filak
17b808c8a5
Mass activation: re-check DDIC objs in transport
...
DDLS objects are not cheked in a transport in their deserialize method.
The parallel activation does not call RS_WORKING_OBJECTS_ACTIVATE which
checks in the activated object in a transport.
Therefor, DDLS objecst are never checked in a transport when
the parallel activation is in place (the option experimental features
is enabled - which is enabled by default on all our systems).
I wanted to use TRINT_OBJECTS_CHECK_AND_INSERT because this function
is used by ADT:
CL_WB_ADT_REST_RESOURCE~post
CL_WB_ADT_REST_RESOURCE_DATA
~if_wb_adt_rest_resource_data~get_transport_key
CL_WB_OBJECT~get_transport_key -> PGMID%3DR3TR, OBJTYPE%3DDDLS
CL_WB_ADT_REST_RESOURCE~lock
CL_WB_ADT_REST_RESOURCE~check_obj_in_transport_request
CL_ADT_CTS_MANAGEMENT~check_objects_in_request
CL_ADT_CTS_MANAGEMENT~LCL_DB_PERSISTENCE~check_objects
CALL FUNCTION CTS_WBO_API_CHECK_OBJECTS
CALL FUNCTION TRINT_WBO_IMPL_CHECK_OBJECTS
SAPLCTS_WBO_API_IMPL /
LCTS_WBO_API_IMPLF06 /
FORM CALL_OBJECTS_CHECK_AND_INSERT
CALL FUNCTION
TRINT_OBJECTS_CHECK_AND_INSERT
But it is not enough to call this function, hence, I use RS_CORR_INSERT
which was mentioned by @larshp in our slack conversation. The function
internally use calls TRINT_OBJECTS_CHECK_AND_INSERT.
I tested this patch with modification of a CDS view and also with
adding a new CDS view.
Closes #1466
2018-06-07 16:10:23 +02:00
juancarlosrodriguezf
857947b03d
Use the 2-character code for language. Downwards compatibility.
...
Check first the new 2-character file name, if fail, use the old name.
2018-06-07 12:02:24 +02:00
Christian Guenter
41d09125d4
set new remote: supply remote SHA1
2018-06-07 11:01:56 +02:00
larshp
61fb07bffc
1.68.3
2018-06-06 14:44:22 +00:00
Lars Hvam
2f2712d146
Merge pull request #1463 from christianguenter2/1088_01
...
redesign create tag page
2018-06-06 16:40:00 +02:00
Lars Hvam
21889dddf7
Merge pull request #1462 from filak-sap/issue_1427
...
TABL: ignore the unused field RESERVEDTE
2018-06-06 16:38:32 +02:00
Lars Hvam
5baeaf070c
Minor changes ( #1461 )
...
* remove double space after IF
* remove accesses to table bodies
* remove parameter name where possible
* identical code in conditions
2018-06-06 16:24:15 +02:00
Lars Hvam
12c48ebb50
fix dump #1457 ( #1459 )
2018-06-06 16:23:36 +02:00
Lars Hvam
41344dec3a
news feature #1450 ( #1453 )
...
now works for both "/abapGit" and "/abapGit.git" urls
2018-06-06 16:23:23 +02:00
Lars Hvam
aff81df37e
FUGR: force update of where-used #1441 ( #1452 )
...
Updates the where-used after deletion for all includes
2018-06-06 16:23:03 +02:00
Christian Guenter
319abf5b7b
redesign create tag page
2018-06-06 14:20:22 +02:00
Jakub Filak
e71358f744
tabl: ignore the unused field RESERVEDTE
...
The short description contains "(unused)".
For some strange reason, I saw that field set to D in one of our sandbox
systems.
Addresses the issue #1427 .
2018-06-06 08:03:51 +02:00
larshp
353c1a15f2
change agent #1432
...
example "git/2.0 (abapGit 1.68.0)"
removed "v" in front of version number
2018-06-05 07:46:19 +00:00
larshp
ce79d2a841
v1.68.2
2018-06-04 13:27:43 +00:00
Lars Hvam
4417c3257c
Merge pull request #1445 from christianguenter2/1408
...
fix format empty xml attributes
2018-06-04 15:12:41 +02:00
Lars Hvam
6b42e59afa
Merge pull request #1444 from christianguenter2/1408_ecatt
...
ECATT: remove empty attributes
2018-06-04 15:12:25 +02:00
Lars Hvam
10dbd74f57
Minor changes ( #1442 )
...
* remove try without catch
* reduce nesting
* reduce nesting
* reduce line length
2018-06-04 15:12:03 +02:00
Lars Hvam
71bcc8afac
CLAS: ignore deletion of non-existent objects ( #1439 )
...
* CLAS: ignore deletion of non-existent objects
2018-06-04 15:11:41 +02:00
Lars Hvam
f1c15b1e95
fix TOBJ diffs, #1435 ( #1437 )
2018-06-04 15:11:23 +02:00
Lars Hvam
068cf963d9
ENHO: implement changed_by #1417 ( #1436 )
2018-06-04 15:10:49 +02:00
Christian Guenter
6812fd56f6
fix format empty xml attributes
2018-06-04 09:38:40 +02:00
Christian Guenter
d5e9506d51
ECATT: remove empty attributes
2018-06-04 09:09:42 +02:00
larshp
71787d74f0
evaluate 2FA implementations alphabetically #1443
2018-06-03 14:14:19 +00:00