Commit Graph

366 Commits

Author SHA1 Message Date
Jaime Rodriguez Capote
fce71de4d1
Use constants for Y/N/P (#3291)
* Use constants

* Pretty Printer
2020-04-05 10:55:24 +02:00
Jaime Rodriguez Capote
27ac61e95d
Apack dependencies (#3285)
* Support APACK dependencies

Check installed apack package dependencies for current repository
Display a popup with dependencies

* abaplint checks

* abaplint checks

* abaplint checks

* Popup only when dependency not met

* abaplint checks

* abaplint checks

* Optimization

* abaplint checks

* abaplint checks

* Fix typo "dependeNcies"

* Remove address from dependency check

* Dependencies popup title

* Dependencies popup enhanced

* EXCEPTION column replacing MET
* Enable Git URL hiperlink

* APACK doc - Version dependency support

* Dependencies version check support

* abaplint checks

* abaplint checks

* Version utils

* fix syntax warning

* move set_dot_apack to protected

Co-authored-by: larshp <larshp@hotmail.com>
2020-04-05 08:57:59 +02:00
Christian Günter
803ca23176
Refactor page diff: Introduce subclass for patch (#3283)
* Introduce zcl_abapgit_gui_page_patch as subclass of zcl_abapgit_gui_page_diff

introduce pop-method on GUI stack

fix linter + raising exception when gui stack emp

introduce zcl_abapgit_gui_page_patch

more

add

fix linter

remove go back to patch after commit

fix linter

remove bookmark for stage page

remove pop

src/ui/core/zcl_abapgit_gui.clas.abap

 src/zcl_abapgit_repo_online.clas.abap

* refactor: move more logic to  render_line_split_ro

* refactor move logic to render_diff_head_after_stat

* add logic to render_table_head_non_unified

* extract render_table_head_unified

* extract of is_patch_possible calculation

* fix linter

* move hotkey to patch

* refactor and rename to get_normalized_fname_with_p

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-31 17:14:13 +02:00
Christian Günter
1e4560b32a
Patch: new refresh functions (#3271)
* Patch: Refresh object first working version

* Patch: add refresh local and refresh repo + refact

* add missing stuff

* fix lint

* refactoring and cleanup

* add missing stuff

* refactor

* refactor

* refactor

* add title for menu bar

* Save and restore scroll position

* refactoring and cleanup

* refactor

* cleanup

* cleanup

* cleanup

* remove new hotkey

* disable object refresh for non-object files

* remove restore scrollposition

* cleanup

* refactor

* cleanup

* save scroll position

* Fix: refresh of deleted objects

* Fix dump: refresh new objects

* add hotkey support for refresh all local objects

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-26 12:30:22 +01:00
Frederik Hudák
63640bb3fc
Minor ux improvements (#3253)
* Resize stage list to full width

* Move patch button to the top menu

* Center stage list, increase line width in repo, stage

* Repo page - Increase line height for path column

* Stage list to full size

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-21 09:56:53 +01:00
Eduardo Ferrari Copat
e74d40516c
Diff - Add option to collapse files (#3248)
* Update zcl_abapgit_gui_page_diff.clas.abap

* Update zcl_abapgit_gui_page_diff.clas.abap

* Update zabapgit_css_common.w3mi.data.css

* Update zabapgit_css_common.w3mi.data.css

* test

* Update zabapgit_css_theme_default.w3mi.data.css

* Add collapse to css

* Add user select

* onDiffCollapse

* show source

* src

* Tries text

* hide/show

* uses nodisplay instead of hidden

* good hide

* ===

* Add button

* lint

* lint

* set function as global

* lint

* Exclude gui page diff

* remove extra space

* chevron

* pointer

* class

* Icons

* lint

* lint

* hide

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-12 17:09:00 +01:00
g-back
79a1a667c6
Switch branch protected (#3250)
* add write-protect check for switch branch

* disable link for disabled toolbar functions

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-11 12:54:24 +01:00
larshp
e638e6065a ZCL_ABAPGIT_GUI_PAGE_DIFF propagate exception 2020-03-10 08:17:12 +01:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
larshp
8fcf072917 remove call to super->constructor
there is no super class
2020-03-09 17:19:34 +01:00
larshp
b4b3414009 non existing package: fix dump #3224 2020-03-03 10:10:35 +01:00
Daniel Wegner
eb10fae8ef
Proxy bypass (#3221)
* add proxy bypass option in settings

* add proxy bypass popup and persist settings

* add proxy bypass to proxy config class

* Fix Proxy Bypass Button HTML

* Fix indentation

* Implement Method popup_proxy_bypass

* Fix behaviour in case of empty range tab

* Fix behaviour in case of empty range tab 2
2020-03-02 15:30:23 +01:00
Christian Günter
cec926e954
Diff: Only add beacon at beginning while patching (#3218) 2020-02-20 16:43:02 +01:00
Christian Günter
a8d474fab4
Patch: add path to jump target (#3216)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-20 09:39:56 +01:00
Christian Günter
1668e670cf
Fix patch: multiple files with same name (#3213)
- unify id generation
- generate unique filenames

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-19 14:24:04 +01:00
Christian Günter
109c8c3be4
Patch: Remember patched lines when cancel Commit (#3212)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-19 13:55:19 +01:00
Christian Günter
5067e403b7
Patch: add beacon at beginning of objects (#3210)
* Patch: add beacon at beginning of objects

* extract constant + fix unit test
2020-02-19 12:48:26 +01:00
Mauricio Lauffer
a9a505faf4
Prefer RETURNING to EXPORTING (#3204)
* refactor: Prefer RETURNING to EXPORTING

* refactor: Prefer RETURNING to EXPORTING
2020-02-11 10:20:45 +01:00
Lars Hvam
eb7e819b25 refactoring, delete unused variables and methods (#3203)
* zlib

* xml

* processor

* shi5

* remove unused filter parameter

* pinf cleanup

* ssfo delete empty method

* highlighter

* gui page res, remove unused

* remove unused in diff class

* adt link

* gui, remove 2 unused parameters

* branch overview
2020-02-09 09:38:17 +01:00
Jaime Rodriguez Capote
701f83ec2d
Travis-CI Error (#3201)
./src/ui/zcl_abapgit_gui_page_merge.clas.abap[187, 18] - Keep single parameter on one line (keep_single_parameter_on_one_line)

https://travis-ci.org/jrodriguez-rc/abapGit/builds/647280505?utm_medium=notification%26utm_source=github_status
2020-02-07 12:34:59 +01:00
Alexander Tsybulsky
0dba9e5af3
remove DEFINE from zcl_abapgit_gui_view_repo (#3186)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-30 08:10:53 +01:00
Alexander Tsybulsky
0c3cdf639e
remove DEFINED from zcl_abapgit_gui_page_repo_over (#3185)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-30 08:03:19 +01:00
Alexander Tsybulsky
dc96e3b3ef
remove DEFINE from zcl_abapgit_ui_factory (#3184)
* remove DEFINE from zcl_abapgit_ui_factory

* linter fixes

* better approach

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-30 07:57:53 +01:00
larshp
d8047ccad6 use built-in type 2020-01-25 17:47:33 +01:00
Lars Hvam
9872f28d1d
GUI_PAGE_MERGE: refactor DEFINE (#3173)
* GUI_PAGE_MERGE: refactor DEFINE

* fix
2020-01-25 09:48:26 +01:00
Lars Hvam
3e0b0505b1
remove commented code (#3166)
* update abaplint.json

* remove commented code

* remove 2 unused variables
2020-01-24 14:31:04 +01:00
Fabian Lupa
c4f4c713b6 Handle spaces in stage filter (#3153)
* Handle spaces in stage filter

#3073

* Fix JS lint issue

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-14 17:01:56 +01:00
Christian Guenter
bae1e21c5b Refactoring: Delete unused variables 2020-01-13 18:41:52 +01:00
Lars Hvam
75812fb17b
less prefixes (#3144) 2020-01-11 09:24:36 +01:00
Lars Hvam
e201bf566f
remove class prefixes if its current class (#3137)
* remove class prefixes if its current class

* Update abaplint.json
2020-01-06 13:20:19 +01:00
Lars Hvam
b42f3bc485
Refactoring (#3134)
* fully type constants

* moving to single line

* move to single line

* enable keep_single_parameter_on_one_line
2019-12-28 12:11:32 +01:00
mariusraht2
5bee54fff3 Commit icon added (#3124)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Added new icon code-commit via SMW0
2019-12-19 06:20:22 +01:00
Frederik Hudák
c686a7dd3b Unescape '=' character (#3102)
* Unescape '=' character

* fix abaplint
2019-12-05 15:23:47 +01:00
Frederik Hudák
c846801d19 Add adt link to objects on diff page (#3095)
* Add adt link to object name on diff page

* Fix abaplint, improve error handling

* abaplint

* Remove superflous method
2019-12-05 08:59:15 +01:00
sandraros
175f2fabec Code selection by column on DIFF screen (#3091)
* Code selection by column on DIFF screen

Fix of #3089

Two ways to select a text:

1. Position the mouse at the start of the text, press mouse left button, keep pressed, drag to the end of the text, release the button

2. Position the mouse at the start of the text, press mouse left button, release the button, position the mouse to the end of the text, press shift key + mouse left button.

Two ways to copy the selected text:

1. Press Ctrl + C or Ctrl + Ins

2. Mouse right button on the text to display the context menu and choose Copy

SPLIT VIEW (code at the left is the LOCAL code and code at the right is the REMOTE code):
- Text can be selected only at the left side, or only at the right side.
- The dummy empty lines which show the place of lines which exist only at the other side are not copied.

UNIFIED VIEW (LOCAL and REMOTE are mixed in the same column, "green plus" lines correspond to lines only in the LOCAL code, "red minus" lines correspond to lines only in the REMOTE code.
- Only the lines from the REMOTE code are copied

PATCH VIEW (split view + one extra column on the left)
- Same features as the SPLIT VIEW

* corrections lint javascript

* merge latest abapgit changes

* corrections lint javascript

* JS refactor functions to prototyped fns (classes)

* JS lint corrections + minor last minute changes

* conform current common.js standards

* LINT conform to common.js standards

* unused lines removed
2019-12-02 09:32:15 +01:00
mariusraht2
02204d07b4 Improved time conversion (#3096)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Improved time conversion

Preparation for #3040

> rename time%3D>get to time%3D>get_unix
> added time conversion from unix to real (get_real)
> added unit tests for time conversion

* abapLint

* Raise cx_static_check and removed exc handling
2019-12-02 09:28:41 +01:00
Alexander Tsybulsky
39ee3c961f fix #3048, remote only stage js error (#3086) 2019-11-27 06:19:01 +01:00
Lars Hvam
29cb891d23
remove obsolete NO_HANDLER pragmas (#3085)
* remove obsolete NO_HANDLER pragmas

* update lint to latest
2019-11-25 07:35:41 +01:00
mariusraht2
8df12d34e0 Issue 3061: Change default value for creation of playground page (#3062)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Change def. value for creation of playground page

Closes #3061

* Update zcl_abapgit_popups.clas.abap
2019-11-17 10:18:40 +01:00
Alexander Tsybulsky
5edea3acda quick fix unicode char in js (ctrl+enter) #3035 (#3052) 2019-11-11 09:21:22 +01:00
Lars Hvam
04a6d7e484
Update abaplint.json to latest (#3045)
* Update abaplint.json

* chain mainly declarations
2019-11-06 09:35:18 +01:00
mariusraht2
e014efd3f4 log viewer: refactor types (#3041) 2019-11-06 09:30:21 +01:00
Italo N
be9b57a0f2 Commit form should not be cleared on error (#3015)
* Commit form should not be cleared on error

* move the type definition to ZIF_ABAPGIT_DEFINITION

* Move type definition to new interface
2019-11-04 11:48:53 +01:00
Alexander Tsybulsky
f0bb81f04a #3022 patch commit state 2019-11-03 07:57:28 +01:00
Alexander Tsybulsky
d501afdf83 downport (#3026) 2019-11-01 17:25:44 +01:00
Lars Hvam
dca54d2590
refactoring public attributes (#3023)
* testclass for testing and remove public attr

* refactor public vars in local class

* rename
2019-11-01 17:07:17 +01:00
Frederik Hudák
04e196b816 Improve branching messages (#3018)
Mention name of branch which was just deleted/switched to.
2019-10-31 14:35:29 +01:00
Alexander Tsybulsky
4f3bd19a8b stage UX improvements: ctrl-enter, autoadd deleted, remote state bugfix (#3007)
* stage: ctrl-enter, autoadd deleted

* linter fix

* eslint fix

* review fixes
2019-10-31 14:29:23 +01:00
Christian Guenter
99761e37c9 Links: add tooltip with hotkey 2019-10-31 08:42:37 +01:00
Alexander Tsybulsky
1af5648e5f Diff state at stage and commit pages (#3003)
* state at stage and commit pages

* review fix
2019-10-27 11:26:59 +01:00